Fuami
5cd4564a32
Added Breaking Animation for Smart Models, Checking each layer.
...
Added Layered Smart Render Test.
2015-06-05 19:23:17 -05:00
Lex Manos
5064d33519
Mitigate potential issue with users requesting lots of server status information by caching ServerStatus json.
2015-06-03 23:16:25 -07:00
Clienthax
9b53b7e111
Add missing forge patch from 1.8 port
...
https://github.com/MinecraftForge/MinecraftForge/blob/1.7.10/patches/minecraft/net/minecraft/client/Minecraft.java.patch#L88
2015-06-04 01:55:13 +01:00
LexManos
61f9c5a201
Merge pull request #1885 from LexManos/EnhanvedBlockStateJson
...
Hook BlockState's Json loading to add support for simplified Forge format.
2015-06-02 16:52:06 -07:00
Lex Manos
267e1ee62f
Hook BlockState's Json loading to add support for simplified Forge format.
...
See https://github.com/MinecraftForge/MinecraftForge/pull/1885 for more details.
2015-06-02 16:49:56 -07:00
LexManos
41cae458a4
Merge pull request #1911 from AlgorithmX2/ItemFramesOnSolidSurfaces
...
Allow placing item frames on Solid Block Faces (isSideSolid)
2015-06-01 20:45:28 -07:00
AlgorithmX2
885d7602f9
Allow placing item frames on Solid Block Faces (isSideSolid)
2015-06-01 22:31:55 -05:00
cpw
d02636213a
Merge branch '1.7.10' - imports all the fluid fixups and other stuff from 1.7 into 1.8
...
Conflicts:
fml/src/main/java/net/minecraftforge/fml/common/FMLCommonHandler.java
fml/src/main/java/net/minecraftforge/fml/common/Loader.java
patches/minecraft/net/minecraft/client/Minecraft.java.patch
patches/minecraft/net/minecraft/client/renderer/texture/TextureMap.java.patch
patches/minecraft/net/minecraft/item/ItemArmor.java.patch
patches/minecraft/net/minecraft/nbt/CompressedStreamTools.java.patch
patches/minecraft/net/minecraft/nbt/NBTTagCompound.java.patch
patches/minecraft/net/minecraft/nbt/NBTTagList.java.patch
patches/minecraft/net/minecraft/world/World.java.patch
patches/minecraft/net/minecraft/world/WorldProvider.java.patch
src/main/java/net/minecraftforge/common/ForgeVersion.java
src/main/java/net/minecraftforge/common/network/ForgeMessage.java
src/main/java/net/minecraftforge/fluids/BlockFluidBase.java
src/main/java/net/minecraftforge/fluids/FluidContainerRegistry.java
src/main/java/net/minecraftforge/fluids/FluidRegistry.java
src/main/java/net/minecraftforge/oredict/OreDictionary.java
2015-06-01 16:29:34 -04:00
LexManos
f9b1e4e23b
Merge pull request #1892 from AlgorithmX2/vanilla_lighting_bug
...
Fix Vanilla Lighting Bug - Fixes Top/Bottom Faces interpolation.
2015-05-26 19:24:37 -07:00
AlgorithmX2
76f8843017
Fix Partial Face Lighting on Top/Bottom Faces ; Vanilla MC-80148
2015-05-26 19:33:56 -05:00
Lex Manos
9fa51447a2
Fixed command exploit with C12
2015-05-25 16:08:42 -07:00
Lex Manos
c608e7c04e
Fixes MC-75630 - Exploit with signs and command blocks
2015-05-25 15:28:14 -07:00
Lex Manos
df5e594e95
Loosen up ServerChatEvent to support IChatComponent Closes #1893
2015-05-25 13:34:34 -07:00
LexManos
8d7b999506
Merge pull request #1804 from Prototik/font
...
Add true support for unicode fonts
2015-05-21 10:43:22 -07:00
Prototik
2798fc4e49
Add true support for unicode fonts
2015-05-21 20:14:56 +07:00
Flan
306af4feee
Added CameraSetup sub-event for camera angles
...
Allows players to alter yaw and pitch of renderViewEntity, but more importantly, adds the ability to roll the view.
Added camera roll hook
2015-05-19 16:14:44 +01:00
cpw
58fdfb6fa1
Fix patches after last fml merge.
2015-05-14 13:56:10 -04:00
Silfadur
b756bd5f9a
Added hook for IPerspectiveAwareModel in RenderItem.renderItemIntoGUI for ItemCameraTransforms.TransformType.GUI
2015-05-05 02:23:38 +02:00
LexManos
a003d1b360
Merge pull request #1843 from Zaggy1024/getlightvaluefix
...
Make World.setBlockState check whether the light value from getLightValue(IBlockAccess, BlockPos) has changed.
2015-05-01 17:58:30 -07:00
Zaggy1024
ee003ef77e
Fixed a bug which caused the light level not to update when a block implements Block.getLightValue(IBlockAccess, BlockPos) to change the light value for different block states.
2015-05-01 17:10:08 -05:00
LexManos
c6525cb3f3
Merge pull request #1832 from Parker8283/lhsf-1.8
...
[1.8] Fixes MC-52974: Host's skin doesn't load in LAN
2015-04-25 17:21:30 -07:00
Parker Young
9a7c20e791
Fixes MC-52974: Host's skin doesn't load in LAN
2015-04-25 19:58:24 -04:00
Zaggy1024
2589a0d1f6
Removed @SideOnly(Side.CLIENT) from EnumWorldBlockLayer.
2015-04-25 18:45:49 -05:00
cpw
55cbba0764
MinecraftForge/FML@36688e781a Add in resource reloading to the bar. Tidy up some of the labels a bit.
...
MinecraftForge/FML@a1dc465a55 More progress bar action!
MinecraftForge/FML@bfcbf4ef43 More progress bar hooks
MinecraftForge/FML@a6670c415e Thread errors should be correctly displayed in the crash report now
MinecraftForge/FML@9a16d26186 fixed bar text positioning
MinecraftForge/FML@0059c63028 Track mipmaps and texture upload
MinecraftForge/FML@ef5f809752 Fix broken log message in vanilla.
2015-04-24 19:16:55 -04:00
Lex Manos
591971936d
Cleanup RenderEntityItem patch, fixes Z-fighting issue in EntityItems. Closes #1824
2015-04-23 23:46:55 -07:00
Lunatrius
ea9d805e4f
Extracted the creation of RegionRenderCache into a method.
...
Classes extending RegionRenderCache can change the behavior of the cache, allowing to visually change blocks (schematics etc).
2015-04-22 15:40:07 +02:00
cpw
7e9d2fb509
Reformat ItemArmor$ArmorMaterial.getBaseItem to use an if/then/else structure. The switch
...
causes the generation of an internal class which may derp custom armor addition.
Closes #1799
2015-04-19 12:04:22 -04:00
cpw
178acfbb20
Change logging to avoid the String.format bug. Closes #1809
2015-04-19 11:52:23 -04:00
Lex Manos
1effc27790
Fixed NBTSizeTracker missing a lot of data being read. Also made new NBT object allocation claim 32-bits in the size tracker.
...
(cherry picked from commit de066a86da
)
Conflicts:
patches/minecraft/net/minecraft/nbt/CompressedStreamTools.java.patch
patches/minecraft/net/minecraft/nbt/NBTTagList.java.patch
2015-04-18 21:22:44 -04:00
Lex Manos
de066a86da
Fixed NBTSizeTracker missing a lot of data being read. Also made new NBT object allocation claim 32-bits in the size tracker.
2015-04-17 02:07:01 -07:00
Lumien
81ab4cbc5f
Added LivingExperienceDropsEvent to change the amount of experience an entity drops
2015-04-14 11:58:00 +02:00
cpw
eb12936a52
MinecraftForge/FML@0da1263ff9 Enhance error output for bad textures a bit more and try and capture more types of error..
2015-04-11 12:30:20 -04:00
cpw
345d905438
MinecraftForge/FML@be5ec06e31 Cleaning up the missing resource stack spam, and condensing the information into a usefully understandable format.
2015-04-11 01:03:50 -04:00
Timothy Tomkins
dfd42ab573
Player sensitive version of Block.getPickBlock
...
Block.getPickBlock was patched in 1.7 but was overlooked in 1.8.
Closes: https://github.com/MinecraftForge/MinecraftForge/issues/1709
2015-04-09 02:09:58 -04:00
iChun
8c35bc1dc7
Reimplement RenderPlayerEvent that was removed in the port to 1.8 from 1.7.10.
...
RenderPlayerEvent.Specials was removed because the special effects are done in the LayerRenderer now.
2015-04-03 21:11:43 +01:00
cpw
38b9febfe5
Forge really should have always supported the concept of an "exact spawn". Individual world providers can still
...
change this behaviour of course, but for default maps it makes sense to support it as a config option.
2015-04-03 10:31:25 -04:00
cpw
01000f9d34
Update FML - merge the 1.7.10 changes in to forge @ 1.8. Wow git is (sorta) AWESOME!
...
MinecraftForge/FML@6b0ae369eb Try and improve performance of the registry by avoiding superType.cast.
MinecraftForge/FML@dfebcafd49 Something I meant to add a long time ago, but it got overlooked. My apologies. Presend the (int) dimension ID in the serverhello packet. This should be 100% backward compatible with existing servers but bumping a server to this version will allow clients with this version as well to now login in dimensions outside the byte range. Probably fixes a bunch of mods that add dimensions.
MinecraftForge/FML@6011419fa0 Clean up my patch. Terrible person I am..
MinecraftForge/FML@c6bbd0e82d Forgot that I need a noarg ctor. I'm so rusty.
MinecraftForge/FML@6edc1635de Need to load the dimension from disk - do it without filling out the player so that the normal player loading (including events) works properly
MinecraftForge/FML@4ca6f6e19f What a dumb oversight. One needs to copy the active substitution set to the active gamedata. Doesn't work well otherwise.
MinecraftForge/FML@6f6cec96be Substitutions need to be activated when they're registered, otherwise they won't appear in world, ever.
MinecraftForge/FML@13ac015f0c Change iterator behaviour for the registry - include substitutions in the standard iterator, so that vanilla MC methods visit them (so they can get textures etc). The fml special one only visits the absolute set, used mostly for sanity checking and serialization.
MinecraftForge/FML@24cb4a42c4 Enhance output of common FML errors in crash reports and server GUI.
MinecraftForge/FML@12ccf9cf49 Rather than try to fall back to the backup level.dat in case of weirdness in the ID map, just fail hard. There is probably a serious modder derp in this case and there's nothing FML can do to recover the situation except avoid making it worse.
MinecraftForge/FML@e8cd368da3 It's an IllegalState not an IllegalArgument *sigh*
MinecraftForge/FML@2be9c74342 And fix itemblocks being removed, leaving behind a residual block. This is a legitimate action - use the missing mapping event to let the mod tell us about it
MinecraftForge/FML@7d8804cf65 You can't setAction to BLOCKONLY
MinecraftForge/FML@13df640d9d Pull in a lot of the FML tweaks from 1.7 to 1.8
MinecraftForge/FML@447beaa99e Merge remote-tracking branch 'origin/1.7.10'
2015-04-01 17:50:58 -04:00
cpw
8fe5d26e94
Merge remote-tracking branch 'origin/1.7.10'
...
Conflicts:
fml
2015-04-01 17:43:25 -04:00
cpw
e1c83de490
Comment on previous commit fix - it worked. Thanks to skyboy and tterrag for investigating and verifying.
...
A chest as an acheivement icon will recreate the original problem, for note.
2015-04-01 07:13:14 -04:00
cpw
1b7ce7592c
Experimental "fix" for the weird rendering in the Acheivements screen. Thanks skyboy for spotting this.
2015-03-31 20:50:16 -04:00
simon816
301088acdc
Add getTileData() to TileEntity
...
- The same idea as Entity.getEntityData()
2015-03-21 01:23:55 +00:00
cpw
c9fd2b6173
MinecraftForge/FML@6b0ae369eb Try and improve performance of the registry by avoiding superType.cast.
...
MinecraftForge/FML@dfebcafd49 Something I meant to add a long time ago, but it got overlooked. My apologies. Presend the (int) dimension ID in the serverhello packet. This should be 100% backward compatible with existing servers but bumping a server to this version will allow clients with this version as well to now login in dimensions outside the byte range. Probably fixes a bunch of mods that add dimensions.
MinecraftForge/FML@6011419fa0 Clean up my patch. Terrible person I am..
MinecraftForge/FML@c6bbd0e82d Forgot that I need a noarg ctor. I'm so rusty.
MinecraftForge/FML@6edc1635de Need to load the dimension from disk - do it without filling out the player so that the normal player loading (including events) works properly
2015-03-20 16:12:05 -04:00
JamiesWhiteShirt
3b567a92d8
Added newVolume and newPitch to PlaySoundAtEntityEvent. Deprecated ForgeEventFactory.onPlaySoundAt, added replacement ForgeEventFactory.onPlaySoundAtEntity.
2015-03-19 12:37:21 +01:00
LexManos
888bab92c3
Merge pull request #1723 from Geforce132/master
...
Add an EntityMountEvent.
2015-03-16 10:01:53 -07:00
Geforce132
d2f36d56f1
-Added EntityMountEvent.
2015-03-13 19:12:16 -05:00
LexManos
d93e8bcf48
Merge pull request #1733 from Zot201/enchantment-fix
...
Fixed enchanting table applying secondary enchs. Closes #1428
2015-03-02 12:10:12 -08:00
Zot201
ecca5720c8
Fixed enchanting table applying secondary enchs.
2015-03-02 17:00:38 +09:00
LexManos
7355bdf600
Merge pull request #1721 from me4502/update-event
...
Added NeighborNotifyEvent fired on server side only, allows for monitoring and disabling world 'physics' updates.
2015-02-28 22:54:48 -08:00
Me4502
c21e38cd3b
Add NeighborNotiftyEvent.
2015-03-01 16:53:32 +10:00
Lex Manos
1af0734f51
Fix compile error in ClientHax's PR.
2015-02-26 23:20:43 -08:00
LexManos
d82e80b2cf
Merge pull request #1729 from clienthax/master
...
Add method to set entity placement type.
2015-02-26 22:16:22 -08:00
clienthax
848dee14d2
Current spawner implementation checks the EntitySpawnPlacementRegistry hashmap to check where a entity should spawn
...
as there is no way to modify this without the use of reflection or a AT, you can not specify where you want your entity to spawn
adding this helper method will allow developers to specify where they want their entity to spawn.
Signed-off-by: Clienthax <clienthax@gmail.com>
Update EntitySpawnPlacementRegistry.java.patch
2015-02-27 03:58:40 +00:00
Tmtravlr
f152741bba
Added Nether Fortress chest to the ChestGenHooks
...
I tried to follow the directions on
https://github.com/MinecraftForge/MinecraftForge/wiki/If-you-want-to-contribute-to-Forge
as best as I could. =)
If anything is wrong, let me know and I'll change it!
2015-02-26 14:25:41 -07:00
Lex Manos
7c03542d94
Fire WorldEvent.Load for Client worlds. Closes #1719
2015-02-23 02:18:58 -08:00
Lex Manos
b2ca559851
Make Container.mergeItemStack respect Slot.isValidItem Closes #1630
2015-02-23 02:03:52 -08:00
Lex Manos
f16a7ff890
Fix JukeBoxes not storing the inserted record. All TE's in minecraft are in net.minecraft.tileentity EXCEPT JukeBoxes. Closes #1633 Closes #1714
2015-02-23 01:44:54 -08:00
Lex Manos
ae085bb84d
Fixed using items on the wrong block client side caused by iChuns eyeheight update.
2015-02-19 18:09:36 -08:00
iChun
d66951b368
Reimplement variable eyeHeight for players which was removed in the 1.7 to 1.8 port.
2015-02-19 02:08:03 +00:00
LexManos
83ca72bef2
Merge pull request #1708 from matthewprenger/PR-1
...
Ability to add prefixes and suffixes to the player's display name
2015-02-16 22:52:03 -08:00
RainWarrior
b14cfa45e5
RenderItem can now use baked quad color
2015-02-17 05:02:16 +03:00
Matthew Prenger
b4f8945fec
Add the ability to add prefixes and suffixes to the player's display name.
2015-02-15 17:47:13 -06:00
RainWarrior
5616d0c1b0
ModelRotation.getMatrix() now returns the correct matrix; fixed the application of custom transformations to vanilla models; fixed application of transformations to B3D models; fixed the culling of rotated vanilla models
2015-02-14 04:44:41 +03:00
Lex Manos
f0d96b7c50
Fixed being kicked from the server while swimming.
2015-02-06 21:35:27 -08:00
Lex Manos
9704f25aa8
Fixed potential NPEs in Structure code caused by componenets not being able to load.
2015-02-05 17:03:43 -08:00
Lex Manos
c80e75de9b
Fixed potential NPEs in Structure code caused by componenets not being able to load. Closes #1686
2015-02-05 17:02:30 -08:00
Lex Manos
b036b37a35
Fixed BlockBush and BlockCrops not respecting custom soils. Closes #1683
2015-02-04 12:20:24 -08:00
Lex Manos
48c24246a5
Fixed InitMapGenEvent's fire order so values are used. And added OCEAN_MONUMENT type. Closes #1681
2015-02-04 12:20:24 -08:00
RainWarrior
b8add23d9b
ModelBakeEvent now has ModelLoader as an argument instead of ModelBakery; Added various static hooks to ModelLoader to allow registering model-related information before it's needed (prevents file-not-found errors on first baking pass); ModelLoader waits until ModelBakeEvent is done before showing any missing model exceptions; It's now possible to define models completely in-code (as illustrated by ModelBakeEventDebug).
2015-02-04 09:45:23 +03:00
Lex Manos
76825d19b8
Fixed Buttons not dropping anything when broken. Closes #1676
2015-02-01 10:49:17 -08:00
Lex Manos
80c0ff4066
Fixed domain support in ArmorMaterial texture name. Closes #1675
2015-02-01 10:48:48 -08:00
RainWarrior
6eba0ebb93
Added model loader registry
...
Entry point: ModelLoaderRegistry
loader interface: ICustomModelLoader
custom model: IModel
ModelLoader is responsible for splicing into vanilla model system.
(you probably don't need to use it directly)
Interop with vanilla models isn't great yet
(vanilla models can't refer to custom ones as parents), will improve in
the future.
Includes loader for B3D models, with animation support
(net.minecraftforge.client.model.b3d).
Blender export plugin with compatible coordinate system:
https://github.com/RainWarrior/B3DExport
OBJ loader is being written, will be included at some point in the
future. For now you can convert OBJ to B3D via blender, or wait.
2015-01-29 11:33:52 +03:00
Lunatrius
4380ca026e
Fixed NPE when canceling ClientChatRecievedEvent. Fixes #1644
2015-01-16 23:09:45 +01:00
Lex Manos
f6a378e136
Silently eat exceptions when getting a TE's rendering bounding box, this 'fixes' Bukkit servers screwing up world data and causing clients to crash.
2015-01-14 19:02:50 -08:00
asiekierka
0a707236e1
fix shouldRefresh being too broad in tile entity update
2015-01-11 11:12:54 +01:00
RainWarrior
dcabad2bd1
Merge pull request #1602 from Chicken-Bones/1.8
...
Allow blocks to render in multiple layers
2015-01-10 13:35:29 +03:00
Lex Manos
64bf7bb3be
Fix value passed for Item.getModel useRemaining argument. Closes #1623
2015-01-08 23:37:06 -08:00
Lex Manos
fb88b021c5
Made Chunk.fillBlock respect TileEntity.shouldRefresh.
2015-01-08 23:22:45 -08:00
Lex Manos
5328701219
Fix potential NPE when loading a single player world where you were saved in a unloaded dimension. Closes #1575
2015-01-08 21:42:13 -08:00
CovertJaguar
30196b8696
Bulk Chunk Data packets should also check TileEntity.shouldRefresh().
2015-01-07 15:37:54 -08:00
Chicken-Bones
0cbc685d3c
Allow blocks to render in multiple layers
2014-12-26 15:45:00 +10:00
Lex Manos
51271dcc3a
Fix MC-30864 (sending web links in chat)
2014-12-23 15:04:41 -08:00
LexManos
d5d312b452
Merge pull request #1491 from killjoy1221/master
...
Fix MC-30864 (sending web links in chat)
2014-12-23 14:33:10 -08:00
LexManos
389abd98c1
Merge pull request #1338 from MinestrapTeam/renderpane
...
Fix Stained Glass pane rendering issues
2014-12-23 14:03:36 -08:00
Lex Manos
959eaf0218
Fix BlockSnapshots not firing correctly due to patch mixup in 1.8 update. Closes #1591
2014-12-21 18:55:46 -08:00
Lunatrius
7916a21682
Fixed messages not being added to the chat history and ClientCommandHandler not being called when sleeping.
2014-12-18 20:46:24 +01:00
LexManos
010e687664
Merge pull request #1581 from Lunatrius/fix-chat
...
Fixed messages not being added to the chat history
2014-12-18 10:33:13 -08:00
Lex Manos
4aaabdd0e0
Fix incorrect logic in world change clumping.
2014-12-18 08:11:30 -08:00
Lex Manos
7419c2aa91
Fix incorrect logic in world change clumping.
2014-12-18 08:11:06 -08:00
Lex Manos
cd4e73edfa
Remove our changes to Stitcher slot allocation.
2014-12-18 08:10:38 -08:00
Lunatrius
9453c1d209
Fixed messages not being added to the chat history and ClientCommandHandler not being called when sleeping.
2014-12-17 03:38:26 +01:00
Lex Manos
9d95952dc1
Remove our changes to Stitcher slot allocation.
2014-12-13 18:07:31 -08:00
Lex Manos
fd859812eb
MinecraftForge/FML@e3785c2893 Ensure that EntitySpawn and OpenGUI packets are handled in the world thread. Also log all errors that are thrown in FutureTasks.
2014-12-13 18:07:13 -08:00
LexManos
ca2d49b4cd
Merge pull request #1518 from RainWarrior/model-event
...
Added model bake event, ISmartBlock/itemModel, Block.getExtendedState, IExtendedState and IUnlistedProperty
2014-12-12 12:44:05 -08:00
Lex Manos
0b41756125
Untie ItemModelMesher from using Item Ids internally by implementing our own simple mechanics using Trove.
2014-12-12 11:47:27 -08:00
Lex Manos
bf66e45699
Fix texture stitcher not using all avalible spaces.
2014-12-11 16:40:48 -08:00
Lex Manos
64952331e2
Fix texture stitcher not using all avalible spaces. Closes #1557
2014-12-11 16:40:28 -08:00
Lex Manos
a6c6a79916
Fixed log spam when breaking DoublePlants. Closes #1555
2014-12-10 05:44:07 -08:00
Lex Manos
7c79a4226f
Fix missed patch causing Dispensed Armor to go into the wrong slot. Closes #1560
2014-12-10 05:36:15 -08:00
Lex Manos
f9955efb08
Expand PlayerWakupEvent to expose the three parameters passed into EntityPlayer.wakeUp.
2014-12-07 05:48:26 -08:00
Lex Manos
81086375e8
Expand PlayerWakupEvent to expose the three parameters passed into EntityPlayer.wakeUp. Closes #1486
2014-12-07 05:48:02 -08:00
Lex Manos
4cc278a125
Improved Control of Enchantment.canApplyTogether() in Mod Enchantments, allowing both enchantments to determine if they can apply together. Closes #1434
2014-12-07 05:37:11 -08:00
Lex Manos
fd3f948e4c
Improved Control of Enchantment.canApplyTogether() in Mod Enchantments, allowing both enchantments to determine if they can apply together.
2014-12-07 05:20:50 -08:00
Lex Manos
309fe700cd
Changed ToolMaterial's repair material to ItemStack version to allow metadata sensitive versions.
2014-12-07 04:30:10 -08:00
Lex Manos
35fac1f691
Changed ToolMaterial's repair material to ItemStack version to allow metadata sensitive versions. Closes #1355
2014-12-07 04:29:55 -08:00
Lex Manos
83bcebf3b1
Fix invalid argument being passed to Block.isNormalCube from World.updateNeighbors. Closes #1339 and Closes #1346
2014-12-07 03:49:36 -08:00
Lex Manos
24213a8ca7
Added PotionBrewEvent.Pre/Post. To allow for modification and cancelation of Brewing. Closes #1248
2014-12-07 03:30:52 -08:00
Lex Manos
27524a02ae
Added PotionBrewEvent.Pre/Post. To allow for modification and cancelation of Brewing.
2014-12-07 03:30:10 -08:00
Lex Manos
c9fe5ded9b
Add LivingHealEvent called from EntityLivingBase.heal() Closes #1282
2014-12-07 02:35:07 -08:00
Lex Manos
44b21681e2
Add LivingHealEvent called from EntityLivingBase.heal()
2014-12-07 02:34:28 -08:00
Lex Manos
f2b1622355
Added CreateSpawnPosition event.
2014-12-07 01:52:29 -08:00
Lex Manos
877ba864e7
Added CreateSpawnPosition event Closes #1053
2014-12-07 01:52:17 -08:00
Lex Manos
0c11a1544f
Cleanup deprecated code, and TODOs in OreDictionary. Down-typed things from ArrayList to List. Asking for the ores with a null stack will now throw an Exception.
2014-12-07 01:50:26 -08:00
Lex Manos
49eeedd854
Fixed bug in ServerConfigurationManager.transferPlayerToDimension where it would send the old dimension's information. Closes #1548
2014-12-07 00:39:30 -08:00
Lex Manos
b417594e71
Fixed bug in ServerConfigurationManager.transferPlayerToDimension where it would send the old dimension's information.
2014-12-07 00:39:09 -08:00
Lex Manos
42938a1e7f
Added Explosion Start and Detonate events to control explosion.
2014-12-07 00:28:41 -08:00
Lex Manos
861c00fdfc
Added Explosion Start and Detonate events to control explosion. Closes #1469
2014-12-07 00:27:51 -08:00
mezz
75c7862e78
Add GuiScreenEvents for keyboard and mouse input
2014-12-06 19:06:19 -08:00
RainWarrior
134fbaa1ff
Added model bake event (allows mods to insert custom baked models, much like TextureStitchEvent allows to load custom textures), ISmartBlock/ItemModel (ability form models to react to block/item states), Block.getExtendedState, support for unlisted properties in block states. Includes example implementation of http://imgur.com/a/FyyJX
2014-12-04 14:16:30 +03:00
Lex Manos
1fc1570663
Only call blockBreak when block itself changes, not just meta. Fixes bottles poping out of brewing stands.
2014-12-02 21:40:50 -08:00
Lex Manos
07db77401d
Fix finding of spawn location for mobs. Closes #1546
2014-12-02 21:37:15 -08:00
Lex Manos
c683bce659
Remove debug patch I left in.
2014-12-01 19:17:11 -08:00
Lex Manos
59df94bd90
Updated FML:
...
MinecraftForge/FML@9c8ca4a4e3 Unlink banner block and item id. Mojang should of matched these up but they didn't -.-
MinecraftForge/FML@84a101f344 Update Dev mcp mappings to 11-30 snapshot.
2014-12-01 19:11:17 -08:00
Lex Manos
4caf09cd33
Fix stickey pistons not retracting properly.
2014-12-01 14:53:30 -08:00
Lex Manos
6ff24351d3
Fixed blocks not breaking properly when instantly destroied.
2014-11-30 23:55:28 -08:00
Lex Manos
9f4ef7b38a
Fixed vanilla issue where exceptions in World tasks would not be logged.
2014-11-30 23:55:04 -08:00
Lex Manos
7cc7056c57
Fix NPE with BlockSnapshots that caused items with TileEntities to be used up in creative mode.
2014-11-30 23:54:17 -08:00
Lex Manos
2a02804379
Fixed vanilla bug where top part of double plants would flicker a tifferent texture before dissapearing.
2014-11-30 23:50:56 -08:00
Lex Manos
c539d5389a
Fix BlockPane's connection detection.
2014-11-30 08:36:24 -08:00
Lex Manos
b4779be2f6
Fixed snow layers not being able to stack more then twice. Closes #1534
2014-11-29 23:04:22 -08:00
Lex Manos
cbcdbf56bb
Fixed Entities not being able to climb ladders, Closes #1535
2014-11-29 23:03:55 -08:00
Lex Manos
d6d4735a70
Fixed Entity extended properties init order. Closes #1532
2014-11-29 23:03:26 -08:00
Lex Manos
f35a53bad5
Fix not being able to place blocks in liquids, and related issues.
2014-11-28 11:19:30 -08:00
Lex Manos
dcefcc9047
Fix destroy particles not being added. Closes #1528
2014-11-28 08:31:14 -08:00
Lex Manos
aa07fa4443
Fix potential NPE in Block.isToolEffective
2014-11-28 08:19:40 -08:00
Lex Manos
d879b2c70d
Fix wrong state being passed to Block.getDrops
2014-11-28 07:43:50 -08:00
Lex Manos
17e5480b6e
Fix Entityies not taking damage correctly. Closes #1511
2014-11-28 07:43:10 -08:00
Lex Manos
a059a9a7fb
Fix inverted logic preventing blocks from breaking.
2014-11-28 07:10:37 -08:00
Lex Manos
8dc71d5ffa
Fixed crash with caomparators due to wrong position. Closes #1512
2014-11-28 06:51:55 -08:00
Lex Manos
b9c2968c0e
Fix creative picking a CommandBlock minecart returning wrong item. Closes #1523
2014-11-28 06:09:33 -08:00
Lex Manos
74a57bd9d6
Fix creative picking a CommandBlock minecart returning wrong item. Closes #1523
2014-11-28 06:08:39 -08:00
Lex Manos
0edeb1e04b
Fix acedential inversion causing some tress to not have leaves. Closes #1522
2014-11-28 06:02:41 -08:00
Lex Manos
dce17105ea
Fix fog colors, Closes #1524
2014-11-28 06:01:03 -08:00
Lex Manos
277fc4ea7d
Fix local variable conflict in Forge patch and latest MCP mappings.
2014-11-26 01:12:11 -08:00
Lex Manos
53659fca06
Initial update to 1.8, Super beta. Most rendering related hooks are out due to major changes in 1.8.
...
Some notes:
Almost all int x, int y, int z parameters have been changed to BlockPos class
ForgeDirection has been removed, replaced by net.minecraft.util.EnumFacing.
All FML classes have moved from packet cpw.mods.fml to net.minecraftforge.fml
Fluid Rendering has been disabled for the time being, to be re-evaulated and a test mod created for it.
Minecraft now uses a Model based system for rendering blocks and Items. The intention is to expand the model format to better suit modder's needed once it is evaulated.
As such, The model loaders from Forge have been removed, to be replaced by expanding vanilla's model format.
Metadata has been extracted out in Minecraft to IBlockState, which holds a list of properties instead of magic number metadata. DO NOT listen to the fearmongering, you can do EVERYTHING with block states you could previously with metadata.
Stencil Bits are disabled entirely by for the main Display, Modders must enable and recreate the FrameBuffer if they wish to use Stencil Bits.
2014-11-26 00:00:54 -08:00
XCompWiz
a5358eb916
Fixes client-side fake rain
...
Changes the updateWeather function in WorldServer to only send the
weather info to players in the correct dimension, rather than all
players on the server. This is what causes the client-side rain, as the
client believes that it has started raining locally, rather than in
another dimension.
2014-11-11 01:39:26 +02:00
Matthew Messinger
21ffd28adb
Fix MC-30864 (sending web links in chat)
2014-11-10 15:24:27 -05:00
Lex Manos
47305ff691
Player sensitive version of Block.getPickBlock Closes #1348
2014-11-04 18:27:02 -08:00
Lex Manos
ef0e0d7393
Fix slots being black due to vanilla blending leakage Forge fixes. Closes #1325 & #1242
2014-11-04 18:07:42 -08:00
Lex Manos
2af2795288
Fix logic error in Blodd's Snapshot capture that caused blocks to not be updated to the client. Closes #1451
2014-10-16 20:49:00 -07:00
Azanor
46dfaa6d0c
Fix for biome weights under 10
...
This solves the problem where custom mod biomes with weights under 10
not being generated in the world.
Cleaned up the code and made the patch smaller
2014-10-16 12:28:10 +02:00
LexManos
3aef547046
Merge pull request #1418 from Parker8283/wakeupevent
...
Added PlayerWakeUpEvent
2014-10-11 11:34:50 -07:00
Parker
ff36d4f1d3
Added PlayerWakeUpEvent
2014-10-11 14:13:25 -04:00
LexManos
38275c8232
Merge pull request #1364 from Adubbz/master
...
Fixed biome weights not working with non multiples of 10
2014-10-08 17:58:26 -07:00
Lex Manos
b0190bb50d
Fix vanilla lighting issue and blending issues in achievements gui. Closes #1445
2014-10-08 17:54:20 -07:00
LexManos
6da8a19094
Merge pull request #1219 from Lunatrius/master
...
Prevent client only commands from bleeding through to the server.
2014-10-06 14:50:47 -07:00
bloodshot
37f91681d9
Added PlaceEvent and MultiPlaceEvent which fires before placing a block.
...
Before calling "ItemStack.tryPlaceItemInWorld", a recording flag is turned on for
setBlock to capture a blocksnapshot for each block that attempts to be placed.
If 1 block is captured, a "BlockEvent.PlaceEvent" is fired to notify mods.
If 2 or more blocks are captured, a "BlockEvent.PlaceEvent" is fired first with the first block
captured followed by a "BlockEvent.MultiPlaceEvent" with all captured blocks. This extra event
is required for items that have the ability to place 2 or more blocks such as a BlockBed.
If either event is cancelled, the recorded block snapshot(s), item stacksize, and item meta will
revert back to the captured snapshot(s).
If the events are not cancelled, a notification will be sent to clients and block physics will be updated.
What this means for mods is Forge will be able to capture all player block placement automatically and fire
a PlaceEvent and/or MultiPlaceEvent.
If for whatever reason your mod does not use the standard placement methods then you will need to fire the
appropriate placement events in order to notify mods/servers.
This commit also includes a new utility class called BlockSnapshot which is serializable. This new class is used in conjunction with
both PlaceEvent and MultiPlaceEvent in order to record a snapshot of block space before it is altered. This
allows us to restore the block(s) if an event is cancelled. The class also provides the ability to restore a snapshot
to any location using the restoreToLocation method. This should be helpful to many mods that are looking to be able
to capture block data then restore it to back to any location required.
2014-10-02 11:33:25 -04:00
Lunatrius
7cff6f4c80
Prevent client only commands from bleeding through to the server.
2014-09-17 01:48:44 +02:00
nekosune
f9c68bba81
Fixed Clientside GameProfile UUID being null on offline mode
2014-09-10 00:24:36 +01:00
diesieben07
126d7e3ebe
Added Item#isBeaconpayment
2014-09-06 23:39:38 +02:00
cpw
de521cf531
MinecraftForge/FML@4ce3e73bfe Add overloaded version of SimpleNetworkWrapper#registerMessage that takes the MessageHandler instance directly, allowing to specify the same handler for multiple messages.
...
MinecraftForge/FML@cbe2ccbda4 Add in ModType to the jar manifest. If it's present, and doesn't have value "FML" it will be skipped from the modloading cycle. This should let liteloader mods have a .jar extension.
MinecraftForge/FML@37cf0174fc OK, lets make that a csv list. It'll let you be liteloader and fml in one jar file!
MinecraftForge/FML@0475b15eb1 Change the mods and modListFile argument handling a bit. Other tweakers will get a chance at looking at them now - they're only removed right before launch.
MinecraftForge/FML@abeac06a2e Two new features. ModLists can have a "parent" mod list. Circularity will result in a crash, so be careful. Mods specified in a child will override ones from a parent (using the maven group:name:classifier triple to identify - ignoring the version component)
MinecraftForge/FML@7fcfedcfef Canonicalized file paths in modListFile handling with the minecraftDirectory.
MinecraftForge/FML@633fce19d4 Make Keyevent also fire for key releases
MinecraftForge/FML@57ba2339b6 Merge branch 'keyup-event' of github.com:diesieben07/FML
MinecraftForge/FML@1ff048062c Merge branch 'simple-netw-improve' of github.com:diesieben07/FML
2014-08-31 21:59:47 -04:00
cpw
24989689b3
GIANT FML UPDATE! Bump forge revision number, and fix patches for ItemStack changes. More to come on this branch I expect.
...
MinecraftForge/FML@7c5cf21904 Implement STDOUT/STDERR redirection.
MinecraftForge/FML@bc78e31cb7 added support for \n in tooltip strings added \n test tooltip localization fixed int/double conversion error in slider entry added test slider scenario that highlighted conversion error
MinecraftForge/FML@a2908e5c59 Clean up a bunch of compiler warnings.
MinecraftForge/FML@7f67523d87 Update realms to 1.3.2
MinecraftForge/FML@73f23c24b8 Merge branch 'std-redir' of github.com:Emberwalker/FML
MinecraftForge/FML@1c6b25df74 If an IO exception comes from the datawatcher, spew it all over the console don't discard it silently. Should stop pixelmon blaming forge for their mistakes.
MinecraftForge/FML@e77da9eb2f And fix the read side too, incase someone is trying to bitbang and failing.
MinecraftForge/FML@305d8950c9 Make LogContext optional. This can be useful for debugging mod issues, but Apache's implementation in log4j2 is responsible for a very significant % of the overall runtime. Quite frankly this is shockingly bad performance from what is supposed to be a high performance logging framework. Anyway, until we can figure out if we can fix it, we're turning it off by default.
MinecraftForge/FML@bdfca1c8ed Make more noise when people screw up mod downloading and put .jar.zip in their mod folders.
MinecraftForge/FML@2108494112 Add a custom version range factory method. Should hush skyboy's complaints. Closes #486
MinecraftForge/FML@7c1e6aaa40 Add a delegate to every item and block. this should help with renaming fun stuffs. Also, fix all the tabs from my previous commits. *sigh*
MinecraftForge/FML@61fcb4df06 Tweak Itemstack patch to always delegate to the method call. Set the field, so it's in sync.
MinecraftForge/FML@eb8c5ab146 Fix nested directory for language resources. Closes MinecraftForge#1264
MinecraftForge/FML@7c05e5f70d Default collections, so that we don't crash if useDependencyInfo is true. Closes #485
MinecraftForge/FML@9729fe2332 Kill net.minecraft.src warning. It hasn't served a purpose in a long time now. Closes #313
MinecraftForge/FML@21e875ef22 AllowPlayerLogins only after the server has completed the core init tasks. Closes #372
MinecraftForge/FML@46cfeade80 Add a constructor to CustomModLoadingDisplayException. Closes #387
MinecraftForge/FML@a6eab2683a Update README.txt
MinecraftForge/FML@f75838461c Last part is the itemstack transformer. Itemstacks should now only be loosely coupled with the items within.
MinecraftForge/FML@51f24e9e6d First draft of add alias. It is probably not properly persistent atm.
MinecraftForge/FML@2a4c642470 Finally fix stupid NPE error caused by FML trying to parse the super of Object in IDEA envs.
MinecraftForge/FML@c1b1417ee1 FML now supports passing a json formatted modlist as an argument, as well as a comma separated argument list. These facilitate modpacks mostly, by meaning you don't need to duplicate mods. The modlist is arranged in the maven style, with mods referenced maven-like.
MinecraftForge/FML@3d42cda2a2 Build.Gradle Patch
MinecraftForge/FML@20c7add845 Merge pull request #484 from bspkrs/master
MinecraftForge/FML@26ed4b992e Clear button list on FML fatal error screens. The hidden cancel button should not be there. Closes #497
MinecraftForge/FML@ebe4f5c5e2 Merge pull request #494 from AntonBoch1244/patch-1
MinecraftForge/FML@ad0da05f5c Fix the ItemStack transformer to find the method and field so it works with srg and mcp naming.
MinecraftForge/FML@65d380181a Extend timeout for client to 5 seconds. Should fix Forge #1322
MinecraftForge/FML@45486a0b6d Fix almost invisible NPE in TerminalTransformer when loading a non-existant class
MinecraftForge/FML@13da3efce0 Allow a clean way to exit the game without big ugly warnings, but with logging information available if needed. Closes #496
MinecraftForge/FML@fda305edfe Some more tidying up of the exit handling
MinecraftForge/FML@b087f60c33 More cleanup of exit handling, also add a couple more noise classes to the list of things ignored.
MinecraftForge/FML@d6358a466b Cleanup override warnings
MinecraftForge/FML@af7a58b9e5 Update to legacylauncher 1.10 and asm 5.0.3
MinecraftForge/FML@e6d00440a6 ItemStack swapping
MinecraftForge/FML@8597e45a0e Fix NPE from a boolean
MinecraftForge/FML@b9b9daa8a9 Fix ups from feedback.
MinecraftForge/FML@d89165021f Mark the promise a success in the outbound handler.
MinecraftForge/FML@2e5ccf7988 Update for launchwrapper 1.11. Fixes java 6 compatibility.
MinecraftForge/FML@641250d853 Fix java 8u20. Closes #501 and a bunch of other bugs too.
MinecraftForge/FML@292be72639 Allow client handshake to be reset by server to support BungeeCord.
MinecraftForge/FML@092873fbe5 Merge branch 'bungeecord' of github.com:bloodmc/FML
MinecraftForge/FML@134f2f8e88 Fix bug with entityspawn - if the entity doesn't extend livingbase, it fails to write a headyaw byte, and everything will be derped for that packet.
MinecraftForge/FML@4852de81e0 Wrap the server description box a little bit shorter. Stops the overlapping. Closes #489
2014-08-30 00:16:46 -04:00
Adubbz
0d93bec5e7
Fixed biome weights not working with non multiples of 10
2014-08-30 10:35:05 +10:00
Clashsoft
3119f700f3
Fix Stained Glass pane rendering issues
2014-08-18 20:28:15 +02:00
cpw
6fafbf3b09
Attempt to properly resolve this daft metadata and TE nonsense. This might be mod impacting, if you maintain a reference to a TE via neighbour update calls - you
...
might see two TEs for a single setblock where previously you saw one. This is a phantom TE being created by badly written neighbour triggers - I'm looking at you
redstone.
Anyway, with luck, this'll close a slew of bugs across Forge, IC2, MFR, TE, RC. Yeah, fun times. Thanks to LexManos, skyboy and KingLemming for helping figure this
issue out. Quite frankly, from now on, issues with phantom TEs will be mods behaving badly. Modders will need to adapt.
2014-08-13 00:00:29 -04:00
LexManos
016e303379
Fix invalid math in GuiContainerCreative.
2014-08-12 17:32:53 -07:00
SackCastellon
2519822b25
Add ItemStack sensitive version of getItemEnchantability
2014-08-12 16:48:01 +01:00
Lex Manos
6f693206de
Add ability for creative tabs that have search bars to customize the text box's width, and prevent the default set of enchanted books from being displayed in those tabs. Closes #1303 Closes #1301
2014-08-11 19:18:38 -07:00
LexManos
948f7145d1
Merge pull request #1187 from Abastro/skylight
...
Skylight Hooks for Minecraft Forge
2014-08-11 16:00:11 -07:00
Abastro
f590ce8641
Skylight Hooks for Minecraft Forge
...
Mainly for solar/lunar eclipse.
2014-08-11 15:42:07 +09:00
Lex Manos
5131aed7bd
Fix metadata for every permutation -.- Closes #1294
2014-08-05 15:18:02 -07:00
Lex Manos
d2682ab969
Fix patch screwup in Skyboy's Fishing PR -.-
2014-08-05 15:17:10 -07:00
Lizbeth Rika
63140bcf7f
Fixed items with more than 2 render passes rendering weird in first person
2014-08-05 21:10:28 +01:00
DemoXin
68fd0049fb
* Added AT for ContainerRepair.stackSizeToBeUsedInRepair (Now public)
...
* Added ability to AnvilUpdateEvent to alter stackSizeToBeUsedInRepair (vanilla behavior is now reproducable)
* Added AnvilRepairEvent, fired when the player removes an ItemStack from the output slot of ContainerRepair, and allows the chance to damage the anvil to be altered.
2014-08-04 16:54:35 -04:00
LexManos
224987aa83
Merge pull request #1128 from skyboy/patch-fishingapi
...
Add API for fishing results, I'm tired of this, If shit breaks, Blame Skyboy and King_Lemming.
2014-08-03 16:28:32 -07:00
Lex Manos
cd2982f9b1
Closes #1280
2014-08-02 11:32:34 -07:00
Lex Manos
10192959f9
Fixed bug that allowed duplication of Fluids with redstone dust. Closes #1279
2014-08-01 18:37:54 -07:00
Adubbz
2affeae979
Added an event for fog rendering
2014-07-28 17:01:38 +10:00
skyboy
cc169c3ea1
Update FishingHooks
2014-07-25 06:42:17 -04:00
cpw
bbcc515063
Revert old light amortization patch. It seems to be breaking chunk sending pretty badly when more
...
than a couple of people are online. Tests indicate it is not useful anymore.
2014-07-24 21:40:30 -04:00
skyboy
906dcb999d
Add FishingHooks
2014-07-24 04:12:45 -04:00
Lex Manos
c69958e34b
Made skulls respect Block.isReplaceable when placing, also prevented them from deleting blocks when placed at certain angels. Closes #1233
2014-07-16 18:37:49 -07:00
Darkhax
08826ed84b
Changed exception message for duplicate enchantment ids to contain the
...
class path for both enchantments along with the enchantmnet id that has
been duplicated.
2014-07-16 07:08:57 -06:00
LexManos
e2fe13bd17
Merge pull request #1226 from williewillus/xporb
...
Fix experience orbs spawning at 32x coordinates clientside
2014-07-14 14:56:52 -07:00
Vincent Lee
a35457ecb7
Fix comment derp (+1 squashed commits)
...
Squashed commits:
[52c40bc] Fix experience orbs spawning at 32x coordinates clientside
Add // FORGE comment
Add // FORGE comment to clarify the purpose of the change
2014-07-14 16:43:16 -05:00
Vincent Lee
5c0217d316
Fix chat opacity
...
Add // FORGE comment
As per convention, add // FORGE comment to clarify the purpose of the change
2014-07-13 23:44:47 -05:00
Lex Manos
52ec4f7c57
Updated FML:
...
MinecraftForge/FML@ab52901b8b Force preferIPv4Stack to true early in the load chain to combat netty loopback issues.
MinecraftForge/FML@11893fbbb7 Add system property to skip doing world backups when game registry changes. This is SEVERLY ill-advised, if you do this DO NOT ask for any support.
MinecraftForge/FML@fdb6b34b8f Update authlib and realms to latest json data.
MinecraftForge/FML@b3a74882b4 added slider controls for numerics. default control is textbox, but slider can be used as a custom list entry class. fixed constructor javadocs in GuiConfig
MinecraftForge/FML@7c6d1f7568 Merge pull request #468 from bspkrs/master
MinecraftForge/FML@692d955c1a Update tweaker login to use authlib.
MinecraftForge/FML@c2119eb1c1 Update realms library to 1.3.1, and implement network latch when connecting to Realms. Tested and working.
2014-07-11 18:17:50 -07:00
TheCountryGamer
7adaef9aed
RenderBlockOverlayEvent patch
...
Fixes skewed XYZ parameters
2014-07-08 15:49:32 -04:00
Lex Manos
195542c5fb
Fixed Enchantment.addToBookList Closes #1160
2014-07-07 21:54:32 -07:00
LexManos
ba6c2c88ed
Merge pull request #1194 from diesieben07/potion-icon
...
Added hook for potion inventory icons
2014-07-07 19:56:52 -07:00
LexManos
a6b7ba06c6
Merge pull request #1163 from TheCountryGamer/master
...
Added RenderBlockOverlayEvent
2014-07-07 19:50:04 -07:00
Lex Manos
f6471c3c08
Added World to ChunkProviderEvent.ReplaceBiomeBlocks, and exposed metadata to End and Nether generation events. Close #1201
2014-07-07 19:47:50 -07:00
Lex Manos
86ccfb1d68
Made EmeraldOre respect isReplaceableOreGen. Closes #1157
2014-07-07 18:55:24 -07:00
TheCountryGamer
7e7870026e
Added RenderBlockOverlayEvent.java
...
Adds a Forge event which controls whether an overlay is rendered.
Overlays include: First-person fire, Block (when inside a block)
and water when a player is inside a water block.
Patched for easier manipulation of event
Fixed for Lex
To be squashed
Removed Contructor
Added block XYZ parameters
TODO, the second block overlay event’s XYZ might not be correct
2014-07-07 21:49:51 -04:00
LexManos
53ce6f69e7
Merge pull request #1200 from tterrag1098/master
...
Add AchievementEvent
2014-07-07 18:37:53 -07:00
LexManos
81a791bac7
STENCIL buffer and DEPTH buffer, attempt a fix for GL errors.
2014-07-06 22:19:13 -07:00
Lex Manos
d35098ab9e
Remove the BLEND enable in rendering damage bars. And exclicitly fix blend states in some GUI elements.
2014-07-06 16:25:14 -07:00
tterrag1098
a3c268b577
Add AchievementEvent
...
Allows modders to react to players receiving achievements, and cancel
them.
Fix indentation
More shortening
Down to one line...
Remove newline
2014-07-02 20:18:53 -04:00
LexManos
a59c5fbd8c
Merge pull request #1197 from MrIbby/patch-1
...
Add RenderItemInFrameEvent
2014-07-01 12:34:41 -07:00
Gerard Bruwn
aca429f17b
Add RenderItemInFrameEvent
2014-07-01 09:58:44 -07:00
Lex Manos
6db5d2ed26
Fixed issue where Fire's 'fizz' would not play for the person who extinguished the fire.
2014-06-30 11:08:18 -07:00