1434419e47
Fix gameDir argument error on dedicated server.
2019-06-09 11:19:01 -07:00
3385e62aa7
Add forge registries for most vanilla registries
...
Made all registry names consistent with their vanilla counterparts
Also added a system for legacy registry names, so no data will be lost
Cleaned up formatting in GameData and ForgeRegistries
2019-06-09 04:23:39 -04:00
892fea3df9
Add forge registry for container types, expose ScreenManager.registerFactory
2019-06-09 00:19:17 -04:00
728b4857c3
Fix misobfed methods due to mapping conflict.
2019-06-08 09:22:03 -07:00
9fa4641cb0
Update mappings
...
Signed-off-by: cpw <cpw+github@weeksfamily.ca>
2019-06-08 10:45:28 -04:00
fc04a65a0f
Fix block activation not occurring serverside
...
Missing block of code from the old patch caused it to be skipped
2019-06-08 01:32:53 -04:00
a93d7d20ee
Rework model patches/classes for new bake signature
2019-06-08 01:02:29 -04:00
a7df63e1a1
Update to 1.14.2
2019-06-07 16:50:47 -04:00
c509cac02b
Fix vanilla structures loosing valid flags, And fix error placement for unsaveable structures.
2019-05-27 13:49:15 -07:00
c57c6213ea
Enhance crash reports and logging to capture transformers on stack trace elements.
...
Moved log4j2.xml file to the launcher source set, so it loads first in the client.
Signed-off-by: cpw <cpw+github@weeksfamily.ca>
2019-05-27 00:00:45 -04:00
9c5134fb6b
Fix MC-146650 GuiContainer#keyPressed to return the correct key handled boolean ( #5367 )
2019-05-21 11:00:47 -07:00
d7949d5316
Fix caps not being visible on old player during clone event ( #5728 )
2019-05-13 09:57:50 -07:00
8c44d6d4cb
Fix vanilla bug in writing structure templates with multiple palettes.
2019-05-12 23:40:54 -07:00
049fae5c65
Add support for vanilla recipes having nbt on result ( #5710 ) Fix #5663
2019-05-12 21:44:46 -07:00
41f8459a41
Fix modded TEs not being removed on block change
2019-05-12 15:05:33 -04:00
dcd5f1d711
Remove patch causing TEs to be removed on state change
2019-05-11 23:30:46 -04:00
18ce494cba
Fix default IUnbakedModel bake method using wrong format
2019-05-11 23:22:46 -04:00
de14670d4d
Fix BakedQuadRetextured calling old BakedQuad ctor
2019-05-11 16:36:16 -04:00
9209c3cbfe
Add new system for model data, replacing extended states ( #5564 )
2019-05-09 02:10:38 -04:00
cab1b9716c
Fix EnumRarity, make sure extensible enums have at least one factory candidate
2019-04-25 19:38:03 -04:00
bda3f1b7c6
Make EnumRarity extensible
2019-04-25 19:29:19 -04:00
d8137f7bcf
Add comment to vanilla bugfix, update skipped_commits.md
2019-04-25 15:59:08 -04:00
8408539f1c
Fix MC-128441: cross-dimensional teleporting does not work
2019-04-25 15:18:40 -04:00
1f0467b864
Add Forge dimension-changing hooks to spectator handling code ( #5212 )
2019-04-25 15:08:15 -04:00
931105123e
Allow custom DataSerializers to be registered safely ( #5245 )
2019-04-24 13:05:12 -04:00
c636f6edd6
Remove unnecessary patch
2019-04-24 02:13:17 -04:00
73bb013b25
Fail fast when null is used with setTag instead of crashing in writeEntry ( #5257 )
2019-04-24 01:32:45 -04:00
cb0cf2f04f
Add a few events pertaining to villages ( #5302 )
2019-04-24 01:07:02 -04:00
a4cf5951ca
Sync up canPlaceTorchOnTop logic with BlockTorch#isValidPosition
2019-04-24 00:59:03 -04:00
2ea475ad31
Fix special spawn event not firing in many cases. ( #5389 )
...
Co-authored-by: tterrag <tterrag1098@gmail.com>
2019-04-23 21:10:37 -04:00
a86317efc8
Reimplement ForgeHooks#onPlaceItemIntoWorld and remove old place events
2019-04-23 20:42:08 -04:00
ca973f053f
Add EntityPlaceEvent ( #5057 )
...
Co-authored-by: tterrag <tterrag1098@gmail.com>
2019-04-23 19:58:09 -04:00
aef224221f
Better support for custom bows ( #5209 )
2019-04-23 18:04:19 -04:00
01cb2117cc
Written size does not include int bytes.
2019-04-23 16:30:26 -04:00
574f890e58
Extend Region files to support >1MB per chunk.
...
If the 'sector count' is 255, ask the compressed data header for the proper length.
2019-04-23 16:27:34 -04:00
817546e4c8
Add a hook to allow continuously using items through stack changes ( #4834 )
2019-04-23 15:12:55 -04:00
f19fed0853
Add redirects to PotionEffect to respect registry replacement ( #5213 )
2019-04-23 14:47:47 -04:00
991682956d
Fix some typos in spawn dimension patches ( #5669 )
2019-04-15 19:04:24 -07:00
273b1b110a
Add GuiContainerEvent.DrawBackground event. ( #5595 )
2019-04-15 18:56:58 -07:00
bbc92fa51c
[1.13.x] Fire InputEvents ( #5533 )
2019-04-15 18:50:18 -07:00
65cfef1b2e
Fix potion remove event not always firing, add expiry event
2019-04-13 11:17:00 -04:00
914fe91db5
added PotionHooks, closes #3867 , #4375 ( #4614 )
2019-04-13 11:03:58 -04:00
0c19ccc11a
Fix EntityDataManager logging level
2019-04-13 10:45:33 -04:00
3560e47a77
Fix some typos in cherry-picked commits
2019-04-13 09:47:33 -04:00
a67cce2f91
Add a hook for farmland watering ( #4891 )
2019-04-12 20:16:34 -04:00
72bc39d831
Add logging for data manager key registration errors ( #5129 )
2019-04-12 20:01:00 -04:00
2baa05ace9
Improve support for custom block path types ( #5203 )
...
Co-authored-by: tterrag <tterrag1098@gmail.com>
2019-04-12 13:47:48 -04:00
fa708f93ee
Allow items to control the rate of repair from mending ( #5102 )
2019-04-12 13:26:15 -04:00
bda875166a
Improve exception handling from server starting events ( #5226 )
2019-04-12 11:12:15 -04:00
e376172312
Improve context provided by potion icon rendering hooks ( #5111 )
2019-04-12 11:05:34 -04:00
67da3182c1
Implement rendering for item models with emissive quads ( #5047 )
2019-04-12 10:45:32 -04:00
1280dea111
Fix inaccurate main thread name shown in client log ( #5078 )
2019-04-12 10:23:08 -04:00
ed3aea0980
Stop firing LivingSetAttackTargetEvent for setRevengeTarget ( #5217 )
2019-04-11 19:01:52 -04:00
7496e3dbdf
Re-add some missing villager profession patches ( #5200 )
...
* Fix zombie villagers only spawning with vanilla professions
* Fix spawning modded villagers that do not have their own building
2019-04-11 18:50:01 -04:00
7c401e9a35
Fix the bed position given to the SleepingTimeCheck event ( #5107 )
2019-04-11 18:09:01 -04:00
323fdb014d
Fix respawnevent being fired with old player instead of new. Fixes #5658 ( #5668 )
2019-04-04 19:41:27 -07:00
3f735b715b
Implement API for mods to control their server status response..
...
Signed-off-by: cpw <cpw+github@weeksfamily.ca>
2019-03-31 16:36:49 -04:00
4ecb04ed9f
Merge branch 'pull/5636' into 1.13.x
2019-03-30 15:03:48 -04:00
37016ca77f
Remove remaining deprecations, improve a few patch comments
2019-03-29 16:58:33 -04:00
98a470d813
Add back EntityPlayer patch to return main inventory in IItemHandler
...
Fixes #5638
2019-03-26 01:22:58 -04:00
e0e999da0d
Remove redundant method call in Minecraft patch. Also fix a translation
...
string error (closes #5643 )
Signed-off-by: cpw <cpw+github@weeksfamily.ca>
2019-03-25 21:55:33 -04:00
2f486f2bdd
Add method to IResourcePack to hide it entirely from the UI ( #5525 )
2019-03-25 17:24:37 -04:00
d8d30e1f82
Defer configuration of channel until it is actually available during
...
connection. Closes #5626
Signed-off-by: cpw <cpw+github@weeksfamily.ca>
2019-03-25 17:20:44 -04:00
4764136d47
Re-Add the list ping compatibility checker
...
Signed-off-by: JoJoDeveloping <jojohostert@gmail.com>
2019-03-25 15:15:25 +01:00
18400e8457
Revive CapabilityProvider on entity revive. Madders should NOT need this, as caps are copied via NBT.
2019-03-19 21:21:37 -07:00
f5375783c6
Do not invalidate caps when entity is being moved across worlds. Should fix #5500
2019-03-19 14:10:29 -07:00
8045e48952
Fix NPE in TileEntityPistonRender when class is created to early.
2019-03-17 22:15:52 -07:00
329e04b068
Fix being unable to plant nether wart ( #5572 )
2019-03-13 22:37:37 -07:00
d0c7a496f7
Fix silk touch not working on Ender Chests.
2019-03-13 15:55:18 -07:00
554952e02a
Fix invalid inventory being sent to ItemCraftedEvent Closes #5580
...
Fixed custom ingredient network serialization by removing unneeded mark. Closes #5577
Changed HorseArmorType constructor to not prefix vanilla paths to custom armors. Closes #5574
Fix removeBlock being called with invalid canHarvest value. Closes #5570
2019-03-11 16:40:59 -07:00
7113f4400c
Fix max entity radius not being settable by making it a instance method on world. Closes #5601
...
Fix VoidFluidHandler.INSTANCE not being a instance of VoidFluidHandler. Closes #5602
Remove backwards compat code and make IItemHandler.isItemValid non-default. Closes #5598
2019-03-11 15:04:04 -07:00
1d0c67d67b
Fix rails not being able to be placed on hoppers.
2019-03-08 11:50:41 -08:00
58494f8878
Rewrite the FML Handshake packet formats to include actually syncing the registry data and introduce the concept of caching it locally.
...
Snapshots are not injected yet due top threading issues.
2019-02-27 23:56:31 -08:00
7766eed754
Add missing constructors in KeyBinding to match existing vanilla constructors. ( #5480 )
2019-02-25 19:57:11 -08:00
176e331fc4
Fix Custom Entity Data not persisting between world loads. Closes #5562
...
Fix BlockRailState inverting flexibility flag. Closes #5550
Disable Forge's hooks on dispensing Buckets until Fluid system re-write. Closes #5545
Fix modifier only keybinds. Closes #5544
2019-02-25 17:06:37 -08:00
d846f23e80
Fix entity shearing logic ( #5566 )
2019-02-25 10:41:37 -08:00
c219416bb8
Patch DimensionSavedDataManager to not spam FS mkdirs requests for
...
empty files that don't exist yet, and don't contain data. Should
result in a significant performance improvement for those with slower disks.
Signed-off-by: cpw <cpw+github@weeksfamily.ca>
2019-02-24 13:03:11 -05:00
245d0b6282
Fix startup Query to actually display (fixed commit).
...
Signed-off-by: cpw <cpw+github@weeksfamily.ca>
2019-02-23 20:42:45 -05:00
8aafbb9441
Fix double tall plants not being shearable, add IShearable to seagrass
...
Closes #5524
2019-02-19 13:24:22 -05:00
e4c2d0a779
Add back missing ItemColors patch ( #5474 )
2019-02-19 12:46:41 -05:00
59a213bdaa
Fix entities being killed in one hit. Closes #5511
...
Fix unloc pattern for tps output
2019-02-19 12:35:32 -05:00
4abfedea68
Make BannerPattern extensible ( #5464 )
2019-02-19 12:14:14 -05:00
b4474a4882
Fix GuiEnchantment using wrong value to index enchantClue array ( #5452 )
2019-02-18 20:22:53 -08:00
d1ac90bb3e
Fix some minor patch regressions ( #5490 )
2019-02-18 20:21:03 -08:00
785d9b8deb
Altered EntityType registry to use a Forge based registry ( #5493 )
2019-02-18 14:19:25 -08:00
60315d079b
Clean up Entity patches, remove extra method. Closes #5494
2019-02-18 15:52:01 -05:00
3fa507d6d1
Make SpawnPlacementType extensible, remove from ArmorMaterial
2019-02-18 12:03:02 -05:00
e47fa70279
Fix connection to vanilla servers. Generate a default mod server config
...
for mods connecting to servers.
Signed-off-by: cpw <cpw+github@weeksfamily.ca>
2019-02-17 16:07:47 -05:00
af98088d04
Fix World crashing on load Fixes #5499 ( #5503 )
2019-02-17 00:15:35 -08:00
aa076695b9
Actually dispatch handleWorldDataSave. Closes #5492
...
Signed-off-by: cpw <cpw+github@weeksfamily.ca>
2019-02-16 17:38:12 -05:00
044bb1c395
Add back missing patch for Item.BLOCK_TO_ITEM
2019-02-16 08:14:33 +00:00
3e516e54b2
Remove Forge ChunkLoader - vanilla has a new system. API will follow.
...
Signed-off-by: cpw <cpw+github@weeksfamily.ca>
2019-02-14 23:15:40 -05:00
09a96670e6
Fix VillagerRegistry
...
Signed-off-by: cpw <cpw+github@weeksfamily.ca>
2019-02-14 22:20:59 -05:00
4139504202
Fix GlowstoneFeature patch name
2019-02-14 18:35:39 -05:00
ca72710937
Initial 1.13.2 update. Major thing to note is that Dimensions have been completely revamped.
...
DimensionType is not unique per Dimension. See DimensionManager for more details.
Vanilla now has a chunk loading system, so Forge's will need to be deprecated/adapted.
2019-02-14 15:08:53 -08:00
0d379fdd6b
Fix config to use new system properly, without exploding the server.
...
Separates server specific config into the server config file.
Signed-off-by: cpw <cpw+github@weeksfamily.ca>
2019-02-10 16:38:14 -05:00
8084ca43b9
Port CommandEvent and custom entity selectors to 1.13 ( #5411 )
2019-02-08 17:41:50 -08:00
2e5f25d8ae
Finish off most old patches, fix issue for mounted entities.
2019-02-08 17:40:07 -08:00
04b0d24678
Patch direct accesses to Entity.type to use getter instead ( #5308 )
2019-02-07 19:11:45 -08:00
79c17cb542
Add IExtensibleEnum, fix DimensionType create method
2019-02-07 16:36:30 -05:00
0b1b3c68fa
Invalidate capabilities that we attach to vanilla entities and TileEntities. Closes #5307
2019-02-06 22:55:17 -08:00
39965c55ac
Let ItemGroup provide it's own tabs image resource location ( #5330 )
2019-02-06 16:30:43 -08:00
f87dca2ad4
Allow GuiContainer and ItemGroup to specify slot hover colors ( #5332 )
2019-02-06 15:29:12 -08:00
3e02903d19
Port Minecraft client patch for 'ClientTickEvent' ( #5397 )
2019-02-06 15:14:18 -08:00
febae7f8f2
Fix statistics gui crashing when handling input events ( #5435 )
2019-02-06 15:12:15 -08:00
9119e395d4
Added 'create'-method for EnumCreatureType ( #5400 )
2019-02-04 11:40:03 -08:00
87b67cb45a
Fix wrong grass block being used for comparisons ( #5434 )
2019-02-04 11:38:01 -08:00
36866fed10
Fix inventory items not properly being synced to client. Closes ##5421 & #5417
2019-02-01 10:41:48 -08:00
2918864248
Merge branch 'pull/5405' into 1.13-pre
2019-01-28 20:50:12 -05:00
b40e2cc59e
More old patch work, cleaned up static methods added to ItemStack, and various networking functions.
2019-01-28 16:25:49 -08:00
c2a7fe4019
Bring back the forge beta warning. Use a check to see if the forge minor version is zero, as ForgeVersion.getStatus() is not implemented
2019-01-27 19:50:59 +01:00
161227b1de
Fixed missed OptionalCapabilityInstance to LazyOptional refactors in patches
2019-01-27 14:47:27 +01:00
39633eef4f
Clean up patch a bit, check for net.minecraft.
2019-01-26 10:25:19 -05:00
1f11ac76fa
Readd modded entity spawning/tracking support
2019-01-26 10:25:19 -05:00
4db208332e
Fix NPE in ItemGroup concurrency patch
2019-01-25 19:07:37 -05:00
c8c54113d0
Add RecipesUpdatedEvent, fired when recipes are downloaded from the server. ( #5303 )
2019-01-25 13:36:42 -08:00
06a6fac23a
Add a RayTraceResult method to Block that can be can be overridden ( #5354 )
2019-01-25 13:29:07 -08:00
2c8ab76240
[1.13] Check canSustainPlant for valid ground in BlockBush ( #5362 )
2019-01-25 13:12:34 -08:00
7a651b8c1f
Repatch missed hasTileEntity redirects. And cleanup related patches. Closes #5369
2019-01-25 13:11:06 -08:00
d04df43b27
Fixed fence and iron bars block placement ( #5372 )
2019-01-25 11:24:56 -08:00
f6e2c5c1f0
Make ItemGroup constructor threadsafe ( #5384 )
2019-01-25 11:23:34 -08:00
cc682fd786
Fix item interaction in creative mode. ( #5385 )
2019-01-25 11:21:03 -08:00
7b867d0069
Fix vanilla trying to load the constants json as an recipe. Closes #5388
...
Force constant names to use namespace of their json file. To prevent conflicts.
2019-01-25 11:18:25 -08:00
a15c4dc9b0
Add recipe types for faster runtime iteration. ( #5312 )
2019-01-25 10:22:41 -08:00
7c11fe1022
Fix capability attach event not firing with base type
2019-01-24 21:04:50 -05:00
66f816971f
Port Minecraft client patch for 'RenderTickEvent' ( #5329 )
2019-01-24 12:27:25 -08:00
98c6d5a5f6
Add back several missing patches for FML events ( #5390 )
2019-01-24 12:27:05 -08:00
3b029ba031
Re-introduce patch for injecting registry mappings during world loading.
...
And re-introduce registry freezing to ONLY the Register events.
Filter ObjectHolders by registry type and fire between every Register event.
2019-01-16 12:28:13 -08:00
cd21f7b927
Implement ConfigValue as a wrapper around ForgeConfigSpec results ( #5361 )
2019-01-15 23:28:40 -05:00
220bf8730a
[1.13] Expand tag deserializer to add optional values and remove values without overwriting everything. ( #5350 )
2019-01-14 19:23:36 -08:00
94af6c7f9d
Add CreativeTabs#getLabelColor
...
Patch skipped, was already applied in 47a11b9a7e (diff-0ea0358443c2ecf3b8682228736149b3R71)
2019-01-11 18:32:17 -05:00
f2b54acd67
Allow providing a BufferedImage for banner render generation ( #5041 )
...
Ported to 1.13 using NativeImage
Co-authored-by: tterrag <tterrag1098@gmail.com>
2019-01-11 18:32:17 -05:00
c1bb5cb250
Patch PotionHelper to use registry delegates ( #5142 )
2019-01-11 18:32:17 -05:00
958bbf6c9a
Fix MC-136995 - Chunk loading and unloading issue with entities placed in exact positions. ( #5160 )
...
This includes three commits from 1.12.x:
c20a5e880593b704b459ee0d43bbdefd1bd5223a/Spigot-Server-Patches/0306-Mark-chunk-dirty-anytime-entities-change-to-guarante.patchfd1bd5223a/Spigot-Server-Patches/0315-Always-process-chunk-registration-after-moving.patchfd1bd5223a/Spigot-Server-Patches/0335-Ensure-chunks-are-always-loaded-on-hard-position-set.patchfd1bd5223a/Spigot-Server-Patches/0378-Sync-Player-Position-to-Vehicles.patch
2019-01-11 18:32:16 -05:00
e98951ee65
Fix blockstate id map calculation. ( #5279 )
2019-01-11 14:52:30 -08:00
f3715c3e2e
Fix exception mismatch for entity types ( #5344 )
2019-01-11 11:47:36 -08:00
36d2e67b07
Reimplement @ObjectHolder scanning, and expose system for others to add handlers.
...
Fix forgedev and userdev run configs.
Fix issue in log functions assuming String arguments.
2019-01-09 20:57:01 -08:00
34568a0a74
Fix reference to IForgeDimension.SleepResult being through Dimension, thus causing a Srg2Source issue.
...
And improper getWorld patch.
2019-01-08 05:52:25 -08:00
dc12cda505
Clean progress bar code and fix TextureMap patch ( #5304 )
2018-12-28 18:05:05 -08:00
b4cf6f7f36
Implement GuiScreen events for mouse and keyboard ( #5297 )
2018-12-23 23:46:42 -08:00
8a11e3bac4
Port most of the world patches ( #5294 )
2018-12-22 10:31:18 -08:00
b3b8c78527
Rendering patches ( #5262 )
2018-12-21 14:45:35 -08:00
a992a4325b
Change getWorld function name to prevent inheritance change in Chunk
2018-12-18 16:11:03 -08:00
e47a4ea514
Fix typo in patch, that was preventing the key assigned to the chat keybind from working while in a searchable tab in the creative GUI. ( #5276 )
2018-12-16 11:04:37 -08:00
f13465012b
World and TileEntity patch work.
...
TerrtainGen events are removed, 1.13's world gen re-write invalidates them all.
2018-12-13 01:15:53 -08:00
7265900c62
More entity patch work. ISpecialArmor deleted.
2018-12-10 22:19:43 -08:00
7a77298a60
Port some patches to 1.13 ( #5267 )
2018-12-10 12:37:14 -08:00
0177e7558e
Fix vanilla exception mismatch: DataFixerUpper throws IllegalArgumentException but Minecraft tries to catch IllegalStateException instead, causing a hard crash instead of a soft one. ( #5229 )
2018-12-10 12:05:34 -08:00
bbf1ea41b8
world.gen.feature patches, worldgen should be stable with vanilla. In all places I looked.
2018-12-06 18:09:47 -08:00
eb22f42fea
More patch work, our async chunk loading doesn't appear to be viable for 1.13.
2018-12-05 18:08:27 -08:00
dd32e74e34
Entity patches progress.
2018-12-05 01:16:33 -08:00
a3c8e04ee6
Item and NBT patches, IShearable blocks are responsible for setting themselves to air, to allow for setting other states.
2018-12-03 18:04:37 -08:00
bf9158172f
Most client patches done except the render pipeline.
...
Someone who has more in depth knowledge of that rendering system will need to do it.
2018-11-28 22:15:05 -08:00
47a11b9a7e
GUI Patches
2018-11-21 21:23:24 -08:00
b6ddb0a7cf
More patchwork.
2018-11-19 19:55:46 -08:00
acb7acd661
Fix imports, remember to re-run gen patches!
2018-11-16 23:19:04 -08:00
7c0d94ce9c
Patch work, most of block classes, and fix eclipse run configs.
2018-11-16 23:15:39 -08:00
b5264cacf0
Fix crash when placing furnaces or brewing stands in 1.13 ( #5225 )
2018-11-15 13:55:18 -08:00
f7b35b968b
AdvancementRewards 1.13 patch
2018-10-11 19:27:34 -04:00
9d41c173df
Fix diffuse lighting being broken on vanilla pipeline ( #5185 )
2018-10-11 11:21:44 -07:00
43ed744d46
run textcomponenttranslations through the ForgeI18N message format translator as well.
2018-10-05 22:21:30 -04:00
e199e78a4f
load languages on the server as well as the client, and fix up a bunch of data packs.
2018-10-05 21:42:15 -04:00
1c9b5fae5e
Server run profile, also setup logging for client profile.
2018-10-05 01:25:27 -04:00
fe12687ec1
Branding fixup.
2018-09-30 14:29:14 -04:00
94e1a8e0a4
Update mappings to 09/21 snapshots.
...
Conflict with getMatrix in ITransformation, so renamed to getMatrixVec.
2018-09-22 03:40:22 -07:00
5ed03945a0
Disable eclipse compiler and switch to SRG patches.
2018-09-22 00:38:21 -07:00
d08f8e1a78
Fix remaining issues preventing compilation, launching, and loading worlds ( #5156 )
...
Fix duplicate ID for ingredient serializers
Fix KeyBinding compile errors. No GuiKeyBindingList patches yet.
Implement controls GUI and WorldServer patches
2018-09-21 19:07:48 -07:00
c191851ec0
Fixed all compile errors except the 4 in KeyBinding.
2018-09-21 15:50:37 -07:00
cdfa7caaeb
More work on compile errors, New system for ToolClasses, using a ToolType class instead to de-stringify things.
2018-09-21 01:47:12 -07:00
0cd21ebe7e
Block patches and event work ( #5138 )
2018-09-20 13:11:02 -07:00
86d10d355f
Fix borked Item patch
2018-09-18 00:14:27 -04:00
c4cf950863
Fix the rest of the "easy" compile errors ( #5151 )
...
* Add Entity.changeDimension patch and transitively required patches
* Fix throws declaration on CommandSetDimension#execute
* Fix rest of errors in fluid package
* Add PLAYER_REACH attribute
* Fix compile errors in fml.client.config and add GuiButton patch
* Delete unnecessary client.config classes, fix all config errors
* Comment some fluid errors in models
* Fix all errors in common package root, except ForgeHooks
* Mass comment network package
* Experimental conversion of extended states to generic base class
* Fix errors in common.util
* Remove config annotation stuff cuz lex said so
* Make extended state stuff compile fully
2018-09-18 00:04:02 -04:00
02c31cc867
More work on recipes, custom ingredients, recipes, and constants should work now.
2018-09-17 03:41:16 -07:00
03d19f2e70
Tweak to remove javac compile errors related to generics on registries.
...
Also remove the recipes registry call - they're gone from registries completely.
2018-09-16 22:27:08 -04:00
abacf8e141
Net handling pass 2. Tidied up login packet sourcing, generate registry packets.
2018-09-16 20:59:25 -04:00
9f2c7c881c
Net Handshake phase 1. Validates pairings on client and server.
2018-09-16 20:56:10 -04:00
afead63381
Migrate most of the OreDictionary to tags.
2018-09-16 16:28:21 -07:00
c77d00efe4
Recipe work. No longer a registry. OreDictionary related code removed in favor of Tags. Started moving some OreDict items to tags.
...
Added code to RuntimeEnumExtender to return existing enum values with the same name if they exist instead of creating more.
2018-09-16 04:20:28 -07:00
b4c23aba8e
Command work, and Added TileEntityType as a Forge Registry.
2018-09-15 00:59:19 -07:00
3f743887e7
More compile cleanups. ( #5139 )
2018-09-14 09:30:56 -07:00
949a62a0da
Fix most of the compile errors in the client package ( #5137 )
...
* Add KeyBinding#getKey and clean up errors in KeyModifier
* Add dimension IRenderHandler patches
* Fix most of the compile errors in client package.
The rest are missing Block/KeyBinding patches
* Disable selective reloads until configs are finished
* Add OnlyIn on IForgeDimension to match those of Dimension
2018-09-11 21:42:29 -04:00
a0cef07a0b
Pin MCPConfig version
...
Cleanup and implement BrewingRecipes
Delete client command related things
Cleanup some biome stuff.
2018-09-11 18:25:25 -07:00
f72a7e02e3
Fix vanilla bug with GLFW init error display - actually the error, not the memory address containing the message
...
Load natives from the environment var, not hardcoding.
2018-09-10 20:31:51 -04:00
bec9214d0c
Fix launching in dev
2018-09-10 13:08:35 -07:00
f95da817c4
Fix AnvilChunkLoader not having access to chunk cap dispatcher
2018-09-10 02:45:06 -04:00
a4f2802306
Add I18n accessor, fix up some mod log messages, make the EnumExtender work.
2018-09-09 23:35:02 -04:00
334d925972
Port capability patches to 1.13 and refactor to new system ( #5134 )
...
* resource package and misc leftover rendering stuff
* Port Item and ItemStack patches
* Extract most item patches to interface
* Refactor Item#setNoRepair to be part of Item.Builder
* Adapt AnimationItemOverrideList to new cap system
* Improve null contract of OptionalCapabilityInstance
* Remove Capability.cast
* Update CapabilityAnimation to new cap system
* Remove OptionalCapabilityInstance#flatMap and add NonNullConsumer
* Add capability patch to Entity, not everything yet
* Fix Entity patch and add missing methods to IForgeEntity
* Fix null contract of CapabilityDispatcher
* Add TileEntity caps
* Adapt FluidUtil to new cap system
* Add world caps
* Add chunk caps
* Clean up cap patches
* Replace all tabs with spaces
* Move builder methods on Item to Item.Builder
Whitepsace fix
* Sided stuff take 2
* Prevent OptionalCapabilityInstance creating additional empty instances
* Cache getCapability result in AnimationTESR
* Fix imports in TileEntity patch
* Pull out cap code to base class, add village caps
2018-09-09 17:27:15 -04:00
dde7dccef1
Porting Forge rendering code to 1.13 ( #5132 )
2018-09-08 13:34:59 -07:00
12869710de
Remove old paulscode libraries.
...
Re-work EnumHelper and ObjectHolder systems to bypass JITer of final fields.
Other cleanups.
2018-09-06 04:39:01 -07:00
2798080f60
More error cleanup, reinstanted IForgeReigstryEntry.
...
The abstract class will be used as the default, and to enable delegates but we should keep it api simple by keeping the interface.
Removed some patches that didnt get removed in the rebase.
2018-09-05 20:06:18 -07:00
ff6fa2cfaf
Add some missing libraries and work on GuiIngameForge. Down 700 errors.
2018-09-05 18:00:14 -07:00
d7e9217695
Network init
2018-09-05 13:14:16 -07:00
b50b768852
Server starts
2018-09-05 13:13:53 -07:00
330db1a54d
Patches deleted
2018-09-05 12:58:49 -07:00
f2da4be93e
Remove BlamingTransformer ( #5115 )
2018-08-26 18:57:44 -07:00
f1dfb80931
Allow network leak detection level to be specified ( #5067 )
2018-08-16 13:18:25 -07:00
6ece0ba254
Fix server watchdog thread occasionally crashing on first run ( #5019 )
2018-08-16 13:16:31 -07:00
8e7b5be3d4
New SleepingTimeCheckEvent to add yet another way to control sleeping. ( #5013 )
2018-08-16 13:14:34 -07:00
1171668c25
Allow sending packets to client from ServerConnectionFromClientEvent ( #4991 )
2018-08-16 13:03:32 -07:00
1f58bd71c0
Fixed overworld spawn point reset when respawning in another dimension ( #4982 )
2018-08-16 12:55:11 -07:00
21097a4122
Fix loading languages with no underscore in the name ( #5105 )
2018-08-16 11:02:53 -07:00
3b8146a06e
Fixed Redstone and RedstoneDiodes placement on modded blocks that use BlockFaceShape.SOLID for Top. ( #5100 )
2018-08-12 20:00:05 -07:00
9e30f4f6f9
Added Swim Speed Attribute to EntityLivingBase ( #4990 )
2018-07-28 19:24:30 -07:00
14bfeefb4d
Allow custom SpawnPlacementType registration ( #4973 )
2018-07-28 17:51:44 -07:00
a935859b24
Resource type sensitive ResourceManager reloading, Disabled by default, but may increase performance. ( #4658 )
2018-07-28 17:47:01 -07:00
4c3e6ed139
Improve crash report details ( #5011 )
2018-07-28 17:39:40 -07:00
c7c2921b2f
Fire colour events for mesa and swamp biomes ( #5029 )
2018-07-28 17:38:47 -07:00
eb870bc84c
Added CreativeTabs#getBackgroundImage ( #5034 )
2018-07-28 17:34:40 -07:00
2786cd279c
Update and clean up Forge fluid render model ( #4763 )
2018-07-17 20:37:20 -07:00
cfebf27393
Use itemstack in LivingEntityUseItemEvent.Finish before it was used ( #5015 )
2018-07-14 14:29:32 -07:00
603f4bd7a3
Check use item result before calling onItemUseFirst. ( #5016 )
2018-07-14 14:28:42 -07:00
9121b1f0c0
Fix player movement status not syncing across dimension change (MC-10657) ( #4974 )
2018-06-27 13:10:47 -07:00
464cccaa3e
Fix NPE when sleeping in some custom beds. Closes #4956
2018-06-27 12:23:00 -07:00
1007d3e9c5
Added Fluid Place Block Event for when fluid changes blocks in world. ( #4627 )
2018-06-27 12:06:55 -07:00
c001d2dbf6
Add Farmland Trample Event ( #4895 )
2018-06-27 11:31:38 -07:00
6367c15d32
Added Item#readNBTShareTag(ItemStack, NBTTagCompound) ( #4932 )
2018-06-27 11:27:24 -07:00
4e4ff66bd3
Fix MC-234: Z-fighting when viewing break animation side-on ( #4928 )
2018-06-27 11:25:03 -07:00
4d6fbd9d2f
Clean up some dimension manager code and add a command to list dimensions ( #4902 )
2018-06-27 11:23:23 -07:00
d09a8d98d7
Fix flickering leaves when mods break the blurMipmap settings ( #4997 )
2018-06-25 22:09:17 -07:00
fa50d98357
Fix structure template processors causing cascading world generation ( #4979 )
2018-06-12 22:58:45 -07:00
f492e25bc9
Copy the Dedicated server's EULA checking to main() function so it can exit earlier. Closes #3659 , #3661
2018-05-20 11:21:05 -07:00
f9b8c992ee
Fix language parsing for creating the java locale
2018-05-19 20:28:10 -07:00
330a9c4fd3
Fix server-side data not being released ( #4882 )
2018-05-16 23:13:27 -07:00
8fdc6eff07
Fix memory leaks in EnchantmentHelper (MC-128547) ( #4880 )
2018-05-16 23:12:18 -07:00
fd201fb690
Expand Villager Farmer AI to generic crops. ( #4745 )
2018-05-16 22:54:34 -07:00
40b567e962
Add an event to control nether portal formation ( #4735 )
2018-05-16 22:48:14 -07:00
36f94fd20e
Allow custom models to have per-state lighting ( #4732 )
2018-05-16 22:44:34 -07:00
8d994d074c
Fix some light-emitting blocks letting light through (MC-119932) ( #4642 )
2018-05-16 22:29:03 -07:00
e7cd3d4df6
Preserve original ChunkPos for decoration events. ( #4767 )
2018-05-14 20:20:50 -07:00
4f294da799
Fix MC-12269 Various Particles glitchy movement ( #4914 )
2018-05-08 20:25:06 -07:00
50014c7ca4
Reduce range requirement for World.checkLightFor from 17 to 16 ( #4729 )
2018-04-27 11:53:04 -07:00
c9f035cf03
Fix #4772 : add an "isActivator" boolean to powered rails ( #4774 )
2018-04-22 18:58:21 -07:00
90bf8dd95d
Fix some code holding client world references longer than needed ( #4881 )
2018-04-22 14:40:38 -07:00
bc545450e5
Don't try to render removed tile entities. Fixes MC-123363 ( #4811 )
2018-04-22 14:32:09 -07:00
d9dbec0546
Fix dragon fight not initialising correctly under some circumstances ( #4868 )
2018-04-14 19:43:44 -07:00
bad83a303e
Fix vanilla duplication bug.
2018-04-03 15:29:25 -07:00
34706c7cd7
Slow down Forge chunk gen worker when save queue is to high.
...
Prevents task from completing while tons of chunks are pending save.
And add minimum notification every 60 seconds.
2018-04-03 15:26:28 -07:00
272b337aa3
Fix MC-88179 in a better way that avoids and closes #4824 ( #4830 )
2018-04-02 12:58:15 -07:00
60e0f05b0d
Improve the warning logged for cascading world generation ( #4725 )
2018-04-01 19:01:22 -07:00
fe3478f233
New ITeleporter interface making dimensional teleportation easier. ( #4602 )
2018-04-01 01:55:45 -07:00
1d7c04daeb
Add a FML outbound target for all players tracking a point or entity in the world. Closes #3677 ( #4631 )
2018-04-01 01:42:55 -07:00
f5c0b894bf
Prevent EntityPlayer.attackEntityFrom from firing LivingAttackEvent twice ( #4661 )
2018-04-01 01:12:46 -07:00
4c1167c96d
Check for empty dimensions outside of chunk unloading loop, culling worlds without needing chunk unloads to trigger it. ( #4704 )
2018-04-01 00:54:22 -07:00
b8e411674b
Create event for overriding mob griefing flag based on entity. ( #4710 )
2018-04-01 00:48:25 -07:00
247d4cb5a8
Add description to Error raised by the server hang watchdog. ( #4714 )
2018-04-01 00:45:21 -07:00
6f642ba6ce
Fixed Spectator mode particles and sounds computed from where you have been before (MC-46445) ( #4728 )
2018-04-01 00:40:26 -07:00
e82a7605dc
Add a WorldProvider#canSleepHere() method to allow providers to control sleeping in beds separately from re-spawning. ( #4741 )
2018-04-01 00:27:58 -07:00
0b5a6a3b03
Reduce memory usage of model transforms ( #4753 )
2018-04-01 00:24:37 -07:00
fb61505d35
Fix some block connection logic not matching vanilla ( #4781 )
2018-04-01 00:18:14 -07:00
14a8e099ca
Fix for the player inadvertently being removed from the Entity Tracker when the chunk they were in unloads after they teleport out of it. ( #4784 )
2018-04-01 00:15:37 -07:00
557b41056f
Small performance improvement to ItemStack, by using Items.AIR directly instead of getting it from the Block map. ( #4786 )
2018-04-01 00:08:55 -07:00
11e623bf4d
Added chunk instance to ChunkWatchEvent ( #4805 )
2018-04-01 00:07:01 -07:00
483bf26aa4
Fix entities sometimes not rendering when out-of-world ( #4823 )
2018-04-01 00:02:57 -07:00
cfa3337884
Fix servers crashing due to initializer on @SideOnly field ( #4825 )
2018-03-27 13:59:52 -07:00
ed314864f0
Cleaner TileEntityItemStackRenderers, now stored on the Item. Modders should be careful and cache their renderers. ( #4700 )
2018-03-27 04:26:58 -07:00
a6bbc2761e
Add support for creator mod ID for modded enchanted books, potions, arrows, and spawn eggs ( #4810 )
2018-03-26 23:25:27 -07:00
9d8bf87e93
Fix NBT data loss when shift-clicking stacked items in the enchantment table (MC-17431) ( #4817 )
2018-03-23 17:32:59 -07:00
6ed2879842
Fix integrated server crash not stopping client ( #4796 )
2018-03-13 16:29:12 -07:00
4e8b7803c5
Prevent various vanilla blocks from loading unloaded chunks ( #4689 )
2018-02-26 22:13:01 -08:00
49be9b273e
Fix incorrect dimension ID being used for maps ( #4690 )
2018-02-21 21:20:27 -08:00
bf50f8bc30
Add function to BufferBuilder to directly insert byte data. Closes #4722
2018-02-13 22:00:25 -08:00
931ce0aa3b
Bump version for RB.
2018-02-02 19:56:31 -08:00
35d9cd94e8
Fix inconsistency between vanilla and modded glass. Closes #4679 ( #4680 )
2018-02-02 10:42:41 -08:00
a47eadb9b0
New hook in WorldProvider to control client lighting re-checks ( #4645 )
2018-02-02 10:35:47 -08:00
094245fe06
New hook to delegate some liquid related physics to the blocks themselves. ( #4604 )
2018-02-02 10:32:37 -08:00
9d102a76d4
Fix some shapeless recipes using damageable items not working ( #4713 )
2018-01-29 15:57:49 -08:00
6e731ca3e4
Fixed pumpkins passing the wrong position to isSideSolid on placement ( #4686 )
2018-01-20 09:30:34 -08:00
1d48e06798
Add MobSpawnerBaseLogic reference to SpecialSpawn and CheckSpawn events ( #4600 )
2018-01-18 13:06:53 -08:00
dbf2beb6fa
Moved firing the MinecartInteractEvent from individual subclasses up to EntityMinecart, which as a result automatically supports EntityMinecartMobSpawner and EntityMinecartTNT. ( #4583 )
2018-01-18 12:52:46 -08:00
94d4cb3396
Add missing check for allowed values to recolorBlock() ( #4579 )
2018-01-18 12:51:02 -08:00
6962678804
Make async chunk loading a config option ( #4544 )
2018-01-18 12:44:14 -08:00
3a3883589f
Allow WorldProviders to specify in-game music ( #4539 )
2018-01-18 12:39:14 -08:00
2d424ed2e1
Block::addRunningEffects ( #4248 )
2018-01-18 12:38:00 -08:00
adf3c7164a
[1.12.x] Implement hooks allowing mods to add horse armor. Partially addresses #3975 . ( #3994 )
2018-01-18 12:04:37 -08:00
d0bdb23300
Minor code and documentation cleanup. ( #4664 )
2018-01-12 23:54:29 -08:00
4b1b0d83e9
Fix dimension data not being saved ( #4667 )
2018-01-07 23:16:33 -08:00
d4ade990e3
Fix vanilla giant jungle trees causing cascading generation ( #4652 )
2018-01-04 20:30:41 -08:00
9a2ebd45d7
Fix Beetroot crops don't break/drop when trampled ( #4644 )
2018-01-01 19:18:18 -08:00
02855f7d74
Added Custom Slime Block hook for Piston. ( #4520 )
2017-12-16 18:38:53 -08:00
4ab9929593
Add some extra context to Advancements/Minecart/Fishing/TileEntity loot handlers.( #4443 )
2017-12-16 18:38:03 -08:00
49d072cef8
Fix BakedQuadRetextured not overriding getSprite ( #4137 )
2017-12-16 18:22:45 -08:00
bbf1bef7d3
Added LivingKnockBackEvent event to allow better control over knock back effects. ( #4503 )
2017-12-16 18:03:45 -08:00
441ece67bd
Delay egg creation to avoid null statistics ( #4508 )
2017-12-16 18:01:58 -08:00
7438ef466e
Reimplemented TileEntity and Entity Update Profiling in the /forge track command ( #4521 )
2017-12-16 17:48:48 -08:00
ae790c2345
[macOS] Fix missing text on loading error screens ( #4532 )
2017-12-16 17:42:17 -08:00
41766c9830
Don't enforce IPv4 for clients connecting to IPv6-only servers ( #4563 )
2017-12-16 17:39:27 -08:00
98997061f0
Add an event for registering block/item colour handlers ( #4565 )
2017-12-16 17:34:00 -08:00
e3c630ecb8
Fix: Anvil Bug with Custom Damage Items. ( #4570 )
2017-12-16 17:10:07 -08:00
1f0e0803f0
BlockFlowerPot now checks solid top side instead of old method. ( #4571 )
2017-12-16 17:09:33 -08:00
937b29e49d
Make vanilla powered rails receive power from mods' custom powered rail subclasses ( #4573 )
2017-12-16 17:01:56 -08:00
622c17ff04
Add missing nullability annotations to some Forge-added methods ( #4578 )
2017-12-16 16:59:54 -08:00
f36158dae7
Change how chests check if they're blocked. ( #4584 )
...
Readd Vanilla Bug: https://bugs.mojang.com/browse/MC-378
2017-12-16 16:57:24 -08:00
5cb01b7142
Allow EntityFishHook to spawn water particles in all liquids that use Material.WATER ( #4585 )
2017-12-16 16:49:21 -08:00
a38411be70
Add Sound loading progress bar ( #4593 )
2017-12-16 16:39:14 -08:00
eda4fb231b
Clean up capability checking for entities ( #4591 )
2017-12-13 22:56:01 -08:00
88b49f4a36
Fix sometimes being unable to extract items from double chests ( #4590 )
2017-12-13 12:02:02 -08:00
bd494af7ee
[1.12] Add Advancement Event ( #4467 )
2017-12-05 14:05:05 -08:00
239b9d36a4
Re-enable Vanilla's Shapeless recipe matching.
2017-12-01 13:17:22 -08:00
ccc44956fd
Fix for the EntityItemPickupEvent having 0 count item when event is fired. ( #4549 )
2017-11-30 21:46:54 -08:00
b215d90589
Don't force IPv4 network stack if IPv6 is specifically requested ( #4547 )
2017-11-26 19:20:01 -08:00
44d0e9f05d
Fix more bad shapeless recipe matching. Closes #4557
2017-11-26 14:50:57 -08:00
89db87dbfc
Create custom shapeless recipe matching system. Should solve #4516 damageable items in shapeless recipes.
2017-11-22 13:26:02 -08:00
c16906f8d8
Fix BufferBuilder not expanding under some conditions. ( #4538 )
2017-11-20 11:31:56 -08:00
a2fb242814
Fix server icon response leaking buffer (MC-122085) ( #4534 )
2017-11-19 11:35:59 -08:00
7a31b10364
Non-player entities now respect WorldProvider.getMovementFactor, closes #4470 ( #4471 )
2017-11-15 13:32:41 -08:00
fc87d83d73
Make Ingredient explode wildcard values like OreIngredient.
...
Fixes some issues related to Grums order fix for Shapeless recipes.
Other more advanced usages need to be documented and tested.
2017-11-14 00:10:33 -08:00
7d21b324ec
Fix server incorrectly marked as stopped before forge's handleServerStopped() ( #4517 )
2017-11-13 11:07:15 -08:00
baaa6c6505
Fix buffer leak in vanilla custom payload packet handling ( #4512 )
2017-11-12 10:38:10 -08:00
a59d20fc02
Fix resource loading on some mac systems when SplashProgress is enabled ( #4082 )
2017-11-09 22:32:01 -08:00
5a6f19f1c2
Fix MC-51150 ( #4495 )
2017-11-09 14:33:42 -08:00
d060747fad
Fix NPE when player tries to sleep without bed ( #4487 )
2017-11-09 14:30:36 -08:00
e102943a2d
Fix FastTESR quad sort ( #4298 )
2017-11-09 13:52:57 -08:00
c8efe29d61
Fix the incorrect matching algorithm in ShapelessRecipes and ShapelessOreRecipe ( #4472 )
2017-11-07 21:33:04 -08:00
8eb6ec9cdd
Fix BlockDynamicLiquid using mismatched state/position pair ( #4501 )
2017-11-06 10:30:43 -08:00
dd69f0623c
Add LivingDamageEvent ( #4349 )
2017-10-31 15:29:19 -07:00
ba71017001
Create IRecipeContainer interface and implementation to allow RecipeBook to work on custom GUIs ( #4480 )
2017-10-31 11:48:55 -07:00
6f49568c98
Add InputUpdateEvent ( #4356 )
2017-10-31 11:47:47 -07:00
9c7538db8d
Added a cloud renderer that uploads geometry to the GPU. ( #4143 )
2017-10-31 11:45:46 -07:00
31655b3a7d
[1.12] Replace ThrowableImpactEvent with a more generic version ( #4040 )
2017-10-31 11:34:48 -07:00
aa2480c7a1
Allow custom selector types to be defined ( #4259 )
2017-10-31 11:28:11 -07:00
2a546955a4
Clean up more deprecated library functions ( #4283 )
2017-10-31 11:22:55 -07:00
22ea5a23ad
Improve performance of World.collidesWithAnyBlock ( #4286 )
2017-10-31 11:20:59 -07:00
6d946fa088
Move reach distance to an attribute ( #4331 )
2017-10-31 11:16:22 -07:00
94c8534a83
Resolve a crash relating to plantFlower when biome has no flowers ( #4381 )
2017-10-31 11:04:42 -07:00
48320b315f
Prevent fake players from making advancements ( #4438 )
2017-10-31 11:02:47 -07:00
f8e375279d
Fix killing blow causing combat tracker to lose data (MC-121048) ( #4452 )
2017-10-31 10:59:04 -07:00
0bf82697bb
Recalculate chunk height map minimum on load ( #4453 )
2017-10-31 10:57:48 -07:00
57e6559fa4
Fix some locations where State Sensitive Materials were not used. Closes #4474
2017-10-31 10:40:38 -07:00
ac634a2049
Fix spider/chicken jockeys being unable to spawn naturally (MC-103516) ( #4429 )
2017-10-31 10:06:16 -07:00
e1dd7cc9ae
Fix performance regression in FastTESR rendering
2017-10-07 17:05:34 -07:00
cf39ff18e1
Add Item.getModId to show which mod is associated with a subitem ( #4330 )
2017-10-02 22:08:16 -07:00
8a285e0fed
Add Chunk capabilities ( #4228 )
2017-10-02 20:24:11 -07:00
267cd19291
Fix some chunk data packets being created unnecessarily ( #4414 )
2017-10-02 16:49:07 -07:00
0d34b02f88
Improve performance of vertex format mapping by caching hashcodes ( #4370 )
2017-10-02 16:45:58 -07:00
025495f98b
[1.12] Check both hands for sneak interaction bypass ( #4256 )
2017-10-02 16:28:34 -07:00
071664d95f
Fix being unable to see with night vision under some conditions ( #4383 )
2017-10-02 16:02:31 -07:00
5cddcc0280
Fix block and torch placement logic not matching vanilla ( #4210 )
2017-10-02 15:58:30 -07:00
b4676f5a0b
Add hook to configure EntityEquipmentSlot for item.
2017-10-02 15:54:01 -07:00
f3273ca0c9
Store entity data for dormant chunks using NBT ( #4162 )
2017-10-02 15:17:37 -07:00
3511e9ef2e
Allow for MapDecoration to use alternate rendering, for example a custom spritesheet ( #4027 )
2017-10-02 15:15:17 -07:00
b361b72515
Remove limitation of Shaped crafting recipes not being used on grids larger than 3x3
2017-10-01 16:05:15 -07:00
a93f3ab61e
Fix not being able to write in a blank, renamed Book and Quill ( #4433 )
...
https://bugs.mojang.com/browse/MC-1685
2017-09-30 12:44:43 -07:00
78630a6bf1
Prevent a mutable BlockPos leak in World#setBlockState ( #4388 )
2017-09-23 14:26:38 -07:00
50265786b2
MC 1.12.2 update.
2017-09-18 14:35:45 -07:00
ceaa9ba52f
Fix chunk gen mobs not firing the CheckSpawn event. Closes #4394 ( #4396 )
2017-09-16 21:30:38 -07:00
0ad4218bc2
Add new /forge gen command to generate large amounts of chunks.
...
Usage: /forge gen <position> <count> [dimension] [notifications]
Position is in Block Coords, and can be relative to the player. These will be converted to chunk coords for you.
Count is the number of chunks to load. This is not a radius, actual total number of chunks.
Dimension is optional, you can use this to pregen other worlds.
Notifications is the chunk interval to inform you of the generating progress. This is optional and will be 5% or 100 whichever is higher.
Added new config option to modify vanilla world gen to fix various cascading issues. MC-117810 MC-114332 and more.
This WILL change block placement from vanilla world gen. So this is a opt-in value. Do not report differences in worlds with this flag enabled.
2017-09-15 19:01:59 -07:00
036191cd52
Fixed ShapedOre recipes not laying out correctly with the guidebook.
2017-09-14 14:32:03 -07:00
883109182d
Fixed search tabs using wrong contents. ( #4393 )
2017-09-12 11:57:12 -07:00
638a54b04a
Fix #4386 Race condition when unloading chunks causes dead tile entities
2017-09-09 13:30:14 -07:00
bcea480d36
Patch block model renderer to use location-aware light value ( #4303 )
2017-09-06 14:32:08 -07:00
fe3ba2b40e
Fix light sources rendering wrongly with night vision (MC-58177) ( #4365 )
2017-09-06 14:18:25 -07:00
44f35fa8b1
Fix vanilla map pixel data being used in various places ( #4068 )
2017-09-06 13:54:00 -07:00
71d81cbd8d
[1.12] Remove patches adding chunkExists() function, switch to vanilla code ( #4054 )
2017-09-06 13:52:43 -07:00
523b4f85c2
Added missing MapGen types to the InitMapGenEvent ( #4322 )
2017-09-03 16:26:29 -07:00
a171220aba
Fix nether wart, pumpkins, and melons passing the new state as the original state to CropGrowEvent.Post ( #4377 )
2017-09-03 15:03:22 -07:00
0e789f3543
Fix KeyBindings reset buttons being inverted.
2017-08-24 04:53:19 -05:00
7273065132
Fix UnknownFormatConversionException during erroring TE/Entity removal ( #4312 )
2017-08-17 21:06:34 -07:00
28e341002f
Add support for server side only recipes, as well as detection of vanilla client recipe book filter to prevent errors.
2017-08-15 05:10:07 -07:00
29b717faa7
Add PlayerSPPushOutOfBlocksEvent. ( #4091 )
2017-08-09 15:26:51 -05:00
ffb71dce8c
Add Ability to Override PotionEffect Default Sort Order ( #4172 )
2017-08-09 15:22:09 -05:00
ee449e427c
Add support for oredict item predicates in advancements, and add a registry for item predicates ( #4188 )
2017-08-09 15:20:45 -05:00
d14a8724b0
Fix invalid FastTESR quad ordering ( #4267 )
2017-08-09 15:18:17 -05:00
9d7f6bf6e4
Add a hook to allow world providers to change the lightmap colours ( #4279 )
2017-08-09 15:16:44 -05:00
31b46e9e77
Fix MC-117075 lag spike when unloading many tile entities ( #4281 )
2017-08-09 15:15:32 -05:00
f73c7cb764
1.12.1 Update, Not much modder facing changes, 1.12 mods should load and run fine on this version.
2017-08-03 17:30:43 -07:00
639589703d
Add smarter getter for block slipperiness ( #4116 )
...
Fixed MC-119811, Boats rubber banding when dismounted.
2017-08-01 16:25:28 -05:00
099bbd479a
Add GuiContainer Foreground render event. ( #4127 )
2017-08-01 16:23:08 -05:00
2f7f2e7bc1
Use ClassValue to store tileentity names for profiler in lazy cache. ( #4021 )
2017-08-01 14:42:18 -05:00
c8379da83b
Added CriticalHitEvent to allow more control over whether a attack is a critical or not, and what damage it does.
2017-08-01 14:13:37 -05:00
eee8b7ff38
Fix stacked entity item rendering using the wrong transform for the extra items. ( #4158 )
2017-08-01 13:57:12 -05:00
173e929173
Added pages to the advancements GUI to allow for unlimited root advancements. ( #4183 )
2017-08-01 13:43:24 -05:00
b7e56a61b9
Ignore neighbor changes for comparators on the client (Vanilla behavior) ( #4186 )
2017-08-01 13:38:57 -05:00
d3fa82c18a
Allow sneaking to bypass villager interaction GUI. ( #4193 )
2017-08-01 13:29:19 -05:00
4a31e86bd3
Clean up Block.getLightValue(IBlockState, IBlockAccess, BlockPos) ( #4203 )
2017-08-01 13:28:27 -05:00
817bd72a76
Replace hardcoded block check with isTopSolid method call for placing button/lever ( #4212 )
2017-08-01 13:25:59 -05:00
f9bb29c240
Added support for oredict dyes to Fireworks, Armors, and Shulker recipes. ( #4223 )
2017-08-01 13:03:01 -05:00
8aa78da4de
Limit some server to client update packets for Item Capabilities ( #4252 )
2017-08-01 12:46:04 -05:00
32e811bd7a
Fixed Armor bar disappear after changing dimension. MC-88179 ( #4265 )
2017-08-01 12:35:03 -05:00
00f82331e4
Fix the firing location of InputEvent.MouseInputEvent ( #4270 )
2017-07-31 23:16:55 -07:00
7d0a8524aa
Fix FML handshake race condition, fixes #4219 ( #4220 )
2017-07-23 17:24:43 -05:00
32dc726df1
Prevent player from dying infinitely due to zero max health (MC-119183)
2017-07-20 21:54:46 -07:00
a6b9fbfa9f
[1.12] Allow the server to handle item-block interaction if onItemUse doesn not return PASS ( #3967 )
2017-07-20 17:11:50 -05:00
ad15209f8d
Allow support for custom Shields and Shield disabling weapons.
2017-07-20 16:44:37 -05:00
fb10d7cbd4
Ignore fortune for anything but seeds in crops ( #4160 )
2017-07-20 16:31:16 -05:00
afea45dccc
Fix tripwire statemap not being complete when mappings change. Closes #3924
2017-07-18 12:53:55 -07:00
6167bbfea9
Fixed issue where rendered held items wouldn't properly update when the reequip animations isnt shown. Closes #4175
2017-07-13 15:21:57 -07:00
ead0e81025
Remove unneeded block patches ( #4167 )
2017-07-12 21:49:21 -07:00
4df20daf41
Allow advancement icons to have nbt ( #4114 )
2017-07-08 15:14:29 -05:00
80da39d4e3
Attempt fix, or at least better debugging for RecipeBook accessing unknown recipes.
2017-07-08 13:08:44 -07:00
0215e2e128
Fix MC-68754, Screen is not resizeable after exiting fullscreen due to LWJGL bug
2017-07-08 13:08:06 -07:00
d3c11c2b4f
Use Item's custom FontRenderer for tooltips in the Creative Gui ( #4101 )
2017-07-08 00:19:49 -07:00
02ef4155c8
Fix Recipe Toast crash when granted more than 5000 recipes ( #4124 )
2017-07-07 23:47:58 -07:00
3847a2cf5d
Throw packet encoding exceptions instead of suppressing them, to prevent corrupt packets ( #4144 )
2017-07-07 04:39:27 -05:00
5fc380665e
Include location of the call when a mod uses System.out or System.err ( Fix #4135 )
2017-07-04 23:20:04 -07:00
c1ae2cdbf2
Improve furnace fuel handling ( #4083 )
2017-07-03 12:54:01 -07:00
e1a2bcf902
Add isSpawner parameter to the CheckSpawn event ( #4075 )
2017-07-03 12:45:57 -07:00
43be1f46a5
RenderLivingEvent now stores partialTick
...
2
2017-07-03 12:20:45 -07:00
9e413de6c9
Added Block::getFogColor to allow custom blocks to control fog colors while inside them. ( #4090 )
2017-06-28 17:23:32 -05:00
10ca404e9e
Fix the creative menu search function. Closes #4100
2017-06-27 21:34:03 -07:00
a4fb33d945
Add support for loading mod advancements from the mod jar files.
2017-06-27 15:18:52 -07:00
a480fa0821
Remove outdated patch to BlockDoublePlant
2017-06-26 22:37:17 -07:00
9a09ff68aa
Remove some deprecated methods and clean up
2017-06-25 22:30:18 -07:00
7892ca922c
Remove the call to client.refreshResources during loading ( #4032 )
2017-06-25 22:13:58 -07:00
0f7ec7e7fd
Added dependencies and dependency ordering for textures. ( #4070 )
2017-06-26 07:58:19 +04:00
690c9bb76a
Further Java 8 cleanup ( #4077 )
2017-06-25 14:25:57 -07:00
3738a2e42b
Fix missed side only on BlockFlower
2017-06-25 12:24:07 -07:00
368d206cc6
Make Block.getSubBlocks not client side only.
2017-06-25 11:17:31 -07:00
dc043ac79f
Cleanup of model system, taking advantage of java 8;
...
replaced guava Optional and Function with java 8 versions.
2017-06-25 04:08:20 +03:00
1c24600bbb
Reload client recipe book after loading modded recipes.
2017-06-24 15:34:09 -07:00
efd8b38be9
Make getSubItems non-client only. Use it for Ingredient iteration.
2017-06-24 14:47:48 -07:00
478a84e748
Fix Emerald generation causing chunk loading.
2017-06-24 14:47:11 -07:00
72f037b0fa
Add Block.getDrops that uses NonNullList, deprecate the old method. Fix #3567 ( #3778 )
2017-06-24 03:05:42 -07:00
a8734e368d
Remove arrival/departure message methods from WorldProvider ( #2733 )
2017-06-24 02:02:56 -07:00
c0188d3228
Use instanceof ItemFishingRod instead of item equality ( #4060 )
2017-06-24 01:26:36 -07:00
f670ec4f0b
Fix onBlockClicked handler firing twice and Item.onArmorTick in the wrong place ( #4037 )
2017-06-24 01:01:28 -07:00
b0dfaa2b81
Remove Java 8 warnings now that Minecraft requires it
2017-06-23 23:31:50 -07:00
286f6a910b
Fire AnimalTameEvent for parrots ( #4003 )
2017-06-23 23:11:47 -07:00
d032a34aaa
Fix conflicts
2017-06-23 16:59:57 -05:00
dee84dc1e4
More work, game loads and runs now.
...
Moved Registry events to directly AFTER PreInit instead of before.
This allows modders to register handlers for it without @EventBusSubscriber.
It also allows you to register custom things needed before the construction of blocks or items such as Fluids.
TODO: Move Fluids to a real registry.
@ObjectHolder can now be used on private fields.
Reworked FMLModIdMappingEvent to include data for all registries.
Tile Entities are now registrable.
2017-06-23 16:59:57 -05:00
a26d89c876
First pass of registry rewrite.
...
Tests do not run yet.
Things of note:
Removed the idea of substitutions, just register multiple items with the same name they will override each other like a normal map.
Decoupled Forge registries from vanilla classes. They now use bouncer classes. MODDERS SHOULD NEVER USE THESE
Introduced more stringent registry locking. As it sits things are only allowed to be registered during the RegistryEvent.Registry phases!
This is to force modders to split up their registrations, and pave the way for calling these functions multiple times during a single MC lifecycle.
ObjectHolder, Missing Mappings, etc... *should* now work for all registry types, nothing should be special cased to Blocks/Items anymore.
Added optional generic dummy factory to registries, to allow registry creators the ability to dummy more then just Blocks.
Re-worked the ItemStack transformer and applied it to ItemBlock and ItemBlockSpecial. Allowing us to cleanup reflective hacks in Block callbacks.
Registry onAdd callback is now only fired on the ACTIVE registry, fixing any issues of temp registries overriding active objects.
2017-06-23 16:59:57 -05:00
0e9820c51c
Clean up Logging ( #3953 )
...
# Conflicts:
# patches/minecraft/net/minecraft/client/renderer/texture/Stitcher.java.patch
# patches/minecraft/net/minecraft/client/renderer/texture/TextureMap.java.patch
# patches/minecraft/net/minecraft/entity/EntityList.java.patch
# patches/minecraft/net/minecraft/tileentity/TileEntity.java.patch
# src/main/java/net/minecraftforge/oredict/OreDictionary.java
2017-06-22 23:18:49 -07:00
98f464ad43
Fix Chunk patch ( #4036 )
2017-06-20 20:40:45 -07:00
17a714f7fd
Fix patches in Chunk and Explosion ( #4036 )
2017-06-19 23:27:52 -07:00
c6d7c7c11f
Fix itemstack comparison with null
2017-06-19 23:27:52 -07:00
80d9beedc9
Remove unused patch to ItemRecord. Closes #2686 . ( #4035 )
2017-06-19 16:47:01 -07:00
c2845967cc
Update MCP mappings to 20170617
2017-06-17 18:06:04 -07:00
4a4c38b4e0
Patch a small bug in SPacketLoginSuccess that lets us emulate the network
...
handshake. This will be very useful as I rebuild the networking.
2017-06-16 22:00:54 -04:00
22d243e70d
Fix NPE in config menu with custom keybinds. Closes #3985
2017-06-14 10:23:49 -07:00
a8659a1613
In-progress Registry system enhancement.
...
Needs cpw to take a look at enabling removing/overriding in the registry stuff.
But in theory it loads json recipes for mods now.
2017-06-14 10:14:56 -07:00
f1cca475ea
Initial patch update to 1.12.
...
Some things to note:
Netty is screwy so currently can't join single player. @cpw
Crafting has been MAJORY reworked. The current GameRegistry functions are nooped, this is IN THE WORKS.
Just need to move the recipe list to a full class registry, and then re implement the in-code recipe registration.
Also, it IS advised that modders move to JSON, because ideally we'll see a S->C recipe syncing system in 1.13
which would allow servers to have custom recipes.
OreDictionary currently 1/2 works, need to write a better algorithm for replacing ingredients.
Please be patient
Rendering:
A lot of functions got a new float parameter, this is similar to partial ticks, needs more research
2017-06-10 22:22:02 -04:00
286777b824
Fix getShareTag replacing data on the server ( #3776 ) Closes #3682
2017-06-04 18:38:16 -07:00
c544f06880
Fix shaders not loading from mod domains Closes #3921
2017-06-01 15:47:49 -07:00
d867bd299f
Clean up MapData patch ( #3905 )
2017-06-01 14:38:12 -07:00
ca298ef6aa
NBTTagList implements Iterable<NBTBase> ( #3884 )
2017-06-01 14:37:22 -07:00
df52accf76
Fix canRiderInteract being called on the wrong entity ( #3934 )
2017-06-01 14:35:05 -07:00
e2f60c1aaf
Deprecate vanilla getExplosionResistance and properly annotate the forge replacement ( #3929 )
2017-06-01 14:32:37 -07:00
9c148b56f8
Fix patches of GuiScreen( #3704 ) and ItemDye( #3736 ) ( #3878 )
2017-05-26 14:19:58 -07:00
c6f181dcb2
Fixes for PlayerDestroyItemEvent being called with empty itemstacks. ( #3728 )
2017-05-26 13:54:13 -07:00
7976ac4a2b
[1.11.2] Added support for Village capabilities ( #3648 )
2017-05-26 13:51:18 -07:00
03e922fa05
Disable frost walker enchantment on anything but vanilla water ( #3906 )
2017-05-21 13:52:25 -07:00
81d61218b6
Fix head being angled badly when riding mobs. Fixes MC-1207 ( #3901 )
2017-05-21 12:37:28 -07:00
61d00dd05f
Fix MC-117087, prevent calling Class.getSimpleName on TEs unnecessarily ( #3873 )
2017-05-06 12:19:51 -07:00
34463690c5
Changed custom entity selectors from event based to factory based. ( #3579 )
2017-05-01 18:36:24 -07:00
6ffd94a08e
Create ItemFishedEvent, the event is cancelable, but items are not mutable. Use LootTables to control that. ( #3705 )
2017-05-01 18:10:47 -07:00
003d0c601d
Relocate TileEntity#onLoad call to after it's added to the world instead of the chunk so as to have a valid world reference ( #3836 )
2017-05-01 17:41:37 -07:00
93a4e13837
[1.11.2] Fixed Zombie Villagers not setting and getting professions correctly ( #3678 )
2017-04-30 21:59:57 -07:00
d84ee35245
Fix NumberFormatException being thrown for empty ItemStack deserialization
...
Thanks @gabizou, 1.11.2 version of #3830
2017-04-09 23:13:13 -07:00
582f33fc85
Fix mutable blockpos leak MC-114281 ( #3742 )
2017-04-07 17:36:36 -07:00
f92425cf71
Fix typo in LootEntry.Serialiser causing incorrect serialisation. Closes #2757 , Fixes MC-115407 ( #3823 )
2017-04-07 17:09:56 -07:00
5f4cd69167
Fix invulnerable items becoming invisible client side MC-53850 ( #3807 )
2017-04-07 17:03:43 -07:00
dbc6baf2f7
Add Item.canDestroyBlocksInCreative() allowing more items to not break blocks in creative ( #3805 )
2017-04-07 16:59:21 -07:00
2c7c538c73
Fixed HarvestDropsEvent issue by fixed-length lists on getDrops ( #3778 )
2017-04-07 16:51:21 -07:00
2234039b96
Add GenerateMinable event for mesa gold ( #3774 ) Closes #3738
2017-04-07 16:48:28 -07:00
901df8345c
Add AnimalTameEvent for handling animal taming ( #3763 )
2017-04-07 16:47:28 -07:00
f22874d3be
Added missing bounds check to ChunkCache.getBiome ( #3752 )
2017-04-07 16:43:09 -07:00
72dd06ca85
Allow result of PlayerInteractEvent to be changed when it's cancelled ( #3744 )
2017-04-07 16:38:56 -07:00
5ffbbd3b9f
Add EnumHand and ItemStack to BonemealEvent ( #3736 )
2017-04-07 16:31:51 -07:00
fd0dabd60c
Added a boolean flag for disabling Entity onUpdate ( #3731 )
...
The flag is false by default, and if true the Entity will not update. It is saved and loaded from NBT, and is called updateBlocked. Modders are responsible for managing this flag for entities they with to 'freeze' or 'unfreeze'.
2017-04-07 16:28:53 -07:00
be2d814155
Add LootTableManager to the LootTableLoadEvent ( #3717 )
2017-04-07 16:22:49 -07:00
b99aa9bca4
Fix EntityFallingBlock check for ITileEntityProvider ( #3711 )
2017-04-07 16:18:45 -07:00
671d462645
Added ClientChatEvent. Closes #1442 ( #3704 )
2017-04-07 16:09:46 -07:00
9619be4a17
Use thread groups to detect the effective side ( #3644 )
2017-04-07 15:35:58 -07:00
f0eb941abc
New LivingDestroyBlockEvent for controlling if some entities can destroy blocks ( #3628 )
2017-04-07 15:34:26 -07:00
f2425b7486
Fix breaking particles on dedicated server. Closes #3825
2017-04-06 13:16:01 -07:00
d850ca890f
[MC-2518] Fixed missing break sound and particles. Closes #3821
2017-04-05 14:28:28 -07:00
b6194b0cca
[1.11.x] Fix blank tab in creative inventory when additional tabs evenly divisible by 10 ( #3817 )
2017-04-02 19:50:10 -07:00
72937c90be
Fix vanilla bug where player reputations villages were reset on read.
...
Deprecated Username based API in favor of UUID based API.
2017-03-31 02:33:39 -07:00
c1a38c541a
Fix error when reading world info for old saves with missing dimensions. Closes #3786 #3331
2017-03-15 02:51:52 -07:00
4fbc847736
Detect and log cascading chunk generation issues during terrain population ( #3756 )
2017-03-14 21:19:47 -05:00
43375ded29
Fix duplicate achievements getting added to the achievement list ( #3770 ) ( #3779 )
2017-03-14 21:04:09 -05:00
55587fca08
Fix parameter-names for WorldProvider.shouldMapSpin ( #3767 )
2017-03-07 15:29:09 -08:00
45e0738f43
Fix MC-112730 TE global renderer duplicate render ( #3651 )
...
* Fix TE global renderer duplicate render
2017-02-26 12:21:30 +04:00
724ffe1d70
Fix entity write catch block ( #3726 )
2017-02-24 16:03:19 -08:00
c49ff259b5
Fixed TESR items not rendering correctly before entering world (MC-112292) ( #3666 )
...
Fixed crash when rendering text in TESR items before entering world
2017-02-23 18:41:57 -08:00
2003dee17f
Add DifficultyChangeEvent ( #3525 )
2017-02-23 18:12:27 -08:00
a6284e6053
Allow mods to set other default "home dimensions" for respawning. ( #3528 )
2017-02-23 18:08:58 -08:00
a15dee61d6
Persist PotionEffect curative items and initialize defaults from Potion ( #3573 )
2017-02-23 18:04:06 -08:00
384567c4a5
Added Forge slot methods to creative container ( #3581 )
2017-02-23 18:01:09 -08:00
d3e4fde2b2
Restore missing Biome GetWaterColor event. Closes #3164 . ( #3625 )
2017-02-23 17:47:21 -08:00
da5b2201fa
Fixed Missing Furnace Fuels ( #3627 )
2017-02-23 17:46:37 -08:00
64cb9cdafd
Prevent concurrent modification of ClassInheritanceMultiMap ( #3632 )
2017-02-23 17:20:25 -08:00
64c9aae0c4
Fixed ChunkCache.getTileEntity creating tile entities off world thread.
2017-02-23 17:12:37 -08:00
a4a6d5fa6c
Fixed Flower Forests not having proper flowers. Closes #3652
2017-02-23 15:51:36 -08:00
7cdbe5d518
Fix Poppy to Dandelion ratio
2017-02-23 15:50:30 -08:00
3c3fcc0ffd
Add implementation for Living Attack event on client-side for players ( #3667 )
...
* Fixed unused import
2017-02-23 15:35:44 -08:00
ab4c4db0d5
Fix bug caused by ItemMinecart patch ( #3672 )
2017-02-23 15:27:02 -08:00
e5eb2e795b
Make getRGBDurabilityForDisplay use getDurailityForDisplay by default. Closes #3670 ( #3673 )
2017-02-23 15:25:43 -08:00
d3c6130f88
Use Forge setting to determine baby zombie chance. Fixes #3690 .
2017-02-23 15:18:59 -08:00
403eda184a
Properly fix IShearable implementation. Fixes shears taking damage twice, mooshroom particles, and blocks dropping incorrect loot.
2017-02-23 15:15:48 -08:00
6ae39ac027
Fix hoppers being able to insert shulker boxes into shulker boxes.
2017-02-21 14:22:28 -08:00
7aa1e00f31
Fix for bad decompile process on Particle.java that causes onGround flag to not get set properly as well as motionX and motionZ not being set to 0 when their axis has collision happening ( #3716 )
2017-02-19 21:39:27 -08:00
a605c64c49
Fix ClientTickEvent Post firing inside another profiler section ( #3715 )
2017-02-19 21:21:48 -08:00
1d6cd35a09
Fix Item.doesSneakBypassUse being applied incorrectly.
2017-02-19 21:19:43 -08:00
5f6bf3b063
Stop rotation of extended pistons, beds, and double chests Fixes #3634
...
Fix rotation of repeaters and comparators
2017-02-19 10:48:43 -08:00
caa85b33bf
Fixed TileEntity#getRenderBoundingBox not offsetting correctly causing more TEs to render then needed ( #3709 )
2017-02-19 09:07:12 -08:00
6745022d46
Fix spawn-fuzz formula ( #3695 )
2017-02-12 13:28:27 -08:00
4a6b3ef6e3
Fix world spawn fuzz. (reverted from commit 450c3a80c1)
...
Protip Don't code while groggy.
2017-02-12 12:18:21 -08:00
450c3a80c1
Fix world spawn fuzz.
2017-02-12 12:11:40 -08:00
0e9d741163
Fix some cases where world time is not passed through the WorldProvider. ( #3685 )
2017-02-11 11:22:25 -08:00
dcc76ccb58
this finaly fixes #2866 ( #3656 )
2017-01-24 10:30:31 -08:00
LexManos