0
0
Fork 0
mirror of https://github.com/Sanae6/SmoOnlineServer.git synced 2024-11-16 00:25:07 +00:00
Commit graph

71 commits

Author SHA1 Message Date
Robin C. Ladiges
11c291c105
fix: actually working ban functionality
Changes:
- ignore new sockets from banned IP addresses way earlier.
- ignore all packets by banned profiles.

Intentionally keeping the connection open instead of d/c banned clients.
This is to prevent endless server logs due to automatically reconnecting clients.

Before:
Reconnecting clients aren't entering `ClientJoined` and therefore the d/c is only working on first connections.
Effectively banned clients got a d/c and then automatically reconnected again without getting a d/c again.
Therefore allowing them to play normally.
2023-03-24 01:02:26 +01:00
Robin C. Ladiges
122a3cd80d fix: don't output empty player IDs or RemoteEndPoints in the log
Make and use a copy of the RemoteEndPoint at the start of the HandleSocket method.
Because in some cases when the socket is disposed, the RemoteEndPoint inside of it is cleared and isn't available for the following disconnect log entries.
Also: port scanners on the internet don't introduce themselves with a name and ID.

(cherry picked from commit 2f4cd0509a)
2022-10-10 11:13:32 -06:00
Robin C. Ladiges
69cef89953 fix: on reconnect do not disconnect the new client
Currently when a client connects that is already there,
the old socket is closed, and the code tries to reuse the existing client object by exchanging its socket.

Reusing the same client object and just changing its socket does cause issues though with copies of the client in other threads.
In the situations that I could reproduce, it always disconnected both sockets, the old one and then the new one.

Instead I make a copy of the client object, use the new socket, remove the old object and add the new object to the collection.

(cherry picked from commit 9e6c312c8e)
2022-10-10 11:12:28 -06:00
Robin C. Ladiges
472c8856bc move the client.CurrentCostume update to the PacketHandler and log the packet
(cherry picked from commit 47505dbdd5)
2022-10-10 11:09:39 -06:00
Robin C. Ladiges
c41499f953 remove unused label
git cherry-pick accidentially picked up a line from another commit for the JSON API
2022-09-07 10:35:26 -06:00
Robin C. Ladiges
76fc4a80a6 only broadcast the DisconnectPacket if the client was connected
Otherwise port scans, banned players or clients failing to initialize correctly,
will cause the server to send unnecessary packets to all connected clients.

They currently are informed about a disconnect for a client that hasn't even connected correctly.

(cherry picked from commit 4b04a3d5be)
2022-09-07 10:35:26 -06:00
Sanae
e7a3347a37
Merge pull request #19 from TheUbMunster/restart-command 2022-07-29 13:19:04 -06:00
TheUbMunster
95c918b5c4 Removed fire-and-forget warnings, null-forgave some metadata. 2022-07-29 12:55:01 -06:00
TheUbMunster
068cc7c06d Added restart server command 2022-07-27 23:56:50 -06:00
Sanae
66114bdecb
Always update client's name on connect
Since the client variable would be changed in a reconnect, the name is not set on the old client object.
2022-07-27 14:00:58 -06:00
CraftyBoss
11015bd445 only send game packet on join to connected clients 2022-07-08 23:13:35 +00:00
Sanae
99aabeffc9 Add init packet 2022-05-08 16:04:57 -06:00
Sanae
ab318db1b8 Clean up logging from testing 2022-04-27 21:32:52 -06:00
Sanae
605be3947f I'm going to commit war crimes 2022-04-27 14:17:02 -06:00
Sanae
a775e593c3 Absurd logging 2022-04-27 14:02:26 -06:00
Sanae
bddce48f9d Stop using MemoryMarshal for header serde 2022-04-27 00:24:11 -06:00
Sanae
6964c3bbf4 Add max players to connect packet 2022-04-26 23:24:40 -06:00
Sanae
1a82666d93 Disconnect previous client instead of throwing on new client (rejoins) 2022-04-04 14:43:44 -06:00
Sanae
a0a53ff7bf ReuseAddress requires Socket level 2022-04-02 20:58:57 -06:00
Sanae
cc5c86091e Try using tcp to not require sudo? 2022-04-02 20:14:35 -06:00
Sanae
50adf23be3 Use correct maxplayers field 2022-03-22 03:20:49 -06:00
Sanae
8645db12fa Improving rejoins and other changes 2022-03-22 03:19:06 -06:00
Sanae
27d2d9acd9 Bye send buffer stuff 2022-03-15 20:25:36 -06:00
Sanae
709af8d3ec Send buffer 1 on another oscket 2022-03-15 17:28:15 -06:00
Sanae
206bbd5d4c Set send buffer to 1 2022-03-15 17:23:53 -06:00
Sanae
a288e5b7a8 Rejoyne 2022-03-15 15:37:23 -06:00
Sanae
8d11623ada Various useful changes 2022-03-15 14:44:46 -06:00
Sanae
ad0a40878d Add tag commands and improve command handling 2022-03-14 23:59:23 -06:00
Sanae
217dc2765e Remove test exception when disconnecting 2022-03-13 15:27:53 -06:00
Sanae
c778d15644 Packet cleanup and refactoring 2022-03-13 05:14:01 -06:00
Sanae
3b13e1f86d Fixing variable packet sizes once and for all 2022-03-11 23:42:51 -06:00
Sanae
93143a80ef Another log 2022-03-11 20:56:58 -06:00
Sanae
cf5ba12861 One more log 2022-03-11 20:29:17 -06:00
Sanae
ebf5080a00 More log changes 2022-03-11 20:16:10 -06:00
Sanae
4c5682e59b Read better 2022-03-11 20:06:47 -06:00
Sanae
89dcb7f6c9 More changes to reading varsize packets 2022-03-11 19:08:50 -06:00
Sanae
8c5cd0ced2 Untested conversion to variable size packets 2022-03-10 23:59:02 -06:00
Sanae
134437eec9 Set client name regardless of connection type 2022-03-06 17:19:49 -06:00
Sanae
00626ab12f Add scenario merging and run reformatting on solution 2022-03-01 15:08:53 -06:00
Sanae
557a926a68 Handle max player count correctly 2022-02-22 14:33:59 -06:00
Sanae
31e70a08b9 Add proper exit handling 2022-02-21 22:05:13 -06:00
Sanae
821301e756 Implement console commands and settings (flip list broken) 2022-02-17 19:56:12 -06:00
Sanae
78af568603 Add RentZero extension as rented memory can be non-zero 2022-02-16 15:20:03 -06:00
Sanae
18bd69338f Improve packet processing and send function 2022-02-16 14:33:21 -06:00
Sanae
514c68d2e9 Lycel go flippy flippy 2022-02-15 18:35:38 -06:00
Sanae
4ccf33ad37 Read until received full packet size 2022-02-15 15:17:18 -06:00
Sanae
57560a9db1 Don't substring, it crashes 2022-02-15 14:39:34 -06:00
Sanae
f0c3ae6963 Logs cleaned up, and tested shine support 2022-02-15 14:26:50 -06:00
Sanae
fca81a4894 im stupid 2022-02-14 16:07:42 -06:00
Sanae
d004df2f4a die 2022-02-14 16:06:49 -06:00