Commit Graph

803 Commits

Author SHA1 Message Date
cpw 0c5ced1bbf
Fix NPE problem when modid is mismatched.
Signed-off-by: cpw <cpw+github@weeksfamily.ca>
2020-11-13 20:41:20 -05:00
cpw 0d7f507f4e
Some help in ExtensionPoint regarding DISPLAYTEST. Let's improve those tick rates!
Signed-off-by: cpw <cpw+github@weeksfamily.ca>
2020-11-07 23:11:45 -05:00
cpw f78b943bdf
Handle erroring during early mod construction phases, and actually report that into the error UI
by doing armslength exception handling and propagation.

Signed-off-by: cpw <cpw+github@weeksfamily.ca>
2020-11-07 22:30:19 -05:00
diesieben07 acd18455c2
Workaround for modded attributes on vanilla entities logging warnings on vanilla clients
Switch to a handler-based approach per packet class, simplify patch, add some docs

Add license header and docs

Switch to a network handler based approach

Switch to a network handler based approach

revert build gradle change

Simplify Packet patch

Add license header to IForgePacket

Revert ForgeHooks changes

Less hacky and more generic way to filter packets for vanilla connections

_Actually_ Order SAS.
It's early

Order SAS

simplify vanilla connection check

Remove unneeded import change
2020-11-03 18:47:04 -05:00
cpw 749c9063af
Fix config parse failure causing crash in building exception message. fixes #7438
Signed-off-by: cpw <cpw+github@weeksfamily.ca>
2020-11-01 17:09:00 -05:00
cpw 7e79243bca
Return client resources even if no data pack found on server. Closes #6225 (Pull request)
Signed-off-by: cpw <cpw+github@weeksfamily.ca>
2020-11-01 17:02:56 -05:00
David Quintana 53eedb0f10
Update forge mappings to 20201028-1.16.3 (#7435) 2020-10-29 01:11:57 +01:00
cpw 80baad974e
Restore FingerprintViolationEvent with appropriate THIS IS F*CKING DEAD DELET WARNINGS.
Also, notify in UI if using legacy JDK without capability to read out security data from mod jars.

Signed-off-by: cpw <cpw+github@weeksfamily.ca>
2020-10-26 07:31:49 -04:00
cpw ae160cad12
Add signature reporting for mods, using new signature capture from ModLauncher. Need to figure out
how to reflect Minecraft's JAR signatures into here.

Signed-off-by: cpw <cpw+github@weeksfamily.ca>
2020-10-25 22:26:16 -04:00
cpw 6ff6277efa
Rollback registries to vanilla state if something happens during loading, so subsequent activities can still run and not generate false reports..
Signed-off-by: cpw <cpw+github@weeksfamily.ca>
2020-10-25 11:33:43 -04:00
cpw 3041c2022b
Add in extra debug logging
Signed-off-by: cpw <cpw+github@weeksfamily.ca>
2020-10-04 17:45:28 -04:00
cpw 09be003d61
Remove redundant call to CrashReport generator - Vanilla is doing a crashreport for itself at startup now.
Add a UUID into crashreport that is also logged in all channels at crash report generation time. This will allow to associate crash reports and the logs.

Signed-off-by: cpw <cpw+github@weeksfamily.ca>
2020-10-04 16:40:38 -04:00
cpw 935cb6782d
Modify how ModLoadingStage handles dispatch to Registry Events. Stops the objectholder spam and generally improves performance on larger packs.
Signed-off-by: cpw <cpw+github@weeksfamily.ca>
2020-10-04 15:50:15 -04:00
Richard Freimer af75547d37
Fix a few minor issues with custom tag types and fix OptionalNamedTags (#7316) 2020-09-23 20:12:11 -07:00
ichttt e344fd08a5
Add a better license error screen (#7350) 2020-09-23 14:16:36 -07:00
Cyborgmas 738491c25d
Add MatrixStack-aware alternatives to the methods in GuiUtils (#7127) 2020-09-15 21:46:58 +02:00
Yunus 873c490470
Reimplemented drawHoveringText (#7268) 2020-09-15 15:22:50 +02:00
LexManos c75eb9e7cf 1.16.3 Update
Also included a bunch of warning cleanups.
2020-09-10 12:01:45 -07:00
cpw 9f3141ea16
More crash reporting tweaks. Don't crash when trying to show warnings. Also, put the exception name in the error screen on the second line!
Signed-off-by: cpw <cpw+github@weeksfamily.ca>
2020-09-09 19:04:19 -04:00
Richard Freimer 45f8dc5245
Add support for custom tag types (#7289) 2020-09-08 19:10:36 -07:00
cpw 43391c009c
More crash report tweaks. Put a button to open the generated crash report on the error screen, tweak formatting of crash report, and add the enhanced stack trace data (transformers et al)
Signed-off-by: cpw <cpw+github@weeksfamily.ca>
2020-09-08 20:05:45 -04:00
Cyborgmas f68344cd7c
Fixed crash with zip paths (#7300) 2020-09-08 13:47:39 -07:00
sciwhiz12 47f05a4fcd
Bump resource pack version to 6 (#7299) 2020-09-08 13:02:28 -07:00
ichttt 051416b823
Fix crash when dumping crash report for an exception that has a null cause (#7308) 2020-09-08 12:00:55 -07:00
cpw 84fe2cbcc4
Tweak crash report dump to visit all the causes up to the top.
Signed-off-by: cpw <cpw+github@weeksfamily.ca>
2020-09-06 21:29:21 -04:00
cpw 9051021474
Fix some potential issues in crash dumping during mod loading
Signed-off-by: cpw <cpw+github@weeksfamily.ca>
2020-09-06 18:07:53 -04:00
cpw cc473be332
Park the polling thread for a bit, if we're not the one driving the task list forwards. This allows for the actual driver to work on low cpu count machines.
Signed-off-by: cpw <cpw+github@weeksfamily.ca>
2020-09-06 17:55:03 -04:00
sciwhiz12 bef8c2da3d
Fix crash caused by previous commit (#7298) 2020-09-03 08:40:40 -04:00
LexManos 3820d1b66f Dirty casting hacks to fix eclipse compiler inference issue. I'm sorry cpw. 2020-09-02 21:15:16 -07:00
tterrag 7dbae7ea4a Fix broken ExistingFileHelper import
Add licenses to some new files
2020-09-02 23:37:46 -04:00
tterrag be5885155c
Add validation via resources for tag providers (#7271)
BREAKING CHANGE: Moved ExistingFileHelper to common package
Remove various workarounds from forge tag providers
2020-09-02 23:18:22 -04:00
cpw 5dac065994
Move the "modloading" thread activity onto _our_ worker pool. It turns out that the vanilla worker pool can deadlock during stitching if it's insufficiently large, if modloader "waitForTransition" is also a worker member of that pool.
Closes #7293 (to reproduce issue easily, modify Util.func_240979_a_ and change the values in the MathHelper.clamp call). I've verified that 3 and below for "max" cause the problem. (I didn't test a whole range of values, just sufficient to reproduce problem and verify fix). Note that setting it to zero (and using the "direct executor" that's inaccessible in normal operation) works as well with this fix.

Signed-off-by: cpw <cpw+github@weeksfamily.ca>
2020-09-01 14:36:02 -04:00
cpw 1d7db95539
Fix missed debugging code. Read the config from the config.
Signed-off-by: cpw <cpw+github@weeksfamily.ca>
2020-08-31 22:26:53 -04:00
cpw bfeec0c7bd
Merge branch '1.16.1' into 1.16.x
# Conflicts:
#	patches/minecraft/net/minecraft/client/Minecraft.java.patch
#	patches/minecraft/net/minecraft/item/crafting/Ingredient.java.patch
#	src/main/java/net/minecraftforge/fml/client/ClientModLoader.java
#	src/main/java/net/minecraftforge/registries/GameData.java
2020-08-31 21:15:56 -04:00
cpw 2e42340dfa
Fix up all the things. Removed SidedProvider because it served no real purpose anymore.
Signed-off-by: cpw <cpw+github@weeksfamily.ca>
2020-08-31 21:00:44 -04:00
cpw 16b82bb97b
Merge branch '1.16.x' into 1.16.1
# Conflicts:
#	src/main/java/net/minecraftforge/fml/ModList.java
#	src/main/java/net/minecraftforge/fml/client/ClientModLoader.java
2020-08-30 21:44:51 -04:00
cpw d76ee4edd7
Redo event dispatch, removes a bunch of nonsense, and tries to integrate with the vanilla CF system where possible
Signed-off-by: cpw <cpw+github@weeksfamily.ca>
2020-08-30 21:39:06 -04:00
David Quintana 600e68cace
Clarify in the LazyOptional which methods carry the lazyness over to the returned value and which don't. (#6750)
For consistency, this meant making a few changes:
- Renamed the existing lazy mapping method to lazyMap, to indicate that it doesn't run the mapping immediately.
- Added a new implementation of map(), which returns Optional<T>, and resolves the value in the process.
- Changed filter() to return Optional, since there's no way to filter lazily.
- Added a new method resolve(), which helps convert the custom LazyOptional class into a standard Optional, for use
with library methods that expect Optional<T>.

* Update License headers.
2020-08-25 03:11:28 +02:00
sciwhiz12 625cd746ef
Add user-friendly exceptions when config loading fails (#7214) 2020-08-21 14:27:12 -07:00
Philip T 5a20705f05
Log info about server list warning (#7209)
Make it easier to figure out what mods are missing or have to be marked as client/server side only.
2020-08-21 11:15:44 -07:00
Take Weiland 50197b1fa5
Improve performance and cleanup code for DelegatingResourcePack (#7228) 2020-08-21 10:48:48 -07:00
Cyborgmas 797791c2af
Fix small logging issues with loading pack.png for mods (#7265) 2020-08-21 10:24:49 -07:00
LexManos fe43088c96 Initial 1.16.2 Update 2020-08-13 00:35:08 -07:00
David Quintana a8e68328c4 Move ModelRegistryEvent invocation to when the model loading is about to start.
Freeze the ModelLoaderRegistry right after this event happens, just before model loading actually begins.
This means ModelRegistryEvent is now the correct place to register loaders, as it was intended.
This is a slight breaking change, but any mod that used FMLClientSetupEvent before will need to be updated regardless due to the existing race condition.
2020-08-08 03:00:15 +02:00
Take Weiland 20702456ac
Re-introduce "outdated" notification on Mods button in main menu (#7123) 2020-08-03 15:11:06 -07:00
LexManos e62805f1d7 Fix another case of swallowed errors not shutting down mods. 2020-07-28 16:44:29 -07:00
cpw ff752ab14b
Revert "Properly shutdown FMLModContainer's event bus when an error in a lifecycle event is detected."
This reverts commit 30bad1e2

Signed-off-by: cpw <cpw+github@weeksfamily.ca>
2020-07-28 19:17:35 -04:00
cpw 19a38f5cb9
Revert "Shut down all other mod handlers if the loading cycle errors. This prevents other mods from throwing errors and being blamed for initial cause. This is a temporary hack until cpw re-writes the mod event dispatcher."
This reverts commit 7592bbe8

Signed-off-by: cpw <cpw+github@weeksfamily.ca>
2020-07-28 19:17:29 -04:00
LexManos 7592bbe87e Shut down all other mod handlers if the loading cycle errors.
This prevents other mods from throwing errors and being blamed for initial cause.
This is a temporary hack until cpw re-writes the mod event dispatcher.
2020-07-28 14:39:53 -07:00
LexManos 30bad1e26d Properly shutdown FMLModContainer's event bus when an error in a lifecycle event is detected. 2020-07-28 12:01:15 -07:00