During the rewrite in 89e55e9065, a queue system was added to allow
using both VoxelManip-based generation steps, and set_node-based steps,
however some set_node-based steps (underground mushrooms, nether
decorations, and structures) were missed and remained in a VoxelManip
step. The result is that the changes made by the set_node stages were
overwritten after the (now-stale) VoxelManip data was committed later.
(ref. Mineclonia/Mineclonia#26)
This commit makes enchanted tools which have no use for
tool_capabilities to not include it in their metadata. It does this by
not including tool_capabilities in the metadata of an enchanted tool if
at least one of two cases is true:
(1) The tool is not enchanted with unbreaking or efficiency
(2) The tool does not have tool_capabilities defined in its definition
The first case covers situations like having a pickaxe only being
enchanted with silk_touch. The second case covers situations like a
piece of armor being enchanted with unbreaking.
This commit fixes an issue were tools enchanted with both efficiency and
unbreaking would loose the effect of one of the enchantments in some
conditions.
Reviewed-on: https://git.minetest.land/Mineclonia/Mineclonia/pulls/4
This code fixes annoying minecart bugs that were introduced with Mineclone2 0.71.0:
• Minecarts going off the rails (#9)
• Minecarts being unable to go back on the rails (#10)
• TNT minecarts being broken (#11)
• Minecarts not being pushed by mobs (#12)
I have verified that it does not break the following features present in Mineclone2 0.70:
• Minecart teleporters
• Minecarts stop at the end of the rail
• Going uphill in a minecart
• Going downhill in a minecart
• Going around curves in a minecart
• Going left at intersections in a minecart with both left and right rail connections
• Going straight ahead at intersections with both right and straight ahead rail connections
• Pushing minecarts
• Powered golden rails make minecarts go faster
• Unpowered golden rails make minecarts stop
• Detector rails activate Redstone circuits
• Minecarts going in circles at maximum speed without glitching off the rails
• Dispensers placing minecarts on top of rail blocks on top of the dispenser
• Going to the Nether in a minecart
• Powered activator rails drop players from minecarts
• Unpowered activator rails do not drop players from minecarts
• Track switching using pistons pushing a Minecart from one track to another
• Minecarts stay on powered rails going up a spiral staircase
• Minecarts can activate note blocks through sensor blocks
• Minecarts can activate Redstone lamps through sensor blocks
It looks like the dependency might cause problems with the mod loading
order and lead to situations were _mcl_autogroup is not loaded after all
the other mods. Because _mcl_autogroup begins with an underscore it
should always be loaded after mcl_autogroup anyways.
If the tool_capabilities defaults to {} if unspecified the tool, then
users will not be able to attack with the tool at all. This solves that
by including the damage_group and full_punch_interval from the hand into
the tool_capabilities when it is nil.
Group levels are now specified as a list of names when registering a
digging group. Digging groups which do not have specified levels will
support tools having two levels, 0 and 1 where 0 means the tool can dig
but not harvest the node and 1 means it can also harvest the node. If
more levels are required one has to specifiy them when registering the
digging group.
This adds the metadata field "groupcaps_hash" to tools enchanted with
efficiency. This value contains a hash of the groupcaps field in
tool_capabilities. This value gets compared to the expected hash value
to determine if the tools tool_capabilities should be updated according
to commit af31f8189e8e5c2b.
This commit makes efficiency more efficient.
Because of the way digging times is implemented in Mineclone2, it is
possible for the digging times of efficiency enchanted tools to become
outdated.
This fixes that by automatically updating the tools tool_capabilities
after each time the tool is used.
Added the API function mcl_autogroup.get_wear which is used to get the
tool wear for digging a node of a group. This is used by mcl_tools to
compute the wear of shovels and shears when rightclicking to create
grass paths and carve pumpkins.
The function mcl_autogroups.get_groupcaps is used by mods to get the
groupcaps for tools with efficiency enchantments. This function is used
by mcl_enchanting when enchanting tools with efficiency.
Previously some nodes like "mcl_flowers:double_grass_top" would be
undiggable. This was because they did not define _mcl_hardness and it
was not defaulted to 0 in all parts of _mcl_autogroup.
Requiring tool definitions to call a function in _mcl_autogroup means
that they need to be loaded after _mcl_autogroup. This can cause
problems because _mcl_autogroup needs to be loaded after all tool and
node definitions are completed.
Because of this the API is changed so tool definitions instead put the
data used to generate groupcaps in the custom field
_mcl_autogroup_groupcaps. _mcl_autogroup will then go through all
registered tools and update the groupcaps for every tool where this
field is present. This means that no mod ever has to depend on
_mcl_autogroup.
These changes are primarly made to make mcl_autogroup more efficient.
Previously enchanted tools required storing around 21 kB of metadata due
to the way the previous version of the mod was implemented. This caused
a lot of lag and a huge amount of network traffic. With the changes
enchanted tools won't require more than 1 kB of metadata.
The mod is also rewritten to use an API to register digging groups and
compute the groupcaps for tools. This will make it easier for modders
to register custom digging groups.
The mod is now split up into two parts. One part called "mcl_autogroup"
to implement the API for registering custom digging groups, and the
other part called "_mcl_autogroup" which contains most of the code which
has to be loaded after most mods.
