ForgePatch/skipped_commits.md
2019-04-12 20:18:17 -04:00

3.6 KiB

Commit Needs Revisit Note
Class transformer optimizations (#5159) Yes
Change universal bucket support to use fluid names instead of instances Yes The affected code is nearly entirely absent
Change biome spawn list entries to use factory method where possible (#5075) No EntityType makes this obsolete
Prevent some texture loading errors from crashing the game (#5121) Yes TextureMap has changed drastically, is this still needed?
Add a notification event for handling game rule changes (#5152) No GameRules$Value has a change callback, mods can just use this
Allow IModel to express itself as a vanilla parent (#5195) Yes Vanilla has integrated the check we used to do (see ModelBlock#resolveParent) so this will need a new solution.
A different approach to my changes in 8ace535 to fix #5207 No 🦀FML IS GONE🦀
Fix patches from #5160 setting rotation as well as position (#5233) No Apparently I included it in this commit accidentally.
Use HTTPS for files website. No Irrelevant, buildscript was completely changed
Prevent RecipeBook from crashing on empty modded ingredients (#5234) No Fixed in vanilla
Improve reflection helper methods (#4853) No ObfuscationReflectionHelper refactored
Clean up logged mod states (#5227) Yes Currently the mod state table dump is absent from crash reports, should revisit once that is added again
Fix minor issue in getFilledPercentage for Fluid rendering (#5206) No Fluid block classes are gone
Fix missing comments in configs created with annotations (#5189) No Configs rewritten
Compute ASMDataTable submaps parallel, speeds up contructing mods (#5246) No ASMData is no more
Add methods to allow loading json constants outside of _constants (#4975) Yes CraftingHelper was overhauled quite a bit, is this necessary still?

Currently updated through: 32c24be6b49769b6d9be73b46144f62cabe13175