Commit graph

4071 commits

Author SHA1 Message Date
alederer
c5310d1855
Instrument editor undo (minus FixedQueue change) (#2094)
* add undo to instrument editor (check for diffs on the current DivInstrument in insEdit, record them in a stack)

* style fixes

* accidentally left some logs in

* typo in style fix

* cheat to avoid warning -Werror=class-memaccess on linux

* warn instead of assert on case where MemPatch application would exceed size of target buffer (which should never happen, if you're applying the patch to the same type it was generated from)

* instrument editor undo: don't check delta if no user input has come in that could potentially have dirtied the editor

* don't run a delta against cached instrument if not insEditOpen

* revert fixedQueue to before my 'fix' (if i touch it again i'll add unit tests)

* explicitly cast to (DivInstrumentPOD*) when memsetting DivInstrumentPOD in DivInstrument constructor, rather than relying on implicit memory layout

* use delete[] instead of free (whoops)

* MemPatch/DivInstrumentUndoStep -- remove clear() function (ambiguous whether it should free data, it only existed to set data to null after the swap, so just do that directly now). Also set data to null after delete.

* DivInstrument -- fix dangling undo-step pointers being created on duplicate (potentially leading to use-after-free), fix undo-step objects being shamelessly leaked

---------

Co-authored-by: Adam Lederer <adam@adamlederer.com>
2024-08-23 15:17:19 -05:00
tildearrow
bae45e0b86 SN: fix arp macro with easy period 2024-08-23 02:25:53 -05:00
LTVA1
3b6ddebc64 disable 2024-08-23 00:53:44 -05:00
LTVA1
9f9638931d yeah 2024-08-23 00:53:44 -05:00
tildearrow
8a18f962f9 VGM export: don't generate garbage stop sample com
issue #2072
2024-08-22 23:17:22 -05:00
LTVA1
a4dae5302b account for fadeout length, optimize some progress bar calc 2024-08-22 03:17:35 -05:00
LTVA1
beca6bea00 fix? 2024-08-22 03:17:35 -05:00
LTVA1
d79bad195a looks like it works, no account for fadeout tho 2024-08-22 03:17:35 -05:00
tildearrow
a410b90452 CRAP 2024-08-19 12:54:09 -05:00
tildearrow
ecbfacef1f add SFWrapper error logging 2024-08-19 12:40:51 -05:00
tildearrow
d3af810462 Revert "add undo to instrument editor (check for diffs on the current DivInstrument in insEdit, record them in a stack)"
This reverts commit 5c9fd69ac1.
2024-08-19 02:49:24 -05:00
tildearrow
f1de0bf2b7 Revert "style fixes"
This reverts commit 15d47d0aae.
2024-08-19 02:49:24 -05:00
tildearrow
73c61d9ac7 Revert "accidentally left some logs in"
This reverts commit 55af1648e7.
2024-08-19 02:49:24 -05:00
tildearrow
c00947071a Revert "typo in style fix"
This reverts commit 91d36d0a62.
2024-08-19 02:49:24 -05:00
tildearrow
78d7fb4da0 Revert "cheat to avoid warning -Werror=class-memaccess on linux"
This reverts commit 94ef697ea6.
2024-08-19 02:49:24 -05:00
tildearrow
257abca831 Revert "warn instead of assert on case where MemPatch application would exceed size of target buffer (which should never happen, if you're applying the patch to the same type it was generated from)"
This reverts commit ea02a913b2.
2024-08-19 02:49:24 -05:00
tildearrow
251be67b69 Revert "instrument editor undo: don't check delta if no user input has come in that could potentially have dirtied the editor"
This reverts commit ad53b33d7c.
2024-08-19 02:49:24 -05:00
Adam Lederer
ad53b33d7c instrument editor undo: don't check delta if no user input has come in that could potentially have dirtied the editor 2024-08-19 02:44:18 -05:00
Adam Lederer
ea02a913b2 warn instead of assert on case where MemPatch application would exceed size of target buffer (which should never happen, if you're applying the patch to the same type it was generated from) 2024-08-19 02:44:18 -05:00
Adam Lederer
94ef697ea6 cheat to avoid warning -Werror=class-memaccess on linux 2024-08-19 02:44:18 -05:00
Adam Lederer
91d36d0a62 typo in style fix 2024-08-19 02:44:18 -05:00
Adam Lederer
55af1648e7 accidentally left some logs in 2024-08-19 02:44:18 -05:00
Adam Lederer
15d47d0aae style fixes 2024-08-19 02:44:18 -05:00
Adam Lederer
5c9fd69ac1 add undo to instrument editor (check for diffs on the current DivInstrument in insEdit, record them in a stack) 2024-08-19 02:44:18 -05:00
tildearrow
a318508b40 0.5 leftover 2024-08-18 18:20:01 -05:00
tildearrow
39923742ab ZSM export: move to ROM export framework 2024-08-18 17:21:17 -05:00
cam900
875ef08256
Fix Y8950 ADPCM memory addressing
Max supported size is 262144 bytes, so I fixed that.
2024-08-18 20:22:24 +09:00
tildearrow
7974b96275 fixes 2024-08-18 02:30:30 -05:00
tildearrow
aa4ccc3c3f importExport/shared -> fileOpsCommon 2024-08-17 18:51:05 -05:00
tildearrow
e3e61c817c Merge branch 'master' into sample_banks 2024-08-17 17:53:15 -05:00
tildearrow
3f47979ea7 IT import: handle end of file when reading samples 2024-08-17 17:18:14 -05:00
tildearrow
636a9921a2 changes 2024-08-17 16:29:13 -05:00
LTVA1
5770f381ba setting to choose between OPL2 and OPL3, channel naming 2024-08-17 16:26:53 -05:00
LTVA1
41e094d79d OPL3, hide unused channels 2024-08-17 16:26:53 -05:00
tildearrow
8ad9bfa245 fix panbrello depth 2024-08-16 23:59:20 -05:00
Aleksi Knutsi
a9591fae71
AY Timer bug fixes and some QOL improvements (#2073)
* Create android.yml

* bug fixes part 1

* bollocks number 1

* Update android.yml

* why are you crackling you arent supposed to do that

* stop crackling please

* what a load of

* what a load of part 2

* what a load of part 3

* what a load of part 4

* final commit... i hope!

* final commit my rear bottom

* final commit for real this time

* Delete .github/workflows/android.yml

* Update sysDef.cpp
2024-08-15 15:55:29 -05:00
tildearrow
eaa943e724 GUI: parse ROM export requisites 2024-08-15 11:28:10 -05:00
freq-mod
33f56ba531 remove leftovers 2024-08-14 20:27:58 +02:00
cam900
f906b4ebe4 Safety check for MSM6295 bankswitched address 2024-08-14 17:54:20 +09:00
tildearrow
34517754ad port TIunA to export framework, part 4
index option
2024-08-13 18:42:11 -05:00
tildearrow
249032f096 port TIunA to export framework, part 2
progress bars!
2024-08-13 17:47:18 -05:00
tildearrow
bb5ad38fb6 port TIunA to export framework, part 1
part 2 includes progress bars and options
2024-08-13 16:50:13 -05:00
tildearrow
aad42210d7 it kinda works 2024-08-13 14:34:06 -05:00
tildearrow
e475b29ec3 a menu 2024-08-13 04:40:26 -05:00
tildearrow
b5e500d85d dev217 2024-08-13 04:14:46 -05:00
MooingLemur
0224882a42 oops, should have been 47.0.2 2024-08-13 04:11:08 -05:00
MooingLemur
3b9cf70ff5 VERA: bump default chip type 2024-08-13 04:11:08 -05:00
MooingLemur
a8122d3efd Add VERA 47.0.3 chip type 2024-08-13 04:11:08 -05:00
tildearrow
45eab67fd4 prepare more stuff 2024-08-13 04:10:03 -05:00
freq-mod
8e39d5ff8f part final please god 2024-08-12 19:26:20 +02:00