5E01: fix 12xx

.github/issue_template.md

@@ -1,7 +1,12 @@
-# IMPORTANT NOTICE
+# EXTREMELY IMPORTANT NOTICE - PLEASE **READ**!!!!!!!
 
-1. this section is exclusively for ISSUES related to Furnace (bugs, major annoyances and others).
+BY SUBMITTING AN ISSUE, YOU HEREBY AGREE TO COMPLY WITH THESE TERMS.
-2. this section is NOT for Suggestions, Questions, Showcase or any other Discussions that do not meet the criteria and definition of an ISSUE.
+FAILURE TO DO SO MAY RESULT IN YOUR ISSUE BEING DECLARED VOID.
+
+**ADDITIONALLY, FAILURE TO COMPLY WITH POINTS 1 AND 2 WILL RESULT IN THE INABILITY TO ISSUE FURTHER ISSUE REPORTS.**
+
+1. this section is exclusively for ISSUES related to Furnace (bugs, major annoyances and others). ONLY THINGS THAT COUNT AS **ISSUES** (ad pedem litterae).
+2. **THIS SECTION IS NOT FOR SUGGESTIONS, REQUESTS, QUESTIONS, SHOWCASE OR ANY OTHER DISCUSSIONS THAT DO NOT MEET THE CRITERIA AND DEFINITION OF AN __ISSUE__.**
   - see the Discussions section if you wish to submit these.
 3. check whether your issue has been reported already.
   - go to the Issues section, and use the search bar that appears on top of the Issues list.
@@ -33,7 +38,11 @@
     - Linux: `~/.config/furnace/furnace.log`
     - make sure to remove any personal information for privacy reasons.
 
-BY SUBMITTING A TICKET, YOU HEREBY AGREE TO COMPLY WITH THESE TERMS.
+BY SUBMITTING AN ISSUE, YOU HEREBY AGREE TO COMPLY WITH THESE TERMS.
-FAILURE TO DO SO MAY RESULT IN YOUR TICKET BEING DECLARED VOID.
+FAILURE TO DO SO MAY RESULT IN YOUR ISSUE BEING DECLARED VOID.
 
-***END OF NOTICE*** --- REMOVE THIS NOTICE AFTER READING!
+**ADDITIONALLY, FAILURE TO COMPLY WITH POINTS 1 AND 2 WILL RESULT IN THE INABILITY TO ISSUE FURTHER ISSUE REPORTS.**
+
+***END OF NOTICE***
+PLEASE REMOVE THIS NOTICE AFTER READING.
+FAILURE TO REMOVE THIS NOTICE IS NEGLIGENCE.

CONTRIBUTING.md

@@ -2,7 +2,19 @@
 
 contributions to Furnace are welcome!
 
-# Getting ready
+# Issue reports
+
+if you find an issue with Furnace, see the Issues section.
+
+# Suggestions and other types of discussions
+
+see the Discussions section.
+
+**DO NOT USE THE ISSUES SECTION FOR THESE - it is only for ISSUES.**
+
+# Other
+
+## Getting ready
 
 log into your Github account, and click the Fork button in the header of the project's page.
 
@@ -14,9 +26,9 @@ git clone git@github.com:USERNAME/furnace.git
 
 (replace `USERNAME` with your username)
 
-# Working
+## Working
 
-## Code
+### Code
 
 bug fixes, improvements and several other things accepted.
 
@@ -84,11 +96,11 @@ additional guidelines:
 - on a switch block, **always** put `default` last and not in any other position.
   - I have fear of some C/C++ compilers ignoring the rest of cases upon hitting default.
 
-## Do NOT Force-Push after submitting Pull Request
+### Do NOT Force-Push after submitting Pull Request
 
 if you do so, your pull request will be closed.
 
-## Demo Songs
+### Demo Songs
 
 just put your demo song in `demos/`! be noted there are some guidelines:
 
@@ -100,11 +112,11 @@ just put your demo song in `demos/`! be noted there are some guidelines:
   - Pong: it is a joke system.
 - the song shall be in Furnace file format.
 
-# Finishing
+## Finishing
 
 after you've done your modifications, commit the changes and push.
 then open your fork on GitHub and send a pull request.
 
-# I don't know how to use Git but I want to contribute with a demo song
+## I don't know how to use Git but I want to contribute with a demo song
 
 you can also contact me directly! [find me here.](https://tildearrow.org/?p=contact)

src/engine/platform/nes.cpp

@@ -608,6 +608,8 @@ int DivPlatformNES::dispatch(DivCommand c) {
       chan[c.chan].duty=c.value;
       if (c.chan==3) { // noise
         chan[c.chan].freqChanged=true;
+      } else if (c.chan==2 && isE) {
+        rWrite(0x4000+9,chan[c.chan].duty);
       } else if (c.chan<2) {
         rWrite(0x4000+c.chan*4,(chan[c.chan].active?((chan[c.chan].envMode<<4)|chan[c.chan].outVol):0x30)|((chan[c.chan].duty&3)<<6));
       }