this still won't pass CI
This commit is contained in:
parent
a9acba3cb7
commit
78a2218ee1
|
@ -76,6 +76,7 @@ additional guidelines:
|
|||
- I will run a test suite to make sure this is the case.
|
||||
- if something breaks, you might want to add a compatibility flag (this requires changing the format though).
|
||||
- do not use `#pragma once`.
|
||||
- do not memcmp() structs.
|
||||
- on a switch block, **always** put `default` last and not in any other position.
|
||||
- I have fear of some C/C++ compilers ignoring the rest of cases upon hitting default.
|
||||
|
||||
|
|
|
@ -60,6 +60,10 @@ void DivInstrument::putInsData2(SafeWriter* w, bool fui) {
|
|||
bool featureSU=false;
|
||||
bool featureES=false;
|
||||
|
||||
// almost 40 years of C++, and there still isn't a way to easily compare two structs.
|
||||
// even Java, which many regard as having a slow runtime, has .equals().
|
||||
|
||||
|
||||
blockEndSeek=w->tell();
|
||||
if (!fui) {
|
||||
w->seek(blockStartSeek,SEEK_SET);
|
||||
|
|
Loading…
Reference in New Issue