SuperMarioOdysseyOnline/include/packets/PlayerConnect.h

#pragma once

#include "Packet.h"

#include <cstdint>

struct PACKED PlayerConnect : Packet {
    PlayerConnect() : Packet() {this->mType = PacketType::PLAYERCON; mPacketSize = sizeof(PlayerConnect) - sizeof(Packet);};
    ConnectionTypes conType;
    u16 maxPlayerCount = USHRT_MAX;
    char clientName[COSTUMEBUFSIZE] = {};
};
First Commit 2022-06-16 21:33:18 +00:00			`#pragma once`

			`#include "Packet.h"`

packets/PlayerConnect: Initialize maxPlayerCount It was sending bad data since it wasn't getting inited anywhere. 2022-06-24 00:18:40 +00:00			`#include <cstdint>`

packets: Fix struct packing related bugs - sizeof(bool) is implementation defined. The server assumes it's 4 but for me it was 1 (tested with Release too) which caused some bugs - Structs aren't guaranteed to be packed. The compiler is free to change the layout, which we wouldn't want to for the Packet structs that we deserialize on the server. 2022-06-22 17:16:08 +00:00			`struct PACKED PlayerConnect : Packet {`
First Commit 2022-06-16 21:33:18 +00:00			`PlayerConnect() : Packet() {this->mType = PacketType::PLAYERCON; mPacketSize = sizeof(PlayerConnect) - sizeof(Packet);};`
			`ConnectionTypes conType;`
packets/PlayerConnect: Initialize maxPlayerCount It was sending bad data since it wasn't getting inited anywhere. 2022-06-24 00:18:40 +00:00			`u16 maxPlayerCount = USHRT_MAX;`
First Commit 2022-06-16 21:33:18 +00:00			`char clientName[COSTUMEBUFSIZE] = {};`
			`};`