SuperMarioOdysseyOnline/include/packets/ShineCollect.h

#pragma once

#include "Packet.h"

struct PACKED ShineCollect : Packet {
    ShineCollect() : Packet() {this->mType = PacketType::SHINECOLL; mPacketSize = sizeof(ShineCollect) - sizeof(Packet);};
    int shineId = -1;
    bool4 isGrand = false;
};
First Commit 2022-06-16 21:33:18 +00:00			`#pragma once`

			`#include "Packet.h"`

packets: Fix struct packing related bugs - sizeof(bool) is implementation defined. The server assumes it's 4 but for me it was 1 (tested with Release too) which caused some bugs - Structs aren't guaranteed to be packed. The compiler is free to change the layout, which we wouldn't want to for the Packet structs that we deserialize on the server. 2022-06-22 17:16:08 +00:00			`struct PACKED ShineCollect : Packet {`
First Commit 2022-06-16 21:33:18 +00:00			`ShineCollect() : Packet() {this->mType = PacketType::SHINECOLL; mPacketSize = sizeof(ShineCollect) - sizeof(Packet);};`
			`int shineId = -1;`
packets: Fix struct packing related bugs - sizeof(bool) is implementation defined. The server assumes it's 4 but for me it was 1 (tested with Release too) which caused some bugs - Structs aren't guaranteed to be packed. The compiler is free to change the layout, which we wouldn't want to for the Packet structs that we deserialize on the server. 2022-06-22 17:16:08 +00:00			`bool4 isGrand = false;`
First Commit 2022-06-16 21:33:18 +00:00			`};`