etc/SmoOnlineServer
0
0
Fork 0
mirror of https://github.com/Sanae6/SmoOnlineServer.git synced 2024-11-16 00:25:07 +00:00
Code Issues Projects Releases Wiki Activity

only broadcast the DisconnectPacket if the client was connected

Browse source 
Otherwise port scans, banned players or clients failing to initialize correctly,
will cause the server to send unnecessary packets to all connected clients.

They currently are informed about a disconnect for a client that hasn't even connected correctly.

(cherry picked from commit 4b04a3d5be)
This commit is contained in:
Robin C. Ladiges 2022-09-06 02:46:40 +02:00
parent e14616030c
commit 891cfb41fb
No known key found for this signature in database
GPG key ID: B494D3DF92661B99
1 changed files with 6 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
Server/Server.cs
View file

@ -308,6 +308,8 @@ public class Server {
disconnect:
Logger.Info($"Client {socket.RemoteEndPoint} ({client.Name}/{client.Id}) disconnected from the server");
close:
bool wasConnected = client.Connected;
// Clients.Remove(client)
client.Connected = false;
try {
@ -316,8 +318,10 @@ public class Server {
catch { /*lol*/ }
#pragma warning disable CS4014
Task.Run(() => Broadcast(new DisconnectPacket(), client))
.ContinueWith(x => { if (x.Exception != null) { Logger.Error(x.Exception.ToString()); } });
if (wasConnected) {
Task.Run(() => Broadcast(new DisconnectPacket(), client))
.ContinueWith(x => { if (x.Exception != null) { Logger.Error(x.Exception.ToString()); } });
}
#pragma warning restore CS4014
}