Implement proper actor/component lifecycle #9

New Issue

Closed

opened 2022-02-22 00:06:48 +00:00 by keith · 3 comments

keith commented

2022-02-22 00:06:48 +00:00

Owner

Currently, the lifecycle described in Scene-Actor-Component model is not actually properly implemented. Specifically, (resume) and (activate) are not called as described during initialization.

To implement this lifecycle, actors should not be properly added to their scenes (via [scene (add-actor)]) immediately after they are created. Instead, a new function should be called to properly initialize them, after all their components and children have been attached.

Currently, the lifecycle described in [Scene-Actor-Component model](https://bytes.keithhacks.cyou/keith/wh-engine/wiki/Scene-Actor-Component-model#lifecycle) is not actually properly implemented. Specifically, `(resume)` and `(activate)` are not called as described during initialization. To implement this lifecycle, actors should *not* be properly added to their scenes (via `[scene (add-actor)]`) immediately after they are created. Instead, a new function should be called to properly initialize them, after all their components and children have been attached.

keith added the

missing

label 2022-02-22 00:06:48 +00:00

keith self-assigned this 2022-02-22 00:16:48 +00:00

keith referenced this issue from a commit

2022-02-22 03:17:28 +00:00

(attach-actor-to-world) method for proper initialization (for #9)

keith commented

2022-02-22 03:22:47 +00:00

Author

Owner

The (attach-actor-to-world) functionality can probably be done in [scene (add-actor)] instead?

Also, (parent-activated) and (parent-deactivated) should be rolled into the standard (activate)/(deactivate) methods, with some parameter to specify whether it's being called manually or due to a parent changing activation state.

The `(attach-actor-to-world)` functionality can probably be done in `[scene (add-actor)]` instead? Also, `(parent-activated)` and `(parent-deactivated)` should be rolled into the standard `(activate)`/`(deactivate)` methods, with some parameter to specify whether it's being called manually or due to a parent changing activation state.

keith referenced this issue from a commit

2022-02-22 14:32:57 +00:00

Roll (parent-activated) into (activate) (for #9), and update objective-lisp syntax

keith commented

2022-02-22 14:35:40 +00:00

Author

Owner

Actually, (attach-actor-to-world) can't really be moved into [scene (add-actor)] because that would also be called when moving an already-initialized actor between scenes.

Actually, `(attach-actor-to-world)` can't really be moved into `[scene (add-actor)]` because that would also be called when moving an already-initialized actor between scenes.

keith commented

2022-02-22 16:41:58 +00:00

Author

Owner

Okay so there's an unpredictable bug where (weak-pointer-value child-ptr) will return nil in #[actor (apply-to-tree)]. This happens when garbage collection occurs after the actors have been created in memory, but before (initialize-actors-in) has completed. During this time, the child actors are only referenced by a weak-pointer in their parent, so they are garbage collected. Not entirely sure how to fix this.

Okay so there's an unpredictable bug where `(weak-pointer-value child-ptr)` will return `nil` in `#[actor (apply-to-tree)]`. This happens when garbage collection occurs after the actors have been created in memory, but before `(initialize-actors-in)` has completed. During this time, the child actors are only referenced by a weak-pointer in their parent, so they are garbage collected. Not entirely sure how to fix this.

keith referenced this issue from a commit

2022-02-22 19:03:01 +00:00

Fix actors being GC'd during initialization (closes #9)

keith closed this issue

2022-02-22 19:03:01 +00:00