Roland Häder
80c8ec17c2
Fixed documentation
2022-06-21 18:43:25 +02:00
Roland Häder
0332a57bfd
Rewrote to suggestions from @MrPetovan (I tried to maintain the old way of
...
['scheme' => 'table'] with my version).
2022-06-21 18:13:01 +02:00
Roland Häder
5fe428d3e4
Fixed:
...
- PHPUnit\Framework\Error\Notice: Undefined index: language in /.../src/Util/EMailer/MailBuilder.php on line 122
2022-06-21 13:47:40 +02:00
Roland Häder
1080a840f5
Changes:
...
- Database->$driver can no longer be NULL, an empty string is fine anyway
2022-06-21 13:47:39 +02:00
Roland Häder
945cd1a2c2
Fixed:
...
- since $table can be now schema.table, this needs being taken care off
- maybe this foreach(explode()) is a bit an overkill as only 1 or 2 entries
can be found in it
2022-06-21 13:47:39 +02:00
Roland Häder
0d81a08e3c
WIP: Properly some fixes? Also why is DROP VIEW IF EXISTS is being killed?
2022-06-21 13:47:39 +02:00
Roland Häder
44a9ec9b17
Rewrite:
...
- avoid having array|string for $table to have a "string" type-hint for $table
- you now have to do it for yourself by giving 'schema.table' as parameter
2022-06-21 13:47:38 +02:00
Roland Häder
f62c28008a
Removed comment
2022-06-21 13:47:38 +02:00
Roland Häder
cefffde691
Changes:
...
- added type-hints
- added some missing documentation
2022-06-21 13:47:37 +02:00
Roland Häder
f1867463a0
Changes:
...
- added more type-hints
2022-06-21 13:47:37 +02:00
Roland Häder
77c37ff2db
Fixed:
...
- Uncaught Exception TypeError: "Argument 3 passed to
Friendica\Protocol\DFRN::createActivity() must be of the type string, null
given, called ..."
2022-06-21 13:47:37 +02:00
Tobias Diekershoff
4650ff53d9
Merge pull request #11662 from MrPetovan/bug/11661-splitattachment-null
...
Ensure parameter 4 of Post\Media::splitAttachment is a boolean value
2022-06-21 06:48:52 +02:00
Hypolite Petovan
d2ca812647
Merge pull request #11660 from Quix0r/fixes/more-type-hints-003
...
More type-hints - Batch 003
2022-06-20 21:53:17 -04:00
Roland Häder
3e522ed512
Fixed:
...
- prevent NULL from being handled over to XML::escape()
- still I wonder that an object can be? It is a string-only accepting method
2022-06-21 01:42:37 +02:00
Roland Häder
95f9eb34ac
Fixed indenting
2022-06-21 01:29:33 +02:00
Roland Häder
b6fa022a73
Changes:
...
- added type-hints
- added some documentation
- marked some generic methods to be moved to Util\Strings class instead
2022-06-20 23:50:24 +02:00
Roland Häder
fbae0b8bcf
Changes:
...
- renamed ItemArrayFromMail() to getItemArrayFromMail() to follow naming-convetion
- added missing type-hints
- added missing documentation
2022-06-20 21:22:46 +02:00
Roland Häder
ea22e88896
Added documentation
2022-06-20 21:02:34 +02:00
Roland Häder
752953e472
Changes:
...
- as @MrPetovan pointed out, $actor can be NULL earlier and used later as NULL
- added some missing type-hints
- added missing documentation
- the added @TODO points out to avoid true|false|null for a boolean
2022-06-20 21:00:19 +02:00
Hypolite Petovan
88eacbf66e
Ensure parameter 4 of Post\Media::splitAttachment is a boolean value
2022-06-20 14:34:02 -04:00
Roland Häder
0c12e947dd
Changes:
...
- null was 2nd argument's value before, an empty string is basically the same here
2022-06-20 20:01:59 +02:00
Roland Häder
feb87e8dc3
Changes:
...
- let's start throwing exceptions on e.g. invalid arguments instead of returning
FALSE
2022-06-20 19:09:08 +02:00
Roland Häder
4fb03cf163
Changes:
...
- fixed a null value handled over to Friendica\Model\APContact::getByURL()
- added missing type-hints
2022-06-20 19:05:02 +02:00
Roland Häder
e96a548286
Changes:
...
- dumped default value for $input
- added unknown 'platform' which prevents an "Undefined index: platform in
/var/www/.../src/Model/GServer.php on line 940" error
2022-06-20 18:56:22 +02:00
Roland Häder
6743de63f5
Changed:
...
- DBA::exists() should only be used for checking if records exists.
- if you want to check if a table exists, please ALWAYS use
DBStructure::existsTable() instead
2022-06-20 08:20:07 +02:00
Roland Häder
9c80dd35e5
Both declarations must be the same
2022-06-20 08:07:12 +02:00
Tobias Diekershoff
13a5a30b28
Merge pull request #11659 from MrPetovan/bug/11511-relocate-quote-identifier
...
Add missing identifier quote in Database->replaceInTableFields
2022-06-20 06:26:33 +02:00
Roland Häder
cd3b01fd82
Changed:
...
- cannot have type-hints :-(
2022-06-20 03:48:34 +02:00
Roland Häder
94a594eeb2
Ops, wrong type-hint
2022-06-20 03:36:36 +02:00
Roland Häder
ec96f2252e
Changes:
...
- added type-hints
- added some missing documentation
2022-06-20 03:10:23 +02:00
Roland Häder
14bf72e4fe
Changes:
...
- added some documentation
- added type-hints
2022-06-20 02:48:05 +02:00
Roland Häder
97904ea7dd
Changes:
...
- added type-hints
- added missing documentation
2022-06-20 02:48:02 +02:00
Roland Häder
a0c8fc6d6e
Changes:
...
- added more type-hints
2022-06-20 02:48:02 +02:00
Hypolite Petovan
d48e40c1bf
Add missing identifier quote in Database->replaceInTableFields
...
- This caused hyphenated table names to fail the replace query
2022-06-19 20:06:12 -04:00
Roland Häder
d276f2c62b
Changes:
...
- added type-hints
- changed some double-quotes to single
2022-06-20 01:00:29 +02:00
Hypolite Petovan
622b978a84
Merge pull request #11655 from Quix0r/fixes/more-type-hints-002
...
More type-hints and documentation added
2022-06-19 09:27:29 -04:00
Roland Häder
ed3c53a5f8
Ops, not here wanted. :-(
2022-06-19 14:06:32 +02:00
Roland Häder
bff57bb030
Changes:
...
- added type-hints
- added returned type-hints in interface (I checked all)
2022-06-19 14:00:31 +02:00
Roland Häder
c0d7f8944d
Some calls saved
2022-06-19 11:26:10 +02:00
Roland Häder
60f8c2d795
Changes:
...
- added missing type-hints
- added documentation for a method
2022-06-19 10:50:09 +02:00
Roland Häder
5792a01a01
Contact::getAccountType()'s parameter is never a string, ops
2022-06-19 09:36:24 +02:00
Roland Häder
f3599fa3e9
Changes:
...
- dbstructure(null) is no longer possible, an empty string does it
2022-06-19 09:13:10 +02:00
Tobias Diekershoff
a063a89c57
Accesskey was used twice
...
The accesskey on the User Settings pages for the _account settings_ and the _two factor authentication_ were the same. This PR is assinging a new one to the 2FA.
2022-06-19 06:30:00 +02:00
Roland Häder
b6bfe72083
Wrong returned type, has to be array
2022-06-19 02:40:07 +02:00
Roland Häder
7bb0cb5323
Changes:
...
- added more type-hints
- DBStructure::existsTable() does no longer need array support for table name
because this is no longer used (good work!)
2022-06-19 02:11:12 +02:00
Roland Häder
2c5685c89c
Changes:
...
- changed to proper "use Foo\Bar;"
- added doctag
- added return type as this is fixed
2022-06-19 01:11:30 +02:00
Roland Häder
d7d2ad77ff
Ops, also this!
2022-06-18 23:31:52 +02:00
Roland Häder
39f2d197ea
Changed to suggestings (back to original) + fixed typo in scalar type
2022-06-18 23:30:37 +02:00
Roland Häder
6f1d52cf71
Changed back to suggestions by @MrPetovan
2022-06-18 23:24:08 +02:00
Roland Häder
fa14a02a19
Changes:
...
- added type-hints
- added documentation
- changed double-quotes to single
2022-06-18 23:12:52 +02:00