keith/friendica
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity
35717 commits 4 branches 0 tags 179 MiB
Commit graph

3067 commits

Author SHA1 Message Date
René Wagner
b99e7a9e92
fix exception when adding an poll option without votes 2022-10-28 18:51:35 +02:00
Hypolite Petovan
f418687a71
Merge pull request #12070 from annando/share 
Some more improvements for posts with shares
 2022-10-27 08:19:23 -04:00
Michael
deccea0228 More functions moved to content class 2022-10-27 05:44:44 +00:00
Michael
c65fff6f93 Some more improvements for posts with shares 2022-10-26 17:00:55 +00:00
Roland Häder
498d7f690a
Changes: 
- php-cs is now happy with it
 2022-10-26 17:59:10 +02:00
Roland Häder
2f1336339f
Changes: 
- added missing type-hints
- added missing documentation
- changed double-quotes to single
- Setters do ALWAYS return void
 2022-10-26 01:29:01 +02:00
Roland Häder
5306bb3e31
Changes: 
- added more missing type-hints (checked them in body of the method)
- reformatted code a little (code-style)
- moved '/.well-known/host-meta' to constant Probe::HOST_META
 2022-10-25 20:25:13 +02:00
Michael
ebd175872d Improved description 2022-10-25 08:45:41 +00:00
Michael
1a0b63659b Merge remote-tracking branch 'upstream/develop' into share-rework 2022-10-25 08:31:01 +00:00
Michael
f54a886a5e The "share" handling is improved 2022-10-25 06:37:23 +00:00
Philipp
8ad83e5d5c
Add missing DI 2022-10-21 19:16:25 +02:00
Philipp
b4ffb0bde0
UserSession class [4] - Refactor src/Model/ files 2022-10-20 22:14:50 +02:00
Philipp
940619325d
Add SessionUsers class including tests 2022-10-20 20:27:34 +02:00
Michael
ee1acba9eb old boot.php functions replaced in /src 2022-10-19 07:56:25 -04:00
Philipp
7ac86e49d1
Move Core\Session::get() to DI::session()->get() 2022-10-18 21:10:37 +02:00
Roland Häder
26e0469de7
Merge branch 'develop' into rewrite/gravity-constants 2022-10-18 16:34:40 +02:00
Michael
6f68679375 The EOL constant is removed 2022-10-18 12:29:50 +00:00
Michael
fdfa1f8630 The notice and info have been moved 2022-10-17 18:55:22 +00:00
Michael
018858934b The priority is now a class constant 2022-10-17 05:49:55 +00:00
Michael
f8f0dfa91a Detect linked posts and add them as quote 2022-10-16 21:37:05 +00:00
Michael
8e1af9277a Improve quite generation 2022-10-15 13:00:52 +00:00
Roland Häder
da66730e4f
Rewrite: 
- moved constants GRAVITY_* from boot.php to Friendica\Model\Item
- also rewrote some array initialization:

From:
````
<?php
$arr = [];
$arr['foo'] = "FOO";
````

To:
````
<?php
$arr['foo'] = "FOO";
````
- added a few type-hints
 2022-10-15 00:44:06 +02:00
Michael
3e868416c7 Check for post existence 2022-10-14 22:02:25 +00:00
Michael
88aceeb27f Merge remote-tracking branch 'upstream/2022.09-rc' into quote-uri-id 2022-10-14 19:11:15 +00:00
Hypolite Petovan
0480d9aebd Add missing post keys to retrieve pLink in Model\Event::prepareListForTemplate() 
- Address https://github.com/friendica/friendica/issues/11632#issuecomment-1275117722
 2022-10-11 22:18:52 -04:00
Michael
0e82f64d71 Only attach images 2022-10-11 21:39:28 +00:00
Hypolite Petovan
9e74a1bd06 Contact array can be empty in Model\Contact::getAvatarPath 
- Address https://github.com/friendica/friendica/issues/11630#issuecomment-1274195844
 2022-10-11 08:26:00 -04:00
Michael
aeb4645ba6 New field "quote-uri-id" for quoted posts 2022-10-10 22:39:30 +00:00
Hypolite Petovan
a10f55bb85
Merge pull request #11979 from annando/issue-11853 
Notices
 2022-10-09 17:45:33 -04:00
Michael
0d3aa681b4 The quote functionality is simplified 2022-10-09 21:16:36 +00:00
Michael
4a37c978c2 Issue 11969: Simplified share 2022-10-08 09:36:35 +00:00
Michael
21bd2a8396 More whitespace 2022-10-07 07:57:20 +00:00
Michael
ef934db614 Moved the share interpretation 2022-10-07 07:41:03 +00:00
Michael
d7a9745ffd Simplified share element 2022-10-07 05:51:36 +00:00
Michael
48182a95fb Improve quote share ("message_id" added) 2022-10-06 21:50:20 +00:00
Michael
c65f78e579 Only display reshared thread starting posts 2022-09-28 09:48:48 +00:00
Michael
2def5e9f02 Issue 11876: Fix local message distribution 2022-09-27 15:58:16 +00:00
Hypolite Petovan
02e9a867ae
Merge pull request #11926 from annando/sql-queries 
(Hopefully) SQL improvements
 2022-09-24 15:01:34 -04:00
Michael Vogel
b00947025a
Merge pull request #11922 from MrPetovan/bug/notices 
Ward against missing keys in Model\APContact::isRelay
 2022-09-24 20:02:21 +02:00
Michael
3911c9450b (Hopefully) SQL improvements 2022-09-24 17:56:07 +00:00
Hypolite Petovan
6ca725e5b6 Check for network key existence before calling Probe::isProbable in Model\Contact 
- Address https://github.com/friendica/friendica/issues/11630#issuecomment-1253225607
 2022-09-24 10:18:41 -04:00
Hypolite Petovan
ded5a0ac6a Ward against missing keys in Model\APContact::isRelay 
- Address https://github.com/friendica/friendica/issues/11632#issuecomment-1231904280
 2022-09-24 09:56:12 -04:00
Michael
36668dfdb1 Merge remote-tracking branch 'upstream/2022.09-rc' into duplicates 2022-09-21 03:46:25 +00:00
Michael Vogel
199d8bbf35 Merge remote-tracking branch 'upstream/2022.09-rc' into relay-languages 2022-09-20 06:05:15 +02:00
Michael Vogel
6ba2c4bb01 Added documentation 2022-09-19 12:49:37 +02:00
Michael Vogel
3650feb256 "Count" parameter added 2022-09-19 12:46:28 +02:00
Michael Vogel
f08b08e0d8 Allow to reject specific languages on receiving posts via the relay 2022-09-19 12:36:12 +02:00
Michael Vogel
e5c24f33f0 The fcontact table is now updated in the background to improve performance 2022-09-18 15:40:44 +02:00
Michael
79b64cc44f Detect and remove contact duplicates 2022-09-16 05:00:06 +00:00
Hypolite Petovan
7da43fe28a
Merge pull request #11892 from annando/pagecache 
Pagecache for frequently fetched pages
 2022-09-07 22:25:19 -04:00
Michael
a0b99f61ea Use the cached activity function 2022-09-07 19:46:24 +00:00
Michael
da658cbf1d Delete the cache entry when the post is changed or deleted 2022-09-06 21:51:47 +00:00
Michael
ec8377a8c7 Issue 11893: Postupdate to fix wrong parents 2022-09-06 20:00:06 +00:00
Michael
6eb9dff807 Pagecache for frequently fetched pages 2022-09-06 06:04:41 +00:00
Hypolite Petovan
8f283985f0
Merge pull request #11884 from annando/language 
Improved language detection
 2022-09-04 15:52:29 -04:00
Michael
e2cb705468 Merge remote-tracking branch 'upstream/2022.09-rc' into language 2022-09-04 17:04:13 +00:00
Michael
437c230a6f Merge remote-tracking branch 'upstream/2022.09-rc' into database 2022-09-04 17:03:14 +00:00
Michael
144547009b All URL fields are now binary and longer 2022-09-04 07:54:01 +00:00
Michael
4304aa9eec Improved language detection 2022-09-04 07:32:46 +00:00
Michael
9f2d3e6f88 Use AP data when possible 2022-09-04 07:15:04 +00:00
Michael
cc43b567cb Some changes after code review 2022-08-31 19:03:37 +00:00
Michael
f7b85092b0 Some more changed log levels 2022-08-31 05:01:22 +00:00
Michael
757a5c2de9 Loglevels are adjusted 2022-08-30 19:45:30 +00:00
Michael
3a840aa22d Some more warnings and erors are fixed 2022-08-28 19:27:21 +00:00
Michael
3052ae71b7 Avoid warnings 2022-08-28 09:12:36 +00:00
Michael
2173fb38e0 Issue 11853/11867: Fix reshare of public posts 2022-08-27 21:22:49 +00:00
Michael
a0eaff8fd5 Fix issue 11865 2022-08-27 11:43:46 +00:00
Michael
ceb88c10e6 Warnings/Errors reduced - improved relay processing 2022-08-27 08:08:58 +00:00
Michael
dd8279afc2 Some more protection against database errors 2022-08-25 18:47:07 +00:00
Michael
15d975f143 Avoid some database errors 2022-08-25 04:57:41 +00:00
Michael
2a0ca80630 The contact-id of a wall posting is always the owner contact 2022-08-22 07:54:48 +00:00
Michael
51331ced9b Improved function to fetch the contact id 2022-08-18 10:13:46 +00:00
Michael
a4f1df68e4 Improved contact-id detection 2022-08-18 07:48:39 +00:00
Michael
531085890a Fetch the parent only - thread parents only on reshares 2022-08-17 19:39:20 +00:00
Michael
6070221364 Improved checks in "storeForUserByUriId" to reduce recursion depth 2022-08-17 05:28:24 +00:00
Michael
4d617c9c48 This cache key doesn't exist anymore 2022-08-15 18:46:10 +00:00
Michael
5b3145d7ce Several performance improvements 2022-08-15 13:23:01 +00:00
Michael
c6de91a8ec Don't delete the post when there is some undeleted post-user 2022-08-13 12:24:25 +00:00
Michael
5c5ae00370 Improved performance when updating contacts 2022-08-13 09:01:48 +00:00
Philipp
a145712f04
Merge pull request #11837 from MrPetovan/task/remove-poke 
Remove poke feature
 2022-08-11 18:17:11 +02:00
Hypolite Petovan
809beeee9d
Merge pull request #11838 from annando/asynchronous-conversation 
Conversation entries will now be stored asynchronous if possible
 2022-08-10 10:42:19 -04:00
Michael
d9aee0b3ea Conversation entries will now be stored asynchronous if possible 2022-08-10 09:28:18 +00:00
Hypolite Petovan
4a885a13a6 Remove poke feature 2022-08-09 14:55:55 -04:00
Hypolite Petovan
f917286d6e Use L10n->tt instead of t() for plural strings for polls in Model\Item 2022-08-08 01:52:16 -04:00
Michael
d60d2caef6 Improved queue processing 2022-08-07 19:24:50 +00:00
Michael
06f7244280 New option to disable the fetching of parents 2022-08-04 19:32:36 +00:00
Hypolite Petovan
196a1de7f2
Merge pull request #11812 from annando/ap-performance 
Hopefully fixes loops during message processing
 2022-08-03 03:00:50 -04:00
Michael
f2eec66240 Hopefully fixes loops during message processing 2022-08-03 03:38:03 +00:00
Hypolite Petovan
49394aedeb Add password length limit if using the Blowfish hashing algorithm 
- Add new page to reset a password that would be too long
- Add support for pattern parameter in field_password
 2022-08-01 12:12:18 -04:00
Michael
3945de5e3b No blubb allowed 2022-08-01 00:58:56 +00:00
Michael
0347f4fc66 Remove test code 2022-07-31 16:01:56 +00:00
Michael
b6da15557b The post-reason / protocol is now filled in most cases 2022-07-31 15:54:35 +00:00
Hypolite Petovan
2e75d442a5
Merge pull request #11793 from Quix0r/reformatted-arrays 
Reformatted some arrays for better readability
 2022-07-29 17:54:53 -04:00
Michael
f9bf2424b1 Merge remote-tracking branch 'upstream/develop' into post-reason 2022-07-29 21:29:15 +00:00
Michael
699152e15e Add more post reasons 2022-07-29 21:28:22 +00:00
Michael
0971bcf165 Make the tests happy 2022-07-29 16:05:04 +00:00
Roland Häder
1210e235fb
Extracted as variable to have 2 more array fields moved to array initialization. 2022-07-29 17:20:09 +02:00
Roland Häder
676ca36c52
Changes: 
- reformatted arrays
 2022-07-29 17:20:07 +02:00
Michael
2c32429d8d Fix test 2022-07-29 14:56:40 +00:00
Michael
81aaacc67d Improvements for the "post-reason" 2022-07-29 14:17:53 +00:00
Roland Häder
f8ed028013
Changed back to $cdata. 2022-07-29 12:41:08 +02:00
Hypolite Petovan
a20d05ba39
Merge pull request #11792 from Quix0r/fixes/get-request-value 
Wrong variable name fixed (maybe copy-paste mistake) + used method instead of direct array access
 2022-07-28 21:17:34 -04:00
Roland Häder
eaed3945d1
Changed: 
- used `$this->getRequestValue($request, 'foo', <bar>)` instead of `$request['foo'] ?? <bar>`
- fixed wrong variable naming
- changed double-quotes to single
- see https://github.com/friendica/friendica/issues/11631#issuecomment-1196410497
 2022-07-29 00:38:46 +02:00
Roland Häder
37bda3e5fb
Changes: 
- fixed wrong type-hint uid => int
- added returned type-hint
- added some documentation
- formatted arrays a bit
 2022-07-29 00:08:38 +02:00
Michael
ff9dc1e291 Merge remote-tracking branch 'upstream/develop' into untrusted 2022-07-27 17:56:56 +00:00
Michael
86105635ca Improved message handling / new activity relay handling 2022-07-27 17:39:00 +00:00
Michael Vogel
f9777ce0dc
Merge pull request #11770 from MrPetovan/bug/notices 
Handle rare case where contact doesn't exist in Model\Group::getIdsByContactId
 2022-07-25 21:01:12 +02:00
Hypolite Petovan
488f4dcaa4 Handle rare case where contact doesn't exist in Model\Group::getIdsByContactId 
- Address https://github.com/friendica/friendica/issues/11632#issuecomment-1193953621
 2022-07-25 12:07:42 -04:00
Roland Häder
d1b21eaf42
Changes: 
- use local variables
 2022-07-25 17:53:54 +02:00
Roland Häder
1ac1db6173
Changed: 
- rewrote to almost one block of array initialization
 2022-07-25 16:49:01 +02:00
Hypolite Petovan
a5d679ea95
Merge pull request #11759 from annando/enqueue-posts 
Fetch missing posts via a queue
 2022-07-24 15:38:44 -04:00
Michael
6abb4d40d6 Handle changed parents 2022-07-24 13:09:35 +00:00
Roland Häder
86ef7c66d3
Changes: 
- added some missing type-hints, thanks to @MrPetovan
 2022-07-23 23:09:35 +02:00
Roland Häder
ba1c1049d6
Changes: 
- added some type-hints
- added some documentation
- used self::exists() instead of DBA::exists('user', ['uid' => $uid])
 2022-07-23 21:58:00 +02:00
Roland Häder
a2a7d04fa1
Changed double-quotes to single 2022-07-23 21:58:00 +02:00
Hypolite Petovan
edc49ec9b4 Add expected "users" property to NodeInfo usage property for all versions 2022-07-23 13:21:44 -04:00
Michael
abf39ff9cf Merge remote-tracking branch 'upstream/develop' into enqueue-posts 2022-07-23 12:55:34 +00:00
Michael
8c602071c2 Bookwyrm posts now work 2022-07-23 12:50:15 +00:00
Michael
7eb410bed7 Conversation/context is now stored 2022-07-23 06:52:43 +00:00
Michael
1d13574225 Fetching of missing posts is reworked 2022-07-21 05:16:14 +00:00
Michael
7dcd02938d Remove entries from queue / relay detection 2022-07-20 05:37:40 +00:00
Roland Häder
cf8698afe6
This is the correct way: 
<?php
if (!isset($foo['account_removed) || $foo['account_removed'])
?>
 2022-07-19 18:08:18 +02:00
Roland Häder
cb2a052a70
Fixed E_NOTICE, for some strange reason 'account_removed' isn't around? 2022-07-18 23:49:58 +02:00
Michael
af8e059990 Renamed platform definition file 2022-07-18 03:48:19 +00:00
Michael
46fdd9893c Merge remote-tracking branch 'upstream/develop' into server-detection 2022-07-17 15:42:09 +00:00
Michael
2ddf37f32d Emergency fixes to fix a bunch of fatal errors 2022-07-17 11:47:12 +00:00
Michael
d52f52f45f Somed added documentation 2022-07-17 05:42:44 +00:00
Michael
0a19759e4f Fix wrong variable type 2022-07-16 13:44:35 +00:00
Michael
8b7cb5d9ef Merge remote-tracking branch 'upstream/develop' into server-detection 2022-07-16 12:44:21 +00:00
Michael
896fd3fc91 Use the redirect value 2022-07-14 05:39:25 +00:00
Philipp
d74e57ef2c
include suggested changes 2022-07-13 00:23:12 +02:00
Philipp
a910fd8864
Split DBStructure & View to avoid DB-calls and dependencies for basic operations 
- new "Definition" classes vor DB and Views
- new "Writer" classes to create SQL definitions for DB and Views
- DBStructure & View are responsible to execute DB-querys
 2022-07-12 23:40:31 +02:00
Michael
dad05f1c76 Only fetch the first word for the platform 2022-07-10 13:52:38 +00:00
Michael
85c7bacb00 Improved server detection 2022-07-10 13:01:47 +00:00
Hypolite Petovan
eb8237dd89 Remove unused uid parameter in Item::newURI 2022-07-09 07:39:51 -04:00
Michael
cc75eb5d18 Improved server detection 2022-07-05 05:04:05 +00:00
Roland Häder
a392a22eee
Changes: 
- added some type-hints
- fixed some documentation (void is lately returned, not null)
- added some documentation
 2022-06-27 15:16:17 +02:00
Roland Häder
98bc5216ef
A bit more documentation 2022-06-27 15:16:17 +02:00
Roland Häder
8e19998191
Fixes: 
- more "bool expected but null returned" errors
 2022-06-27 13:49:53 +02:00
Roland Häder
7c049abfda
Fixed: 
- Contact/User::isBlocked() needs to return boolean, but sometimes (strangely)
  a NULL can come from database, so let's cast it

This tries to fix:
TypeError: "Return value of Friendica\Model\Contact\User::isBlocked() must be of the type bool, null returned"
 2022-06-27 11:39:18 +02:00
Philipp
e594656a48
Merge pull request #11684 from MrPetovan/bug/11651-ap-fetch-queue 
Create ActivityPub\FetchQueue and ActivityPub\FetchQueueItem classes
 2022-06-26 13:36:19 +02:00
Philipp
0223c030a9
Improve 2 factor usage 2022-06-25 23:04:00 +02:00
Hypolite Petovan
da32fa8fa6 Create ActivityPub\FetchQueue and ActivityPub\FetchQueueItem classes 
- These classes are used to flatten the recursive missing activity fetch that can hit PHP's maximum function nesting limit
- The original caller is responsible for processing the remaining queue once the original activity has been fetched
 2022-06-25 12:40:54 -04:00
Hypolite Petovan
3c70d592f6
Merge pull request #11689 from Quix0r/rewrites/double-quotes-single 
Changed more double-quotes to single
 2022-06-25 12:02:01 -04:00
Hypolite Petovan
a7d49877a8 Centralize share tag attribute extraction code in Content\Text\BBCode 2022-06-25 11:46:52 -04:00
Roland Häder
88870d18be
Changes: 
- added some type-hints
- added documentation
 2022-06-25 16:48:36 +02:00
Roland Häder
39675fe683
Space for the rescue. ;-) 2022-06-25 16:48:35 +02:00
Roland Häder
f12cc9648e
Changes: 
- added some type-hints
- changed some double-quotes to single
 2022-06-25 16:48:35 +02:00
Hypolite Petovan
aa133b5437 Add explicit gserver.site_name string truncate in Model\GServer 
- Avoids "Data too long for column 'site_name'" database errors
 2022-06-25 06:25:48 -04:00
Hypolite Petovan
636b84b41c Update return value type-hint of GServer::getProtocol 
- Address https://github.com/friendica/friendica/issues/11630#issuecomment-1164880874
 2022-06-25 05:06:22 -04:00
Hypolite Petovan
c5b46fe748
Merge pull request #11681 from Quix0r/fixes/item-guidfromuri-allow-null 
Allowing Item::getFromUri()'s 2nd parameter a null value
 2022-06-24 10:15:26 -04:00
Roland Häder
82bb36e13d
Changes: 
- Made Item::guidFromUri()'s $host parameter optional (allowing null)
- added some type-hints
- added documentation
- this may fix reported issue in #11630
 2022-06-24 03:17:57 +02:00
Philipp
d441b90bda
Respect Forwarded-For headers 2022-06-23 22:42:35 +02:00
Roland Häder
202857ba7d
No need to log $tid here 2022-06-23 17:30:17 +02:00
Roland Häder
fd8f4269ff
Reformatted code 2022-06-23 17:30:17 +02:00
Roland Häder
182c3db9b8
Changes: 
- added type-hints
- added missing documentation
 2022-06-23 17:30:15 +02:00
Roland Häder
b8353a6eb7
Changes: 
- reformatted some array
- added missing documentation
- added type-hints
- changed double-quotes to single
 2022-06-23 17:30:14 +02:00
Roland Häder
c6c936a80f
Added more type-hints 2022-06-23 17:30:14 +02:00
Roland Häder
2f3705f471
Continued: 
- renamed varibales to $camelCase
- added type-hints
- updated documentation
 2022-06-23 17:30:11 +02:00
Roland Häder
7eefb9aed8
Changed: 
- empty() is maybe superflous here, still I would prefer a code style that is
  written explicitly and not rely on "magic casting"
 2022-06-22 18:57:01 +02:00
Roland Häder
101cd2dd10
Changes: 
- added some documentation
- fixed some documentation
- changed more double-quotes to singl
 2022-06-22 16:14:14 +02:00
Roland Häder
ee8d0ad619
Changes: 
- added more type-hints
- added some documentation
 2022-06-22 14:36:47 +02:00
Tobias Diekershoff
4650ff53d9
Merge pull request #11662 from MrPetovan/bug/11661-splitattachment-null 
Ensure parameter 4 of Post\Media::splitAttachment is a boolean value
 2022-06-21 06:48:52 +02:00
Roland Häder
752953e472
Changes: 
- as @MrPetovan pointed out, $actor can be NULL earlier and used later as NULL
- added some missing type-hints
- added missing documentation
- the added @TODO points out to avoid true|false|null for a boolean
 2022-06-20 21:00:19 +02:00
Hypolite Petovan
88eacbf66e Ensure parameter 4 of Post\Media::splitAttachment is a boolean value 2022-06-20 14:34:02 -04:00
Roland Häder
4fb03cf163
Changes: 
- fixed a null value handled over to Friendica\Model\APContact::getByURL()
- added missing type-hints
 2022-06-20 19:05:02 +02:00
Roland Häder
e96a548286
Changes: 
- dumped default value for $input
- added unknown 'platform' which prevents an "Undefined index: platform in
  /var/www/.../src/Model/GServer.php on line 940" error
 2022-06-20 18:56:22 +02:00
Roland Häder
c0d7f8944d
Some calls saved 2022-06-19 11:26:10 +02:00
Roland Häder
2c5685c89c
Changes: 
- changed to proper "use Foo\Bar;"
- added doctag
- added return type as this is fixed
 2022-06-19 01:11:30 +02:00
Roland Häder
39f2d197ea
Changed to suggestings (back to original) + fixed typo in scalar type 2022-06-18 23:30:37 +02:00
Roland Häder
6f1d52cf71
Changed back to suggestions by @MrPetovan 2022-06-18 23:24:08 +02:00
Roland Häder
fa14a02a19
Changes: 
- added type-hints
- added documentation
- changed double-quotes to single
 2022-06-18 23:12:52 +02:00
Roland Häder
f3b57008b5
Proper type is string 2022-06-18 18:41:16 +02:00
Roland Häder
41f34c4261
Maybe fix for: 
"Argument 1 passed to Friendica\Model\ItemURI::getIdByURI() must be of the type string, null given, called in Processor.php line 1219"
 2022-06-18 18:30:50 +02:00
Roland Häder
9691bb06fb
Changes: 
- added more type-hints
- added missing documentation
 2022-06-18 18:21:29 +02:00
Roland Häder
94eb426151
Nodeinfo::getOrganization() doesn't need configuration object being inserted 
when you have DI::config() around.
 2022-06-18 17:56:33 +02:00
Roland Häder
c29c49797a
Added missing type-hints 2022-06-18 17:52:46 +02:00
Roland Häder
4e437190c5
Renamed variable, no need for "orig_" prefix 2022-06-18 17:50:11 +02:00
Roland Häder
a1a81cdc6b
Continued: 
- changed some double-quotes to single
- added missing type-hints
- added missing documentation
- fixed indenting a bit
 2022-06-18 17:46:34 +02:00
Roland Häder
8fc710f82a
Continued: 
- added more type-hints
- added some missing documentation
- Return the result from DBA::delete() to let other methods know about it
 2022-06-18 17:22:50 +02:00
Roland Häder
8ba3f13fae
Changes: 
- added more type-hints
- added missing documentation
 2022-06-18 17:09:46 +02:00
Roland Häder
7ec07178c8
Changes: 
- added missing type-hints
- added missing documentation
 2022-06-18 16:59:23 +02:00
Roland Häder
adb4aea6ad
Changes: 
- added some type-hints
- replaced most double-quotes (only Diaspora.php, later more) with single
- added some documentation
- normalized indenting in Diaspora.php (I hope I got all?)
 2022-06-18 05:03:10 +02:00
Roland Häder
36d56a4041 Continued: 
- changed back to 'return false;' as other methods heavily rely on false instead
  of an empty array as pointed out by @heluecht@pirati.ca
- $fetched_contact should be initialized as an empty array, let's not make this
  code more crazier than it already is (see APContact::getByURL())
 2022-06-17 17:18:31 +02:00
Roland Häder
c467bff79f Some more type-hints added 2022-06-17 17:18:31 +02:00
Roland Häder
4f3321cc9f Nore fixes 2022-06-17 17:18:31 +02:00
Roland Häder
10bb7d5625 Possible fix for 
Uncaught Exception TypeError: "Return value of
Friendica\Model\APContact::getByURL() must be of the type array, bool returned"
 2022-06-17 17:18:31 +02:00
Roland Häder
fdd237a090 Fix for "Uncaught Exception TypeError: "Argument 1 passed to 
Friendica\Model\APContact::unarchiveInbox() must be of the type string, null
given" error message
 2022-06-17 17:18:31 +02:00
Roland Häder
605e7d55b3 Continued: 
- added more type-hints
- some methods in Diaspora returned void but integer was documented so I
  changed it to -1 to have a proper type-hint
 2022-06-17 17:18:31 +02:00
Roland Häder
227bab43a8 Ops, wrong type-hint here, must be string ($nickname can never be an integer). 2022-06-17 17:18:31 +02:00
Roland Häder
e484b6d6dc Continued: 
- added more type-hints
- added some documentation
- Contact::getAccountType() should only process string, not null
 2022-06-17 17:18:31 +02:00
Roland Häder
45b5f67bca Fix for non-existing record system.mobile_theme in config table 2022-06-17 17:18:31 +02:00
Roland Häder
33768ea1c6 Some fixes: 
- $gsid's default value cannot sadly be 0, it now must be null to allow some
  code work
- added some more type-hints
- documented a bit more
 2022-06-17 17:18:31 +02:00
Roland Häder
7560dccc08 Added again more type-hints 2022-06-17 17:18:31 +02:00
Roland Häder
40d7f29a11 Continued: 
- more type-hints
- fixed incompatible method declarations
 2022-06-17 17:18:31 +02:00
Roland Häder
c2e889cfae Added more type-hints 2022-06-17 17:18:31 +02:00
Roland Häder
0e1f734b03
Also make this null-coalscing 2022-06-16 17:35:01 +02:00
Roland Häder
f2b7326650
This will 2 things: 
1) The first change prevents "expensive" code in HTML::toBBcode() to be executed
   just for an empty string which makes no sense.
2) The above change was maybe flawed as $apcontact['about'] would have never
   been created, not even empty which could have side effects

Thanks to @annando to make me rethink this part of code.
 2022-06-16 16:54:50 +02:00
Roland Häder
b1e4c0931a
Fixes and type-hints: 
- added more checked type-hints as they prevent bad method invocations
- fixed TypeError for HTML::toBBCode() invocations with NULL as first (wrong)
  argument, thanks to @tobias@social.diekershoff.de pointing this out.
 2022-06-16 16:54:49 +02:00
Roland Häder
5fa954208a
Changes: 
- ops, wasn't actually fixing `return;` to proper `return '';`
- added more type-hints
- added TODO ($uid is unused)
 2022-06-15 22:28:33 +02:00