Commit graph

7232 commits

Author SHA1 Message Date
Hypolite Petovan
e5ab4f1889 Re-enable pinned items in profile wall 2020-01-26 14:21:20 -05:00
nupplaPhil
0840938dff
Rename classes
- Repository/Model Notification => Notify
- Factory/Object Notification => Notification
2020-01-26 20:30:24 +01:00
nupplaPhil
b85511b00d
Improvements:
- Fix API-select
- Introduce OTYPE-constants
- Rename `IntroductionFactory` methods
2020-01-26 14:33:10 +01:00
nupplaPhil
74f3a2f90c
Fix API result, add PHPDoc and cleanup object construction
Fix missing getters
fix data array
fix missing "$" for template-variables
Remove lazy-loaded parent notification instance (for now..)
2020-01-25 21:15:01 +01:00
nupplaPhil
0850fb88dd
ReWork Notification Model/Module/Object/Repository/Factory
- Introduce Repository for interaction with "notify" table
- Introduce Factory for read-only notification objects (they're just loosely based on notification the table!)
- Introduce Objects for type-safe usage at the presentation layer
- Reworked Model, which is now fully based on the notify table, including generated fields (cache, ..)
2020-01-25 19:58:22 +01:00
nupplaPhil
0f932ae723
Notify => Notification
Notifs => Notifications
2020-01-24 18:32:38 +01:00
Hypolite Petovan
6d7f0a6fd8 Remove duplicate profile_uid key in App->profile array 2020-01-20 07:32:46 -05:00
nupplaPhil
ed9392469e
Remove unneeded Config namespace usages 2020-01-19 22:50:44 +01:00
nupplaPhil
6c36fd9e01
Move Config::get() to DI::config()->get() 2020-01-19 21:21:13 +01:00
nupplaPhil
d6efc90194
cleanup namespace usages for L10n 2020-01-19 16:31:33 +01:00
nupplaPhil
d3255afa66
Move L10n::withLang() calls to DI::l10n()->withLang() calls 2020-01-19 16:31:18 +01:00
nupplaPhil
a9a36fb302
Move L10n::tt() calls to DI::l10n()->tt() calls 2020-01-19 16:31:17 +01:00
nupplaPhil
5dfee31108
Move L10n::t() calls to DI::l10n()->t() calls 2020-01-19 16:31:16 +01:00
Michael
0a4119adaf @brief is removed completely 2020-01-19 06:05:23 +00:00
nupplaPhil
800694e9b3
Remove unused use statements & remove PConfig class 2020-01-18 17:02:59 +01:00
nupplaPhil
9e9429b56d
Move PConfig::get() to DI::pConfig()->get() 2020-01-18 16:50:57 +01:00
Michael
b83f328983 Remove "f" parameter / network page parameter cleanup 2020-01-13 20:10:13 +00:00
Michael
ad11579eaa API: Use NOTIF_DIRECT_THREAD_COMMENT for the API mentions as well 2020-01-09 17:58:22 +00:00
Michael
469eefdc5b Notifications: Now declare direct thread answers as replies 2020-01-09 17:53:17 +00:00
Michael
3bf7664ee3 changed priority of messages 2020-01-08 22:36:31 +00:00
Michael
d9ea0fea87 Use "replied" 2020-01-08 21:59:12 +00:00
Michael
cabaea38ac Improved notification messages 2020-01-08 21:48:59 +00:00
Michael
4d5e15709c The item notifications now are based upon the "user-item" field 2020-01-06 00:59:18 +00:00
Michael
6670a2409f Fix condition creation 2020-01-05 19:48:01 +00:00
Michael
f134903fcf API: We now use the "notification-type" field for mentions 2020-01-05 19:32:39 +00:00
nupplaPhil
f0eea6f875
Remove get_app() in favor of DI::app() 2020-01-04 23:42:01 +01:00
Hypolite Petovan
ebaf726744 Rework Feed::import parameters
- Remove unused $hub
- Replace $simulate with an implicit condition
2020-01-03 09:26:28 -05:00
nupplaPhil
a4a7f19df1
Move redundant System::removedBaseUrl() to DI::baseUrl()->remove() calls 2019-12-30 23:03:56 +01:00
nupplaPhil
3f34229752
Move redundant System::baseUrl() to DI::baseUrl() calls 2019-12-30 23:00:08 +01:00
nupplaPhil
6d7362da41
Replace deprecated $a->page with DI::page() 2019-12-30 20:02:09 +01:00
nupplaPhil
4835f1185f
Remove deprecated App::module - replace with DI::module()->getName() 2019-12-29 20:17:52 +01:00
nupplaPhil
33674808dc
Remove deprecated App::cmd - replace with DI::args()->getCommand() 2019-12-29 20:17:51 +01:00
nupplaPhil
e6f61c2cc7
Remove deprecated App::query_string - replace with DI::args()->getQueryString() 2019-12-29 20:17:50 +01:00
nupplaPhil
50be94aa5e
Remove deprecated App::getHostName() - process methods to DI::baseUrl()->getHostName() 2019-12-29 20:17:47 +01:00
nupplaPhil
8e6973b774
Refactor deprecated App::internalRedirect() to DI::baseUrl()->redirect() 2019-12-29 20:17:43 +01:00
nupplaPhil
181529f3df
Refactor dynamic App::getProfiler() to static DI::profiler() 2019-12-29 20:17:42 +01:00
nupplaPhil
e2b2778e0a
Refactor dynamic App::getLogger() to static DI::logger() 2019-12-29 20:17:41 +01:00
nupplaPhil
388b963714
Replace BaseObject class with DI::* calls 2019-12-29 20:17:38 +01:00
nupplaPhil
1de3f186d7
Introduce new DI container
- Adding Friendica\DI class for getting dynamic classes
- Replacing BaseObject::getApp() with this class
2019-12-29 20:16:55 +01:00
nupplaPhil
7a2f4dc54e
Make L10n immutable
- Remove Push/Pop
- Add "withLang($lang)" method
2019-12-28 23:12:01 +01:00
Michael
c037e9143c Additionally display the protocol together with the network 2019-12-27 17:24:29 +00:00
Tobias Diekershoff
00756737b5 Merge branch 'master' 2019.12 into develop 2019-12-23 20:03:47 +01:00
Michael
30dfbb95d9 Remove legacy function 2019-12-20 06:40:41 +00:00
Michael
295ee82a61 Changed "??" to "?:" 2019-12-19 12:39:30 +00:00
Michael
6dbaf34290 Issue 7685: Just forward on remoteauth for non legacy-DFRN and other contacts 2019-12-19 11:02:50 +00:00
Michael
1c7bc56cb3 API: Missing endpoint for reshares had been added 2019-12-19 07:19:03 +00:00
Michael
3a6a78ca46 Issue 7664: Don't notify every time a contact posted something 2019-12-18 06:36:43 +00:00
Michael
533f07e874 Issue 6867: Only display direct mentions in the corresponding API endpoint 2019-12-15 13:14:55 +00:00
Michael Vogel
b2ae39db1a
Merge pull request #7943 from MrPetovan/bug/7920-api-fix-followers-friends-ids
Add relationship filter to api_friends_ids and api_followers_ids
2019-12-13 21:34:09 +01:00
Hypolite Petovan
c2233e3416
Merge pull request #7947 from annando/api-attachments
API: Improved handling of quoted posts and attachments
2019-12-13 15:15:34 -05:00
Hypolite Petovan
c9c30e4a23 Add relationship filter to api_friends_ids and api_followers_ids 2019-12-13 11:43:45 -05:00
Hypolite Petovan
81b9d25906 Add relationship filter to api_ff_ids() 2019-12-13 11:43:20 -05:00
Michael
b42262f206 API: Improved handling of quoted posts and attachments 2019-12-13 10:12:40 +00:00
Hypolite Petovan
5a15e6bc59 Support post URL search term in api_search() 2019-12-12 20:59:19 -05:00
Hypolite Petovan
0069bb022d Support user profile URL search term in api_users_search() 2019-12-12 17:04:47 -05:00
nupplaPhil
54392fab81
Move Cookie to own class (with tests)
Move Authentication to App namespace
2019-12-08 22:45:34 +01:00
nupplaPhil
96555a7385
Refactor "Authentication" class with four main methods:
- withSession() - for auto authentication with Session/Cookie variables
- withOpenId() - for authentication with an OpenID account
- withPassword() - for authentication with Password
- setForUser() - for setting the user auth context of the current session

Refactor "Session" class - contains now "native" Session Management methods
2019-12-05 23:02:51 +01:00
Michael
043df55bc5 Make tests happy 2019-12-05 06:46:00 +00:00
Michael
eeb8bee1b7 Use the new function to fetch shared information 2019-12-05 06:16:27 +00:00
Michael
abf841ff79 Handle resharing of items with title via the API 2019-12-05 05:24:29 +00:00
Hypolite Petovan
4403aeeda5
Merge pull request #7901 from annando/disable-smart-threading
Changed the option to enable the smart threading with the option to disable this
2019-12-04 15:25:53 -05:00
Michael Vogel
9cf1aea8c9 Changed the option to enable the smart threading with the option to disable this 2019-12-04 21:21:20 +01:00
Michael
164e6b350d API: Improve attachment removal functionality for the status text 2019-12-02 21:19:47 +00:00
Michael
d3e12c58e2 Fix some notices/warnings again 2019-11-21 22:40:54 +00:00
Michael Vogel
bd6774bd9b Fix fatal errors, caused by an empty "verb" 2019-11-18 07:39:56 +01:00
Hypolite Petovan
35ece9924d
Merge pull request #7829 from annando/picture-links
Fix image links with descriptions in API and AP transmission
2019-11-12 07:14:27 -05:00
Michael
1b5fa55bdc Fix image links with descriptions in API and AP transmission 2019-11-11 22:37:50 +00:00
Hypolite Petovan
f2c31ef1c0
Merge pull request #7828 from nupplaphil/task/move_enotify
Remove unnecessary code in "include/enotify"
2019-11-09 16:48:26 -05:00
Philipp Holzer
dbbe3ec031
Remove deprecated method to find duplicates (issue from 2013) 2019-11-09 22:00:04 +01:00
Philipp Holzer
f9e3ff4b55
Remove unnecessary hash function.
- Was introduced for getting the last inserted ID before "lastInstertID()" was possible
- See b821399f00 (diff-a8e86a3c07531e66a3b0b4c8b4b07879R148)
2019-11-09 21:50:52 +01:00
Michael
fc94cad5f2 Pinned posts now work for visitors in the intended way 2019-11-08 06:52:44 +00:00
Michael
806e6a230e Added description, removed sorting 2019-11-07 07:41:54 +00:00
Michael
91ad7936f3 Only sort the profile after pinned 2019-11-07 07:39:50 +00:00
Michael
463c9131b6 Pinned items are always at the top 2019-11-07 07:09:46 +00:00
Hypolite Petovan
26b5de9a76 Rename Photo::newResource() result variable from $hash to $resource_id 2019-11-02 07:48:45 -04:00
Hypolite Petovan
03bf1dcbd3 Move Object\Image static methods to Util\Images
- Optimize imports in modified files
2019-11-02 07:48:45 -04:00
Philipp Holzer
a72e65a760
Adapt class structure
- Introduce constants
- Add constructor parameters
- Add typehints
- Renamed fields more meaningful
- Renamed method names to match identifier
- Adjust PHP doc
- Add GetClass call at used places
2019-10-26 04:03:27 +02:00
Philipp Holzer
1f368d469f
Move Friendica\Core\NotificationsManager to Friendica\Model\Notify 2019-10-26 02:01:46 +02:00
Philipp Holzer
3897c74deb
Add docs 2019-10-25 00:10:20 +02:00
Philipp Holzer
07cea24430
Move Activity/Namespaces defines to constants 2019-10-24 21:40:12 +02:00
Philipp Holzer
edf006905b
Move (last) get_cats_and_terms to Content\Item::determineCategoriesTerms()
- Added incomplete test
2019-10-23 02:48:46 +02:00
Philipp Holzer
ad67fd3aa8
Move is_a_date_arg to DateTimeFormat::isYearMonth
- Improved functionality
- Added tests
2019-10-23 02:39:28 +02:00
Philipp Holzer
52c42491c4
Move activity_match() to Protocol\Activity::match()
- With tests
2019-10-23 02:05:11 +02:00
Philipp Holzer
9e94e8b48c
Remove function prepare_text and use BBCode::convert() instead 2019-10-23 00:58:13 +02:00
Philipp Holzer
2c31916757
Remove unused function qp() 2019-10-23 00:55:14 +02:00
Philipp Holzer
5843a80b6c
Move perms2str to ACLFormatter::aclToString()
- including new tests
2019-10-23 00:54:34 +02:00
Philipp Holzer
f65f7f11c3
Move expand_acl to ACLFormatter::expand()
- including tests
2019-10-23 00:40:14 +02:00
Philipp Holzer
7a9c5d10ee
Remove unused function attribute_contains 2019-10-23 00:22:39 +02:00
Philipp Holzer
a3e350313d
Move redir_private_images to Item::addRedirLinkToImageLinks() 2019-10-23 00:20:44 +02:00
Philipp Holzer
4704bf6394
Remove unused function return_bytes 2019-10-23 00:15:17 +02:00
Philipp Holzer
2870f42ca2
Move bb_translate_video
- To new Class BBCode\Video
- Adding tests
- Make BaseObject::getClass() public
2019-10-23 00:14:47 +02:00
Philipp Holzer
7f49c73730
Move undo_post_tagging to mod/editpost because of the only occurrence 2019-10-22 23:57:44 +02:00
Hypolite Petovan
8b836189d4 Replace deprecated defaults() calls with ?? and ?: in include/ and view/ 2019-10-16 08:51:03 -04:00
Hypolite Petovan
f498068b0f Replace deprecated defaults() calls in include/api and boot 2019-10-12 22:01:34 -04:00
Hypolite Petovan
cb4950a3be Replace duplicated authentication code in FKOAuth1 with Session::setAuthenticatedForUser 2019-10-06 11:17:30 -04:00
Hypolite Petovan
2333526b8a
Merge pull request #7678 from annando/remote-rework
Reworked the remote authentication
2019-09-30 09:18:43 -04:00
Philipp Holzer
d5dd12b8f8
Add Drone CI
- Add drone test environment
- Add drone config
- apt phpunit
- Fix api.php
- Fix item.php
- Fix DBStructure
- Check if caching is possible during tests
2019-09-30 14:03:12 +02:00
Michael
83b00ef308 New function "isAuthenticated" 2019-09-28 18:09:11 +00:00
Michael
6e9026e033 Renamed function, beginning to replace the "remote_user" function 2019-09-28 09:36:41 +00:00
Michael
ec66553032 Reworked "remote" cookie handling 2019-09-25 22:24:17 +00:00
Michael
461c3169b1 Issue 6521: Don't send notifications for deleted items 2019-09-10 05:44:09 +00:00
Michael
8fc8e26e23 Replace not working "redir" link with a working one 2019-09-09 21:37:26 +00:00
Michael
a7d23a1196 API Support "friendica_html" 2019-09-03 21:11:33 +00:00
Michael
9cbf320c86 Issue 7563: Use icons instead of names on posts 2019-08-28 06:38:35 +00:00
Michael
ae3c9eceed Support for posting multiple pictures via API 2019-08-06 05:34:04 +00:00
Hypolite Petovan
c3e3e83a52 Improve BBCode:toPlaintext
- Fix issue where matching literal square brackets were removed with their content
- Fix issue where content without line feeds between BBCode tags would end up compacted in plain text
- Update extr calls to BBCode::toPlaintext in api
2019-08-04 10:22:23 -04:00
Michael
1b7f96dac8 Partly reverted, real problem fixed 2019-08-04 04:29:52 +00:00
Michael
cb77b1af8c API: We now transmit the text description there as well 2019-08-04 03:45:23 +00:00
Michael
fc59aa6bc7 The "contact-uid" is now a reliable proof for contacts that we follow 2019-08-03 10:44:16 +00:00
Hypolite Petovan
6c4fea5e6c
Merge pull request #7459 from annando/notice
Fix a notice when setting a picture description via API
2019-08-02 13:26:47 -04:00
Michael
5dc74513cc Fix a notice when setting a picture description via API 2019-08-02 16:43:36 +00:00
Michael Vogel
e8459cce34
Merge pull request #7381 from MrPetovan/task/7309-frio-compose
[frio] New Compose page
2019-08-01 08:15:02 +02:00
Michael
b4c673a620 We now use a central function for fetching the postdata 2019-07-30 22:26:01 +00:00
Michael
223cb8f037 We can now set image descriptions via API 2019-07-30 05:02:26 +00:00
Hypolite Petovan
0579252362 Add user meta-groups for followers and mutual contacts
- Both Group::expand and Item::enumeratePermissions now have a user id parameter to expand meta-groups
2019-07-29 20:31:46 -04:00
Hypolite Petovan
b684fffcb7 Replace last instance of Contact::select 2019-07-27 23:51:04 -04:00
Philipp Holzer
2f5928f43a
Refactoring Profile:: selectors 2019-07-28 00:19:38 +02:00
Philipp Holzer
46211de037
Fix DBA::fetch in API 2019-07-27 23:54:15 +02:00
Philipp Holzer
b7f1de1e64
Revert $term DB result check 2019-07-27 23:54:14 +02:00
Philipp Holzer
2a87464c97
Replace q() call with Profile::get() method 2019-07-27 23:54:12 +02:00
Michael
5120c27d10 Fix displaying of reshared items 2019-07-27 20:21:11 +00:00
hlad
c8ee4cc49f we work with utf8 string so we should use multibyte functions 2019-07-26 12:57:39 +02:00
Hypolite Petovan
cd257dc7e8 Enable app-specific password authentication for API login 2019-07-22 07:56:36 -04:00
Michael
23830dc45f Preparation for quoted reshares on AP 2019-07-20 21:32:19 +00:00
Philipp Holzer
8f0aa0ca5a
bugfix: add missing group by parameters 2019-07-14 22:12:14 +02:00
Michael
6bb418c5a7 Use "received" instead of "created" when displaying posts in creation order 2019-07-07 21:30:33 +00:00
Michael
6041f74df6 New constant for federated protocols 2019-07-01 18:00:55 +00:00
Michael Vogel
26accbe3ef
Merge pull request #7296 from MrPetovan/task/smilies-replace
Limit smilies replacement to BBCode::convert
2019-06-24 22:05:37 +02:00
Philipp Holzer
082634adbc
Moving from DBA to Database 2019-06-24 09:36:07 +02:00
Hypolite Petovan
b51fb8c994 Fix typo in docblock in include/text 2019-06-23 17:53:25 -04:00
Hypolite Petovan
9545ff614b Limit smilies replacement to BBCode::convert 2019-06-23 17:53:25 -04:00
Hypolite Petovan
b9ab613777 Merge branch 'master' into develop 2019-06-23 17:40:52 -04:00
Philipp Holzer
c76258c370
catching nulls for FileTag 2019-05-30 13:54:35 +02:00
Philipp
9245942a0c
Merge pull request #7199 from MrPetovan/bug/7171-filer-network
Allow commas in saved folder names
2019-05-29 07:03:44 +02:00
Hypolite Petovan
0fadc7730c Replace deprecated string-bases Model\FileTag calls with array-based ones 2019-05-27 17:40:08 -04:00
Hypolite Petovan
0e5b9514ef [API] Convert user description to plain text 2019-05-27 11:58:02 -04:00
Hypolite Petovan
661aca0f88 [API] Ensures user_show includes a status the user actually authored 2019-05-27 11:01:13 -04:00
Hypolite Petovan
01e71254d9 Replace defaults() calls on $_SESSION by Core\Session calls
- Replace direct calls to $_SESSION by Core\Session calls in Module\Login
2019-05-26 21:26:59 -04:00
Hypolite Petovan
d27d4d8927 Move posted date widget to Content\Widget 2019-05-25 19:08:15 -04:00
Hypolite Petovan
b5454547e9 Add query string to API "call not implemented" log message 2019-05-20 15:28:54 -04:00
Hypolite Petovan
6071fe81b4 Move Authentication::setAuthenticatedSessionForUser to Session::setAuthenticatedForUser 2019-05-13 01:51:59 -04:00
Hypolite Petovan
08ef4c23d7 Replace last references to removed HTTPException->httpcode property 2019-05-02 13:08:06 -04:00
Michael
d4b7e00837 Cleaning up transmitted fields (only needed for the root entry) 2019-04-24 21:28:56 +00:00
Michael
d778a29e04 Use all fields 2019-04-24 20:46:12 +00:00
Michael
9753ccab33 API: Reshares and Quotes should now work in any combination 2019-04-24 19:06:39 +00:00
Michael
3db9420ec7 Unify behaviour of friendica-author and friendica-owner 2019-04-24 05:22:31 +00:00
Michael
dd7406f285 API: Fix the displaying of reshared posts 2019-04-24 04:26:23 +00:00
Michael
d8ed5482aa Improved reshare check 2019-04-21 17:09:01 +00:00
Michael
0d49d0593d Don't show a reshare in the top of a message if we know the author 2019-04-19 07:47:00 +00:00
Michael
4a30490ac9 Fix: Only use reshare information for the top level post 2019-04-05 08:59:39 +00:00
Michael
d73b6015d8 Set the newest resharer as owner of a thread 2019-04-03 18:51:50 +00:00
Michael
a0fddca407 Display if an item is reshared 2019-04-02 05:38:42 +00:00
Michael
cbe574f6f6 Preparation to be able to store "announce" activities 2019-03-28 05:45:50 +00:00
Hypolite Petovan
ab7ec357cb Remove type parameter from api_get_last_status function prototype 2019-03-23 14:28:54 -04:00
Hypolite Petovan
e60e7a56ac Add author_user support to api_format_item 2019-03-23 14:28:54 -04:00
Hypolite Petovan
8d28f199a6 Test fix: Add expected author-network field to api_get_item() result 2019-03-23 14:28:54 -04:00
Hypolite Petovan
9693a7472e Extract API status formatting from api_get_status()
- Rename api_get_status() to api_get_item()
- Ad new api_format_item() function for single item formatting
2019-03-23 14:28:54 -04:00
Hypolite Petovan
aa6192258e Extract API status retrieval from api_status_show()
- Remove 'raw' type from api_status_show()
- Add new api_get_status() and api_get_last_status() functions
- Use api_get_last_status() in api_account_verify_credentials() and api_show_user()
2019-03-23 14:28:53 -04:00
Philipp Holzer
b2edb85588 Replace "q" calls 2019-03-22 22:55:48 -04:00
Michael
80a33763ea Take the author from the author 2019-03-17 18:46:22 +00:00
Michael
b8b5b7b753 Issue 6537: Transmit the real author of a post in a dedicated field in the API 2019-03-17 18:39:34 +00:00
Michael
3b7be251d5 Issue 6521: Don't show notifications on posts that the user deleted 2019-03-15 05:23:45 +00:00
Philipp Holzer
6872b118a4
Fixing preamble in enotify 2019-03-13 20:44:07 +01:00
Michael
1f0c662854 The contact menu now displays the contact and posts link as well 2019-03-11 20:42:32 +00:00
Hypolite Petovan
ad854d5d40 Define absolute paths for various includes
- Fix errors running local tests in IDE
2019-03-09 23:21:19 -05:00
Philipp Holzer
04b7280f38
Take void return into account 2019-03-02 14:23:46 +01:00
Philipp Holzer
6986e6902b
check if user_info is an array before counting 2019-03-02 11:55:51 +01:00
Philipp Holzer
4c11255624
Hide silenced authors from public timeline 2019-02-27 11:41:57 +01:00
Tobias Diekershoff
bd7aaacfb0 fixing links in photoMenu 2019-02-26 10:19:08 +01:00
Hypolite Petovan
34bc0b0c97 Add potential debug display of implicit mentions in frio
- Refactored conversation() by removing extraneous intermediary variables
2019-02-23 17:32:11 -05:00
Hypolite Petovan
8c1db51a76 Improve Logger calls
- Replace various deprecated Logger::log calls
- Reassign log level for verbose log calls
2019-02-23 17:32:11 -05:00
Hypolite Petovan
7320c5e8e8 Normalize Contact::magicLinkByContact method name 2019-02-23 17:32:10 -05:00
Roland Häder
9fa812b35d
Rewrites:
- converted single-line if() block to multi-line and with curly braces
- "imported" SPL classes to have unified code style
- always initialize your variables ... :-/
- added some empty lines/spaces for better readability

Signed-off-by: Roland Häder <roland@mxchange.org>
2019-02-19 01:56:41 +01:00
Hypolite Petovan
256e845c5d
Merge pull request #6641 from nupplaphil/config_followup
Config FollowUp
2019-02-17 17:56:31 -05:00
Philipp Holzer
5e5c39b0e1
Refactored DependencyFactory for Profiler 2019-02-17 21:12:12 +01:00
Philipp Holzer
5e6e1a8025
Introducing Profiler 2019-02-16 23:11:30 +01:00
Hypolite Petovan
642f9409a7 Switch tag of expanded like list to paragraph 2019-02-14 22:17:08 -05:00
Hypolite Petovan
cef6757c92 Replace REGISTER_* constants by Module\Register::* ones 2019-01-22 22:24:15 -05:00
Hypolite Petovan
592592525b Various fixes in include/api
- Fix unused condition in api_status_show()
- Fix wrong operator orders in api_get_entitites()
- Fix wrong variable usage in api_account_update_profile_image()
2019-01-21 11:40:14 -05:00
Hypolite Petovan
9b27d049dc Add missing break statements in include/conversation
- Remove bad variable initialization in format_like()
2019-01-21 11:38:54 -05:00
Hypolite Petovan
04b742a97d Fix variable type in include/text 2019-01-21 11:38:12 -05:00
Hypolite Petovan
1467a02576 Fix namespace usage in include/enotify 2019-01-21 11:38:01 -05:00
Hypolite Petovan
6f7ec1dc0c Remove unused consume_feed() parameters 2019-01-21 11:37:43 -05:00
Hypolite Petovan
b161bd1dfa Improve get_responses() prototype 2019-01-21 11:37:05 -05:00
Hypolite Petovan
ce177f22c8 Fix doc blocks and return value type 2019-01-21 11:36:01 -05:00
Hypolite Petovan
7f2dc40601 Fix potential bugs without expected behavior change
- Fix uninitialized variables
- Fix potentially not set variables
- Fix wrong parameter default value
- Fix method scope
- Fix missing return value
2019-01-21 11:04:19 -05:00
Hypolite Petovan
ad9c67663d Move Contact::Page_* constants to User::PAGE_FLAGS_* 2019-01-21 10:55:37 -05:00
Hypolite Petovan
da7706ce61 Remove unused code in include/
- Remove unused variables
2019-01-21 10:53:33 -05:00
Hypolite Petovan
c5cb976b62 Update PHPDoc in include/ 2019-01-21 10:44:46 -05:00
Hypolite Petovan
d1c6ec9718 Update namespaces declaration in include/
- Remove unused use statements
- Add required use statements
2019-01-21 10:44:45 -05:00
Hypolite Petovan
070aa016e0 Update more PHPDoc, including in include/ 2019-01-21 10:39:28 -05:00
Hypolite Petovan
cbda92f253 Add "on their post" label to notifications
- Align tag notifications on comment notifications
2019-01-21 10:12:52 -05:00
Philipp Holzer
2e602afd3e Add Monolog 2019-01-21 10:10:40 -05:00
Hypolite Petovan
2f49c4a058 Revert "Add monolog" 2019-01-21 10:08:09 -05:00
Philipp Holzer
5ee72b681b removed unused get_app() 2019-01-21 10:00:46 -05:00
Philipp Holzer
6e48df2163 Refactor Loglevels 2019-01-21 10:00:46 -05:00
Philipp Holzer
81cb6bec30 define api log prefix 2019-01-21 09:59:10 -05:00
Philipp Holzer
ff162dfef2 Replacing log usage 2019-01-21 09:59:09 -05:00
Philipp Holzer
fe8f0e0045 Add Monolog 2019-01-21 09:58:05 -05:00
Hypolite Petovan
55e54bb950 Replace deprecated Addon::callHooks with Hook::callAll
- Update documentation
2019-01-21 09:50:56 -05:00
Hypolite Petovan
895b3abf32 Remove/replace killme() with *exit() 2019-01-21 09:49:17 -05:00
root
dbd2e4cdf3 follow code standard 2019-01-21 09:13:10 -05:00
root
06ccba1c28 code style & use DBA::p 2019-01-21 09:13:09 -05:00
root
61afd5b3fb refs #6292
APIs show number of comments
- /api/statuses/*_timeline
- /api/search
- /api/favorites

/api/search enhacement
- support exclude_replies parameter
2019-01-21 09:13:09 -05:00
root
6c2ace3cab update hashtag regular expression 2019-01-21 09:12:35 -05:00
root
8de263df8b #6275 - q support hashtag search 2019-01-21 09:12:35 -05:00
root
939364f9a0 API - /search #6274
- fixed: search result always return empty
- add hashtag search: friendica_tag params
- ApiTest & api.md updated
2019-01-21 09:12:35 -05:00
root
b43dd28b7a closes #6272 2019-01-21 09:12:33 -05:00
root
d331e4e6e3 API - /media/upload - add return value #6272
image.preview: string (url for small image)
2019-01-21 09:12:33 -05:00
fabrixxm
55292c954b Remove resourceid parameter from Photo::exists() 2019-01-21 09:12:29 -05:00
fabrixxm
e7fbe04b11 Fix parse error 2019-01-21 09:12:29 -05:00
fabrixxm
8c75c26361 Use Model\Photo as much as possible
Most important is to use `Photo::delete()` to have backend
to remove data.
2019-01-21 09:12:28 -05:00
Hypolite Petovan
ea1946ec03 Use preg_quote instead of str_replace in include/items 2019-01-03 21:27:47 -05:00
Hypolite Petovan
5e1ceb57de Escape global namespaced get_app() calls
- Add deprecated status
2019-01-03 21:27:36 -05:00
Michael Vogel
94eca77041
Merge pull request #6315 from MrPetovan/bug/6309-add-fulltext-index-profile
Rework mod/match and mod/msearch
2018-12-27 18:04:06 +01:00
Hypolite Petovan
c5867df24c Remove useless intermediate network_name variable in include/api 2018-12-26 11:02:28 -05:00
Michael
bb0d7a5c51 Don't show "follow" activity 2018-12-25 19:50:40 +00:00
Hypolite Petovan
acaee626f5 Remove include/ requires that are now done directly from Composer 2018-12-24 09:56:25 -05:00
Michael
1f432d006b API: Fix author of repeated items from Diaspora 2018-12-21 22:55:36 +00:00
Hypolite Petovan
38109665c7 Various improvements/fixes
- Fix potential missing variable
- Improve replaceMacros doc
- Fix CSS value in smoothly
2018-12-16 22:38:30 -05:00
Michael
f6c3974c8f Issue 6257: Make notes visible again 2018-12-13 20:09:19 +00:00
Michael
f2e2066d33 Non public content is now displayed again to visitors. 2018-12-09 13:09:49 +00:00
Hypolite Petovan
9c534546e4 Fix condition in api_fr_photo_create_update 2018-11-30 10:48:47 -05:00
Hypolite Petovan
458981f75c Replace x() by isset(), !empty() or defaults()
- Remove extraneous parentheses around empty() calls
- Remove duplicate calls to intval(), count() or strlen() after empty()
- Replace ternary operators outputting binary value with empty() return value
- Rewrite defaults() without x()
2018-11-30 09:06:22 -05:00
Tobias Diekershoff
c77926be03
Merge pull request #6206 from annando/parent
Missing '
2018-11-26 11:43:16 +01:00
Michael
563a24e30b Missing ' 2018-11-26 08:52:40 +00:00
Michael
b9efe5a532 Show contact posts from hidden users 2018-11-25 18:50:41 +00:00
Michael Vogel
42a3610a79
Merge pull request #6184 from MrPetovan/task/normalize-bbcode-hashtags
Normalize BBCode hashtags links
2018-11-24 13:14:50 +01:00
Hypolite Petovan
c23d1b2776 Urlencode /network file parameter 2018-11-23 10:02:30 -05:00
Hypolite Petovan
4874f7f8ab Remove useless rawurlencode calls for building hashtag bbcode
- Fix some formatting
2018-11-22 09:32:41 -05:00
Michael
43079bfaf8 Several default features are now in the core 2018-11-18 20:13:46 +00:00
Jonny Tischbein
a36a780b99 Add fallback if comment as no parent 2018-11-18 12:46:21 +01:00
Jonny Tischbein
5d464c353f Delete comment from its guid and return to parent guid 2018-11-18 12:43:26 +01:00
Jonny Tischbein
cf9c3444bc Fix return url when delete comment from display 2018-11-17 13:56:58 +01:00
Michael
a5ddaa9dbc Issue 6128: Websub could work now 2018-11-13 22:23:16 +00:00
Michael
34a0e71485 API: The wrong user had been shown for repeated posts 2018-11-11 19:05:57 +00:00
Adam Magness
218f0734be Rename removeTags to escapeTags
rename function and update calls.
2018-11-09 13:29:42 -05:00
Adam Magness
ffc406d819 normalise_link calls
implement normaliseLink function
2018-11-08 11:28:29 -05:00
Adam Magness
46d7767fd0 formatBytes calls
implement function in new class
2018-11-08 10:28:49 -05:00
Adam Magness
a0f65ca7a1 notags calls
implement removeTags function
2018-11-08 10:14:37 -05:00
Adam Magness
991f259ecb random_string calls
implement getRandomHex function
2018-11-08 08:45:46 -05:00
Adam Magness
fd597472f1 Split text.php to Strings class
move functions to new strings class
Split text.php to Strings class

move functions to new Strings class
2018-11-08 08:33:28 -05:00
Adam Magness
7cb9138201 Move another function
move get_plink to Item class, and also fix up getApp since we extend BaseObject
2018-11-07 07:19:39 -05:00
Adam Magness
e537f7d017 Function calls
update function calls to new class
2018-11-06 21:16:27 -05:00
Adam Magness
d50a1edef4 Split text to Item
move functions from text.php to Item class
2018-11-06 21:12:41 -05:00
Jonny Tischbein
509dc29b2d Fix return url when dropping post loaded by update_* in non-frio 2018-11-06 21:37:10 +01:00
Adam Magness
352da9bcf3 Update function calls
update function calls for moved functions
2018-11-06 09:52:58 -05:00
Adam Magness
1d571a527b Split text.php to L10n
move functions from text.php to L10n class
2018-11-06 09:52:58 -05:00
Adam Magness
4f07ebb52f Rename properly
rename function properly this time!
2018-11-06 06:34:32 -05:00
Adam Magness
3eecd108c5 rename function
rename function and update calls.
2018-11-06 06:31:48 -05:00
Adam Magness
9264059945 Missing Include
missed use statement
2018-11-05 21:15:47 -05:00
Adam Magness
a71eb1d127 functions moved to HTML class
update function calls to moved class.
2018-11-05 21:06:26 -05:00
Adam Magness
e31dde6084 Split text.php to HTML class
move functions from text.php to src/Content/Text/HTML
2018-11-05 20:27:22 -05:00
Philipp Holzer
6e10bdf361
Move random Digits to Crypto class 2018-11-05 21:02:54 +01:00
Adam Magness
9e51be7554 Revert "Update function calls"
This reverts commit 748fb8b946.
2018-11-05 13:07:07 -05:00
Adam Magness
748fb8b946 Update function calls
update function calls to new class
2018-11-05 07:40:18 -05:00
Adam Magness
b07d47b0f7 Update function calls
update function calls to new names
2018-11-05 07:24:14 -05:00
Adam Magness
61bc9facc8 Implement functions
implement functions relocated to xml class
2018-11-05 07:24:14 -05:00
Adam Magness
84e900d96f Move to XML
move functions from text to xml
2018-11-05 07:24:14 -05:00
Jonny Tischbein
645f9387fa make return url optional 2018-10-31 20:09:44 +01:00
Jonny Tischbein
b66bcb20da Redirect to previous page after NON-AJAX Post delete via second parameter in /item/drop 2018-10-31 20:09:44 +01:00
Adam Magness
93ccd7bcdb Remove old functions
remove old functions from file.
2018-10-31 11:02:30 -04:00
Adam Magness
35abc4bb64 get markup template
implement getMarkupTemplate function
2018-10-31 10:44:06 -04:00
Adam Magness
91facd2d0a replace macros
implement new replaceMacros function
2018-10-31 10:35:50 -04:00
Adam Magness
f6c86649c2 Create Core\Renderer Class
create new class and redirect old functions
2018-10-31 10:03:42 -04:00
Adam Magness
3a604029eb Create FileTag class
create class and move functions
2018-10-30 14:51:21 -04:00
Adam Magness
50da89d861 Logger Levels
update logger levels in calls
2018-10-30 09:58:45 -04:00
Adam Magness
80367d05d8 Remove functions
remove functions that were moved to Logger class
2018-10-30 09:57:14 -04:00
Adam Magness
14fde5dc9b Log function
implement log() function.
2018-10-30 09:57:14 -04:00
Adam Magness
d6d593d724 Create Logger class
Create Core\Logger class and point old functions to the new ones.
2018-10-30 09:57:14 -04:00
Hypolite Petovan
14237a9599 Move $pager and $page_offset out of App
- Move infinite scroll data output in a module hook
- Use Pager instead of paginate() and alt_pager()
2018-10-25 00:07:15 -04:00
Hypolite Petovan
9c9ebfc7c9
Merge pull request #6013 from JonnyTischbein/issue_comment_media_link_prompt
[frio] Add media / link prompt in comments
2018-10-24 12:17:58 -04:00
Jonny Tischbein
d2b5f77be9 Add multimedia link for jot + enables hover text in jot + autosize in when paste link + renaming / Code Standards 2018-10-24 16:20:10 +02:00
vinzv
cb75c40f4e adapted profile pic resize to 300px for whole system 2018-10-23 16:36:57 +02:00
Philipp Holzer
32af52842b
adding defaults in mod/redir.php 2018-10-22 22:13:41 +02:00
Philipp Holzer
3edad1591e
replaced $return_url to $return_path to make it more clear that it is a relative path to the Friendica baseurl 2018-10-22 22:13:37 +02:00
Philipp Holzer
d00ddc01af
Split goaway to System::externalRedirectTo() and App->internalRedirect() 2018-10-22 22:13:35 +02:00
Philipp Holzer
2ef81108b3
Renamed System::redirect() to $a->redirect() 2018-10-22 22:13:22 +02:00
Michael
1cd72e7694 API: The source field does now reliably return the correct network name of the author 2018-10-22 14:15:14 +00:00
Michael
8e11f055b1 Improve PR 5984: better check for remote users as well 2018-10-21 21:56:46 +00:00
Michael
9b387a226c Fix webmentions and microformats ("redir" only for logged in users) 2018-10-21 20:23:08 +00:00
Hypolite Petovan
a8d3a4d218 Add missing L10n::popLang calls 2018-10-20 09:02:10 -04:00
Hypolite Petovan
ec0d3a6eac
Merge pull request #5946 from JonnyTischbein/move_include_security
Move and Split include/security
2018-10-19 08:55:08 -04:00
Jonny Tischbein
f3fc1f36ca Renaming functions + moving functions from security to Model/Item and BaseModule + fix multiline comments 2018-10-17 21:30:41 +02:00
Michael Vogel
389685e099
Merge pull request #5920 from MrPetovan/bug/remove-password-from-register
Avoid storing plaintext password in register table
2018-10-17 21:04:11 +02:00
Jonny Tischbein
ce2b1f5715 Rename function Authentication::authenticate_success to Authentication::success 2018-10-17 18:45:32 +02:00
Jonny Tischbein
05be2db725 Move include/security tp /src/Core/Authentication and /src/Util/Security 2018-10-17 14:19:58 +02:00
Adam Magness
370ee08fcc Remaining contacts to contact
Update occurrences of contacts/ to contact/
2018-10-17 07:49:27 -04:00
Hypolite Petovan
481b0ac138 Fix notices in include/enotify 2018-10-15 23:13:00 -04:00
Hypolite Petovan
f2bde919e5 Fix ignored show_in_notification_page parameter in notification() 2018-10-14 11:30:39 -04:00
Jonny Tischbein
bfa05156ca change links from /contacts to /contact 2018-10-13 13:29:56 +02:00
Philipp Holzer
7c73e8634c
Curl Response Refactoring
- refactored Network::post()
- replaced every Network::post() execution with the new Curl container
2018-10-10 21:15:26 +02:00
Philipp Holzer
5a02e39a65
Rename App Methods
- renamed a lot of App methods to CamelCase
- replaced direct public variables with get-/set-Methods
2018-10-10 00:16:06 +02:00
Jonny Tischbein
29033bdf05 goaway to network if deleted item + remove goaway for filerm 2018-10-09 20:44:30 +02:00
Jonny Tischbein
d18421f760 Return to item if not owned by user or canceld 2018-10-09 20:40:25 +02:00
Jonny Tischbein
d8780b1640 Replace goaway location SESSION var return_url with page as string value 2018-10-09 20:10:34 +02:00
Michael
9fbaaa1481 We now can show "Friendica (AP)" as network name 2018-10-05 19:26:20 +00:00
Michael
3ab837f3c7 Functionality is now split 2018-10-03 09:15:38 +00:00
Hypolite Petovan
505350c9fb
Merge pull request #5794 from annando/ap1
ActivityPub support
2018-10-02 11:24:04 -04:00
Michael
54c7ca58d8 Repeated posts from OStatus, ActitivyPub and Twitter are now shown as is 2018-10-02 03:41:38 +00:00
Michael
b746ddec64 Issue 5797: Retweets are now displayed again via API 2018-10-01 18:16:19 +00:00
Michael
e3a4a9c407 Issue 5798: We had displayed the author as owner 2018-10-01 17:36:23 +00:00
Michael Vogel
103535d620
Merge pull request #5773 from MrPetovan/task/rewrite-js-hooks
Rewrite JS hooks
2018-10-01 17:10:30 +00:00
Hypolite Petovan
3dfb0c2e7c
Merge pull request #5762 from JonnyTischbein/2018.08-rc
Add api_friendships_destroy() like mod/unfollow.php
2018-10-01 12:51:46 -04:00
Michael
cb9be8a7ab UUID is now createUUID 2018-09-27 11:52:15 +00:00
Michael
60b0759b50 UUID instead of GUID 2018-09-26 20:03:46 +00:00
Michael
c083ae047c Merge remote-tracking branch 'upstream/2018.08-rc' into ap1 2018-09-22 15:18:53 +00:00
Michael
c6268ca0b7 Issue 5760: Avoid a non numeric value for "tt" 2018-09-22 14:17:14 +00:00
Hypolite Petovan
1eaa523e61 Remove unused App->page['end']
- Remove unused empty templates
2018-09-20 21:02:28 -04:00
Jonny Tischbein
9821f173a4 fix response 2018-09-16 19:36:25 +02:00
Hypolite Petovan
ba4f368b45 Remove references to pear/Text_Highlighter 2018-09-16 09:05:00 -04:00
Jonny Tischbein
a0942963c9 api_friendships_detroy uid - api_user instead of local_uer, empty check for 2018-09-15 11:06:55 +02:00
Jonny Tischbein
b7e15e8b38 api_friendships_destroy finally function header + NotFoundException typo 2018-09-14 19:35:24 +02:00
Michael
61e2c7d20d Added AP to many network conditions / enabling inbox processing 2018-09-14 16:51:32 +00:00
Jonny Tischbein
2c3a58d44e api_friendhips_destroy function header 2018-09-14 10:06:26 +02:00
Jonny Tischbein
3eb539aefd api_friendships_destroy idents, DBA::selectFirst, Excepions and LogMessages 2018-09-14 09:28:14 +02:00
root
a89f9cf7d5 api_friendships_destroy cleanup 2018-09-13 23:32:26 +02:00
root
3f85fee7e3 Add api_friendships_destroy() like mod/unfollow.php 2018-09-13 23:23:53 +02:00
Tobias Diekershoff
d5a3b0bd5e
Merge pull request #5710 from annando/fix-api
Fix for timeout issues when posting to the API
2018-09-02 14:52:09 +02:00
Michael
703c668a37 More notices ... 2018-09-02 08:01:13 +00:00
Michael
394526db74 Typo corrected / use the thread table instead 2018-09-02 07:35:12 +00:00
Michael
4bb45f611f Fix for timeout issues when posting to the API 2018-09-02 07:20:04 +00:00
Michael
38fd21019b Invalid pictures could lead to notices, this is removed now 2018-08-31 07:48:44 +00:00
Michael Vogel
601851f3d0 Removed notice - pokes do now work mostly (#5693) 2018-08-29 09:00:01 -04:00
Michael Vogel
99b8f85624 Poke is fixed (#5689)
* Fix: Poke hasn't worked. It does work now partially

* Poke are now displayed good again

* removed code
2018-08-28 15:38:28 -04:00
Michael Vogel
edcd0a3744 Issue 4960: Ignoring and blocking of contacts should work again (#5657)
* Issue 4960: Ignoring and blocking of contacts should work again

* Renamed functions

* This function should be renamed as well.

* We now have a frontend to block and ignore public contacts

* Hide some parts for public contacts

* Removed notices, public contact is now accessible from dirfind as well

* We now show contact conversations and contact posts

* We now use a new conversation mode

* The update functionality is disabled until it will work completely

* Fixing tabs chaos

* Update after posts on the contacts page will now work

* Show connect link
2018-08-25 09:48:00 -04:00
Michael
82d097879b Oh no ... there are still some notices that want to be removed ... 2018-08-24 11:09:58 +00:00
fabrixxm
93ba393559 API: add private value (bool) to item results (#5647)
* API: add private value (bool) to item results

friendica:private for xml
friendica_privarte for json

* API Docs: add a section about custom value returned in status data
2018-08-23 10:09:50 -04:00
Michael Vogel
dc3d2d5988 "dba" is now "DBA". This hadn't been respected at some places (#5655)
* "dba" is now "DBA". This hadn't been respected at some places

* Cleaning up unneeded stuff
2018-08-23 09:51:58 -04:00
Michael Vogel
d29cb1acaf Fix: Mail notifications arrive again (#5654)
* Fix: Mail notifications arrive again

* Ensure that user data is always there
2018-08-23 10:00:25 +02:00
Tobias Diekershoff
578549df13
Merge pull request #5646 from annando/notes
The notes are now fetching their content from a central function
2018-08-21 17:36:15 +02:00
Michael Vogel
54aee2aaa7 Removed notices that revealed themselfes over night ... (#5645)
* Removed notices that revealed themselfes over night ...

* And more notices removed that occured over night

* One more ..

* Some more notices of the day ...
2018-08-21 17:35:09 +02:00
Michael
1fb5925073 The notes are now fetching their content from a central function 2018-08-21 07:35:22 +00:00
Michael Vogel
d9b44153da The content generation for the display page is now using a centralized function (#5642)
* The content generation for the display page is now using a centralized function

* Small correction to avoid notices
2018-08-20 16:32:55 -04:00
Michael Vogel
16a081871c Improved profile page, improved "limit" handling (#5639)
* Improved profile page, improved "limit" handling

* Update will now work again

* Update will work now
2018-08-20 06:26:05 +02:00
Michael Vogel
c1da44b7dc We now use a central function to fetch the importer (#5636) 2018-08-19 13:37:56 +00:00
Michael Vogel
7f3fb34c24 Some easy to replace "q" calls have been replaced by "DBA" calls (#5632)
* Some easy to replace "q" calls have been replaced by "DBA" calls

* Simplified the GUID creation

* And one in the API ...

* And OStatus has got some DBA calls more

* Just some more replaced database calls

* The event query is now simplified

* Events are now shown again

* subthread is now using the DBA calls as well

* Some more replaced database calls

* And some more replaced database calls and prevented notices

* Better use gravity

* Some more replaced database stuff

* Some more replaced database calls in DFRN.php

* The gcontact class now has got the new DBA functions as well

* The Contact class is now changed to new database functions as well

* Small correction

* We can now delete without cascade

* One more functionality is safe for future changes
2018-08-19 12:46:10 +00:00
Michael Vogel
dfe4413463 Avoid blocks with invalid entries in superblock (#5635) 2018-08-19 12:14:12 +02:00
Tobias Diekershoff
d5c2c41b02
Merge pull request #5626 from annando/notices-oh-yeah
Removed notices, will it ever end?
2018-08-17 09:33:02 +02:00
Michael
0342f9e084 Removed notices, will it ever end? 2018-08-17 03:19:42 +00:00
fabrixxm
66b4730a70 api: fix friendica/notification/seen api call
Fix return item related to notification when notification is set as seen
2018-08-16 11:46:53 +02:00
Michael
56443b53cb Fix: We now are notified again when a new post had been created 2018-08-12 04:34:56 +00:00
Roland Häder
e06fc2aa69 Stopped using deprecated constants NETWORK_* (#5537)
* Rewrite:
- stopped using deprecated NETWORK_* constants, now Protocol::* should be used
- still left them intact for slow/lazy developers ...

* Removed deprecated NETWORK_* constants as per code reviewer's request.
2018-08-11 22:40:44 +02:00
Michael
a8016e4187 Issue 4507: Superblock does now work on comments as well 2018-08-10 04:27:52 +00:00
Michael Vogel
276abfaba6 Issue 5158: Ignore all threads, even public ones (#5588)
* Issue 5158: Ignore all threads, even public ones

* Remove some notice

* Now it really should work

* Using "defaults"
2018-08-08 22:32:11 +02:00
Michael Vogel
c72c64a6d8 Notices again (#5543)
* And again notices

* Notices in the directory

* Much more places

* Fix some double $

* Notice in ping

* Missing field

* Fix: We now remove deleted users from the directory

* Some more stuff

* Notices when removing users

* Added logging

* More logging

* Two more
2018-08-02 07:21:01 +02:00
Michael Vogel
9d0f18c0b3 Yeah, and again notices ... (#5536)
* Yeah, and again notices ...

* And some more

* Block access without given user name

* Reformatting
2018-08-01 07:29:58 +02:00
Michael Vogel
71b1638d9a Once again, notices ... (#5535) 2018-07-31 18:39:23 +02:00
Roland Häder
2c0ad47dfc Fixed fatal error: (#5532)
* Fixed fatal error:
````
PHP Fatal error:  Uncaught TypeError: Argument 1 passed to add_page_info_data()
must be of the type array, boolean given, called in
/var/www/../include/items.php on line 153 and defined in
/var/www/../include/items.php:27
````

Fix for type-hint array when query_page_info() returned a non-array, this may
happen when the instance/node/pod owner decided to shutdown server and replace
all URLs with a replacement message.

* Fixed parser error, ops.
2018-07-30 22:24:32 -04:00
Roland Häder
4d39164c1e [WIP] Rewrite to Proxy class: (#5507)
* Rewrite to Proxy class:
- introduced new Friendica\Network\Proxy class for in exchange of proxy_*()
  functions
- moved also all PROXY_* constants there as Proxy::*
- removed now no longer needed mod/proxy.php loading as composer's auto-load
  will do this for us
- renamed those proxy_*() functions to better names:
  + proxy_init()           -> Proxy::init()         (public)
  + proxy_url()            -> Proxy::proxifyUrl()   (public)
  + proxy_parse_html()     -> Proxy::proxifyHtml()  (public)
  + proxy_is_local_image() -> Proxy::isLocalImage() (private)
  + proxy_parse_query()    -> Proxy::parseQuery()   (private)
  + proxy_img_cb()         -> Proxy::replaceUrl()   (private)

* Ops, need to set $a here ...

* CR request:
- moved Proxy class to Friendica\Module
- extended BaseModule

* Ops, no need for own instance of $a when self::getApp() is around.

* Proxy-rewrite:
- proxy_url() and proxy_parse_html() are both non-module functions (now
  methods)
- so they must be splitted into a seperate class
- also the SIZE_* and DEFAULT_TIME constants are both not relevant to module

* No instances from utility classes

* Fixed error:
- proxify*() is now located in `Friendica\Util\ProxyUtils`

* Moved back to original place, ops? How did they move here? Well, it was not
intended by me.

* Removed duplicate (left-over from split) constants and static array. Thank to
MrPetovan finding it.

* Renamed ProxyUtils -> Proxy and aliased it back to ProxyUtils.
2018-07-30 22:06:22 -04:00
Roland Häder
3da1b9f319 Cleaned up include/items.php (#5523)
* Cleaned up include/items.php
- added type-hint for array where suitable
- moved opening curly brace to new line after function
- used BaseObject::getApp() instead of get_app()
- used empty() instead of is_array(), maybe avoids E_NOTICE

* Changed 'AS' to 'as', keywords in PHP are all lower-case.
2018-07-30 21:02:34 -04:00
Roland Häder
4a22710b3b Moved global PAGE_* to Profile class (#5500)
* Rewrites:
- moved PAGE_* to Friendica\Model\Profile class

* Fixed more rewrites from plain (global namespace) PAGE_* to Friendica\Models\Profile class

* CR request:
- moved all PAGE_* constants to Friendica\Model\Contact class
- fixed all references of both classes

* CR request:
- moved ACCOUNT_TYPE_* constants from boot.php to Contact::ACCOUNT_TYPE_*

* Just copy-pasted this code from boot.php, needs to be changed to `const ACCOUNT_TYPE_FOO = x;`

* Ops, melting brain cells here ... :-/
2018-07-27 19:25:57 -04:00
Michael Vogel
986106a8f7 Item storage: Permissions aren't stored in the items anymore (#5495)
* The permission set is now used for item permissions

* Check for allow_cid, ... is superfluous. Checking for "private" is enough

* We query the permissionset

* Permissions are displayed correctly

* Changed index

* We don't store the permissions in the item table anymore

* Permission fields are now deprecated

* Reversed ...
2018-07-25 19:14:55 -04:00
Roland Häder
37253656e3 Moved CONTACT_* constants to Friendica\Model\Contact class, lesser in global namespace (#5490)
* Rewrite:
- moved all CONTACT_* constants from boot.php to Contact class

* CR request:
- renamed Contact::CONTACT_IS_* -> Contact::* ;-)
2018-07-24 22:53:46 -04:00
Hypolite Petovan
6141023640 Remove dbesc() and dba_timer() function declarations 2018-07-23 15:30:54 -04:00
Hypolite Petovan
a6fb3568f9 Rename dbesc to DBA::escape 2018-07-23 15:30:54 -04:00
Hypolite Petovan
ecea7425f8 Rename DBA::is_result to DBA::isResult 2018-07-23 11:04:14 -04:00
Hypolite Petovan
0ec44f3e8a Rename DBM method calls to DBA method calls 2018-07-23 11:02:24 -04:00
Hypolite Petovan
4db98eb43d Rename DBA::inArray to DBA::toArray 2018-07-22 19:27:35 -04:00
Hypolite Petovan
abbaaf5aa5 Rename DBA::clean_query to DBA::cleanQuery 2018-07-22 19:27:34 -04:00
Hypolite Petovan
910e832dc2 Rename DBA::any_value_fallback to DBA::anyValueFallback 2018-07-22 19:27:34 -04:00
Roland Häder
c17adaf333 Uncommon logger levels in Friendica (#5453)
* "normal" is an uncommon logger level:
- changed LOGGER_NORMAL -> LOGGER_INFO
- added LOGGER_WARNING (a common logger level)

* Used constants instead of values (MrPetovan)
2018-07-22 14:07:44 -04:00
Hypolite Petovan
af6dbc654f Rename Friendica\Database\dba to Friendica\Database\DBA 2018-07-20 08:19:26 -04:00
Hypolite Petovan
72f32f90d1 Remove class \dba from include/dba 2018-07-19 22:15:57 -04:00
Hypolite Petovan
daa1177e3a Update use statement lists with new Friendica\Database\dba class
- Remove unused use statement
- Remove superfluous use statements (classes in the same namespace)
- Add missing use statements
2018-07-19 22:15:21 -04:00
Michael Vogel
ece4d3f4fb Issue 5407: Workers didn't start anymore (#5409) 2018-07-19 11:05:17 -04:00
Michael Vogel
5af9596dde New item field "Post-type" and new table "permissionset" (#5408)
* "post-type" replaces "bookmark" and "type"

* Removed some more type

* Added index to permission set

* The permission set is now stored

* The permission set is now removed upon expiry

* Post update now stores the permission set

* New file

* Permissions are now sorted

* Changed documentation
2018-07-19 09:52:05 -04:00
Roland Häder
0b38f1c58b Fixes applied: (#5399)
- $_SESSION['remember_user'] did only exist here and no where else
- it seems to be accient old-lost code, so I fixed it to $a->user['nickname']
  instead
- used multi-line comment for multiple lines of on-line comments

Signed-off-by: Roland Häder <roland@mxchange.org>
2018-07-19 07:11:03 -04:00
Hypolite Petovan
67dc08d120 Enforce systen.register_policy value type 2018-07-16 19:38:19 -04:00
Hypolite Petovan
c207f6d597 Remove remaining references to Config::get in include/dba 2018-07-16 19:38:18 -04:00
Hypolite Petovan
820afa2284 Replace global $a with BaseObject::getApp() 2018-07-16 19:38:17 -04:00
Hypolite Petovan
adacf421a6 Remove deprecated functions in include/text 2018-07-16 19:38:17 -04:00
Hypolite Petovan
5906c7e013 Remove api test pconfig debug 2018-07-16 19:38:17 -04:00
Hypolite Petovan
224765cdf5 Wrong table name 2018-07-16 19:38:16 -04:00
Hypolite Petovan
f8a90f3425 Add more api test debug 2018-07-16 19:38:16 -04:00
Hypolite Petovan
de0afd3b32 Add api test debug 2018-07-16 19:38:16 -04:00
Hypolite Petovan
9396b05659 Revert using Config class in dba 2018-07-16 19:38:16 -04:00
Hypolite Petovan
9be9741562 Fix uses in include/dba 2018-07-16 19:38:16 -04:00
Hypolite Petovan
762a786611 Replace direct accesses to App->config by Config::get/set calls 2018-07-16 19:38:16 -04:00
Hypolite Petovan
cd9b864045 Rework App modes
- Replace App mode constants with capability-based flags
- Add App->isInstallMode()
- Add file config fallback in (P)Config abstraction
- Removed logger disabling code
2018-07-16 19:38:15 -04:00
Hypolite Petovan
7d8c45dde8 Remove dependency to App in dba::connect
- Remove timing (can be done centrally)
- Add charset parameter to dba::connect and dba::reconnect
2018-07-16 19:38:13 -04:00
Michael
0e8fa34156 Fix for displaying public items 2018-07-16 04:00:57 +00:00
Hypolite Petovan
a6eae9adec Add new put_item_in_cache hook in include/text 2018-07-15 08:03:12 -04:00
Roland Häder
6b5d90333f Fixes for some E_NOTICE and type-hints added (#5358)
* Fixed http://github to https://github

Signed-off-by: Roland Häder <roland@mxchange.org>

* Fixes for #4965:
- updated messages.po file

Signed-off-by: Roland Häder <roland@mxchange.org>

* Fixed E_NOTICE where isset()/empty() was absent.

Signed-off-by: Roland Häder <roland@mxchange.org>

* Fixed missing variable $sql_order causing E_NOTICE.

Signed-off-by: Roland Häder <roland@mxchange.org>

* Continued:
- added array type-hint where known (some)

Signed-off-by: Roland Häder <roland@mxchange.org>

* Fixes:
- in Profile::load() $user is now only one-dimensional
- $a->get_hostname is no property, it is a method

Signed-off-by: Roland Häder <roland@mxchange.org>

* reverted changes that are unintended

Signed-off-by: Roland Häder <roland@mxchange.org>

* Continued:
- removed leading \ (uncommon, okay)
- removed entire if() block (CR by Hypolite)

Signed-off-by: Roland Häder <roland@mxchange.org>

* Removed if() block

Signed-off-by: Roland Häder <roland@mxchange.org>
2018-07-13 15:47:14 -04:00
Michael Vogel
0360f7197a Several more warnings ... (#5340)
* Some more warnings removed

* Even more warnings ...

* Will it ever end? ;-)

* Avoid warning in dbstructure

* Origin and OStatus ...

* There are more warnings solved ... yeah!

* And again ...

* We are not done yet

* And more ...

* And some new places ...

* And more in the feeds

* Avoid some more

* And some backend stuff

* Notifications cleared

* Some more stuff

* and again ...

* It's getting fewer ...

* Some warnings had been hidden in the notifications

* Fix the fix

* And another missing one ...

* We need the owner here, not the user

* Forgotten user

* And more ...

* And some more warnings disappeared ...

* Some more frontend warnings

* Some backend warnings removed

* Fixed sidebar for "vier"

* And more ...

* Some more ...

* And something for "remote self"

* Am I stuck in an endless loop?

* Fix: Clear tag and file field on update

* Preset page content
2018-07-10 08:27:56 -04:00
Philipp Holzer
c829e43725
moved get_guid to System::createGUID 2018-07-09 21:38:16 +02:00
Michael
675a6adf35 Added comment 2018-07-08 13:52:11 +00:00
Michael
8a2230bc4c Avoid warnings in addons 2018-07-08 12:01:36 +00:00
Michael
3e797547a3 Warnings fixed 2018-07-08 09:37:05 +00:00
Michael
69db696ab1 Improve test behaviour 2018-07-08 05:29:06 +00:00
Michael Vogel
ff5ee74ecf
Merge branch 'develop' into item-activities 2018-07-08 06:35:50 +02:00
Michael
4d35e228c4 More item abstraction / making remote deletion work again 2018-07-07 18:14:16 +00:00
Philipp Holzer
1ffe0cfd81
Added Lock Unittests & Bugfixings
Added Redis Lock Unittests
Added Memcached Lock Unittests

Fixed a bug in dba
Fixed a bug in RedisLock
2018-07-07 16:15:03 +02:00
Hypolite Petovan
e44111e935 Revert renaming lang to language in api
- Normalize some quotes
- Put "Empty user-agent" log message in a else statement
2018-07-04 17:33:09 -04:00
Hypolite Petovan
43688c04b1 Add NotFoundException for recipients in api_direct_messages_new() 2018-07-02 07:48:59 -04:00
Hypolite Petovan
cb7176ee70 Fix Config use in api_statusnet_config() 2018-07-02 07:48:53 -04:00
Hypolite Petovan
757fd357f6 Fix yet more undefined variable/index notice in api 2018-07-02 07:48:48 -04:00
Hypolite Petovan
dde61a77a4 Fix root element containing only text in api_create_xml() 2018-07-02 07:48:42 -04:00
Hypolite Petovan
62eba48679 Fix yet more undefined variable/index messages in api_statuses_show 2018-07-02 07:48:38 -04:00
Hypolite Petovan
0ee153e1bd Fix Array to String conversion message for IN conditions 2018-07-02 07:47:47 -04:00