keith/friendica
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity
37727 commits 4 branches 0 tags 179 MiB
Commit graph

2058 commits

Author SHA1 Message Date
Hypolite Petovan
818cdf83ca [Database version 1500] Remove obsolete table fcontact 2022-12-05 00:00:50 -05:00
Hypolite Petovan
ce69026964 [Database version 1499] Create new paradigm classes for Diaspora Contact 
- Switch table fcontact for dcontact in views
 2022-12-05 00:00:50 -05:00
Michael
ace80ca1b4 Use "author_handle" for the author handle extracted from Diaspora XML messages 
- We have structured data under the variable name "author"
- Remove unused $uid parameter from Diaspora::storeByGuid
- Convert $person parameter to just its URL in Diaspora::authorContactByUrl
- Flip parameters in getUriFromGuid to get rid of $onlyfound
 2022-12-05 00:00:49 -05:00
Hypolite Petovan
303d556ab0 Fix last reference of replaced variable $owner_nick in Protocol\Feed::atom() 
- Address https://github.com/friendica/friendica/issues/11994#issuecomment-1336146405
 2022-12-03 10:19:04 -05:00
Hypolite Petovan
b83526ad0b Tighten profile restriction feature 
- Prevent feed access to restricted profiles
- Rework display of restricted profiles with a redirect to the profile/restricted route
- Normalize permission checking with IHandleUserSession->isAuthenticated
- Remove unusable "nocache" parameter in feed module because session isn't initialized
- Reword setting name and description
 2022-12-01 08:03:35 -05:00
Hypolite Petovan
150c0e0750 Address some PHP 8.1 deprecation notices 
- Replace a strstr call by strpos in Model\APContact
- Simplify conditions in Protocol\DFRN
- Address part of https://github.com/friendica/friendica/issues/12011#issuecomment-1331012289
 2022-11-29 21:37:41 -05:00
Philipp
c2c563be26
Merge pull request #12249 from MrPetovan/bug/deprecated 
Address several PHP 8.1 deprecation notices
 2022-11-25 23:32:32 +01:00
Philipp
4291e0def5
Merge pull request #12246 from MrPetovan/bug/notices 
Ensure the existence of various keys in decoded data in Diaspora::decodeRaw
 2022-11-25 23:30:56 +01:00
Hypolite Petovan
55640eec87 [Composer] Upgrade to phpseclib version 3 
- Create custom Key file format for Salmon Magic key
- Remove obsolete pemToME and MEtoPem Crypto methods
- Remove unused newECKeypair Crypto method
- Switch to constant-time Base64 encode/decode in Base64Url Strings methods
 2022-11-25 08:13:05 -05:00
Hypolite Petovan
d2ea58428d Ensure the existence of various keys in decoded data in Diaspora::decodeRaw 
- Address https://github.com/friendica/friendica/issues/11994#issuecomment-1302681295
 2022-11-23 11:22:54 -05:00
Hypolite Petovan
14ebc4a821 Ensure $owner is set in ActivityPub\Transmitter::sendContactReject 
- Address https://github.com/friendica/friendica/issues/11993#issuecomment-1289535020
 2022-11-23 11:05:36 -05:00
Hypolite Petovan
a5af1408d6 Ward against the possible case that $actor is empty in ActivityPub\Processor::createItem 
- Address https://github.com/friendica/friendica/issues/11993#issuecomment-1323273452
 2022-11-23 10:47:51 -05:00
Hypolite Petovan
a8eabae12f Ensure $owner is set in ActivityPub\Transmitter::sendActivity 
- Address https://github.com/friendica/friendica/issues/11993#issuecomment-1322704863
 2022-11-23 10:40:41 -05:00
Hypolite Petovan
d4bb5223a4 Use guid from shared post in Protocol\Diaspora::getReshareDetails 
- Address https://github.com/friendica/friendica/issues/11993#issuecomment-1321194769
 2022-11-20 13:01:37 -05:00
Hypolite Petovan
6f93ee7e49 Fix various PHP 8 deprecations 2022-11-19 19:15:47 -05:00
Michael
cdbfa34066 "View" activities are now ignored 2022-11-17 20:01:32 +00:00
Hypolite Petovan
fe547b7851 Centralize config.admin_email management in Model\User 2022-11-14 17:02:42 -05:00
Michael
4dd2d7ebab Transmit the quoted part in the source 2022-11-05 16:25:04 +00:00
Michael
842e51194e Improved bulk delivery / don't redistribute activities 2022-11-03 04:03:39 +00:00
Hypolite Petovan
2cf1e1074b Fix documentation typo in src/Protocol/Diaspora.php 2022-11-01 08:45:25 -04:00
Michael
1f1c2d8ca6 (Hopefully) query performance improvements 2022-11-01 08:45:25 -04:00
Michael
3c169b534e Improved handling of native quotes 2022-10-29 22:11:39 +00:00
Michael
deccea0228 More functions moved to content class 2022-10-27 05:44:44 +00:00
Michael
c65fff6f93 Some more improvements for posts with shares 2022-10-26 17:00:55 +00:00
Michael
842a4bb904 Changed function name 2022-10-25 12:40:22 +00:00
Michael
f54a886a5e The "share" handling is improved 2022-10-25 06:37:23 +00:00
Roland Häder
26e0469de7
Merge branch 'develop' into rewrite/gravity-constants 2022-10-18 16:34:40 +02:00
Michael
62a0d55fc8 The friendica constants have been moved to the app class 2022-10-17 10:37:48 +00:00
Michael
018858934b The priority is now a class constant 2022-10-17 05:49:55 +00:00
Michael
f8f0dfa91a Detect linked posts and add them as quote 2022-10-16 21:37:05 +00:00
Michael
8e1af9277a Improve quite generation 2022-10-15 13:00:52 +00:00
Roland Häder
da66730e4f
Rewrite: 
- moved constants GRAVITY_* from boot.php to Friendica\Model\Item
- also rewrote some array initialization:

From:
````
<?php
$arr = [];
$arr['foo'] = "FOO";
````

To:
````
<?php
$arr['foo'] = "FOO";
````
- added a few type-hints
 2022-10-15 00:44:06 +02:00
Michael
aeb4645ba6 New field "quote-uri-id" for quoted posts 2022-10-10 22:39:30 +00:00
Michael
028de0e228 Quote of quotes are visually improved 2022-10-10 12:30:07 +00:00
Michael
0d3aa681b4 The quote functionality is simplified 2022-10-09 21:16:36 +00:00
Michael
48182a95fb Improve quote share ("message_id" added) 2022-10-06 21:50:20 +00:00
Michael
f9b7f3acdb Added sharing check for DFRN 2022-10-05 21:11:09 +00:00
Michael
bde7283b04 Fix: Undefined array key "object_object_type" 2022-10-03 20:01:28 +00:00
Michael
8347f0144b Fix log message 2022-10-03 11:42:50 +00:00
Michael
5127784acb Recursively check if the thread supports Diaspora 2022-10-03 11:04:57 +00:00
Michael
7395ae22f7 Issue 11952: Avoid to send AP related comments to Diaspora 2022-10-03 10:40:16 +00:00
Michael
0de458e134 Case changed 2022-10-02 04:51:00 +00:00
Michael
6fb5e13b08 Add ♲ symbol 2022-10-01 22:36:02 +00:00
Michael
8eb4ab2a33 Added comment for the deactivated part 2022-09-30 07:17:07 +00:00
Michael
d43b85e94b Don't transmit the shared attachments 2022-09-30 07:10:43 +00:00
Michael
59004711ec Support for transmitting quoted posts 2022-09-29 22:29:15 +00:00
Michael
a653c6350d Support for quoted links is added 2022-09-29 16:04:33 +00:00
Michael
9587787089 Add uri as well 2022-09-29 14:13:39 +00:00
Michael
6140f850e1 Detect the thread parent id if it is missing 2022-09-29 13:48:10 +00:00
Michael
ff80a25966 Additional checks for non follower content 2022-09-29 12:45:47 +00:00
Michael
b10496f4e9 Changed log level 2022-09-28 16:45:18 +00:00
Michael
d821afb418 Added logging of unexpected follow messages 2022-09-28 16:32:17 +00:00
Michael
4939be065e Merge remote-tracking branch 'upstream/2022.09-rc' into cooldown 2022-09-22 04:31:50 +00:00
Hypolite Petovan
6a9d91c824
Merge pull request #11902 from annando/duplicates 
Detect and remove contact duplicates
 2022-09-21 21:23:37 -04:00
Michael Vogel
0fa281247d More cooldown calls for worker processes 2022-09-21 21:03:07 +02:00
Michael Vogel
6ee8a966bf Fix forum delivery in case of beiong addressed via "@" 2022-09-21 10:54:05 +02:00
Michael
36668dfdb1 Merge remote-tracking branch 'upstream/2022.09-rc' into duplicates 2022-09-21 03:46:25 +00:00
Michael Vogel
3650feb256 "Count" parameter added 2022-09-19 12:46:28 +02:00
Michael Vogel
f08b08e0d8 Allow to reject specific languages on receiving posts via the relay 2022-09-19 12:36:12 +02:00
Michael
79b64cc44f Detect and remove contact duplicates 2022-09-16 05:00:06 +00:00
Michael
a0b99f61ea Use the cached activity function 2022-09-07 19:46:24 +00:00
Michael
da658cbf1d Delete the cache entry when the post is changed or deleted 2022-09-06 21:51:47 +00:00
Michael
7c9f10e58f Merge remote-tracking branch 'upstream/2022.09-rc' into pagecache 2022-09-06 17:36:42 +00:00
Michael
2a4c6d44bb Don't transmit empty conversations 2022-09-06 15:18:41 +00:00
Michael
f0d151932e Issue 11890: Don't use empty contexts 2022-09-06 14:08:25 +00:00
Michael
6eb9dff807 Pagecache for frequently fetched pages 2022-09-06 06:04:41 +00:00
Michael
f93418b295 Merge remote-tracking branch 'upstream/2022.09-rc' into database 2022-09-04 13:41:21 +00:00
Michael
c3d478aeed Improved logger calls 2022-09-04 09:22:15 +00:00
Michael
f22a4ba6f5 Be more tolerant when receiving messages 2022-09-04 07:39:09 +00:00
Michael
f7be610629 Fix logger warmings/errors 2022-09-03 13:32:41 +00:00
Michael
3e28d62bdb Fix receiving of reshared posts 2022-08-31 21:18:33 +00:00
Michael
f7b85092b0 Some more changed log levels 2022-08-31 05:01:22 +00:00
Michael
757a5c2de9 Loglevels are adjusted 2022-08-30 19:45:30 +00:00
Michael
2173fb38e0 Issue 11853/11867: Fix reshare of public posts 2022-08-27 21:22:49 +00:00
Michael
ceb88c10e6 Warnings/Errors reduced - improved relay processing 2022-08-27 08:08:58 +00:00
Michael
15d975f143 Avoid some database errors 2022-08-25 04:57:41 +00:00
Michael
4e3102bfb3 Diaspora: Don't check the author signature when author = parent author 2022-08-22 09:54:29 +00:00
Michael
531085890a Fetch the parent only - thread parents only on reshares 2022-08-17 19:39:20 +00:00
Michael
bb52e5a804 Cascade on author deletion 2022-08-16 04:18:29 +00:00
Michael
5b3145d7ce Several performance improvements 2022-08-15 13:23:01 +00:00
Roland Häder
cfa575b8e5
Changes: 
- added missing type-hints
- added documentation
- removed parameter $baseURL while it can be locally get the same way but
  lesser parameter
- used ActivityNamespace::SALMON_ME
- changed double-quotes to single
 2022-08-12 14:01:40 +02:00
Philipp
a145712f04
Merge pull request #11837 from MrPetovan/task/remove-poke 
Remove poke feature
 2022-08-11 18:17:11 +02:00
Michael
e2896b449b Changes after code review 2022-08-10 13:43:00 +00:00
Michael
d9aee0b3ea Conversation entries will now be stored asynchronous if possible 2022-08-10 09:28:18 +00:00
Hypolite Petovan
4a885a13a6 Remove poke feature 2022-08-09 14:55:55 -04:00
Michael
548b7f43a5 Improve SQL-Queries / fixed "fetch_parents" setting 2022-08-08 20:00:21 +00:00
Michael
d60d2caef6 Improved queue processing 2022-08-07 19:24:50 +00:00
Michael
22c1873064 Merge remote-tracking branch 'upstream/develop' into loop-prevention 2022-08-06 17:11:04 +00:00
Michael
87a945b295 More prevention of double processing of the same content 2022-08-06 17:06:55 +00:00
Hypolite Petovan
bd246b8cc2
Merge pull request #11817 from annando/double-processing 
Avoid processing the same activity
 2022-08-05 09:04:33 -04:00
Michael
8b698b183d Abort when public item cannot be inserted 2022-08-05 05:48:20 +00:00
Michael
8227367522 Remove test code, add documentation 2022-08-05 04:45:31 +00:00
Michael
f222e9d278 Avoid to provess the same activity 2022-08-04 21:52:10 +00:00
Hypolite Petovan
2e00797ebc
Merge pull request #11816 from annando/fetch-parents 
New option to disable the fetching of parents
 2022-08-04 16:00:00 -04:00
Michael
06f7244280 New option to disable the fetching of parents 2022-08-04 19:32:36 +00:00
Roland Häder
8105668caf
Added missing 'private' field, see Processor::processContent() where it is needed 2022-08-04 10:50:44 +02:00
Michael
e82ef8890b Only process entries for existing posts 2022-08-03 05:14:07 +00:00
Michael
3463e34693 Don't always fetch parent posts 2022-08-03 04:51:57 +00:00
Michael
23ef4a99bb Changes after code review 2022-08-03 04:31:56 +00:00
Michael
f2eec66240 Hopefully fixes loops during message processing 2022-08-03 03:38:03 +00:00
Michael
c8d1bf4cdf Code standards and updated database documentation 2022-08-01 07:06:30 +00:00
Michael
81b244f91e Option to activate or deactivate the background fetching 2022-08-01 06:59:20 +00:00
Michael
f7ec8d5b8e Improved log message 2022-08-01 05:59:59 +00:00
Michael
7d5b4808cd Merge branch 'fetch' into fetch-cache 2022-08-01 05:57:59 +00:00
Michael
4be6e9a27d Cache if an activity has recently been fetched 2022-08-01 05:56:55 +00:00
Michael
6c7dfd6958 New table to control the fetching process 2022-08-01 04:48:49 +00:00
Michael
b6da15557b The post-reason / protocol is now filled in most cases 2022-07-31 15:54:35 +00:00
Michael
06a124338a Only store the inbox-queue on activated background processing 2022-07-31 08:10:47 +00:00
Michael
8b4bf890f8 Issue 11798: Handling of empty author 2022-07-30 05:30:08 +00:00
Michael
f6d11e8401 Issue 11800: Remove entry from queue in any case. 2022-07-30 04:43:18 +00:00
Michael
6383b07022 Don't add zero as receiver 2022-07-29 22:56:53 +00:00
Michael
f9bf2424b1 Merge remote-tracking branch 'upstream/develop' into post-reason 2022-07-29 21:29:15 +00:00
Michael
699152e15e Add more post reasons 2022-07-29 21:28:22 +00:00
Michael
0971bcf165 Make the tests happy 2022-07-29 16:05:04 +00:00
Michael
81aaacc67d Improvements for the "post-reason" 2022-07-29 14:17:53 +00:00
Roland Häder
95ac2aa54b
Fixed a possible NULL value (not valid, at least empty string) 2022-07-29 12:45:21 +02:00
Roland Häder
37bda3e5fb
Changes: 
- fixed wrong type-hint uid => int
- added returned type-hint
- added some documentation
- formatted arrays a bit
 2022-07-29 00:08:38 +02:00
Michael
b63ad63c29 Config for receiver / fix fatals 2022-07-28 21:16:42 +00:00
Michael
f0499e7269 Use negative caching 2022-07-28 20:25:38 +00:00
Michael
1aacff4ce1 Fix fatal error 2022-07-28 19:35:25 +00:00
Michael
d12c9a8f58 Caching for fetched activities 2022-07-28 19:05:04 +00:00
Michael
a27274b3b4 Avoid loops at deletion / decoupling for relay posts 2022-07-28 05:29:47 +00:00
Michael
3c71392f9e Avoid endless loop while deleting 2022-07-27 21:57:05 +00:00
Michael
505191dec5 Decouple the processor from the receiver 2022-07-27 20:59:42 +00:00
Michael
3af55de978 Issue 11776 - process replies via a worker task 2022-07-27 20:03:28 +00:00
Michael
86105635ca Improved message handling / new activity relay handling 2022-07-27 17:39:00 +00:00
Michael
b546173747 IMproved handling of untrusted posts 2022-07-24 21:58:09 +00:00
Michael
5ab94ea921 Option to store untrusted entries 2022-07-24 19:31:31 +00:00
Michael
51cc1f679f Added trust / isActivityGone 2022-07-24 14:26:06 +00:00
Michael
55b6a89c7c Optimizing 2022-07-24 13:49:57 +00:00
Michael
6abb4d40d6 Handle changed parents 2022-07-24 13:09:35 +00:00
Michael
06280aa5a3 Recursively delete failed worker tasks 2022-07-24 09:26:52 +00:00
Michael
073695b33c Funkwhale context file moved 2022-07-23 23:10:47 +00:00
Michael
6a19639ac2 Standards 2022-07-23 14:10:07 +00:00
Michael
5d6eb4670a We now store the conversation as well 2022-07-23 13:58:14 +00:00
Michael
abf39ff9cf Merge remote-tracking branch 'upstream/develop' into enqueue-posts 2022-07-23 12:55:34 +00:00
Michael
8c602071c2 Bookwyrm posts now work 2022-07-23 12:50:15 +00:00
Michael
7eb410bed7 Conversation/context is now stored 2022-07-23 06:52:43 +00:00
Michael
54cebf5a88 Remove test code 2022-07-21 12:42:26 +00:00
Michael
4c5e9f206e Remove ignored undo 2022-07-21 11:47:23 +00:00
Michael
99f7270e18 Improved workerqueue handling 2022-07-21 08:55:45 +00:00
Michael
4930e77eb3 We are now setting the corresponding worker id 2022-07-21 07:05:38 +00:00
Michael
28fb022425 Reset the recursion depth at a different place 2022-07-21 06:26:31 +00:00
Michael
c775833117 Use deferred tasks 2022-07-21 06:23:55 +00:00
Michael
d4a536137d database.sql updated, standards fixed 2022-07-21 05:42:53 +00:00
Michael
4a1fb1da12 Hourly process pending queue entries 2022-07-21 05:33:01 +00:00
Michael
1d13574225 Fetching of missing posts is reworked 2022-07-21 05:16:14 +00:00
Hypolite Petovan
650e05bcb5
Merge pull request #11758 from Quix0r/fixes/wrong-variable-name 
Fixed variable name + used empty()
 2022-07-20 07:55:38 -04:00
Roland Häder
4b5ae32ec6
Changes: 
- ops, fixed variable name (thanks to @annando)
- also used empty() for an empty array (and false/null)
 2022-07-20 11:54:28 +02:00
Michael Vogel
fc52296a77
Merge branch 'develop' into diaspora 2022-07-20 08:12:30 +02:00
Michael
138a15404f Fix processing of incoming Diaspora messages 2022-07-20 05:38:53 +00:00
Michael
7dcd02938d Remove entries from queue / relay detection 2022-07-20 05:37:40 +00:00
Roland Häder
1fbda27aad
Changes: 
- rewrote a lot local variables to an array and returned it instead of an
  anonymous array
- added more debug/warning logging in case something went wrong -> lesser guessing! ;-)
- changed double-quote to single
 2022-07-20 01:08:15 +02:00
Roland Häder
2ef0566ba5
Fixed: 
- "Undefined variable: contact in .../src/Protocol/Diaspora.php on line 4097
Trying to access array offset on value of type null in .../src/Protocol/Diaspora.php on line 4097"
- see https://github.com/friendica/friendica/issues/11632#issuecomment-1189465336
 2022-07-19 23:46:09 +02:00
Michael
ce38e63399 Add and delete entries 2022-07-18 14:03:49 +00:00
Michael
2f462ffa16 Store incoming posts in a queue 2022-07-18 03:31:00 +00:00
Philipp
6175f9086e
Merge pull request #11747 from annando/fixes 
Emergency fixes to fix a bunch of fatal errors
 2022-07-17 16:34:53 +02:00
Michael
6882e70024 Match the documentation 2022-07-17 13:00:34 +00:00
Michael
2ddf37f32d Emergency fixes to fix a bunch of fatal errors 2022-07-17 11:47:12 +00:00
Roland Häder
cb7f52cc6a
Fixed: 
- $item is the proper array here,
- see https://github.com/friendica/friendica/issues/11632#issuecomment-1186119430
 2022-07-16 12:19:09 +02:00
Hypolite Petovan
74991d1f95 Fix type hint typo in Protocol\Email::messageGetPart 
- Address https://github.com/friendica/friendica/issues/11724
 2022-07-11 23:05:13 -04:00
Hypolite Petovan
eb8237dd89 Remove unused uid parameter in Item::newURI 2022-07-09 07:39:51 -04:00
Roland Häder
bf809c9d57
Fixed: 
> TypeError: "Argument 2 passed to Friendica\Protocol\ActivityPub\Transmitter::sendContactReject()
> must be of the type int, string given

I followed here here the documentation, may fix #11708
 2022-07-06 05:43:00 +02:00
Hypolite Petovan
181c142bb4 Remove overly strict type-hint in ActivityPub\Transmission::createCachedActivityFromItem 
- Fix "Return value of Friendica\Protocol\ActivityPub\Transmitter::createCachedActivityFromItem() must be of the type array, bool returned" error
 2022-07-02 22:16:59 -04:00
Philipp
e594656a48
Merge pull request #11684 from MrPetovan/bug/11651-ap-fetch-queue 
Create ActivityPub\FetchQueue and ActivityPub\FetchQueueItem classes
 2022-06-26 13:36:19 +02:00
Hypolite Petovan
91f5a7cc6b Convert potential spaces in Memcache(d) key names 
- Address https://github.com/friendica/friendica/issues/11630#issuecomment-1166475036
- Add test for space in cache keys
 2022-06-26 07:30:30 -04:00
Hypolite Petovan
da32fa8fa6 Create ActivityPub\FetchQueue and ActivityPub\FetchQueueItem classes 
- These classes are used to flatten the recursive missing activity fetch that can hit PHP's maximum function nesting limit
- The original caller is responsible for processing the remaining queue once the original activity has been fetched
 2022-06-25 12:40:54 -04:00
Roland Häder
88870d18be
Changes: 
- added some type-hints
- added documentation
 2022-06-25 16:48:36 +02:00
Roland Häder
b0693c1ad7
Reformatted array 2022-06-25 16:48:35 +02:00
Roland Häder
82bb36e13d
Changes: 
- Made Item::guidFromUri()'s $host parameter optional (allowing null)
- added some type-hints
- added documentation
- this may fix reported issue in #11630
 2022-06-24 03:17:57 +02:00
Roland Häder
fd8f4269ff
Reformatted code 2022-06-23 17:30:17 +02:00
Roland Häder
3f74a59f73
Added some type-hints 2022-06-23 17:30:14 +02:00
Roland Häder
0ddb315b23
$id in Transmitter::sendContactAccept() is a string, see Introduction class 2022-06-23 16:48:00 +02:00
Roland Häder
636fef26f1
Maybe this fixes missing array element 2022-06-23 07:40:49 +02:00
Roland Häder
7eefb9aed8
Changed: 
- empty() is maybe superflous here, still I would prefer a code style that is
  written explicitly and not rely on "magic casting"
 2022-06-22 18:57:01 +02:00
Roland Häder
b996712ef7
Images::getInfoFromURL[Cached]() will both return empty arrays on error and 
that needs to be reflected here, too.
 2022-06-22 17:20:59 +02:00
Roland Häder
101cd2dd10
Changes: 
- added some documentation
- fixed some documentation
- changed more double-quotes to singl
 2022-06-22 16:14:14 +02:00
Roland Häder
ba45e59313
Changes: 
- added more type-hints
- added missing documentation
- Email::send() now returns what mail() returns (bool)
 2022-06-22 14:36:48 +02:00
Roland Häder
2dd7d465e8
Changes: 
- added more type-hints
- updated documentation
- changed double-quotes to single
 2022-06-22 14:36:47 +02:00
Roland Häder
74ab7648c6
Changes: 
- addHubLink()'s 2nd parameter is DOMElement
- added more type-hints
- converted double-quotes to single
 2022-06-22 14:36:46 +02:00
Roland Häder
abd0d9f3fd
Changes 
- added type-hints
- added some documentation
- added default: block for unknown 'rel' value
- changed return type void to empty array
 2022-06-22 14:36:45 +02:00
Roland Häder
77c37ff2db
Fixed: 
- Uncaught Exception TypeError: "Argument 3 passed to
  Friendica\Protocol\DFRN::createActivity() must be of the type string, null
  given, called ..."
 2022-06-21 13:47:37 +02:00
Roland Häder
95f9eb34ac
Fixed indenting 2022-06-21 01:29:33 +02:00
Roland Häder
fbae0b8bcf
Changes: 
- renamed ItemArrayFromMail() to getItemArrayFromMail() to follow naming-convetion
- added missing type-hints
- added missing documentation
 2022-06-20 21:22:46 +02:00
Roland Häder
ea22e88896
Added documentation 2022-06-20 21:02:34 +02:00
Roland Häder
752953e472
Changes: 
- as @MrPetovan pointed out, $actor can be NULL earlier and used later as NULL
- added some missing type-hints
- added missing documentation
- the added @TODO points out to avoid true|false|null for a boolean
 2022-06-20 21:00:19 +02:00
Roland Häder
0c12e947dd
Changes: 
- null was 2nd argument's value before, an empty string is basically the same here
 2022-06-20 20:01:59 +02:00
Roland Häder
4fb03cf163
Changes: 
- fixed a null value handled over to Friendica\Model\APContact::getByURL()
- added missing type-hints
 2022-06-20 19:05:02 +02:00
Roland Häder
a0c8fc6d6e
Changes: 
- added more type-hints
 2022-06-20 02:48:02 +02:00
Roland Häder
d276f2c62b
Changes: 
- added type-hints
- changed some double-quotes to single
 2022-06-20 01:00:29 +02:00
Roland Häder
41f34c4261
Maybe fix for: 
"Argument 1 passed to Friendica\Model\ItemURI::getIdByURI() must be of the type string, null given, called in Processor.php line 1219"
 2022-06-18 18:30:50 +02:00
Roland Häder
7cbb818c93
Set type-hint for parameter $data to SimpleXMLElement as $fields in dispatch() 
is the same and being handled over.
 2022-06-18 05:19:24 +02:00
Roland Häder
89302d0843
Some outside code relies on returned "false" 2022-06-18 05:06:18 +02:00
Roland Häder
aaf5c323b6
Fixed indenting 2022-06-18 05:04:14 +02:00
Roland Häder
adb4aea6ad
Changes: 
- added some type-hints
- replaced most double-quotes (only Diaspora.php, later more) with single
- added some documentation
- normalized indenting in Diaspora.php (I hope I got all?)
 2022-06-18 05:03:10 +02:00
Roland Häder
a770634b95 Ops, wrong type 2022-06-17 17:18:31 +02:00
Roland Häder
36d56a4041 Continued: 
- changed back to 'return false;' as other methods heavily rely on false instead
  of an empty array as pointed out by @heluecht@pirati.ca
- $fetched_contact should be initialized as an empty array, let's not make this
  code more crazier than it already is (see APContact::getByURL())
 2022-06-17 17:18:31 +02:00
Roland Häder
605e7d55b3 Continued: 
- added more type-hints
- some methods in Diaspora returned void but integer was documented so I
  changed it to -1 to have a proper type-hint
 2022-06-17 17:18:31 +02:00
Roland Häder
0c9aff8a09 Also need to declare $profile or otherwise an invocation of 
Receiver::getReceiverForActor() will fail.
 2022-06-17 17:18:31 +02:00
Roland Häder
5c9ce790bf Fixed: 
- $object_data['actor'] can be null, but Receiver::getReceivers()'s 2nd
  parameter expect it to be string
 2022-06-17 17:18:31 +02:00