Commit graph

2734 commits

Author SHA1 Message Date
Roland Häder
36d56a4041 Continued:
- changed back to 'return false;' as other methods heavily rely on false instead
  of an empty array as pointed out by @heluecht@pirati.ca
- $fetched_contact should be initialized as an empty array, let's not make this
  code more crazier than it already is (see APContact::getByURL())
2022-06-17 17:18:31 +02:00
Roland Häder
c467bff79f Some more type-hints added 2022-06-17 17:18:31 +02:00
Roland Häder
4f3321cc9f Nore fixes 2022-06-17 17:18:31 +02:00
Roland Häder
10bb7d5625 Possible fix for
Uncaught Exception TypeError: "Return value of
Friendica\Model\APContact::getByURL() must be of the type array, bool returned"
2022-06-17 17:18:31 +02:00
Roland Häder
fdd237a090 Fix for "Uncaught Exception TypeError: "Argument 1 passed to
Friendica\Model\APContact::unarchiveInbox() must be of the type string, null
given" error message
2022-06-17 17:18:31 +02:00
Roland Häder
605e7d55b3 Continued:
- added more type-hints
- some methods in Diaspora returned void but integer was documented so I
  changed it to -1 to have a proper type-hint
2022-06-17 17:18:31 +02:00
Roland Häder
227bab43a8 Ops, wrong type-hint here, must be string ($nickname can never be an integer). 2022-06-17 17:18:31 +02:00
Roland Häder
e484b6d6dc Continued:
- added more type-hints
- added some documentation
- Contact::getAccountType() should only process string, not null
2022-06-17 17:18:31 +02:00
Roland Häder
45b5f67bca Fix for non-existing record system.mobile_theme in config table 2022-06-17 17:18:31 +02:00
Roland Häder
33768ea1c6 Some fixes:
- $gsid's default value cannot sadly be 0, it now must be null to allow some
  code work
- added some more type-hints
- documented a bit more
2022-06-17 17:18:31 +02:00
Roland Häder
7560dccc08 Added again more type-hints 2022-06-17 17:18:31 +02:00
Roland Häder
40d7f29a11 Continued:
- more type-hints
- fixed incompatible method declarations
2022-06-17 17:18:31 +02:00
Roland Häder
c2e889cfae Added more type-hints 2022-06-17 17:18:31 +02:00
Roland Häder
0e1f734b03
Also make this null-coalscing 2022-06-16 17:35:01 +02:00
Roland Häder
f2b7326650
This will 2 things:
1) The first change prevents "expensive" code in HTML::toBBcode() to be executed
   just for an empty string which makes no sense.
2) The above change was maybe flawed as $apcontact['about'] would have never
   been created, not even empty which could have side effects

Thanks to @annando to make me rethink this part of code.
2022-06-16 16:54:50 +02:00
Roland Häder
b1e4c0931a
Fixes and type-hints:
- added more checked type-hints as they prevent bad method invocations
- fixed TypeError for HTML::toBBCode() invocations with NULL as first (wrong)
  argument, thanks to @tobias@social.diekershoff.de pointing this out.
2022-06-16 16:54:49 +02:00
Roland Häder
5fa954208a
Changes:
- ops, wasn't actually fixing `return;` to proper `return '';`
- added more type-hints
- added TODO ($uid is unused)
2022-06-15 22:28:33 +02:00
Roland Häder
a3fa95e8e4
Changes:
- added more type-hints
- changed `return;` to `return '';` when `string` was requested as returned type-hint
  (thanks to @MrPetovan)
2022-06-15 22:05:38 +02:00
Roland Häder
34aee64349
Added more type-hints
Signed-off-by: Roland Häder <roland@mxchange.org>
2022-06-15 21:52:51 +02:00
Roland Häder
143e4c4a18
Added more known type-hints
Signed-off-by: Roland Häder <roland@mxchange.org>
2022-06-15 21:52:50 +02:00
Michael
b816ae4db5 Some more default avatars 2022-06-13 20:07:54 +00:00
Michael
70b9a8114d Improve license comment 2022-06-13 10:30:21 +00:00
Michael
d9fb081db9 Using separate avatars for different peertube account types 2022-06-13 10:27:46 +00:00
Michael
c1a64b77c0 Improved license text 2022-06-13 10:03:34 +00:00
Michael
e0a0c57c44 Use platform specific default avatar pictures 2022-06-13 05:18:54 +00:00
Michael
57b8708425 Issue 11566: More detailled notification configuration 2022-06-05 11:41:08 +00:00
Michael
4108704ee3 Fix: Only public posts can be pinned 2022-06-04 06:11:32 +00:00
Hypolite Petovan
7f711e266f Assume unsettable system.always_my_theme pconfig value is always true
- This was a logged in user setting so it assumes false for anonymous users
2022-05-29 16:13:49 -04:00
Hypolite Petovan
220703575c
Merge pull request #11577 from annando/issue-11557
Issue 11557: Update all local contacts
2022-05-29 15:53:21 -04:00
Michael
540b3f892b Issue 11557: Update all local contacts 2022-05-29 17:48:09 +00:00
Michael
42d3e5c1ce Issue 11488: Don't search for mentions in shared posts 2022-05-29 16:07:53 +00:00
Michael
1dccc31508 Issue 11469: Repect desktop notification settings 2022-05-29 09:20:06 +00:00
Michael
4ef7f42257 Issue 11470: Check for removed account 2022-05-28 16:21:41 +00:00
Michael
0a43fe857c Pass the "force" parameter to the avatar update 2022-05-27 05:36:07 +00:00
Hypolite Petovan
488fdd9791
Merge pull request #11558 from annando/public-contact
Ensure that the public contact exists before adding a user contact
2022-05-25 09:06:13 -04:00
Michael
918c1eeb56 Check for phantom network 2022-05-25 11:46:58 +00:00
Michael
f5d69b3b6a Ensure that the public contact exixts before adding a user contact 2022-05-25 11:43:29 +00:00
Michael
0ff8ca8053 Trim the rid 2022-05-24 17:39:02 +00:00
Michael
49dab14215 Only use proxied image links with images 2022-05-21 06:58:26 +00:00
Michael
49c47008d1 Convert class calls into DI calls 2022-05-19 09:08:04 +00:00
Tobias Diekershoff
b18880221a
Merge pull request #11531 from annando/display-polls
Improved poll texts for different conditions
2022-05-18 08:16:41 +02:00
Michael
0b50dc363b Caching of "noscrape" 2022-05-17 15:39:04 +00:00
Michael
c3fd8b39aa Caching for profiles removed 2022-05-17 12:53:31 +00:00
Michael
4e3e9dc763 Cache the profile as well 2022-05-17 12:46:55 +00:00
Michael
75534fa3f3 Fix warning " Trying to access array offset on value of type bool" 2022-05-17 12:38:39 +00:00
Michael
73019284ce Increase cache lifespan / clear cache upon changes 2022-05-17 12:32:25 +00:00
Michael
10cdefa232 Fix: Fetch media in shared posts 2022-05-17 07:58:41 +00:00
Michael
4daae255d8 Performance: Avoid queries where there is no media or category 2022-05-16 17:06:58 +00:00
Michael
62a1cf257e Improved poll texts for different conditions 2022-05-16 06:04:46 +00:00
Michael
2dc9b4eda2 Vote text changed 2022-05-16 05:31:53 +00:00