Commit graph

1758 commits

Author SHA1 Message Date
Tobias Diekershoff
0d1fa70e2e
Merge pull request #9039 from MrPetovan/task/frio-accent-scheme
[frio] Add accented schemes including dark scheme and black scheme
2020-08-20 07:01:40 +02:00
Hypolite Petovan
91a1e5df91 Add more references to theme.php 2020-08-19 22:54:12 -04:00
Michael
d9fc0ae0ea Using a constant value for the default avatar 2020-08-18 20:30:24 +00:00
Michael
2cae485e0d Don't show poll frequency on auto adjust 2020-08-17 17:40:31 +00:00
Michael Vogel
dfa177e940
Merge pull request #8986 from MrPetovan/task/8918-move-mod-common
Reduce page size in contacts pages
2020-08-11 13:45:02 +02:00
Michael
2c97e2190b Merge remote-tracking branch 'upstream/develop' into ap-forum 2020-08-10 14:00:17 +00:00
Michael
bf7128b4b2 AP Improvements for forums 2020-08-09 18:42:25 +00:00
Hypolite Petovan
3d3ad07385 Enable profile contacts page for profile owner 2020-08-09 09:09:38 -04:00
Hypolite Petovan
e57449ee35 Reduce page size in contacts pages 2020-08-07 21:18:25 -04:00
Michael Vogel
f0a0c6b822
Merge pull request #8982 from MrPetovan/task/8918-move-mod-common
Move mod/common.php to src/ Part 3: Add Module\Contact\Contacts class
2020-08-07 20:51:02 +02:00
Hypolite Petovan
e64dcc5b5b Remove obsolete modules common and allfriends
- Delete obsolete Model\GContact class
2020-08-06 22:59:10 -04:00
Hypolite Petovan
18cd4f7412 Add new contact/{id}/contacts[/{type}] route and module
- Rework contact pages tabs
- Add constants for active contact page tab
2020-08-06 22:59:09 -04:00
Hypolite Petovan
383ddb10ed Create new page_tabs template
- Replace explicit tabs in profile contacts page with new template
2020-08-06 22:59:09 -04:00
Hypolite Petovan
f5ea07c731 Remove unused App parameter from Module\Contact::getTabsHTML 2020-08-06 22:59:09 -04:00
Michael
c89b690156 Removed unused parameter 2020-08-06 19:04:00 +00:00
Michael
f09d9bc9cc Remove url caching, locking cleanup 2020-08-06 18:53:45 +00:00
Michael Vogel
1fb47b96aa
Merge pull request #8975 from MrPetovan/task/8918-move-mod-common
Move mod/common.php to src/ Part 2: Add Module\Profile\Common class
2020-08-05 23:17:12 +02:00
Hypolite Petovan
c26b72a426 Rework commonFriendsVisitor widget
- Use new Contact\Relation method to fetch common contacts
- Replace reference to /common by /{nickname}/contacts/common
2020-08-05 00:19:48 -04:00
Michael
018abb4d1d Renamed function 2020-08-05 03:36:37 +00:00
Hypolite Petovan
71db6ab613 Add Module\Profile\Common class
- Add Common tab in profile contacts templates
- Add routing to new module
2020-08-04 23:03:54 -04:00
Hypolite Petovan
1723903219 Rework Module\Profile\Contacts class
- Simplify imports
- Use router parameters
- Use exceptions
- Simplify querying and result processing
- Add no result label
2020-08-04 23:02:43 -04:00
Hypolite Petovan
4c5fe20018 Remove relationship direction display for non-local user contacts
- [frio] Add profile link on avatar in contact_template
2020-08-04 23:00:15 -04:00
Michael
1d44e544cf New class for group related contact actions 2020-08-04 18:22:19 +00:00
Hypolite Petovan
73c112066d
Merge pull request #8971 from annando/optimize
Periodically  run an "optimize table" command for cache tables
2020-08-04 12:43:28 -04:00
Hypolite Petovan
c6f2ed667d
Merge pull request #8970 from annando/user-contact
"Contact\User" class created
2020-08-04 12:13:18 -04:00
Michael
d153db44ac Periodically run an "optimize table" command for cache tables 2020-08-04 12:24:24 +00:00
Michael
a20887a78e Test message removed 2020-08-04 05:46:00 +00:00
Michael
041a96555b Contact search is fixed 2020-08-04 05:44:38 +00:00
Michael
a7d75702cc "Contact\User" class created 2020-08-04 04:47:02 +00:00
Michael
0c4a3330dd Use the public contact 2020-08-03 19:47:46 +00:00
Michael
4e90029234 Adding $fields 2020-08-03 19:38:03 +00:00
Michael
14bb6daa5d "Allfriends" now work again 2020-08-03 19:21:31 +00:00
Michael
ee1cb93f3a Use the new relation functions 2020-08-03 18:21:56 +00:00
Michael
879c30d4fa Merge remote-tracking branch 'upstream/develop' into contact-tabs 2020-08-03 18:00:51 +00:00
Hypolite Petovan
a74c547af4 Move ContactRelation class to Contact\Relation
- Update references in GContact
2020-08-03 13:38:26 -04:00
Hypolite Petovan
24a82110fd Add common relationship methods to Model\ContactRelation
- Introduce DBA::mergeConditions method
- Replace GContact relationship method contents with Model\ContactRelation method calls
2020-08-03 13:34:10 -04:00
Michael
91c360638a Ensure contact tabs will use the correct id 2020-08-02 13:34:49 +00:00
Michael
bb1517a74c Random profiles now moved away from "gcontact" as well 2020-08-02 08:07:31 +00:00
Michael
03e2cbbf3d Merge remote-tracking branch 'upstream/develop' into remove-poco 2020-08-02 01:28:47 +00:00
Michael
0c73531da1 Poco and gcontact (mostly) removed 2020-08-01 16:15:18 +00:00
Michael
2976211992 Add "Nextcloud" to the statisrics 2020-08-01 09:26:41 +00:00
Michael
d9a9876ddd Synchronize contacts with the directory server 2020-07-31 09:08:51 +00:00
Hypolite Petovan
2b9ef97adc
Merge pull request #8952 from annando/contact-template
Use a single function to create the template data for contacts
2020-07-31 03:26:51 -04:00
Michael
71415094cb Removed unused template variables 2020-07-31 06:00:43 +00:00
Michael
45aff10ff8 Replaced with general function 2020-07-31 04:50:24 +00:00
Michael
ce7f192f35 "id" is not needed as a parameter 2020-07-31 04:28:26 +00:00
Michael
a4b5536d17 The local directory is now using the template function as well 2020-07-31 04:19:20 +00:00
Michael
893f6bd692 Use the function from the contact template instead 2020-07-31 03:55:01 +00:00
Hypolite Petovan
869329c972
Merge pull request #8948 from annando/remove-gcontact
Replace "gcontact" with "contact" - improved suggestions
2020-07-30 21:25:22 -04:00
Michael
91b0f2c486 Use a single function to create the template data for contacts 2020-07-30 21:16:15 +00:00
Michael
cc85bc4156 Replace "gcontact" with "contact" - imroved suggestions 2020-07-30 14:08:32 +00:00
Michael
e06d9f20cf AP: Always sign requests 2020-07-29 05:12:16 +00:00
Michael
71b6226909 Some more avatar function replacements 2020-07-28 19:30:55 +00:00
Michael Vogel
701dbdf7fc
Merge pull request #8939 from MrPetovan/task/8906-frio-viewas-redesign
Move "View As" form at the bottom of the profile page
2020-07-28 18:00:17 +02:00
Hypolite Petovan
ab3106a129 Move "View As" form at the bottom of the profile page 2020-07-28 11:40:14 -04:00
Michael
d5a3ef6c2a Removed unused "use" 2020-07-28 15:04:39 +00:00
Michael
b79bb0d2cb Fetch photo fields, ensuring that they are filled 2020-07-28 12:58:19 +00:00
Michael Vogel
3f77bf52f9
Merge pull request #8930 from MrPetovan/task/4090-move-lockview-to-src
Move mod/lockview to Module\PermissionTooltip
2020-07-27 22:06:55 +02:00
Hypolite Petovan
2497d36030 Remove unnecessary parent call in PermissionTooltip::rawContent 2020-07-27 15:54:36 -04:00
Michael
5b884e8348 Changed function name 2020-07-27 10:22:02 +00:00
Michael
6ab82eaa49 Ensure that cached avatar fields are set 2020-07-27 10:11:12 +00:00
Hypolite Petovan
d7b5674476 Move mod/lockview to Module\PermissionTooltip
- Add explicit type parameter to lockview() in main.js
2020-07-27 01:58:53 -04:00
Michael
18617f6c48 Fetch followers/followings of contacts 2020-07-26 07:34:33 +00:00
Michael
9b86f40a5f Store avatar cache fields only when needed 2020-07-25 11:48:52 +00:00
Michael Vogel
398e65d66b
Merge pull request #8911 from MrPetovan/task/curl_DI
Introduce "HTTPRequest" class
2020-07-25 09:50:20 +02:00
Michael
cb830c9ad3 Translation function added 2020-07-23 06:32:31 +00:00
Michael
0007da8630 EOL removed 2020-07-23 06:25:01 +00:00
Michael
3fc3ded750 Useless info messages removed 2020-07-23 06:11:21 +00:00
nupplaPhil
657d08f09f Rename "fetchUrl" and "fetchUrlFull" to "fetch" and "fetchFull" 2020-07-21 03:15:53 -04:00
nupplaPhil
7029012f27 Rename "HTTPRequest::curl()" to HTTPRequest::get() 2020-07-21 03:14:01 -04:00
nupplaPhil
1aa07f87a4 Make "HTTPRequest::fetchUrl" dynamic 2020-07-21 03:04:58 -04:00
nupplaPhil
2973ed6448 Make "HTTPRequest::curl" dynamic 2020-07-21 03:01:12 -04:00
nupplaPhil
5344efef71 Move post/curl/fetchUrl/fetchUrlFull to own class "Network\HTTPRequest" 2020-07-21 02:56:10 -04:00
Hypolite Petovan
0a71495fa4 Add new admin debug module for ActivityPub 2020-07-20 00:39:17 -04:00
Michael
5bf813d0ec Use "failed" field 2020-07-19 11:42:23 +00:00
Michael Vogel
ea8965759e
Merge pull request #8893 from MrPetovan/task/8797-strip-label-shortened-url
Add shortened URL link label stripping to PageInfo::stripTrailingUrlFromBody
2020-07-18 18:06:01 +02:00
Hypolite Petovan
25b3fa83fc Rename PageInfo::appendToBody to searchAndAppendToBody 2020-07-17 19:15:43 -04:00
Hypolite Petovan
da50456675 Add Twitter source debug to Debug\Babel 2020-07-17 17:14:13 -04:00
Michael
ecf6018b89 Atom feed generation is moved to the feed class 2020-07-17 04:40:20 +00:00
Michael
d6bf7f2cda Replace "Probe::uri" with "Contact::getByURL" 2020-07-16 10:22:14 +00:00
Michael
b8682190de Fix fallback on unknown contact 2020-07-16 04:18:33 +00:00
Michael
b0086a49e2 in "getidforurl" "no update" is now "update" 2020-07-15 21:08:42 +00:00
Hypolite Petovan
631095eefd
Merge pull request #8883 from annando/replace-getdetails
Replaced "getDetailsByURL" with "getByURL/getByURLForUser"
2020-07-15 13:49:27 -04:00
Michael
6d3949d54a Changed default value 2020-07-15 17:29:52 +00:00
Michael
e374aecc46 Changed parameter order for "getbyURLForUser" 2020-07-15 17:22:12 +00:00
Michael
fc0312451d Changed parameter order for getByURL 2020-07-15 17:06:48 +00:00
Michael
d9c6a46ffe Replaced "getDetailsByURL" with "getByURL/getByURLForUser" 2020-07-15 04:42:04 +00:00
Hypolite Petovan
3e25fc3a72 Replace *_page_info function calls with Content\PageInfo equivalent 2020-07-14 10:15:04 -04:00
Michael
baea99dee6 Unneeded variable removed 2020-07-13 14:16:44 +00:00
Michael
5a6887fb2e Use "jsonexit" 2020-07-13 13:26:09 +00:00
Michael
27deb4d188 Module classes splitted 2020-07-13 09:45:45 +00:00
Michael
2a1e6e1a74 Support Nodeinfo2 2020-07-12 21:53:17 +00:00
Hypolite Petovan
090fa78057
Merge pull request #8862 from annando/issue-8860
Issue 8860: Activities weren't fetchable all the time
2020-07-11 14:14:03 -04:00
Hypolite Petovan
e91daf8f46 Add logging for unexpected Search::searchGlobalContact return in Module\Search\Acl 2020-07-11 09:19:22 -04:00
Hypolite Petovan
2af20ea17a Fix wrong condition in Diaspora\Fetch 2020-07-11 09:18:42 -04:00
Michael
63dc6950d4 Issue 8860: Activities weren't fetchable all the time 2020-07-11 07:15:54 +00:00
Hypolite Petovan
ad66a92deb Add check for $a->profile structure in Module\HoverCard 2020-07-09 15:09:07 -04:00
Hypolite Petovan
1f0b7690eb Add error handling in Module\Profile\Status
- Address part of https://github.com/friendica/friendica/issues/8475#issuecomment-653912096
2020-07-08 09:49:39 -04:00
Hypolite Petovan
f2adec6a7f Add error handling in Module\Xrd
- Address part of https://github.com/friendica/friendica/issues/8475#issuecomment-653912096
2020-07-08 09:14:34 -04:00
Hypolite Petovan
9c6fbc6a74 Update references to the friendica/friendica stable branch 2020-06-30 15:25:16 -04:00
Michael
c947b7f211 "print_r" in logging replaced / obsolete stuff removed 2020-06-29 20:22:00 +00:00
Michael Vogel
77e0d8c7bc
Merge pull request #8821 from MrPetovan/bug/fix-item-source-route
Improve Module\Admin\Item\Source
2020-06-28 14:02:25 +02:00
Hypolite Petovan
7d726dbb0c Improve Module\Admin\Item\Source
- Use router parameter
- Accept full URLs with GUID in form
- Fix 500 error when item with guid doesn't exist
2020-06-28 07:51:17 -04:00
Hypolite Petovan
50d05cec83 Ensure url property of Probe::uri result is used authoritatively
- Some profile URLs aren't canonical and need to be updated during probe
2020-06-26 12:52:39 -04:00
Hypolite Petovan
06b992a5dd Add expected whitespace before Widget::unavailableNetworks() output in Module\Contact 2020-06-24 18:49:55 -04:00
Hypolite Petovan
4e7c45f835 Add PageInfo result panels to Debug\Babel 2020-06-17 13:24:44 -04:00
Michael Vogel
c5e5defc29
Update src/Module/Admin/Site.php
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2020-06-16 14:37:36 +02:00
Michael
016c99935c Different comment limits for single view 2020-06-16 06:49:53 +00:00
Michael Vogel
f10062dfdb
Merge pull request #8617 from MrPetovan/task/8220-twitter-followers-list
(Re)Implement Twitter contact API endpoints
2020-06-14 16:06:22 +02:00
Hypolite Petovan
a5a7855d39 Remove dependency to App in Contact::createFromProbe
- Address https://github.com/friendica/friendica/issues/8473#issuecomment-641259906
2020-06-10 10:36:42 -04:00
Hypolite Petovan
5f18d27b0b
Merge pull request #8752 from annando/posts-from-id
Avoid unneeded database calls when showing posts of contacts
2020-06-10 00:11:51 -04:00
Michael
0e9331a1ff Avoid unneeded database calls when showing posts of contacts 2020-06-09 22:38:06 +00:00
Hypolite Petovan
8111ede2e5 Add support for max_id parameter in new Twitter contact API endpoints
- Use filter_input instead of manual type casting
2020-06-09 08:36:53 -04:00
Hypolite Petovan
7a5afc10bb Implement Twitter contact endpoints
- Implement /followers/ids
- Implement /followers/list
- Reimplement /friends/ids
- Reimplement /friends/list
- Update API reference
- Remove obsolete tests
2020-06-09 08:36:46 -04:00
Hypolite Petovan
76460ddd2d Add tag escaping to Item::setHashtags
- Add return value to Item::setHashtags
2020-06-08 18:40:21 -04:00
Hypolite Petovan
8eeb7807d3 Replace remaining instances with "allowlist", "denylist" and "blocklist" 2020-06-07 11:24:56 -04:00
Hypolite Petovan
34463f37e4 Rename contact table column to ffi_keyword_denylist 2020-06-07 11:24:52 -04:00
Hypolite Petovan
1304e14572 Exit with an error if profile info isn't available in Module\NoScrape 2020-06-05 14:28:11 -04:00
Michael
e379698227 Issue 8675: reduce requests of foreign pages 2020-06-01 21:52:31 +00:00
Michael Vogel
235f4eaa89
Merge pull request #8697 from MrPetovan/task/8691-like-links-one-way
Make like links one way
2020-05-29 15:33:24 +02:00
Michael
db907c2ff8 Issue 8700: Resolvable activities 2020-05-27 19:05:33 +00:00
Hypolite Petovan
2d217129b9 Improve performance of asynchronous like/update
- Make the like module return earlier instead of outputting a full empty HTML page
- Update the force_update variable earlier to prevent spilling on multiple unrelated nav update calls
2020-05-27 08:41:10 -04:00
Michael Vogel
e315bc3eae
Merge pull request #8657 from MrPetovan/bug/8653-catch-template-engine-errors
Catch template engine errors
2020-05-19 00:22:45 +02:00
Hypolite Petovan
346f99b877 Add new TemplateEngine->testInstall method
- Add admin summary template engine error messages
2020-05-18 01:20:47 -04:00
Michael
a3c4021f12 Issue 8514: Make paging for searcg items work again
Fixes #8514
2020-05-17 13:51:56 +00:00
Michael
0cf517ad76 Use constants for the BBCode modes 2020-05-16 16:28:15 +00:00
Michael
7a82171bfe The "term" table is removed 2020-05-15 06:50:20 +00:00
Hypolite Petovan
75977ee72b Remove remaining references to cirtual field item.tag 2020-05-13 22:35:13 -04:00
Hypolite Petovan
ccb69414d2 Combine getFollowers and getFollowing into getContacts in ActivityPub\Transmitter 2020-05-05 22:32:45 -04:00
Hypolite Petovan
f7a45e4153
Merge pull request #8577 from annando/no-term2
File and category aren't using "term" anymore
2020-05-05 13:45:48 -04:00
Michael
d67b9cb693 Formula according to documentation 2020-05-05 16:01:20 +00:00
Michael
7de6e60328 Merge remote-tracking branch 'upstream/develop' into issue-8550 2020-05-05 15:56:24 +00:00
Michael
875d6b36e9 File and category aren't using "term" anymore 2020-05-03 15:13:40 +00:00
Michael
74081a71ff Removed unused "use" 2020-05-01 13:26:13 +00:00
Michael
ede69a8673 Function renamed 2020-05-01 13:13:58 +00:00
Michael
ac2957c4dd Some more "term" to "tag" conversion 2020-05-01 10:57:32 +00:00
Michael
8602bbb3b9 "term" replaced with "tag" 2020-05-01 08:02:21 +00:00
Michael
6487daa4a9 Issue 8550: Check for a good table_definition cache value 2020-04-29 06:28:06 +00:00
Michael
8c44f535b7 Merge remote-tracking branch 'upstream/develop' into write-tags 2020-04-29 02:38:33 +00:00
Michael
6f3b46217e Fix for "Undefined index: profile_url" 2020-04-28 19:36:10 +00:00
Michael
70e5639e29 Merge 2020-04-28 13:33:03 +00:00
Michael
c2a9b3b9e9 Usage of the new tag tables 2020-04-28 11:52:51 +00:00
Michael
5367620467 Merge remote-tracking branch 'upstream/develop' into write-tags 2020-04-28 08:03:26 +00:00
Michael
e52e505a48 Merge 2020-04-28 08:00:38 +00:00
Michael
f75009c20c Some more forgotten DBA::close 2020-04-28 07:10:18 +00:00
Michael
0c4dde8e68 Fix issue 8551: Last item is now displayed again 2020-04-28 05:22:29 +00:00
Michael
7f5f68a904 More preparations for term to tag transition 2020-04-26 16:15:39 +00:00
Michael
5df5e9521b The tag table is now really used 2020-04-26 15:24:58 +00:00
Michael
7d111e2a6f Duplicated fields renamed 2020-04-25 07:29:02 +00:00
Michael
cf0d36737f Removed query for "updated" in gcontact 2020-04-24 15:18:34 +00:00
Michael
02aed490e2 Owner-view added 2020-04-24 11:04:50 +00:00
Hypolite Petovan
43b8bdea07
Merge pull request #8520 from annando/term2tag
We now store tags in "tag"
2020-04-22 22:56:07 -04:00
Michael Vogel
ee098277b9
Merge pull request #8530 from MrPetovan/task/8498-move-poke-to-src
Move poke module to src/
2020-04-21 05:56:59 +02:00
Hypolite Petovan
8cc11d6033 Update log string in Module\Contact\Poke 2020-04-20 18:02:23 -04:00
Hypolite Petovan
7f04aea8b1 Move poke module to src/
- Add new route contact/<cid>/poke and update all references
- Rework template with form field includes
- [frio] Enable modal behavior
2020-04-20 11:47:08 -04:00
Michael
661dd43b0d Term constants updated 2020-04-13 19:24:22 +00:00
Hypolite Petovan
af817b2ad5 Add cache and CORS headers to ActivityPub endpoints 2020-04-05 18:02:38 -04:00
Hypolite Petovan
1e32f74b0b Rework Module/Objects
- Merge two item queries into one
- Add ETag check
- Use Router parameter
2020-04-05 18:00:46 -04:00
Hypolite Petovan
6bb210ff7a Refactor features pages
- Create frio template for admin features page
- Fix header hierarchy
2020-04-01 19:06:10 -04:00
Hypolite Petovan
fd89572606 Refactor admin site settings templates
- Fix header hierarchy in admin/site.tpl
- Fix panel display in frio/templates/admin/site.tpl
2020-04-01 19:06:10 -04:00
Michael
01c6179feb Check for Antelope and convert to Barracuda 2020-04-01 18:11:06 +00:00
Michael
d3722c945b Improved Mime Type detection 2020-04-01 05:42:44 +00:00
Steffen K9
154109f9ee
remove default from welcome.php 2020-03-29 11:36:04 +02:00
Michael Vogel
3ca88f53ec Fixes "Undefined index: object" 2020-03-28 22:37:03 +01:00
Michael Vogel
fcb0fa4cfa Fix: Fetching content via the "objects" endpoint behaved wrong 2020-03-26 07:52:48 +01:00
Hypolite Petovan
b0dc3d6cf9 Improve Babel code
- Add Diaspora source text choice
- Simplify escaped display
2020-03-11 09:01:17 -04:00
Hypolite Petovan
737b04d7e2
Merge pull request #8401 from annando/gfollower-epilogue
Reduce the load of "gfollower"
2020-03-10 18:52:31 -04:00
Michael
59f58f999d Small fixes 2020-03-10 22:51:05 +00:00
Michael
f27900ad78 Reduce the load of "gfollower" 2020-03-10 21:10:59 +00:00
Michael
8e421f0893 Fix uninstall of installed addons 2020-03-09 23:28:37 +00:00
Michael
37376fa715 Issue 8371: Improvements for picture permissions 2020-03-08 13:16:59 +00:00
Michael
6bef9fb230 Show the relations of Twitter contacts 2020-03-07 13:05:16 +00:00
Michael
d6905e29cf Query the same contact only once a month 2020-03-07 05:31:03 +00:00
Michael
a6e7b5f295 GContact discovery added 2020-03-05 22:03:24 +00:00
Hypolite Petovan
1afb49f412
Merge pull request #8366 from annando/issue-8321
Issue 8321: Follow items now work again
2020-03-05 08:44:41 -05:00
Michael
a55057d974 Function renamed to better reflect the purpose 2020-03-05 08:03:05 +00:00
Hypolite Petovan
6ae5f705b6 Rename Item::delete* methods to Item::markForDeletion* 2020-03-03 01:48:29 -05:00
Michael
72c198990e Merge remote-tracking branch 'upstream/develop' into private 2020-03-02 15:05:00 +00:00
Michael
d3c6f6de2a New query for community page 2020-03-02 14:59:16 +00:00
Hypolite Petovan
e008811514
Merge pull request #8350 from nupplaphil/bug/8342_not_link
Add Login form in case of notification links
2020-03-02 09:31:54 -05:00
Michael
ca1b92bb34 Support unlisted public posts 2020-03-02 07:57:23 +00:00
nupplaPhil
55a5e43715
Add UID as parameter for notify repository call 2020-03-01 22:24:53 +01:00
Hypolite Petovan
ad2b9198a4 Remove last on/off data occurrences in additional features
- Address https://github.com/friendica/friendica/issues/7999#issuecomment-589808923
2020-03-01 14:15:08 -05:00
nupplaPhil
c11cfd5e48
Rename notice message. 2020-03-01 15:38:23 +01:00
nupplaPhil
c751352d60
Add Login form in case of notification links 2020-03-01 13:47:02 +01:00
nupplaPhil
811f075aa1
Rename method name 2020-02-29 17:10:34 +01:00
nupplaPhil
ed422be734
Improve start/count parameter 2020-02-29 17:10:33 +01:00
nupplaPhil
2adc6a0974
Add list command 2020-02-29 17:10:31 +01:00
nupplaPhil
ecf7f40704
Admin page improvements 2020-02-29 17:10:31 +01:00
nupplaPhil
0fade7fc0a
Fix Admin page 2020-02-29 17:10:30 +01:00
nupplaPhil
4f2bea5cb1
Move "regmod" functionality into Admin Users page 2020-02-29 17:10:29 +01:00
nupplaPhil
0c3f8b124b
Add "User::block()" to console command 2020-02-29 17:10:28 +01:00
nupplaPhil
b4f6e8fda1
Move "User::deny()" to own method and update usages 2020-02-29 17:10:28 +01:00
nupplaPhil
6aee153bbd
Move "User::allow()" to own method and update usages 2020-02-29 17:10:27 +01:00
nupplaPhil
f3f764bc39
Add new possibility to add a user per console 2020-02-29 17:10:27 +01:00
Michael Vogel
fccecf92cd
Merge pull request #8337 from MrPetovan/task/8323-protect-target-blank
Add rel="noopener noreferrer" to all target="_blank" links
2020-02-25 05:50:33 +01:00
Hypolite Petovan
b100b9600e Add rel="noopener noreferrer" to all target="_blank" links
See https://mathiasbynens.github.io/rel-noopener/
2020-02-24 20:07:34 -05:00
Hypolite Petovan
e94911620a Expand system.no_auto_update to community, profile statuses and contact conversations pages
- Update setting name and description
2020-02-23 19:38:24 -05:00
Andy
699b567d97 modified: src/Module/Admin/Users.php 2020-02-23 03:31:59 +00:00
Michael
9cbea34fa4 Clean the profile URL when follow 2020-02-22 12:29:33 +00:00
Michael
1b87a97a81 Remove "hidewall" check from ACL 2020-02-22 08:54:28 +00:00
Hypolite Petovan
96ba2ac00d Add new hide dislike user setting 2020-02-20 05:37:07 -05:00
Hypolite Petovan
1a8110234f Move /settings/display module to src/ 2020-02-20 05:37:06 -05:00
Hypolite Petovan
33c7b62326 Move manifest JSON from template to array 2020-02-19 13:29:55 -05:00
Hypolite Petovan
930d395d7b Update manifest output with config/theme info 2020-02-19 10:29:13 -05:00
Michael
c57246450f "Delegations" is renamed to "Accounts" 2020-02-19 07:09:29 +00:00
Steffen K9
3ec23a4c70
Remove 'this' from 'View this profile' 2020-02-17 23:42:35 +01:00
Philipp
09961a07e4
Merge pull request #8297 from MrPetovan/task/8285-api-events
[API] Add new api/friendica/events endpoint
2020-02-16 21:07:44 +01:00
Philipp
da124af6ed
Merge pull request #8293 from MrPetovan/task/5562-community-pagination
Improve community pagination
2020-02-16 19:38:49 +01:00
Hypolite Petovan
e0d03615bc Add node-wide default items per page config 2020-02-16 13:04:26 -05:00
Hypolite Petovan
efbafce2d5 Use namespace alias in Module\Update\Community 2020-02-16 12:50:45 -05:00
Hypolite Petovan
d78f66cd09 Replace local_user() by Session::isAuthenticated() where appropriate 2020-02-16 12:50:44 -05:00
Hypolite Petovan
561472b975 Add L10n parameter to Pager classes 2020-02-16 12:50:39 -05:00
Hypolite Petovan
d3b3f716f8 [API] Add new endpoint api/friendica/events 2020-02-16 12:07:39 -05:00
Michael
ee6cceba30 Clarify the effect of "net-publish" 2020-02-16 15:39:44 +00:00
Michael
3bd1f3a836 No more gender 2020-02-16 10:55:18 +00:00
Hypolite Petovan
682fb7e4e2 Move community module to src/
- Use boundaries pagination instead of number pages
- Trim down community update module output
- Part of https://github.com/friendica/friendica/issues/4090
2020-02-16 04:41:22 -05:00
Hypolite Petovan
5d169a4098 Add System::htmlUpdateExit() method to refactor update modules 2020-02-16 04:32:56 -05:00
Hypolite Petovan
0b0309ce8f Remove pager parameter from conversation()
- Add getUrlParameter() Javascript function to determine current page
2020-02-13 23:40:00 -05:00
Michael
8969af04f9 Duplicated "hide-friends" setting removed 2020-02-10 23:11:28 +00:00
Michael Vogel
e80d68ba53
Merge pull request #8261 from MrPetovan/task/8251-use-about-for-pdesc
Use profile.about for profile description
2020-02-10 23:36:59 +01:00
Hypolite Petovan
2ec3a97393
Merge pull request #8263 from annando/remote-follow
New page for remote follow requests
2020-02-09 17:53:13 -05:00
Michael Vogel
5ad3a40647
Update src/Module/RemoteFollow.php
Co-Authored-By: Philipp <admin+Github@philipp.info>
2020-02-09 23:12:00 +01:00
Michael
e628d2726b Removed unneeded stuff 2020-02-09 22:08:59 +00:00
Michael
2eebeeaa32 New page for remote follow requests 2020-02-09 17:04:35 +00:00
nupplaPhil
85dc9bb96b
Add license info at Friendica PHP files 2020-02-09 16:18:46 +01:00
nupplaPhil
23c64b9a11
Add license info at Friendica classes 2020-02-09 15:45:36 +01:00
Hypolite Petovan
a42104ce43 Use profile.about instead of profile.pdesc for profile description 2020-02-09 02:36:19 -05:00
Hypolite Petovan
5552f5ee72 Accept empty values for profile birthday 2020-02-09 02:17:48 -05:00
Hypolite Petovan
557ece7d5a Remove unused translated yes/no labels in converted checkbox field definitions 2020-02-06 10:25:36 -05:00
Hypolite Petovan
40db6baa6b Rename hide friends checkbox field variable 2020-02-05 21:37:58 -05:00
Hypolite Petovan
a7a38da62d Remove yesno option from Storage backend 2020-02-05 21:37:32 -05:00
Hypolite Petovan
6347578978
Merge pull request #8239 from nupplaphil/task/move_enotify_parts
Move Notify "type" and "otype" into own enum classes
2020-02-05 16:56:54 -05:00
Michael
5bbe02dcae Remove a notice about a missing variable 2020-02-05 21:40:35 +00:00
nupplaPhil
511556085a
Move Notify::TYPE_SYSTEM 2020-02-05 21:41:07 +01:00
nupplaPhil
9435cc4b88
Move Notify::TYPE_MAIL 2020-02-05 21:41:02 +01:00
nupplaPhil
cfd50f9abb
Move Notify::TYPE_INTRO 2020-02-05 21:41:00 +01:00
Hypolite Petovan
16c2705016
Merge pull request #8237 from annando/a11y-2
Accessibility: Improve navigation and contact approval
2020-02-05 12:11:53 -05:00
Michael
0b66970ec9 Acessibility: Improve navigation and contact approval 2020-02-05 16:14:04 +00:00
Hypolite Petovan
e37b1c8794
Merge pull request #8215 from nupplaphil/task/extract_email
Cleanup enotify & Extract System emails
2020-02-04 15:10:27 -05:00
nupplaPhil
0b94b84dc7
simplify mail creation 2020-02-04 21:05:33 +01:00
nupplaPhil
7fb913eb86
Add extra email banner (including setting) 2020-02-02 22:43:44 +01:00
nupplaPhil
262c94f12f
Fix indents 2020-02-02 22:43:43 +01:00
nupplaPhil
97e708f2e2
Remove DI::app() dependency again 2020-02-02 22:43:41 +01:00
nupplaPhil
0e13428210
Move "App::getSenderEmailAddress()" to "Emailer::getSiteEmailAddress()" 2020-02-02 22:43:40 +01:00
nupplaPhil
9428466d1d
Set Sitename / site email as sender for system emails 2020-02-02 22:43:39 +01:00
nupplaPhil
3291728059
Extract System emails from enotify
- Removed every SYSTEM_EMAIL occurrence in enotify
- Introduced a "SystemMailBuilder" for build system emails
- Replaced every SYSTEM_EMAIL usage in the classes with calling this builder
- Added tests for this new Builder
- Split the email templates between "base" template for email and concrete usages for different use cases
2020-02-02 22:43:35 +01:00
nupplaPhil
3ed3e8ff42
Force avatar update for Contact Advanced page 2020-02-02 22:19:02 +01:00
nupplaPhil
41ec7d8370
Replace stylesheet names 2020-02-02 20:56:31 +01:00
nupplaPhil
8632c90327
Fix crepair links 2020-02-02 20:50:53 +01:00
Hypolite Petovan
7033cdcd6b Remove next link when there aren't any introductions in Module\Api\Mastodon\FollowRequests 2020-02-01 21:38:25 -05:00
Hypolite Petovan
6eb985ca47
Merge pull request #8213 from AlfredSK/AlfredSK-fix-archives-widget
Fix Archives Widget on Status Page
2020-02-01 08:29:58 -05:00
Hypolite Petovan
a3028e69aa
Merge pull request #8211 from nupplaphil/task/mod_crepair
Move mod/crepair to src/Module/Contact/Repair
2020-02-01 08:28:29 -05:00
Steffen K9
e901468602
Fix Archives Widget on Status Page
Solution 'borrowed' from PR8116.
2020-02-01 14:06:35 +01:00
nupplaPhil
d9ae813b43
Improvements 2020-02-01 08:45:38 +01:00
Hypolite Petovan
96b9619608
Merge pull request #8210 from nupplaphil/task/mod_fsuggest
Move mod/fsuggest to src/Module/SuggestFriend
2020-01-31 18:43:32 -05:00
nupplaPhil
048bb014d8
Move CRepair to Contact Advanced route 2020-02-01 00:37:11 +01:00
nupplaPhil
f21196df7c
improvements 2020-02-01 00:27:46 +01:00
nupplaPhil
f565d590f6
Move mod/crepair to src/Module/Contact/Repair 2020-02-01 00:20:50 +01:00
Hypolite Petovan
dad530802f
Merge pull request #8209 from nupplaphil/task/mod_worker
Move mod/worker to src\Module\Worker
2020-01-31 18:12:36 -05:00
nupplaPhil
d4e836855b
Remove deprecated code 2020-02-01 00:05:27 +01:00
nupplaPhil
34f4aedb87
Move mod/fsuggest to src/Module/SuggestFriends 2020-01-31 23:50:46 +01:00
Philipp
0406fe7ade
Merge pull request #8163 from MrPetovan/task/7817-custom-fields-part-3
New custom profile fields feature part 3: Updating the API
2020-01-31 22:39:11 +01:00
nupplaPhil
17389de261
Move mod/worker to src\Module\Worker 2020-01-31 22:38:49 +01:00
nupplaPhil
7909d9c417
Notifications cleared for a whole thread in case of one mark seen 2020-01-31 21:34:12 +01:00
Hypolite Petovan
dd24b3bac0 Move api/profile/show to src/Module
- Update API documentation
- Update BaseApi::format to include headers by format
2020-01-29 23:31:37 -05:00
Hypolite Petovan
5670c19d5c Move/rename base module classes 2020-01-29 23:23:07 -05:00
nupplaPhil
d1b7bfda4b
Add System::jsonExit() 2020-01-28 23:36:28 +01:00
nupplaPhil
c2b8c65104
Merge "notification" routes 2020-01-28 23:21:24 +01:00
nupplaPhil
dd8d9d7c70
Fix ignore notification 2020-01-28 22:47:15 +01:00
Philipp
977248f510
Merge pull request #8191 from MrPetovan/task/7967-mastodon-api-custom_emojis
Add custom emojis Mastodon API endpoint
2020-01-28 17:12:00 +01:00
Hypolite Petovan
a2fb8cc035
Fix wrong variable name in Module\NoScrape
- Address https://github.com/friendica/friendica/issues/8000#issuecomment-579292541
2020-01-28 10:33:19 -05:00
Hypolite Petovan
bd910342df Add custom emojis Mastodon API endpoint 2020-01-28 08:14:48 -05:00
Philipp
353dddaf15
Merge pull request #8190 from MrPetovan/task/profile-tidings
Deprecated profile fields cleanup
2020-01-28 13:41:55 +01:00
Hypolite Petovan
7b0ec6252f Remove uses of the rest of deprecated profile fields 2020-01-27 23:06:30 -05:00
Hypolite Petovan
e69497454b Remove uses of profile.marital 2020-01-27 23:01:25 -05:00
Hypolite Petovan
8e2910976f Remove usage of profile.gender 2020-01-27 23:00:18 -05:00
Hypolite Petovan
a7dd0173a7 Remove obsolete profile_id parameter in Model\Profile::load 2020-01-27 22:01:12 -05:00
Hypolite Petovan
65cb77b6a0 Fix wrong use of DPA::p return value in Module\NoScrape
- Address https://github.com/friendica/friendica/issues/7998#issuecomment-579036775
2020-01-27 21:57:07 -05:00
Hypolite Petovan
75a2190af5 Move Module\Base\Api to Module\BaseApi 2020-01-27 21:18:42 -05:00
Hypolite Petovan
0de8e4db08 Move Mastodon API entities to src/Object 2020-01-27 20:01:32 -05:00
Hypolite Petovan
a607656607 Replace profile tab GET parameter by route 2020-01-27 19:21:18 -05:00
nupplaPhil
c4d309f801
Fix NoScrape SQL 2020-01-27 23:28:38 +01:00
nupplaPhil
7db4621eef
Adapt json error 2020-01-27 00:05:45 +01:00
nupplaPhil
4762476c89
Use parameters 2020-01-26 23:53:49 +01:00
nupplaPhil
4260b94fec
Move mod/noscrape to Module\Noscrape 2020-01-26 23:43:47 +01:00
Philipp
9269221825
Merge pull request #8175 from MrPetovan/task/revert-profile-default-tab
Revert profile base URL behavior
2020-01-26 20:33:27 +01:00
Hypolite Petovan
e5ab4f1889 Re-enable pinned items in profile wall 2020-01-26 14:21:20 -05:00
Hypolite Petovan
46c4bfe580 Restore base profile URL behavior
- Add new profile-specific route
2020-01-26 14:21:20 -05:00
Hypolite Petovan
f2d917114f Move Model\Profile::getTabs to new Module\BaseProfile class 2020-01-26 14:21:18 -05:00
Hypolite Petovan
c42dd168c4
Merge pull request #8170 from nupplaphil/task/repo_notification
Prepare Model\Notify for include/enotify.php (Part 2)
2020-01-26 14:09:28 -05:00
nupplaPhil
0840938dff
Rename classes
- Repository/Model Notification => Notify
- Factory/Object Notification => Notification
2020-01-26 20:30:24 +01:00
nupplaPhil
b85511b00d
Improvements:
- Fix API-select
- Introduce OTYPE-constants
- Rename `IntroductionFactory` methods
2020-01-26 14:33:10 +01:00
Hypolite Petovan
602a57577d Remove duplicate call to Profile::getTabs in Module\Profile\Index
- Address https://github.com/friendica/friendica/issues/8167
2020-01-25 16:27:43 -05:00
Hypolite Petovan
5c05d28a8e Increase argument counter after route change in Module\Profile\Status
- Address https://github.com/friendica/friendica/pull/8156#issuecomment-578302294
2020-01-25 16:27:43 -05:00
nupplaPhil
74f3a2f90c
Fix API result, add PHPDoc and cleanup object construction
Fix missing getters
fix data array
fix missing "$" for template-variables
Remove lazy-loaded parent notification instance (for now..)
2020-01-25 21:15:01 +01:00
nupplaPhil
0850fb88dd
ReWork Notification Model/Module/Object/Repository/Factory
- Introduce Repository for interaction with "notify" table
- Introduce Factory for read-only notification objects (they're just loosely based on notification the table!)
- Introduce Objects for type-safe usage at the presentation layer
- Reworked Model, which is now fully based on the notify table, including generated fields (cache, ..)
2020-01-25 19:58:22 +01:00
Philipp
09de4a5b47
Merge pull request #8156 from MrPetovan/task/7817-custom-fields-part-2
New custom profile fields feature part 2: Feature switcheroo
2020-01-24 20:17:52 +01:00
Hypolite Petovan
188720c3cd
Merge pull request #8155 from nupplaphil/task/move_notifications
Move mod/notifications to Module\Notification
2020-01-24 12:10:49 -05:00
nupplaPhil
b229939c3d
rename CSS attributes notify => notification 2020-01-24 18:56:34 +01:00
nupplaPhil
b016e420fe
notify_type => str_type
str_notifytype => st_notification_type
2020-01-24 18:39:50 +01:00
nupplaPhil
16b1d3fc08
Notifies => Notifications 2020-01-24 18:34:29 +01:00
nupplaPhil
0f932ae723
Notify => Notification
Notifs => Notifications
2020-01-24 18:32:38 +01:00
Hypolite Petovan
4da90b9378 Add group membership filter widget in contact list 2020-01-23 17:49:55 -05:00
Hypolite Petovan
ed3ac36621 Refactor queries in contact module 2020-01-23 17:49:42 -05:00
Hypolite Petovan
1fc1989f93 Remove superfluous includes in profile modules 2020-01-23 10:00:48 -05:00
Hypolite Petovan
087c3cdcd8 Remove duplicated TOC loop in Module\Help 2020-01-23 09:13:31 -05:00
Hypolite Petovan
e8bf74914b Update user import/export with profile fields
- Account for backward compatibility when exporting: add values for profile.is-default and profile.profile-name fields
- Account for forward compatibility when importing: migrate legacy profiles to custom profile fields
2020-01-22 19:42:37 -05:00
Hypolite Petovan
18cfd8dfaa Remove references to deprecated profile.is-default and profile.profile-name fields 2020-01-22 19:42:37 -05:00
Hypolite Petovan
64c05f2280 Add custom fields help text 2020-01-22 19:42:36 -05:00
Hypolite Petovan
cc007f715d Add sortability to custom profile fields form 2020-01-22 19:42:36 -05:00
Hypolite Petovan
6657cf7bb1 Rework profile setting page with custom fields 2020-01-22 19:42:35 -05:00
Hypolite Petovan
d475cb5028 Replace advanced profile display with custom profile fields
- Merge all profile/advanced.tpl theme templates into profile/index.tpl
- Remove obsolete Model\Profile::getAdvanced method
2020-01-22 19:42:34 -05:00
Hypolite Petovan
62fec2f190 Remove duplicate profile_uid key in App->profile array 2020-01-22 19:42:33 -05:00
Hypolite Petovan
f6f4cbab9d Remove multi profiles feature
- Remove mod/profperm
- Remove additional feature
- Remove profile visibility on contact page
- Remove profile list templates
2020-01-22 19:42:33 -05:00
Hypolite Petovan
d1be68b754 Move Module\Profile to Module\Profile\Index
- Move /profiles to Module\Settings\Profile\Index
2020-01-22 19:42:32 -05:00
nupplaPhil
5c4eb2b2c9
Move templates into sub-dir "notifications" 2020-01-23 00:16:34 +01:00
nupplaPhil
512b00550e
rename some variables 2020-01-22 23:37:23 +01:00
nupplaPhil
d0c153943a
Add phpdoc 2020-01-22 23:31:00 +01:00
nupplaPhil
fa6c33d3ac
Move mod/notifications to Module\Notification 2020-01-22 23:18:14 +01:00
SpencerDub
2091ae0776
Fix "accout" typo 2020-01-21 22:22:45 -08:00
Hypolite Petovan
689c8ce0e3 Remove superfluous variable type hint in Module\Settings\Profile\Photo\Index 2020-01-20 13:28:41 -05:00
Hypolite Petovan
3ebc0371b7 Add trace for admin in exceptionpages
- Fix exception message not showing on raw exception page
2020-01-20 07:47:53 -05:00
Hypolite Petovan
6d7f0a6fd8 Remove duplicate profile_uid key in App->profile array 2020-01-20 07:32:46 -05:00
Hypolite Petovan
9803c96db4 Move profile-related templates to sub-folder 2020-01-20 07:27:14 -05:00
Hypolite Petovan
0d1befdf2d Move /profile_photo to Module\Settings\Profile\Photo 2020-01-20 07:27:12 -05:00
Michael
035e0c5a61 Issue 8136: Optical enhancements for delegation page 2020-01-20 05:05:20 +00:00
nupplaPhil
ed9392469e
Remove unneeded Config namespace usages 2020-01-19 22:50:44 +01:00
nupplaPhil
d5a473abda
Shorten "PConfiguration" to "PConfig" again, since the Wrapper is gone 2020-01-19 22:23:44 +01:00
nupplaPhil
21640ec5d8
Add missing Friendica\DI namespace to files (PHPStorm inspection) 2020-01-19 21:26:42 +01:00
nupplaPhil
a6a2efa18a
Move Config::delete() to DI::config()->delete() 2020-01-19 21:22:33 +01:00
nupplaPhil
3411ced833
Move Config::set() to DI::config()->set() 2020-01-19 21:21:53 +01:00
nupplaPhil
6c36fd9e01
Move Config::get() to DI::config()->get() 2020-01-19 21:21:13 +01:00
nupplaPhil
174129af94
add missing namespaces/fix wrong class-names 2020-01-19 16:31:35 +01:00
nupplaPhil
d6efc90194
cleanup namespace usages for L10n 2020-01-19 16:31:33 +01:00
nupplaPhil
2838635d64
Move L10n class from L10n subdir to Core (replacing old wrapper) 2020-01-19 16:31:30 +01:00
nupplaPhil
d83f6335eb
Move L10n::getCurrentLang() calls to DI::l10n()->getCurrentLang() calls 2020-01-19 16:31:19 +01:00
nupplaPhil
d3255afa66
Move L10n::withLang() calls to DI::l10n()->withLang() calls 2020-01-19 16:31:18 +01:00
nupplaPhil
a9a36fb302
Move L10n::tt() calls to DI::l10n()->tt() calls 2020-01-19 16:31:17 +01:00
nupplaPhil
5dfee31108
Move L10n::t() calls to DI::l10n()->t() calls 2020-01-19 16:31:16 +01:00
Michael
0a4119adaf @brief is removed completely 2020-01-19 06:05:23 +00:00
Hypolite Petovan
c58dc357d4
Merge pull request #8132 from annando/child-user
Fix: You can now register an account when you haven't done it before
2020-01-18 14:00:48 -05:00
Hypolite Petovan
58f69481e6
Merge pull request #8130 from nupplaphil/task/di_pconfig
Move PConfig to DI::pConfig()
2020-01-18 13:57:57 -05:00
Michael
a3ea98a79f Fix: You can now register an account when you haven't done it before 2020-01-18 18:40:48 +00:00
nupplaPhil
800694e9b3
Remove unused use statements & remove PConfig class 2020-01-18 17:02:59 +01:00
nupplaPhil
b5c0df439f
Move PConfig::delete() to DI::pConfig()->delete() 2020-01-18 16:56:46 +01:00
nupplaPhil
88bb66371c
Move PConfig::set() to DI::pConfig()->set() 2020-01-18 16:54:50 +01:00
nupplaPhil
9e9429b56d
Move PConfig::get() to DI::pConfig()->get() 2020-01-18 16:50:57 +01:00
Hypolite Petovan
c742c62f0a
Merge pull request #8129 from nupplaphil/task/cleanup_cache
CleanUp Cache namespace
2020-01-18 09:09:47 -05:00
nupplaPhil
424c87195b
CleanUp Cache namespace
- Introduce enum "Duration"
- Introduce enum "Type"
- Move "Cache\Cache" to "BaseCache"
2020-01-18 15:41:19 +01:00
Michael
f69a601ab1 Wrong wording 2020-01-18 04:52:30 +00:00
Michael
f3b3c4e866 Link to registration added 2020-01-17 12:44:26 +00:00
Michael
5c0f0c9c19 Improved notices 2020-01-17 07:29:22 +00:00
Michael
e5ecfa7c34 Additional accounts can now be created easily 2020-01-17 07:02:59 +00:00
Michael
fa975fc775 Delegations now work again 2020-01-16 20:58:33 +00:00
Hypolite Petovan
7db4c7ea02
Merge pull request #8118 from annando/spamcheck
Improved spam protection
2020-01-15 13:15:17 -05:00
Michael Vogel
8ebc385772 Improved spam protection 2020-01-15 18:55:32 +01:00
Michael
eb011f47bb Publish lowercase 2020-01-12 21:13:16 +00:00
Michael
7b060aa3f5 User lowercase for platform data 2020-01-12 21:07:40 +00:00
Hypolite Petovan
4dacd5db44
Merge pull request #8100 from annando/statistics
Combine matching systems
2020-01-12 06:55:55 -05:00
Michael
a357b0bf37 Combine matching systems 2020-01-12 11:22:36 +00:00
Tobias Diekershoff
3c1f127e3c
Merge pull request #8099 from annando/statistics
The federation statistics now contain all systems
2020-01-12 11:44:45 +01:00
Michael
3f8b6cb118 Improved order of systems 2020-01-12 09:40:17 +00:00
Michael
1a2a260e9a Improved documentation 2020-01-12 08:36:11 +00:00
Michael
3d1be9f2d1 The federation statistics now contain all systems 2020-01-12 08:14:32 +00:00
Hypolite Petovan
36190d1e79
Merge pull request #8072 from nupplaphil/task/Cache_to_DI
Replace Core\Cache wrapper with DI::cache() method
2020-01-10 08:46:03 -05:00
Hypolite Petovan
84cff91283
Merge pull request #8062 from nupplaphil/Make-Storage
Make Storage testable & add tests
2020-01-10 08:45:07 -05:00
nupplaPhil
016cfcd846
Fixings
- Rename "facStorage" to "storageManager"
- Fix indentation
- Fix tests
2020-01-10 13:22:03 +01:00
nupplaPhil
08edeae2f9
Make Storage testable & add tests
- Making StorageManager dynamic (DI::facStorage())
- Making concrete Storage dynamic (DI::storage())
- Add tests for Storage backend and failure handling
- Bumping Level-2/Dice to "dev-master" until new release
- Using Storage-Names instead of Storage-Classes in config (includes migration)
2020-01-10 13:21:57 +01:00
Michael
9c5b082687 Fix: Show possible managers again 2020-01-10 08:04:48 +00:00
Michael
f48c4fcbe4 Issue 8081: The usage has to be an object, not an array 2020-01-09 09:55:33 +00:00
Hypolite Petovan
6b8db5ad13 Update the Introductions domain to use repository, model and collection 2020-01-06 21:39:05 -05:00
Hypolite Petovan
5a1abb8c7d Introduce Mastodon entity factories and API\Entity 2020-01-06 21:39:05 -05:00
nupplaPhil
a38b0f7eaf
Move remaining namespaces and delete Core\Cache.php 2020-01-07 00:51:02 +01:00
nupplaPhil
fe078410a1
Move Cache::get() to DI::cache()->get() 2020-01-07 00:45:49 +01:00
nupplaPhil
f68929633b
Move Cache::set() to DI::cache()->set() 2020-01-07 00:41:20 +01:00
nupplaPhil
c7476513e3
removed some static wrapper 2020-01-07 00:14:01 +01:00
nupplaPhil
20f1ab05e6
clear cookie before session clear 2020-01-07 00:11:39 +01:00
Hypolite Petovan
00011fe77d Remove unused use statements in Module\Item\Compose 2020-01-05 17:09:14 -05:00
Michael
274788807d Fix a missing ")" 2020-01-05 17:19:37 +00:00
nupplaPhil
48baa0be4b
Remove get_server() in favor of Search::getGlobalDirectory() 2020-01-05 00:04:55 +01:00
Hypolite Petovan
ebaf726744 Rework Feed::import parameters
- Remove unused $hub
- Replace $simulate with an implicit condition
2020-01-03 09:26:28 -05:00
Tobias Diekershoff
d3d63523ef
Merge pull request #8040 from MrPetovan/bug/notices
Add necessary call to BaseUrl->get() in Module\Objects
2019-12-31 19:43:34 +01:00
Hypolite Petovan
ab0a3f194a Add necessary call to BaseUrl->get() in Module\Objects
- Addresses https://github.com/friendica/friendica/issues/8000#issuecomment-569959500
2019-12-31 12:25:41 -05:00
Hypolite Petovan
07f1485df1 Correctly capitalize DI::baseUrl in Module\Tos
- Addresses https://github.com/friendica/friendica/issues/7998#issuecomment-569959102
- Addresses https://github.com/friendica/friendica/issues/8000#issuecomment-569959336
2019-12-31 12:19:12 -05:00
Philipp
b9dba631aa
Merge pull request #8037 from MrPetovan/bug/notices
Replace remaining $a->page by DI::page()
2019-12-30 23:41:23 +01:00
Hypolite Petovan
e84ad15569 Replace remaining $a->page by DI::page() 2019-12-30 17:35:01 -05:00
nupplaPhil
3f34229752
Move redundant System::baseUrl() to DI::baseUrl() calls 2019-12-30 23:00:08 +01:00
nupplaPhil
6d7362da41
Replace deprecated $a->page with DI::page() 2019-12-30 20:02:09 +01:00
Hypolite Petovan
0dbce6e58b Add user contact data superseding to Mastodon\Account::create 2019-12-30 06:12:51 -05:00
Hypolite Petovan
c286772fb5 Correct value of Mastodon API Account acct field for local users 2019-12-30 06:12:51 -05:00
Hypolite Petovan
cb7875b035 Rename Api\Mastodon\Account::createFromContact to just create
- Retrieve public contact in Api\Mastodon\FollowRequests instead of user contact
2019-12-30 06:12:50 -05:00
Hypolite Petovan
015db25d9f Replace obsolete references to App baseURL and getApp by DI 2019-12-29 21:50:15 -05:00
Michael
74f4637ff3 Fix fatal errors caused by PR 8019 2019-12-30 01:17:16 +00:00
nupplaPhil
f2d4a5eb7d
Remove namespaces 2019-12-29 20:18:26 +01:00
nupplaPhil
651d693270
Rebase for OpenId & Hovercard 2019-12-29 20:18:26 +01:00
nupplaPhil
2660edbb48
Use DI::baseUrl() for Search\Index.php 2019-12-29 20:18:25 +01:00
nupplaPhil
df0c05d635
Add Model\Introduction class to DI registry 2019-12-29 20:18:25 +01:00
nupplaPhil
c1dbb25656
Creating interfaces for Config/PConfig & fix tests 2019-12-29 20:18:19 +01:00
nupplaPhil
33674808dc
Remove deprecated App::cmd - replace with DI::args()->getCommand() 2019-12-29 20:17:51 +01:00
nupplaPhil
e6f61c2cc7
Remove deprecated App::query_string - replace with DI::args()->getQueryString() 2019-12-29 20:17:50 +01:00
nupplaPhil
26af2feee2
Remove deprecated App::is_mobile/is_tablet - replace with DI::mode()->isMobile()/isTablet() 2019-12-29 20:17:50 +01:00
nupplaPhil
e944d7bed6
Remove deprecated App::getBaseURL() - process methods to DI::baseUrl()->get() 2019-12-29 20:17:48 +01:00
nupplaPhil
e57a87f224
Remove deprecated App::setBaseURL() - process methods to DI::baseUrl()->saveByURL() 2019-12-29 20:17:47 +01:00
nupplaPhil
50be94aa5e
Remove deprecated App::getHostName() - process methods to DI::baseUrl()->getHostName() 2019-12-29 20:17:47 +01:00
nupplaPhil
2900389696
Remove deprecated App::getUrlPath - process methods to DI::baseUrl()->getUrlPath() 2019-12-29 20:17:46 +01:00
nupplaPhil
e93fba5136
Remove deprecated App::removeBaseURL - process methods to DI::baseUrl()->remove() 2019-12-29 20:17:45 +01:00
nupplaPhil
aedbdc536a
Refactor deprecated App::getArgumentValue() to DI::args()->get() 2019-12-29 20:17:44 +01:00
nupplaPhil
8b6e123b3f
Refactor deprecated App::isAjax() to DI::mode()->isAjax() 2019-12-29 20:17:44 +01:00
nupplaPhil
8e6973b774
Refactor deprecated App::internalRedirect() to DI::baseUrl()->redirect() 2019-12-29 20:17:43 +01:00
nupplaPhil
cc9b7bb14f
Refactor dynamic App::getDBA() to static DI::dba() 2019-12-29 20:17:43 +01:00
nupplaPhil
9cec293ccc
Refactor dynamic App::getMode() to static DI::mode() 2019-12-29 20:17:42 +01:00
nupplaPhil
e2b2778e0a
Refactor dynamic App::getLogger() to static DI::logger() 2019-12-29 20:17:41 +01:00
nupplaPhil
fceb4f3823
Refactor dynamic App::getConfig() to static DI::config() 2019-12-29 20:17:40 +01:00
nupplaPhil
388b963714
Replace BaseObject class with DI::* calls 2019-12-29 20:17:38 +01:00
nupplaPhil
1de3f186d7
Introduce new DI container
- Adding Friendica\DI class for getting dynamic classes
- Replacing BaseObject::getApp() with this class
2019-12-29 20:16:55 +01:00
Hypolite Petovan
a9220aa83b
Merge pull request #8026 from nupplaphil/task/l10n_immutable
Make L10n immutable
2019-12-29 13:54:32 -05:00
Hypolite Petovan
25847c4c71
Merge pull request #8022 from nupplaphil/task/mod_hcard
Move mod/hcard to src\Module\HoverCard
2019-12-28 21:42:01 -05:00
Hypolite Petovan
f000680511
Merge pull request #8021 from nupplaphil/task/mod_openid
Move mod/openid to src\Module\Security\OpenId
2019-12-28 21:39:42 -05:00
nupplaPhil
7a2f4dc54e
Make L10n immutable
- Remove Push/Pop
- Add "withLang($lang)" method
2019-12-28 23:12:01 +01:00
nupplaPhil
4d545825f0
optimize usage of arguments 2019-12-28 15:28:17 +01:00
nupplaPhil
97924d39d9
Merge init() and content() 2019-12-28 15:21:58 +01:00
Michael
f281725a09 Remove test loggings 2019-12-28 11:17:10 +00:00
Michael
160f931861 Fix: Search for terms and posts is now possible again 2019-12-28 11:15:57 +00:00
Tobias Diekershoff
d6274ab6f7
Merge pull request #8023 from MrPetovan/bug/7808-markdown-unescape-chevrons
Fix chevron display in BBCode/Markdown conversion
2019-12-28 08:07:30 +01:00
Hypolite Petovan
424106fd4e Add BBCode to Markdown to HTML raw result in Module\Babel
- Display HTML entities for BBCode to Markdown output
2019-12-27 20:44:24 -05:00
nupplaPhil
12e223b2ef
fix 2019-12-27 23:51:17 +01:00
nupplaPhil
eeb78d2d29
Move mod/hcard to src\Module\HoverCard 2019-12-27 22:53:09 +01:00
nupplaPhil
aa5771cf3e
Move Login/Logout/TwoFactor to bundled submodule "Security" 2019-12-27 22:19:28 +01:00
nupplaPhil
d30e8665e1
Move mod/openid to src\Module\OpenId 2019-12-27 22:16:40 +01:00
Michael
c037e9143c Additionally display the protocol together with the network 2019-12-27 17:24:29 +00:00
Michael Vogel
c7e4157a5a
Merge pull request #8007 from MrPetovan/task/7984-add-profile-url-search
Add profile url search
2019-12-27 02:19:39 +01:00
Hypolite Petovan
a11b47f93d Add profile URL search
- Move post URL search to private method in Module\Search\Index
2019-12-26 20:17:12 -05:00
Hypolite Petovan
016507f346 Use BaseURL::redirect instead of deprecated App->internalRedirect in Search\Index 2019-12-24 17:37:22 -05:00
Hypolite Petovan
1c9cb42d98 Move search term emptiness check before content checks in Search\Index 2019-12-24 17:17:35 -05:00
Hypolite Petovan
ec7eb9d83a Rename BaseSearchModule::performSearch to performContactSearch to remove purpose confusion 2019-12-24 17:15:41 -05:00
Hypolite Petovan
b610d4e82d Remove group management restrictions on pending and blocked in Module\Group 2019-12-24 16:44:43 -05:00
Tobias Diekershoff
00756737b5 Merge branch 'master' 2019.12 into develop 2019-12-23 20:03:47 +01:00
Michael
1af52dd050 Fix: Newer Friendica servers had been detected as ActivityPub 2019-12-21 13:51:25 +00:00
Hypolite Petovan
33ea5dfe35 Add check for $_REQUEST key existence in Module\Item\Compose
- Addresses https://github.com/friendica/friendica/issues/7677#issuecomment-566254464
2019-12-19 07:48:08 -05:00
Philipp
5197833c55
Merge pull request #7930 from MrPetovan/task/7887-api-followers-request
Add POST follow request Mastodon API endpoint
2019-12-18 22:12:52 +01:00
Hypolite Petovan
6e4a428c73
Merge pull request #7907 from nupplaphil/task/reduce_app_deps
Cleanup Session/Authentication
2019-12-14 09:53:40 -05:00
Michael
543c8f8459 Use localuser() 2019-12-12 15:57:08 +00:00
Michael
39560218f8 Issue 7659: Display blocked and ignored public contacts as well 2019-12-12 11:58:57 +00:00
nupplaPhil
1408908c84
Refactor Session Handling (make it more simple & handler are now handler again) 2019-12-11 20:30:31 +01:00
Hypolite Petovan
9a0a11ed39 Improve Api\Mastodon\Account with data from apcontact
- Original work by @annando
2019-12-11 08:25:45 -05:00
Hypolite Petovan
2d47952921 Add POST follow request Mastodon API endpoint 2019-12-11 08:25:44 -05:00
Hypolite Petovan
1625330e70 Switch Api\Mastodon\FollowRequests to list introductions instead of pending contacts 2019-12-11 08:24:17 -05:00
Hypolite Petovan
0656e9ece4 Update web modules handling introduction to use new model class 2019-12-11 08:24:17 -05:00
Hypolite Petovan
c239d218d8 Update Base\Api::login to return the authentication status 2019-12-11 08:24:16 -05:00
Hypolite Petovan
1c69dda2e1
Merge pull request #7926 from annando/api-instance
API: Added endpoints /instance and /instance/peers
2019-12-11 04:07:49 -05:00
Michael
3388274f9a Removed unneeded function 2019-12-11 08:26:18 +00:00
Michael
9296a55dfb Added entities 2019-12-11 06:51:59 +00:00
Michael
4e2804d783 Added some more data 2019-12-10 23:05:25 +00:00
nupplaPhil
b085098b49
Make 2Factor "tel" field instead "number"
- because of missing copy&paste buttons at number
2019-12-10 22:44:45 +01:00
Michael
1958bde4c0 API: Added endpoints /instance and /instance/peers 2019-12-10 21:27:09 +00:00
Hypolite Petovan
c6d422a188 Update Module\Help to use anchor words for titles
- Previous anchors are kept for links backward compatibility
2019-12-09 22:50:37 -05:00
Hypolite Petovan
8016cb3cee Add GET /api/v1/follow_requests Mastodon API endpoint 2019-12-09 22:50:36 -05:00
Hypolite Petovan
b365ffc3b5 Add API base module 2019-12-09 22:50:36 -05:00
nupplaPhil
54392fab81
Move Cookie to own class (with tests)
Move Authentication to App namespace
2019-12-08 22:45:34 +01:00
nupplaPhil
96555a7385
Refactor "Authentication" class with four main methods:
- withSession() - for auto authentication with Session/Cookie variables
- withOpenId() - for authentication with an OpenID account
- withPassword() - for authentication with Password
- setForUser() - for setting the user auth context of the current session

Refactor "Session" class - contains now "native" Session Management methods
2019-12-05 23:02:51 +01:00
nupplaPhil
18a3d18ba6
Move Authentication methods to class "Authentication" 2019-12-05 23:02:50 +01:00
nupplaPhil
c28f1fec51
General usage of type in input fields 2019-12-05 21:42:33 +01:00
nupplaPhil
e6da666885
Make Two Factor Field numeric 2019-12-05 20:19:25 +01:00
Michael
d34052b332 Make quoted announces look better / more announce improvements 2019-12-04 07:02:39 +00:00
Hypolite Petovan
c3d88aca39 Update the return value of Item\Ignore to integer
- Array is unnecessary
2019-11-30 23:15:58 -05:00
Michael Vogel
2f2480d88d
Merge pull request #7876 from MrPetovan/task/7308-backport-compose-acl
Generalize the Compose ACL to the whole site
2019-11-28 21:24:20 +01:00
Hypolite Petovan
8f4f6899dd Update composer module to use the new ACL selector
- Remove ACL-specific code from compose-footer
- Move compose-footer template remaining content to compose.js
2019-11-28 12:54:56 -05:00
Hypolite Petovan
ae3d4f63a3 Use visibility tags input for the default ACL selector
- Move friendica-tagsinput to default view folder
- Update all references to ACL::getFullSelectorHTML
- Fix theme-specific issues with the new ACL
2019-11-28 12:54:53 -05:00
Michael
0979daddac Modules separated 2019-11-28 07:07:34 +00:00
Michael
cb37588375 We can always send via SMTP, receiving mails is via IMAP 2019-11-27 07:44:59 +00:00
Michael
ae306ea7de rss is inbound 2019-11-27 07:38:57 +00:00
Michael
054a111f3c Twitter is also inbound 2019-11-27 07:36:24 +00:00
Michael
a26689f69c remove unused variable 2019-11-27 07:32:46 +00:00
Michael
890bbfa1a7 We now support nodeinfo version 2 / basic nodeinfo data is always enabled 2019-11-27 07:25:54 +00:00
Michael Vogel
f0ffc6df38 Don't use the creation date when transmitting to Diaspora 2019-11-22 21:24:02 +01:00
Hypolite Petovan
babcd24412
[hotfix] Fix syntax error in Module\Register
- Prevents registration
- Addresses https://github.com/friendica/friendica/issues/7675#issuecomment-552070076
2019-11-09 01:09:26 -05:00
Michael
bdacda32ba Pinning: Missing file added 2019-11-09 03:17:18 +00:00
Michael
fc94cad5f2 Pinned posts now work for visitors in the intended way 2019-11-08 06:52:44 +00:00
Hypolite Petovan
2200996d44
[hotfix] Prevent fatal error in profile with pinned posts
- `$a->profile['profile_uid']` may not be set
- Addresses https://github.com/friendica/friendica/issues/7675#issuecomment-551255174
2019-11-07 15:51:05 -05:00
Michael
91ad7936f3 Only sort the profile after pinned 2019-11-07 07:39:50 +00:00
Michael
ed58af25a5 show pinned items 2019-11-07 06:53:18 +00:00
Michael
02c43f283e Changed exceptions 2019-11-05 22:28:12 +00:00
Michael
7adc3460b3 Exceptions 2019-11-05 22:13:33 +00:00
Michael
8c03bdada9 parameters now are having a default value and are optional 2019-11-05 21:48:54 +00:00
Michael
bc2694bf7f Redo some changes 2019-11-05 20:28:35 +00:00
Michael
bd62d548db Added parameters 2019-11-05 20:22:54 +00:00
Michael
abe6724629 Added parameter to rawContent 2019-11-05 19:16:26 +00:00
Michael
30e02beb46 New module to pin posts 2019-11-05 19:16:11 +00:00
Philipp
4daa3d37c1
Merge pull request #7812 from tobiasd/20191103-tarpid
a hidden field for the registration form
2019-11-04 11:03:54 +01:00
Philipp
d0068170db
Merge pull request #7806 from tobiasd/20191102-csvexport
added export and import of followed contacts to and from  CSV files
2019-11-03 20:28:08 +01:00
Tobias Diekershoff
1377d13055 ypot 2019-11-03 17:37:53 +01:00
Tobias Diekershoff
7ca202baad add a tar pid to the registration form 2019-11-03 17:05:06 +01:00
Tobias Diekershoff
d3122c396e really there is no App 2019-11-03 15:53:32 +01:00
Tobias Diekershoff
9b03e2a564 there was no App 2019-11-03 15:07:29 +01:00
Tobias Diekershoff
0c873a0548 mv q() to DBA::select() 2019-11-03 14:03:11 +01:00
Tobias Diekershoff
e5e87d546d we only need one contact export, D* _only_ exports the entire profile 2019-11-03 12:59:14 +01:00
Tobias Diekershoff
955a84a266 added export and import of followed contacts to and from CSV files 2019-11-03 00:12:16 +01:00
Hypolite Petovan
50a2e7001e Replace last instance of local_user() used to guess authentication status in Module/Contact/Hovercard 2019-11-02 12:48:04 -04:00
Hypolite Petovan
ff27f45cb9 Move mod/hovercard to src/Module/Contact/Hovercard
- Rework hovercard.js to remove JS template interpolation
- Remove template/json output from Module/Contact/Hovercard
2019-11-02 12:48:03 -04:00
Hypolite Petovan
b543ee8ac7
Merge pull request #7726 from tobiasd/20191010-uexport
move uexport module to src
2019-11-02 07:46:57 -04:00
Tobias Diekershoff
8bea9e7523 mv URL path uexport -> userexport 2019-11-02 12:44:46 +01:00
Tobias Diekershoff
34932e12bf mv q() to DBA::p() 2019-11-02 12:12:29 +01:00
Tobias Diekershoff
15cdfdd414 mv Uexport to UserExport 2019-11-02 11:36:31 +01:00
Tobias Diekershoff
048b693fbf some more change requests 2019-11-02 11:24:46 +01:00
Hypolite Petovan
41261ba7e1
Merge pull request #7785 from nupplaphil/bug/7676-is_file_warning
Fix wrong check for logfile in admin summary
2019-11-01 11:06:52 -04:00
Philipp Holzer
f8e43ddf8d
rename developer to debug :-) 2019-11-01 15:59:00 +01:00
Philipp Holzer
aa7be41728
Fix ACLFormatterTest
- Add nullable to expand() function again
- Add angle bracket support to toString()
2019-11-01 14:13:29 +01:00
Hypolite Petovan
d6ff89d7b4
Merge pull request #7769 from annando/issue-3229
Changed OpenID registration
2019-10-29 10:32:02 -04:00
Michael
eb0d8c1ed0 Uswe default value 2019-10-29 13:26:54 +00:00
Philipp Holzer
dc4d3842e0
Fix wrong check for logfile in admin summary 2019-10-28 22:26:34 +01:00
Michael
8470fa70d3 Using "args" 2019-10-28 20:38:53 +00:00
Michael
dd7070938b Use "http_build_query" 2019-10-28 19:34:09 +00:00
Philipp Holzer
3eda62bfa6
Check null for acl-fields 2019-10-28 18:16:10 +01:00
Michael
bfbce16d0b Merge remote-tracking branch 'upstream/develop' into issue-3229 2019-10-28 13:50:06 +00:00
Philipp Holzer
a72e65a760
Adapt class structure
- Introduce constants
- Add constructor parameters
- Add typehints
- Renamed fields more meaningful
- Renamed method names to match identifier
- Adjust PHP doc
- Add GetClass call at used places
2019-10-26 04:03:27 +02:00
Philipp Holzer
1f368d469f
Move Friendica\Core\NotificationsManager to Friendica\Model\Notify 2019-10-26 02:01:46 +02:00
Philipp Holzer
7343ee5108
Move Namespace of ActivityNamespace 2019-10-25 00:41:48 +02:00
Philipp Holzer
dc2858938d
Renamed to ActivityNamespace 2019-10-25 00:32:35 +02:00
Michael
aca701bef8 Changed OpenID registration 2019-10-24 20:23:26 +00:00
Philipp Holzer
a83dfc11a0
Fixing https://github.com/friendica/friendica/pull/7759#discussion_r337102107 2019-10-24 21:43:20 +02:00
Philipp Holzer
2fba7ed477
Rename namespace 2019-10-24 21:40:13 +02:00
Philipp Holzer
07cea24430
Move Activity/Namespaces defines to constants 2019-10-24 21:40:12 +02:00
Hypolite Petovan
ee1954f294
Merge pull request #7762 from nupplaphil/task/mod_ignored
move mod/ignored to src/Module/Item/Ignored
2019-10-24 12:04:50 -04:00
Philipp Holzer
062e472314
Rename route '/ignored/{iid}' to '/item/ignore/{iid}' 2019-10-24 17:18:29 +02:00
Philipp Holzer
5aa73afa7e
Rename module class name 2019-10-24 09:09:47 +02:00
Hypolite Petovan
9f460c6797
Merge pull request #7765 from nupplaphil/task/move_text
Move include/text.php to class structure
2019-10-23 15:57:01 -04:00
Philipp Holzer
dba2d574b1
Adapt because of feedback 2019-10-23 21:29:17 +02:00
Philipp Holzer
db25f5b6ca
Add jsonExit() and fix UID issue 2019-10-23 16:24:19 +02:00
Philipp Holzer
ad67fd3aa8
Move is_a_date_arg to DateTimeFormat::isYearMonth
- Improved functionality
- Added tests
2019-10-23 02:39:28 +02:00
Philipp Holzer
f65f7f11c3
Move expand_acl to ACLFormatter::expand()
- including tests
2019-10-23 00:40:14 +02:00
Philipp Holzer
6b2c28e2d7
Add checks & realpath() usage
- New util class "FileSystem"
- Add check in admin summary too
2019-10-22 22:47:37 +02:00
Philipp Holzer
17aca9bee8
move mod/ignored to src/Module/Item/Ignored 2019-10-21 21:19:28 +02:00
Philipp Holzer
a25d841b85
some improvements 2019-10-21 17:29:53 +02:00
Philipp Holzer
2a41f0b104
wrong field 2019-10-21 11:34:47 +02:00
Philipp Holzer
7716374593
Move mod/receive to src/Module/Diaspora/receive
- Added routes
- Make Diaspora::decode(Raw) more explicit
- Add new User::getByGuid() method
2019-10-20 13:07:16 +02:00
Tobias Diekershoff
2ed61194d5 adopted some change requests 2019-10-17 07:45:48 +02:00
Philipp
c0b78a9720
Merge pull request #7743 from MrPetovan/task/7190-remove-defaults-modules
Replace deprecated defaults() calls by ?? and ?: operators in src/Module/
2019-10-15 18:17:45 +02:00
Hypolite Petovan
f59ea2af55 Replace deprecated defaults() calls by ?? and ?: operators in src/Module/ 2019-10-15 09:20:32 -04:00
Philipp
fed486bfc5
Merge pull request #7727 from MrPetovan/task/4090-move-manage-to-src
Move mod/manage to src/Module/Delegation
2019-10-13 18:20:47 +02:00
Hypolite Petovan
230a97ccdd Correctly URL encode return URLS for saved search 2019-10-13 08:39:55 -04:00
Hypolite Petovan
74bf3a4dc8 Replace path parameter with query string parameter in Module\Search\Saved 2019-10-13 08:39:41 -04:00
Hypolite Petovan
c5f4f730e1 Use init() rather than rawContent() in Module\Search\Saved since there's no output 2019-10-13 08:37:25 -04:00
Hypolite Petovan
02f02d44dc Move mod/manage to src/Module/Delegation
- Move templates/manage to templates/delegation
- Update navigation links
- Update CSS classes
2019-10-11 19:59:06 -04:00
Hypolite Petovan
4ee9e21a4f Make Router::getModuleClass throw exceptions
- Add new MethodNotAllowedModule
- Add new Module->determineClass catch blocks
- Update Module and Router tests
2019-10-11 19:59:05 -04:00
Hypolite Petovan
27eaffd7fb
Merge pull request #7725 from dew-git/develop
Fix security vulnerabilities.
2019-10-11 14:48:07 -04:00
Tobias Diekershoff
10a66f368c self should be lower case 2019-10-11 17:44:50 +02:00
Tobias Diekershoff
9f3e68c2c5 correct the file name in the header 2019-10-11 11:55:57 +02:00
Tobias Diekershoff
5ac5a67b6b enhance description 2019-10-11 11:49:28 +02:00
Tobias Diekershoff
e3a947fb3d keep the ToDo hint from delegations 2019-10-11 11:48:05 +02:00
Tobias Diekershoff
882449266c removed debugging leftover 2019-10-11 11:45:28 +02:00
Tobias Diekershoff
06a964c32f only take action, when there is something to do 2019-10-11 11:42:07 +02:00
Tobias Diekershoff
46172b641d moved UExport to src/Module/Settings/Uexport 2019-10-11 07:38:42 +02:00
dew-git
3940e804e3 Remove uneeded variable. 2019-10-10 20:48:13 -08:00
dew-git
811cdcdfcb Fix security vulnerbilities.
Fix possible length extension attack, predicable generators, timing attacks on hash comparision and improved formatting.
2019-10-10 15:21:41 -08:00
Hypolite Petovan
4b71fd2442 Replace deprecated calls to App->getBaseURL in Module\Register 2019-10-10 13:13:23 -04:00
Hypolite Petovan
67d374a14f Complete L10n::detectLanguage call parameters in Module\Register 2019-10-10 13:12:55 -04:00
Philipp
cf4bae26c7
Merge pull request #7720 from MrPetovan/task/4090-move-delegate-to-src
Move mod/delegate to src/Module/Settings/Delegation
2019-10-10 10:24:15 +02:00
Hypolite Petovan
43567bcf0e Add documentation comments to Module\Settings\Delegation 2019-10-10 04:17:37 -04:00
Hypolite Petovan
3cd916d7aa Use Model\User::getById when possible in Module\Settings\Delegation 2019-10-10 04:10:57 -04:00
Hypolite Petovan
cc0cf2b8ce Improve parent user password check in Module/Settings/Delegation 2019-10-10 04:10:29 -04:00
Hypolite Petovan
616edd0600 Move mod/delegate to src/Module/Settings/Delegation
- Move templates/delegate to templates/settings/delegation
2019-10-09 22:17:09 -04:00
Hypolite Petovan
e3e3ee72a0 Improve logging in Module\Search\Index 2019-10-07 16:18:19 -04:00
Hypolite Petovan
c8316bfe57 Use Dice instantiation to access App\Arguments
- Remove App->args accessors
2019-10-07 16:16:42 -04:00
Hypolite Petovan
1e737ae888 Move mod/search to src/Module/Search/Index
- Update BaseSeachModule not to depend on a single query string parameter
2019-10-07 14:27:46 -04:00
Hypolite Petovan
cdefa7f32a Add new module and widget for managing saved searches 2019-10-07 14:27:46 -04:00
Philipp
5f80180b47
Merge pull request #7710 from MrPetovan/task/rework-theme-session-vars
Rework theme session variables
2019-10-07 18:17:29 +02:00
Michael
1c8dd457cc Just some added logging to the proxy functionality to better analyze problems 2019-10-06 18:48:33 +00:00
Hypolite Petovan
f4d06ebd47 Remove useless theme session variable deletions in modules 2019-10-06 12:08:15 -04:00
Tobias Diekershoff
cbaa4d13d1 add server side check about note to admin 2019-10-06 11:57:43 +02:00
Hypolite Petovan
b62e20c7bf Code beautification 2019-10-05 08:34:07 -04:00
Hypolite Petovan
908197cc70 Use switches instead of if/else in Module\Search\Acl 2019-10-04 22:27:13 -04:00
Hypolite Petovan
9e29321aaf Use constants for search type in Module\Search\Acl 2019-10-04 22:20:40 -04:00
Hypolite Petovan
445133cb21 Move Module\Search\Acl::contactAutocomplete to Core\Search::searchGlobalContact
- Replace broken reference to directory /lsearch module with /search module
2019-10-04 22:19:54 -04:00
Hypolite Petovan
8f20e2054b Move /acl module to src/
- Move Core\ACL::contactAutocomplete to Module\Search\Acl
- Rename module path to /search/acl
2019-10-03 22:40:42 -04:00
Tobias Diekershoff
92ee309591 quotes 2019-10-02 08:28:12 +02:00
Tobias Diekershoff
9a0201e674 require a note to the admin when register policy is set to needs approval 2019-10-02 07:39:42 +02:00
Michael
18807ae21d Don't send blank pictures on error, fail instead. 2019-10-01 12:41:49 +00:00
Michael
5eeca432fe removed unused "f" parameter 2019-09-29 18:59:03 +00:00
Michael
51e55bca18 Added some logging 2019-09-29 10:58:07 +00:00
Michael
32ea610559 Avoid a contact lookup for empty URL 2019-09-29 10:23:36 +00:00
Michael
0185c91246 Merge remote-tracking branch 'upstream/2019.09-rc' into remote-rework 2019-09-29 06:32:35 +00:00
Michael
58fb0beaa3 Delete the cache entry allowing direct login again 2019-09-29 06:26:02 +00:00
Michael Vogel
4e9a810206 Fix magic auth for redirects with non profile paths 2019-09-29 02:16:09 +02:00
Michael
83b00ef308 New function "isAuthenticated" 2019-09-28 18:09:11 +00:00
Michael
1c26baec46 remote_user is replaced 2019-09-28 09:59:08 +00:00
Michael
1ddd2df4b8 Removed obsolete code 2019-09-28 05:37:24 +00:00
Michael
704cdf1b5a New function to store the "remote" session value / making the changes work 2019-09-26 04:47:42 +00:00
Hypolite Petovan
f19136905f Remove setting obsolete App->data['user'] in Module\Profile\Contacts 2019-09-21 05:14:49 -04:00
Michael
a037427a54 Added comment 2019-09-14 07:17:06 +00:00
Michael
9d87bc94a6 Issue 6553: Restructured code for treating removed accounts 2019-09-14 07:12:25 +00:00
Michael
57e4b9f806 Issue 7610: Set the appropriate meta header to not being crawled 2019-09-10 17:15:29 +00:00
Michael
a70a0306d7 Only show incoming pending contact requests with intro 2019-09-09 08:58:56 +00:00
Michael
2dbd843ed2 Don't display ignored pending contacts, link to contact request page 2019-09-09 05:29:33 +00:00
Michael
591ba9c68e Display pending contacts in the contact list 2019-09-08 19:18:56 +00:00
Philipp Holzer
62f7510aa7
Fixed wrong app reference 2019-08-27 00:03:05 +02:00
Michael
7d50a086e0 Issue 7559: Merge contact duplicates 2019-08-26 15:51:56 +00:00
Hypolite Petovan
2736aac678 Add missing use statement in Search\Directory
- Fixes https://github.com/friendica/friendica/issues/7297#issuecomment-522346804
2019-08-18 15:21:36 -04:00
Philipp Holzer
bff427174b
Fix parameters for Source 2019-08-18 15:14:03 +02:00
Philipp Holzer
b5cb3bc783
Fixing https://github.com/friendica/friendica/issues/7299#issuecomment-521745931 2019-08-18 15:12:10 +02:00
Philipp Holzer
d39a6ba444
Auto-remove duplicated, allowed themes during reload 2019-08-17 20:00:11 +02:00
Philipp Holzer
7e82f8dc2e
fix Admin Theme reload 2019-08-17 19:55:14 +02:00
Hypolite Petovan
e463df6418 Add existence check for contact.uid and contact.rel fields in Contact::getContactTemplateVars 2019-08-16 07:29:34 -04:00
Hypolite Petovan
98b0f97639 Suppress relationship string in template vars for public contact 2019-08-15 21:24:33 -04:00
Philipp Holzer
08be92a862
Moved BaseURL to App namespace (because similar type as Arguments/Modules/Modes) 2019-08-15 17:23:00 +02:00
Philipp Holzer
0af9747c6c
Add Arguments & Modules class 2019-08-13 16:29:11 +02:00
Michael Vogel
3b0767764b Queue numbers corrected, only display 999 queue items 2019-08-12 07:30:33 +02:00
Hypolite Petovan
66d4e5ce5f Remove wrap length in Babel HTML::toPlaintext display 2019-08-06 21:23:09 -04:00
Hypolite Petovan
4c45cb864a Update master translation strings file
- Fix gettext warning for empty string in Module\Item\Compose
2019-08-06 07:09:05 -04:00
Hypolite Petovan
4a85de4c19 Add HTML output panel to babel module 2019-08-04 10:22:49 -04:00
Michael
cb77b1af8c API: We now transmit the text description there as well 2019-08-04 03:45:23 +00:00
Michael Vogel
e8459cce34
Merge pull request #7381 from MrPetovan/task/7309-frio-compose
[frio] New Compose page
2019-08-01 08:15:02 +02:00
Michael
b4c673a620 We now use a central function for fetching the postdata 2019-07-30 22:26:01 +00:00
Hypolite Petovan
0b6f231ad3 Replace removed Contact::select method with Contact::selectToArray in Compose module 2019-07-29 20:31:50 -04:00
Hypolite Petovan
cb38fe4e72 Develop one-liner in Item\Compose 2019-07-29 20:31:49 -04:00
Hypolite Petovan
9d20705700 Improve compose page template
- Update title and description of the limited/private panel
- Move CC email addresses outside of the visibility panels
2019-07-29 20:31:49 -04:00
Hypolite Petovan
4f4b538bcf [frio] Add jotnet fields to compose page
- Move hardcoded descriptions to translation strings
2019-07-29 20:31:47 -04:00
Hypolite Petovan
c24ca57f21 Add frio-specific /compose module 2019-07-29 20:31:46 -04:00
Philipp
b5a9a1f1d3
Merge pull request #7435 from annando/select-to-array
Added "selectToArray" functions in DBA and Item
2019-07-27 19:45:32 +02:00
Michael
1a3bf05dfb Changed "Contact::select" to "Contact::selectToArray" 2019-07-27 15:57:23 +00:00
Hypolite Petovan
eaf217ef7d Update server block admin page to reflect the addition of shell wildcard syntax 2019-07-25 22:37:30 -04:00
Philipp
56e0a92d83
Merge pull request #7425 from MrPetovan/task/2fa-ping-disallowed
2FA: Remove mod/ping from exception list
2019-07-25 08:49:20 +02:00
Michael
aac086bf91 "all" contacts shouldn't show archived contacts 2019-07-24 19:29:45 +00:00
Hypolite Petovan
4821fe1b98 Use template-displayed errors in TwoFactor\Verify
- Remove the page dependency on jGrowl notices
2019-07-23 20:02:26 -04:00
Hypolite Petovan
8677428edb Remove debug 2019-07-22 17:41:21 -04:00
Hypolite Petovan
1a164b0dc5 Add two-factor app-specific password settings page
- Add two-factor app-specific model
- Add link to new page from 2fa settings index page
2019-07-22 07:56:00 -04:00
Hypolite Petovan
a149d6ec44 Move recovery code model to sub-folder 2019-07-22 07:41:01 -04:00
Hypolite Petovan
55e2006312
Merge pull request #7412 from nupplaphil/task/dice
Introduce DICE
2019-07-21 11:04:41 -04:00
Philipp Holzer
a8e6a57e9b
Fixing installer 2019-07-21 14:21:02 +02:00
Michael
a11206dbcd Issue 6675: Improved check for follower, removed global setting 2019-07-21 05:56:57 +00:00
Michael Vogel
dcebf53ecf
Merge pull request #7402 from MrPetovan/bug/7401-node-settings-style
Ensures node theme settings are used to render theme embed
2019-07-18 06:32:40 +02:00
Hypolite Petovan
477a84a8c4 Ensures node theme settings are used to render theme embed 2019-07-17 23:25:22 -04:00
Hypolite Petovan
9b927fa333
Merge pull request #7399 from annando/only-sharer
Added the option to only receive top level posts from people you follow
2019-07-17 20:53:28 -04:00
Michael
e247a14d2b Added the option to only receive top level posts from people you follow 2019-07-17 21:37:13 +00:00
Hypolite Petovan
0b97b32a59
Merge pull request #7379 from nupplaphil/task/refactor_l10n_for_test
Refactor L10n for testing
2019-07-16 16:03:42 -04:00
Philipp Holzer
92fb0a82ca
Dynamic config loading
- Move settings, defaults and dbstructure to directory 'static'
- Dynamic loading of config files (after the static loading)
- Filter out '-sample.config.php' and '-sample.ini.php' files
- Remove unnecessary ConfigFileManager
- Move ConfigFileLoader to Utils
- Add tests for multi-loading for INI, config and sample-filtering
2019-07-16 20:16:43 +02:00
Philipp Holzer
eb024a3718
Refactor L10n for testing
- Moving L10n to L10n\L10n
- Adding constructor information
- Adding to factory
- simplify/speedup tests
2019-07-16 16:44:47 +02:00
Hypolite Petovan
e16c410b59 Hide registration button on login page when registration are closed 2019-07-15 09:11:21 -04:00
Philipp Holzer
8c0f047bc7
Add namespace 2019-07-12 23:08:01 +02:00
Philipp Holzer
c82127ffb7
Splitting ConfigCache & PConfigCache
- Remove IConfigCache & IPConfigCache
- Add new PConfigCache
- Add missing Logger::init() (bugfixing tests)
2019-07-12 22:53:37 +02:00
Michael
6bb418c5a7 Use "received" instead of "created" when displaying posts in creation order 2019-07-07 21:30:33 +00:00
Michael
6041f74df6 New constant for federated protocols 2019-07-01 18:00:55 +00:00
Hypolite Petovan
b9ab613777 Merge branch 'master' into develop 2019-06-23 17:40:52 -04:00
Michael
b5de71c390 Fix a notice when the author is missing 2019-06-21 17:57:26 +00:00
Michael
7c87e83dcf Fix searching for contacts 2019-06-20 21:56:18 +00:00
Michael
d8ed2ed76d it is poll, not notify 2019-06-19 18:32:38 +00:00
Michael
4ab772ed67 Issue 6477: Automatically repair self contact avatar 2019-06-19 17:05:29 +00:00
Hypolite Petovan
aa5a61baef Fix variable by reference notice in Module\Admin\Federation
- Addresses https://github.com/friendica/friendica/issues/6918#issuecomment-502347979
2019-06-15 17:12:36 -04:00
Hypolite Petovan
394159d41e Use correct entry list in Module\Directory 2019-06-15 08:44:55 -04:00
Hypolite Petovan
68c65af046 Remove unused Module\Directory::init method 2019-06-15 08:44:36 -04:00
Philipp
fb63274aaf
Merge pull request #7250 from MrPetovan/bug/6410-normalize-message-button
Normalize message button in profile sidebar
2019-06-12 17:56:05 +02:00
Philipp
17490fca33
Merge pull request #7256 from MrPetovan/bug/7249-remote-logout
Fix remote logout
2019-06-12 07:37:42 +02:00
Hypolite Petovan
fd8844db83 Redirect remote visitors to their own profile after logout 2019-06-11 19:41:11 -04:00
Hypolite Petovan
b00bcbb1c1 Normalize the contact sidebar with the profile sidebar
- Remove un/follow text links in contact status window
2019-06-10 21:56:06 -04:00
Hypolite Petovan
3aebb92cf3 Rework Profile::sidebar profile link conditions
- Now show Follow, Unfollow, Atom Feed and Message in profile sidebar more consistently with the status of the current visitor
- Remove pseudo-field contact.remoteconnect
2019-06-10 21:56:03 -04:00
Hypolite Petovan
d7d44e1af7
Merge pull request #7245 from annando/unify-constants
Fix delivery counter for poking / unify delivery commands
2019-06-10 11:59:40 -04:00
Michael
41dc243186 Fix delivery counter for poking / unify delivery commands 2019-06-10 14:19:24 +00:00
Philipp Holzer
cc7444d84d
Move internal recursion-counter to the end of all cur/fetchUrl parameters 2019-06-10 14:34:54 +02:00
Philipp Holzer
aba7c9f08c
Remove queue from Admin/Summary 2019-06-02 03:28:22 +02:00
Philipp
25433e79d5
Merge pull request #7211 from MrPetovan/bug/7209-admin-forbidden
Add themed themed error page or login page for /admin[/*]
2019-05-31 11:49:40 +02:00
Hypolite Petovan
f0de19dd8a
Merge pull request #7208 from nupplaphil/bug/6916-filetag
Adding null checks before FileTag method (fix fatal)
2019-05-31 01:47:52 -04:00
Hypolite Petovan
4b4a319af9 Add themed themed error page or login page for /admin[/*] 2019-05-31 00:23:30 -04:00
Philipp Holzer
c76258c370
catching nulls for FileTag 2019-05-30 13:54:35 +02:00
Philipp Holzer
5002bda5fc
Checking the existence of '-' before array operation
See https://github.com/friendica/friendica/issues/6918#issuecomment-491490533
2019-05-29 20:07:53 +02:00
Philipp
be3d7759f0
Merge pull request #7198 from MrPetovan/task/6861-to-plaintext
Simplify BBCode::toPlaintext and HTML::toPlaintext
2019-05-28 07:49:25 +02:00
Hypolite Petovan
ed768c71ee Remove "f=&" nonsense from network module
- Fixes wrong redirect when using the sidebar filters
2019-05-27 17:45:27 -04:00
Hypolite Petovan
0fadc7730c Replace deprecated string-bases Model\FileTag calls with array-based ones 2019-05-27 17:40:08 -04:00
Hypolite Petovan
5d2bf73517 Add Babel result screen for compact HTML::toPlaintext 2019-05-27 12:02:28 -04:00
Hypolite Petovan
01e71254d9 Replace defaults() calls on $_SESSION by Core\Session calls
- Replace direct calls to $_SESSION by Core\Session calls in Module\Login
2019-05-26 21:26:59 -04:00
Hypolite Petovan
e99e8096bf
Merge pull request #7191 from nupplaphil/bug/logfile_permission
Fixing logfile permission denied exceptions
2019-05-26 15:19:26 -04:00
Philipp Holzer
b56b56ccb6
friendica-6379 Monolog - logfile permission denied 2019-05-26 14:33:09 +02:00
Hypolite Petovan
cc6a17d27a Ensures Widget::postedByYear uid parameter is integer in Module\Profile 2019-05-26 08:18:59 -04:00
Hypolite Petovan
d27d4d8927 Move posted date widget to Content\Widget 2019-05-25 19:08:15 -04:00
Philipp
bd0c536736
Merge pull request #7156 from MrPetovan/task/add-relationship-filter
Add contact relationship filter
2019-05-25 20:17:05 +02:00
Hypolite Petovan
08d7d42f81 Ensures Search methods return an empty ResultList instead of null
- Addresses https://github.com/friendica/friendica/issues/6916#issuecomment-494876901
2019-05-24 08:13:36 -04:00
Hypolite Petovan
0dae4f9492
Fix typo in Module\Contact
Follow-up to #7154, thanks to @AlfredSK
2019-05-23 13:01:40 -04:00
Hypolite Petovan
40ca25f4f7 Fix SQL error in Module\Admin\Summary 2019-05-21 17:01:15 -04:00
Hypolite Petovan
bebff3271b Remove obsolete TODO comment in Module\Profile\Contacts 2019-05-20 15:10:34 -04:00
Hypolite Petovan
c65faecc8c Add current tab parameter to Model\Profile::getTabs 2019-05-20 15:09:33 -04:00
Hypolite Petovan
709eba6ce3 Move /viewcontacts to /profile/{nickname}/contacts[/{type}]
- Add contact relationship filter to profile contacts page
- Include feed contacts in contacts page and contact widget
2019-05-20 14:50:09 -04:00
Hypolite Petovan
e6742af65c Add contact relationship filter to /contact module 2019-05-20 14:50:09 -04:00
Hypolite Petovan
862159c712
Merge pull request #7165 from nupplaphil/task/mod_dirfind
Move mod/dirfind to src/Module/Search/Directory
2019-05-20 14:45:19 -04:00
Hypolite Petovan
0c9b76a585
Merge pull request #7173 from nupplaphil/task/mod_newmember
Move mod/newmember to src/Module/Welcome
2019-05-20 14:14:58 -04:00
Philipp Holzer
f97b72eb9f
Move mod/newmember to src/Module/Welcome 2019-05-20 20:12:20 +02:00
Philipp Holzer
5e79d3fc82
Fixing method signature 2019-05-20 19:19:57 +02:00
Philipp Holzer
2bb2bb19fd
refactor method signature 2019-05-20 19:15:47 +02:00
Philipp Holzer
58c8959da0
Add search types 2019-05-20 19:13:37 +02:00
Philipp Holzer
1e36c68e48
Moving Search to Core, Refactor Objects 2019-05-20 18:42:27 +02:00
Hypolite Petovan
1cd7d50939
Merge pull request #7172 from nupplaphil/task/mod_notice_rm
Remove src/Module/Notice
2019-05-20 12:26:28 -04:00
Philipp Holzer
853f5cb92f
Remove src/Module/Notice
see https://github.com/friendica/friendica/pull/7159#issuecomment-493744623
2019-05-20 18:22:34 +02:00
Hypolite Petovan
325ba20141 Improve Diaspora raw text support in /babel module 2019-05-19 18:52:01 -04:00
Hypolite Petovan
6f0c6e8926
Merge pull request #7160 from nupplaphil/task/mod_probe
Move mod/probe to src/Module/Probe
2019-05-19 15:06:13 -04:00
Philipp
a758671a1b
Merge pull request #7154 from MrPetovan/task/refactor-widgets
Refactor widgets
2019-05-19 20:52:00 +02:00
Philipp Holzer
419cc81ef1
renaming 2019-05-19 05:13:06 +02:00
Philipp Holzer
a7aae9603a
Split Directory Search as a base for further changes 2019-05-19 05:06:02 +02:00
Philipp Holzer
5b44fdc202
Split Directory Search as a base for further changes 2019-05-19 05:01:46 +02:00
Philipp Holzer
2520286b1f
some small improvements 2019-05-19 04:43:09 +02:00
Philipp Holzer
34a1e923dd
dependency lowering 2019-05-19 04:38:35 +02:00
Philipp Holzer
e00f110ef1
Move mod/dirfind to src/Module/DirFind 2019-05-19 04:28:16 +02:00
Philipp Holzer
492d7abe92
Renamed Diagnostic to Debug and deleted ItemSource (already defined) 2019-05-19 04:24:56 +02:00