keith/friendica
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity
36412 commits 4 branches 0 tags 179 MiB
Commit graph

10799 commits

Author SHA1 Message Date
Hypolite Petovan
d3ef2b23cc Don't select deleted contact when in Contact::createFromProbeForUser 2023-01-21 09:18:17 -05:00
Hypolite Petovan
6749ace4b7 Reset pending value when unfollowing a contact 2023-01-21 09:18:17 -05:00
Hypolite Petovan
5519b50900 Apply changes to user-contact table first in Contact::update 
- The truncateFieldsForTable call in the same method was potentially restricting the fields that could be updated in the user-contact table
 2023-01-21 09:18:17 -05:00
Hypolite Petovan
dcfb8bb73e Fix connection acknowledgement not appearing on contact page 
- Remove obsolete template variables
- Move contact_edit vier template to base template
 2023-01-21 09:18:17 -05:00
Roland Häder
27969e8ca6
Continued: 
- moved if() block to suggested position by MrPetovan, for me I want to have all
  conditions checked at the start of the method, e.g. no unwanted null
  references or (in this case) if the URL is blacklisted
- normalized URLs are without SSL, means http://host/path/file.ext so they exist
  only once for contacts and servers (aka. instances)
- documented returned type `void`
 2023-01-21 01:07:14 +01:00
Roland Häder
ba08692403
Continued: 
- just for consistency ...
 2023-01-20 02:43:59 +01:00
Roland Häder
a0704db43a
Continued: 
- some trolls managed to flood gserver with useless URLs. They can be blocked
  by domain blocking them, but still it floods gserver table with dead entries
- this hack tries to change that so they won't enter gserver at all. Let's hope
  these trolls as `activitypub-trolls.cf` learn a lesson (and get adults soon)

Signed-off-by: Roland Häder <roland@mxchange.org>
 2023-01-20 01:50:55 +01:00
Philipp
15938c5b87
Merge pull request #12695 from MrPetovan/bug/fatal-errors 
Address a few fatal errors
 2023-01-19 08:09:03 +01:00
Hypolite Petovan
c05956137a Default maintenance reason to empty string in Module\Maintenance 
- Address https://github.com/friendica/friendica/issues/12486#issuecomment-1383250546
 2023-01-18 21:01:07 -05:00
Hypolite Petovan
3b99b98678 Truncate integer values before inserting them 
- Address https://github.com/friendica/friendica/issues/12486#issuecomment-1383250353
 2023-01-18 20:58:49 -05:00
Hypolite Petovan
d2033d4c92 Allow colon in password 
- It was disallowed because of a too strict intepretation of RFC2617
 2023-01-18 20:34:20 -05:00
Hypolite Petovan
81cd334664 Fix wrong logic in password allowed regular expression 2023-01-18 20:27:29 -05:00
Hypolite Petovan
16e1c8f893
Merge pull request #12690 from annando/statistics 
Nodeinfo data has moved to key values
 2023-01-18 08:37:20 -05:00
Michael
73e163100c Nodeinfo data has moved to key values 2023-01-18 05:04:37 +00:00
Hypolite Petovan
c7e944e793
Merge pull request #12680 from nupplaphil/feat/addon_logger 
Introduce new Hook logic
 2023-01-17 16:37:03 -05:00
Michael
259fe7fcf2 Merge remote-tracking branch 'upstream/develop' into blocked-server 2023-01-17 19:25:09 +00:00
Philipp
5358e195d7
Fix Introspection 2023-01-17 20:11:48 +01:00
Philipp
8eed43a7dd
Add whitespace .. 2023-01-17 19:23:20 +01:00
Philipp
3b262f44a3
Adhere feedback 2023-01-17 19:15:37 +01:00
Philipp
eed6db2465
Apply suggestions from code review 
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
 2023-01-17 19:12:33 +01:00
Michael
356a2a9a5a News "blocked" field on the gserver table 2023-01-17 17:25:19 +00:00
Daniel Siepmann
da58b894a4
Properly handle feed item creation date with surrounding whitespace 
Some feeds might have whitespace around the creation date.
This can't be parsed by DateTimeFormat methods.
Therefore the incoming creation date is trimmed to not contain any
surrounding whitespace for proper handling.

Relates: #12686
 2023-01-17 07:18:47 +01:00
Philipp
293c121c48
Adhere PHP-CS.. 2023-01-16 22:25:26 +01:00
Philipp
f609e38600
Introduce new Hook logic 
- InstanceManager for computing strategies and to allow decorators
- Adapting Core\Logger to use it
 2023-01-16 22:20:33 +01:00
Philipp
ab6efea9b2
Replace Config-Cache dependency with Config-Model (no more DB-waiting necessary) 2023-01-15 16:17:08 +01:00
Philipp
a6fb683bcd
Remove BasePath dependency from App\Mode 2023-01-15 16:17:07 +01:00
Philipp
dd6d96d048
Merge pull request #12678 from MrPetovan/bug/12677-addon_admin 
Remove App dependency from addon admin form method
 2023-01-15 15:55:08 +01:00
Hypolite Petovan
6e4663e747 Remove App dependency from addon admin form method 2023-01-15 09:42:18 -05:00
Hypolite Petovan
21f172c585
Merge pull request #12674 from nupplaphil/bug/config_typesafe 
Config: Improve the node.config.php transformation
 2023-01-15 09:38:29 -05:00
Philipp
bc60eb6cb7
Apply feedback and describe the encoding method 2023-01-15 11:57:43 +01:00
Philipp
d63aca97b8
Merge pull request #12673 from annando/andstatus-api 
API: Accept "redirect_uris" as both array and string
 2023-01-15 01:01:06 +01:00
Philipp
4c28f9cf9c
Config: Improve the node.config.php transformation 
- Add more types
- Improvement for assoziative arrays and key-value arrays
- Add a lot more tests
 2023-01-15 00:53:51 +01:00
Michael
e06f699dd9 Added Documentation, updated messages.po 2023-01-14 21:20:04 +00:00
Michael
af2a38c5b3 API: Accept "redirect_uris" as both array and string 2023-01-14 21:07:47 +00:00
Philipp
0c14e51112
Merge pull request #12666 from MrPetovan/bug/12661-public-calendar-export 
Enable calendar export for public_calendar = true
 2023-01-14 19:20:20 +01:00
Hypolite Petovan
323765110c Enable calendar export for public_calendar = true 2023-01-14 10:39:18 -05:00
Hypolite Petovan
e73adde5fb Remove App dependency from Hook::callSingle 
- This was causing a circular dependency with the logger_instance hook
 2023-01-14 10:38:37 -05:00
Hypolite Petovan
2d555b60dd
Merge pull request #12670 from annando/fix-avatar-cache 
Ensure to reset the avatar paths when deleting avatar cache
 2023-01-14 09:47:21 -05:00
Michael
3e3f2555dc Ensure to reset the avatar paths when deleting avatar cache 2023-01-14 13:10:43 +00:00
Hypolite Petovan
91ff24b0e4
Merge pull request #12663 from nupplaphil/sec/xss_404 
Security: Use htmlspecialchars() for user input in Arguments class
 2023-01-13 13:57:41 -05:00
Philipp
0530755332
Security: Use htmlspecialchars() for user input in Arguments class 2023-01-12 20:24:39 +01:00
Hypolite Petovan
a7d0355849
Merge pull request #12659 from DanielSiepmann/12658-fix-feed-urls-with-whitespace 
Properly handle feed item urls with surrounding whitespace
 2023-01-12 07:57:30 -05:00
Daniel Siepmann
6633b0af4b
Properly handle feed item urls with surrounding whitespace 
Some feeds might have whitespace around the URLs of each item.
This can't be handled by parse_url.
Therefore the incoming url is trimmed to not contain any surrounding
whitespace for proper handling.

Relates: #12658
 2023-01-12 13:47:57 +01:00
Michael
8a902afde5 Updated messages.po - again 2023-01-12 07:06:24 +00:00
Michael
6cdafb6b63 Fix "Undefined constant Friendica\Content\Conversation::PARCEL_DIASPORA" 2023-01-12 06:57:31 +00:00
Michael
f542211189 Mode depending control for the behaviour with blocked contacts 2023-01-12 06:25:55 +00:00
Hypolite Petovan
ec54b303c5
Merge pull request #12655 from annando/fix-communication 
Fix: Forum posts from some contacts weren't distributed
 2023-01-11 17:04:41 -05:00
Michael
53e8b21ca3 Fix: Forum posts from some contacts weren't distributed 2023-01-11 21:55:32 +00:00
Philipp
fef10e8a57
Improve encapsulation 2023-01-11 22:00:29 +01:00
Philipp
11a8bd17e3
Assure that deleted cat/keys are working as expected 
- A deleted cache-key would delete a merged cache-key as well
- Deleting a key in the Model results in reloading the config to assure any value from underlying files
 2023-01-11 21:53:34 +01:00
Philipp
fd882abd80
Revert Cache delete() behavior to stable version 2023-01-11 21:10:59 +01:00
Hypolite Petovan
5c8cd8fdd6 Replace remaining mentions of "Status" by "Conversations" or "Posts" 2023-01-11 09:01:29 -05:00
Hypolite Petovan
d0648b10ef Convert Content\Nav to dynamic object 
- Remove DI dependency in Module\Apps
 2023-01-11 09:01:24 -05:00
Hypolite Petovan
3966b58965 Only show line number if it's provided in System::callstack 
- Address https://github.com/friendica/friendica/issues/12488#issuecomment-1377373973
 2023-01-10 10:41:20 -05:00
Hypolite Petovan
3fcafd1d50 Replace HTML regular expression by HTML::extractCharset in ParseUrl::getSiteInfo 
- Address https://github.com/friendica/friendica/issues/12488#issuecomment-1374537440
 2023-01-10 10:36:59 -05:00
Hypolite Petovan
5e2b655b43 Add implementation of HTTP Media Type 
- Add charset extraction from DOMDocument
- TESTS!
 2023-01-10 10:36:58 -05:00
Hypolite Petovan
f4b5d22396
Merge pull request #12644 from annando/improve-ignore 
Improve the ignore behaviour
 2023-01-10 09:05:48 -05:00
Michael
20a2cec0b0 Moved permission assigning / simplified block check 2023-01-10 05:59:25 +00:00
Hypolite Petovan
14e4c0db8e Check image property is set in Object\Image 
- Property was either an object or null, strict comparison with "false" was inaccurate
- Address https://github.com/friendica/friendica/issues/12486#issuecomment-1374888800
 2023-01-09 16:06:22 -05:00
Hypolite Petovan
b77f3a7525 Check for URI ID existence in Post\Media::insert 
- Address https://github.com/friendica/friendica/issues/12486#issuecomment-1374538325
 2023-01-09 16:06:22 -05:00
Hypolite Petovan
4d5d8e5b64 Add line number to output in System::callstack 2023-01-09 16:06:22 -05:00
Hypolite Petovan
670b518875 Include other unique key column in condition in Model\Tag:store 
- Address https://github.com/friendica/friendica/issues/12486#issuecomment-1372640002
 2023-01-09 16:06:22 -05:00
Michael
4e0da578fa Merge remote-tracking branch 'upstream/develop' into improve-ignore 2023-01-09 17:23:10 +00:00
Hypolite Petovan
6bee344681 Add yet another case to DateTimeFormat::fix 
- Address https://github.com/friendica/friendica/issues/12488#issuecomment-1372637862
 2023-01-09 11:38:25 -05:00
Michael
840f25cc5c Improve ignoring of messages 2023-01-09 16:23:39 +00:00
Michael
cd3dbad2a8 Fix some warnings on item creation 2023-01-09 15:55:35 +00:00
Michael Vogel
c1f9c1aaa5
Apply suggestions from code review 
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
 2023-01-08 23:13:31 +01:00
Michael
480d9f53c3 Added "collapsed" list 2023-01-08 18:28:19 +00:00
Michael
50746bad55 Merge remote-tracking branch 'upstream/develop' into collapse 2023-01-08 17:47:21 +00:00
Michael
50e43c530e Posts from contacts can now be collapsed 2023-01-08 17:40:05 +00:00
Hypolite Petovan
0ae7a53daa
Merge pull request #12637 from annando/ostatus-subscription 
OStatus: Fix PubSubHubBub subscription
 2023-01-08 07:58:22 -05:00
Michael Vogel
1ef9768b98
Apply suggestions from code review 
Co-authored-by: Philipp <admin+Github@philipp.info>
 2023-01-08 13:00:58 +01:00
Michael
c3d836db63 OStatus: Fix PubSubHubBub subscription 2023-01-08 09:41:54 +00:00
Tobias Diekershoff
6bf670f64e
Merge pull request #12633 from MrPetovan/bug/12624-api-thumbnail 
Change "thumbnail" for default Friendica banner image in Api\Mastodon\Instance
 2023-01-08 08:28:24 +01:00
Hypolite Petovan
97642e770b Treat unsupported API call as HTTP error 2023-01-07 22:47:52 -05:00
Hypolite Petovan
8ad94fef9b Change "thumbnail" for default Friendica banner image in Api\Mastodon\Instance 2023-01-07 22:39:07 -05:00
Philipp
979672a3c1
Filter disabled addons with "null" 2023-01-08 02:49:56 +01:00
Philipp
5ea50a9e81
Fix "null" addon list 2023-01-08 02:49:56 +01:00
Philipp
2293ff6206
Add test for Addon failures 2023-01-08 02:49:56 +01:00
Philipp
0429a4e429
Fix loading empty node.config.php 2023-01-08 02:49:56 +01:00
Michael
aa3dc7c40c Add configuration 2023-01-07 21:28:21 +00:00
Michael
49c1ad2cc0 Merge remote-tracking branch 'upstream/develop' into diaspora-item 2023-01-07 21:21:51 +00:00
Hypolite Petovan
5fd3d4bda3
Merge pull request #12628 from nupplaphil/bug/typeerror 
Don't ksort() or loop without an addon array
 2023-01-07 15:06:28 -05:00
Michael
24c32cff0d Merge remote-tracking branch 'upstream/develop' into diaspora-item 2023-01-07 19:52:23 +00:00
Philipp
6aaf1ea5d4
Fix addons problem more elegant 2023-01-07 20:49:29 +01:00
Philipp
9fb5b95b5e
Fix other foreach() troubles at Addon.php 2023-01-07 19:54:59 +01:00
Michael Vogel
d5bc6d0006
Apply suggestions from code review 
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
 2023-01-07 19:54:13 +01:00
Philipp
6454c1dee7
Don't ksort() on null 2023-01-07 19:52:43 +01:00
Michael
f5fd99f7ea Unbneeded strlen removed 2023-01-07 18:51:28 +00:00
Michael
4e4eab7548 Merge remote-tracking branch 'upstream/develop' into mod-item 2023-01-07 17:14:40 +00:00
Michael
d86045058e Diaspora: Photos are now transmitted separately 2023-01-07 15:11:34 +00:00
Philipp
6bd1740a94
omg .. wrong assertion .. 2023-01-07 15:49:55 +01:00
Philipp
6e4e2c4a82
Fix warning text 2023-01-07 15:30:45 +01:00
Philipp
b7a2b6b352
Update src/Module/Admin/Summary.php 
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
 2023-01-07 15:28:49 +01:00
Philipp
6e0d16f22b
Add warning message in case node.config.php isn't writable 2023-01-07 15:16:55 +01:00
Hypolite Petovan
308618b559
Merge pull request #12622 from nupplaphil/bug/config 
`node.config.php` bugfixings
 2023-01-07 08:45:53 -05:00
Philipp
80e8f4aa34
Execute critical worker tasks, even if we're in daemon mode 2023-01-07 13:43:16 +01:00
Philipp
abd3b2180f
Merge pull request #12619 from MrPetovan/task/12617-remove-no_auto_update 
Remove system.no_auto_update personal config key and assume default value of true
 2023-01-06 17:54:36 +01:00
Philipp
5b2e02889e
Fix Update::run() 2023-01-06 17:50:56 +01:00
Philipp
baf3225916
Apply Update::check() suggestions 2023-01-06 12:50:14 +01:00
Philipp
c35fd68ec2
Adapt doc 2023-01-06 12:47:00 +01:00
Philipp
beb3d376b2
Apply suggestions from code review 
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
 2023-01-06 12:46:06 +01:00
Philipp
05048d4abf
Update src/Core/Config/ValueObject/Cache.php 
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
 2023-01-06 12:43:04 +01:00
Philipp
70704ccb19
Update src/Core/Update.php 
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
 2023-01-06 12:42:56 +01:00
Philipp
9462bfa763
Update src/Core/Config/Util/ConfigFileManager.php 
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
 2023-01-06 12:42:43 +01:00
Philipp
b3772163d8
Add doc 2023-01-06 03:06:11 +01:00
Philipp
ce8c820221
add description 2023-01-06 02:54:34 +01:00
Philipp
d53cb31869
Update src/Core/Config/Util/ConfigFileManager.php 
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
 2023-01-06 02:16:35 +01:00
Philipp
e14050491a
Config fixing 
- unlock/close the `node.config.php` in every circumstances
 2023-01-06 01:10:57 +01:00
Philipp
5aa8e8adf1
Config fixings 
- Delete now really overwrites static default/setting.config.php keys
- Delete now really overwrites static default/setting.config.php categories
- The Update::check() routine is added to different places
- Merge the given config file with the new config before writing
- Remove ConfigTransaction::get() because it's no more reliable
 2023-01-06 01:03:00 +01:00
Philipp
cdd57275eb
Some improvements 
- Move $_SERVER into ConfigFileManager constructor
- Rename "creatConfigFileLoader" to "createConfigFileManager"
- Rename variable "loader" to "manager" in all tests
 2023-01-06 01:03:00 +01:00
Philipp
b4096251ba
Check 'config' table as fallback for migrations 2023-01-06 01:03:00 +01:00
Hypolite Petovan
6685157f8a Cast alert types to boolean in Api\Mastodon\Subscription 2023-01-05 11:54:01 -05:00
Hypolite Petovan
3b9bf4d70d Remove system.no_auto_update personal config key and assume default value of true 
- By popular request, the behavior with false was too perturbating
 2023-01-05 10:27:03 -05:00
Hypolite Petovan
dfcfae6bcc Replace $_GET references with $request in Update classes 2023-01-05 10:23:25 -05:00
Michael Vogel
2f28ec7af0
Merge pull request #12615 from MrPetovan/task/12601-update-gserver-block 
Drop UpdateGServer worker task if domain is blocked
 2023-01-05 12:37:00 +01:00
Philipp
4b17d6f3bf
Update src/Core/Addon.php 
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
 2023-01-04 23:12:41 +01:00
Michael
9a1a406c03 Preview of attached links work again 2023-01-04 21:52:02 +00:00
Philipp
01403d15c4
sort addon array 2023-01-04 21:55:51 +01:00
Philipp
13b234d279
Use addons config entries instead of the addon table 2023-01-04 21:55:51 +01:00
Philipp
cd11088cc4
Move 'addon' table into config 2023-01-04 21:55:51 +01:00
Hypolite Petovan
647ab1d04a Drop UpdateContact worker task if contact is blocked 2023-01-04 14:41:09 -05:00
Hypolite Petovan
1f3c07c06f Drop UpdateGServer worker task if domain is blocked 2023-01-04 14:41:09 -05:00
Hypolite Petovan
a907d6c87b Add UriInterface-enabled isUriBlocked method in Util\Network 2023-01-04 14:41:08 -05:00
Hypolite Petovan
a574146f04 Add UriInterface-enabled cleanUri method in Model\GServer 
- Tests!
 2023-01-04 14:41:08 -05:00
Philipp
dce86be58e
Just commit config transactions if something changed 2023-01-04 19:55:22 +01:00
Philipp
aabe39220d
Make flock writing easier 2023-01-04 08:16:40 +01:00
Philipp
c057954896
Make BaseURL check/save transactional and make the whole process easier 2023-01-04 08:14:00 +01:00
Michael
d1a951f0ac Post processing centralized 2023-01-04 06:52:40 +00:00
Michael
0d56f156f7 Code cleanup for mod/item.php 2023-01-04 05:44:52 +00:00
Philipp
17105cf7d1
Fix config read/write locking 2023-01-04 00:25:18 +01:00
Philipp
4c2fc3ea38
Reduce config->set() load for worker executions 2023-01-04 00:25:15 +01:00
Philipp
176af67e88
Fix empty fetchResult curResult at Link::fetchMimeType (thx to Marco R.) 2023-01-03 21:06:16 +01:00
Philipp
3110831131
Fix empty fetchResult at ExternalStorage (thx to Marco R.) 2023-01-03 21:05:58 +01:00
Philipp
beff759c82
Update src/Core/Config/Model/ConfigTransaction.php 
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
 2023-01-03 17:39:32 +01:00
Philipp
a46cd2fb36
Remove get() from config transaction interface 2023-01-03 17:26:48 +01:00
Philipp
b439df892a
Apply suggestions 2023-01-03 17:24:05 +01:00
Philipp
dd88d193b9
Escape single quotes and backslashes 2023-01-03 15:36:36 +01:00
Philipp
65d79d4c93
Introduce ISetConfigValuesTransactional for transactional config behaviour 2023-01-03 14:22:07 +01:00
Philipp
4d4b4a8858
Revert BaseURL 2023-01-03 14:22:07 +01:00
Philipp
376e0a9397
Fix Admin\Site 2023-01-03 14:22:07 +01:00
Philipp
ae1533e312
Apply suggestions from code review 
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
 2023-01-03 14:22:06 +01:00
Philipp
88b3effc18
Use toConfigValue in case of serialized, legacy data 2023-01-03 14:22:05 +01:00
Philipp
10f3de0aa2
Remove deprecated Mode::DBCONFIGAVAILABLE 2023-01-03 14:22:04 +01:00
Philipp
1e574d5383
Refactor IManageConfigValues interface 2023-01-03 14:22:04 +01:00
Philipp
d272e8c3c7
Remove unnecessary classes 2023-01-03 14:22:03 +01:00
Philipp
b871e1d264
Introduce lightweight Config model 2023-01-03 14:22:02 +01:00
Philipp
0f91d1cbde
Introduce ConfigFileManager for config files 2023-01-03 14:22:02 +01:00
Philipp
fea4b202c1
Introduce ConfigFileTransformer for Config files 2023-01-03 14:22:02 +01:00
Hypolite Petovan
9c256ad76f Remove obsolete OExchange module and reference 
- Protocol looks unsupported for a decade now
 2023-01-01 19:20:42 -05:00