Commit graph

6173 commits

Author SHA1 Message Date
Michael
74081a71ff Removed unused "use" 2020-05-01 13:26:13 +00:00
Michael
029a379060 Move "isType" to Tag.php 2020-05-01 12:39:41 +00:00
Michael
ac2957c4dd Some more "term" to "tag" conversion 2020-05-01 10:57:32 +00:00
Michael
1f64e672ba Subscribed tags are now based on the tags as well 2020-05-01 07:18:15 +00:00
Michael
8c44f535b7 Merge remote-tracking branch 'upstream/develop' into write-tags 2020-04-29 02:38:33 +00:00
Michael
10ffd3a374 Iissue 8560: Wrong value for parent in mail notification 2020-04-28 20:32:39 +00:00
Michael
70e5639e29 Merge 2020-04-28 13:33:03 +00:00
Michael
f75009c20c Some more forgotten DBA::close 2020-04-28 07:10:18 +00:00
Michael
7f5f68a904 More preparations for term to tag transition 2020-04-26 16:15:39 +00:00
Michael
a5aa43469b Some more places with owner-view 2020-04-24 13:41:11 +00:00
Michael
c4f7f3e26e And some more view calls added 2020-04-24 12:59:19 +00:00
Michael
0950e4bada Another view 2020-04-24 12:09:51 +00:00
Michael
4181eb37f5 More joins replaced by view calls 2020-04-24 11:55:46 +00:00
Hypolite Petovan
43b8bdea07
Merge pull request #8520 from annando/term2tag
We now store tags in "tag"
2020-04-22 22:56:07 -04:00
Hypolite Petovan
16f48731b1 Remove album name bin2hex conversion in file browser
- Avoids Javascript hex2bin() limitation to Latin-1 string encoding
2020-04-21 22:14:11 -04:00
Michael Vogel
ee098277b9
Merge pull request #8530 from MrPetovan/task/8498-move-poke-to-src
Move poke module to src/
2020-04-21 05:56:59 +02:00
Hypolite Petovan
7f04aea8b1 Move poke module to src/
- Add new route contact/<cid>/poke and update all references
- Rework template with form field includes
- [frio] Enable modal behavior
2020-04-20 11:47:08 -04:00
Michael
9e9a104320 Tags can now be added and removed from photos 2020-04-18 20:46:41 +00:00
Michael
060503eb44 Tagger is now storing the tag as well 2020-04-17 13:36:55 +00:00
Michael
3ff607deee Store tags for locally created posts 2020-04-15 19:46:47 +00:00
Michael
661dd43b0d Term constants updated 2020-04-13 19:24:22 +00:00
Hypolite Petovan
1e32f74b0b Rework Module/Objects
- Merge two item queries into one
- Add ETag check
- Use Router parameter
2020-04-05 18:00:46 -04:00
Hypolite Petovan
594db70a72
Merge pull request #8500 from lynn-stephenson/develop
Fix Password Reset Token Security
2020-04-05 08:15:31 -04:00
Lynn Stephenson
6cbcea1aac
Update lostpass.php
reduce info leakage on password reset tokens
2020-04-04 08:10:39 +00:00
Lynn Stephenson
f459a35cf4
Update lostpass.php
use CSPRNG for password reset token generation
2020-04-04 08:06:49 +00:00
Hypolite Petovan
40a7a43bd2 [frio] Add link to Compose page in jot 2020-04-03 16:33:00 -04:00
Hypolite Petovan
5ce404f517 Refactor user settings page
- Fix header hierarchy
- [frio] Fix panel display
- Move checkbox sub-template calls to template
2020-04-01 19:06:00 -04:00
Hypolite Petovan
3c50f985a9 Remove modal window for default post permission setting 2020-04-01 09:21:26 -04:00
Michael
d3722c945b Improved Mime Type detection 2020-04-01 05:42:44 +00:00
Steffen K9
6ea9c1764c
remove default from match.php 2020-03-29 11:37:23 +02:00
Steffen K9
0ddda6160b
Remove multi profile mention in settings
Remove multi/default profile mention in settings privacy.
2020-03-29 11:17:08 +02:00
Hypolite Petovan
7fabafdce6 Enable visibility request parameter to override default user permissions in mod/item 2020-03-24 16:34:19 -04:00
Michael
8bde222fca Issue 8371: Use correct user id for photo upload 2020-03-22 14:07:34 +00:00
Michael
505aa95c3d Fixed wrong contact permisssion 2020-03-22 10:05:52 +00:00
Michael
6de2b0f6d4 Reworked permission stuff 2020-03-21 18:30:40 +00:00
Michael
2234a095c6 Issue 8371 again: Fallback for item permissions 2020-03-20 04:52:04 +00:00
Michael
29bd37cda2 Issue 8371: Ensure to always have permissions 2020-03-19 21:55:31 +00:00
Michael
37376fa715 Issue 8371: Improvements for picture permissions 2020-03-08 13:16:59 +00:00
Michael
a55057d974 Function renamed to better reflect the purpose 2020-03-05 08:03:05 +00:00
Michael
825a7f9f93 Issue 8321: Follow items now work again 2020-03-05 07:16:47 +00:00
Michael
55f43be92a Changed setting description 2020-03-03 04:03:37 +00:00
Michael
a19151fa6a Improved description, support for "unlisted" via DFRN as well. 2020-03-02 22:35:25 +00:00
Michael
72c198990e Merge remote-tracking branch 'upstream/develop' into private 2020-03-02 15:05:00 +00:00
Michael
31f912b78e Warning removed 2020-03-02 14:51:53 +00:00
Michael
4bf04dd6ee Fixed fatal error 2020-03-02 12:29:08 +00:00
Michael
ca1b92bb34 Support unlisted public posts 2020-03-02 07:57:23 +00:00
Philipp
27b60b200e
Merge pull request #8352 from MrPetovan/bug/8002-album-drop-cancel
Use sensible URLs for return after album actions instead of $_SESSION['photo_return'] in mod/photos
2020-03-01 22:21:33 +01:00
Michael Vogel
057df09ffb
Merge pull request #8353 from MrPetovan/bug/8219-frio-fix-contact-csv-import
[frio] Enable file upload in settings form
2020-03-01 21:08:19 +01:00
Hypolite Petovan
ad2b9198a4 Remove last on/off data occurrences in additional features
- Address https://github.com/friendica/friendica/issues/7999#issuecomment-589808923
2020-03-01 14:15:08 -05:00
Hypolite Petovan
7ef3308a8d Improve feedback in mod/settings 2020-03-01 10:15:35 -05:00
Hypolite Petovan
f814ca30d3 Use sensible URLs for return after album actions instead of $_SESSION['photo_return'] in mod/photos 2020-03-01 09:56:02 -05:00
nupplaPhil
4f2bea5cb1
Move "regmod" functionality into Admin Users page 2020-02-29 17:10:29 +01:00
nupplaPhil
b4f6e8fda1
Move "User::deny()" to own method and update usages 2020-02-29 17:10:28 +01:00
nupplaPhil
6aee153bbd
Move "User::allow()" to own method and update usages 2020-02-29 17:10:27 +01:00
Philipp
b0690077aa
Merge pull request #8329 from MrPetovan/bug/notices
Remove unused conversation response code
2020-02-25 21:45:13 +01:00
Hypolite Petovan
e94911620a Expand system.no_auto_update to community, profile statuses and contact conversations pages
- Update setting name and description
2020-02-23 19:38:24 -05:00
Hypolite Petovan
452d7e6404 Remove unused conversation response code
- Remove get_responses()
- Remove get_response_button_text()
- Remove title key from $conv_responses array
- Address https://github.com/friendica/friendica/issues/8000#issuecomment-589263329
2020-02-22 20:41:12 -05:00
Hypolite Petovan
b2bfec3381 Remove unused template variable in mod/photos 2020-02-22 20:30:28 -05:00
Michael
9cbea34fa4 Clean the profile URL when follow 2020-02-22 12:29:33 +00:00
Michael
d03fb89494 Replace "hidewall" with "net-publish" / other "hidewall" stuff 2020-02-20 17:24:41 +00:00
Hypolite Petovan
637e38e535 User hide_dislike user setting to hide dislike button and conversation responses 2020-02-20 05:37:07 -05:00
Hypolite Petovan
1a8110234f Move /settings/display module to src/ 2020-02-20 05:37:06 -05:00
Michael
5ea27b1fd5 "fetch" instead of "add" 2020-02-19 20:34:25 +00:00
Michael
7ee9aad6ca Some more unneeded settings removed 2020-02-19 19:31:55 +00:00
Michael
c57246450f "Delegations" is renamed to "Accounts" 2020-02-19 07:09:29 +00:00
Michael
1d3586623c Replace "suggestme" with "net-publish" 2020-02-17 07:16:45 +00:00
Michael
101251668c Reworked expiration settings 2020-02-16 20:44:55 +00:00
Philipp
da124af6ed
Merge pull request #8293 from MrPetovan/task/5562-community-pagination
Improve community pagination
2020-02-16 19:38:49 +01:00
Hypolite Petovan
e0d03615bc Add node-wide default items per page config 2020-02-16 13:04:26 -05:00
Hypolite Petovan
561472b975 Add L10n parameter to Pager classes 2020-02-16 12:50:39 -05:00
Michael
ee6cceba30 Clarify the effect of "net-publish" 2020-02-16 15:39:44 +00:00
Michael
3bd1f3a836 No more gender 2020-02-16 10:55:18 +00:00
Hypolite Petovan
682fb7e4e2 Move community module to src/
- Use boundaries pagination instead of number pages
- Trim down community update module output
- Part of https://github.com/friendica/friendica/issues/4090
2020-02-16 04:41:22 -05:00
Hypolite Petovan
5d169a4098 Add System::htmlUpdateExit() method to refactor update modules 2020-02-16 04:32:56 -05:00
Hypolite Petovan
0b0309ce8f Remove pager parameter from conversation()
- Add getUrlParameter() Javascript function to determine current page
2020-02-13 23:40:00 -05:00
Hypolite Petovan
95b09aaec4 [frio] Add loading animation on comment form submit 2020-02-11 23:45:47 -05:00
Michael Vogel
13a10b8f20
Merge pull request #8277 from MrPetovan/task/8251-use-about-for-pdesc
Remove profile about field double HTML escaping
2020-02-12 05:23:04 +01:00
Hypolite Petovan
1ce5b1d65b Remove profile about field double HTML escaping
- Add BBcode conversion for profile.about in widget/vcard.tpl
2020-02-11 21:38:42 -05:00
Michael Vogel
e80d68ba53
Merge pull request #8261 from MrPetovan/task/8251-use-about-for-pdesc
Use profile.about for profile description
2020-02-10 23:36:59 +01:00
Hypolite Petovan
2ec3a97393
Merge pull request #8263 from annando/remote-follow
New page for remote follow requests
2020-02-09 17:53:13 -05:00
Michael
2eebeeaa32 New page for remote follow requests 2020-02-09 17:04:35 +00:00
nupplaPhil
7d714319c8
Add license info at Friendica PHP files 2020-02-09 16:34:23 +01:00
nupplaPhil
85dc9bb96b
Add license info at Friendica PHP files 2020-02-09 16:18:46 +01:00
Hypolite Petovan
a42104ce43 Use profile.about instead of profile.pdesc for profile description 2020-02-09 02:36:19 -05:00
Hypolite Petovan
6bcb96982a Switch to second person in dfrn_request "know you" field 2020-02-09 01:01:11 -05:00
Hypolite Petovan
2fb1819e57 Simplify dfrn_request and auto_request templates
- Limit template variables
2020-02-08 17:08:01 -05:00
Hypolite Petovan
7f402da40f Fix undefined variable in contact import n mod/settings 2020-02-07 21:27:35 -05:00
Hypolite Petovan
b53f2f2933
Merge pull request #8250 from annando/issue-8233
Issue 8233: Fix remote subscriptions
2020-02-06 20:00:13 -05:00
Michael
150c74be69 Issue 8233: Fix remote subscriptions 2020-02-06 22:45:22 +00:00
Hypolite Petovan
557ece7d5a Remove unused translated yes/no labels in converted checkbox field definitions 2020-02-06 10:25:36 -05:00
Michael
4f362f6693 Asynchronously add contacts to avoid timeout problems 2020-02-06 00:00:00 +00:00
nupplaPhil
a78e19ea76
Move Notify::TYPE_POKE 2020-02-05 21:41:05 +01:00
nupplaPhil
51260f234f
Move Notify::TYPE_TAGSELF 2020-02-05 21:41:04 +01:00
nupplaPhil
88dc3efdc9
Move Notify::TYPE_SUGGEST 2020-02-05 21:41:03 +01:00
nupplaPhil
9435cc4b88
Move Notify::TYPE_MAIL 2020-02-05 21:41:02 +01:00
nupplaPhil
e6fb044e60
Move Notify::TYPE_COMMENT 2020-02-05 21:41:02 +01:00
nupplaPhil
b86ad37001
Move Notify::TYPE_WALL 2020-02-05 21:41:01 +01:00
nupplaPhil
6e45514e2c
Move Notify::TYPE_CONFIRM 2020-02-05 21:41:00 +01:00
nupplaPhil
cfd50f9abb
Move Notify::TYPE_INTRO 2020-02-05 21:41:00 +01:00
Hypolite Petovan
3f57e16a1a
Merge pull request #8236 from annando/a11y-1
Accessibility: A checkbox is a checkbox
2020-02-05 12:10:16 -05:00
Michael
07148ecf6b Acessibility: A checkbox is a checkbox 2020-02-05 08:08:32 +00:00
nupplaPhil
0b94b84dc7
simplify mail creation 2020-02-04 21:05:33 +01:00
nupplaPhil
262c94f12f
Fix indents 2020-02-02 22:43:43 +01:00
nupplaPhil
6700467ed4
switched intend 2020-02-02 22:43:43 +01:00
nupplaPhil
97e708f2e2
Remove DI::app() dependency again 2020-02-02 22:43:41 +01:00
nupplaPhil
9428466d1d
Set Sitename / site email as sender for system emails 2020-02-02 22:43:39 +01:00
nupplaPhil
16d9b9ff7d
Fixed wrong email field 2020-02-02 22:43:36 +01:00
nupplaPhil
3291728059
Extract System emails from enotify
- Removed every SYSTEM_EMAIL occurrence in enotify
- Introduced a "SystemMailBuilder" for build system emails
- Replaced every SYSTEM_EMAIL usage in the classes with calling this builder
- Added tests for this new Builder
- Split the email templates between "base" template for email and concrete usages for different use cases
2020-02-02 22:43:35 +01:00
Hypolite Petovan
a3028e69aa
Merge pull request #8211 from nupplaphil/task/mod_crepair
Move mod/crepair to src/Module/Contact/Repair
2020-02-01 08:28:29 -05:00
Hypolite Petovan
96b9619608
Merge pull request #8210 from nupplaphil/task/mod_fsuggest
Move mod/fsuggest to src/Module/SuggestFriend
2020-01-31 18:43:32 -05:00
nupplaPhil
f565d590f6
Move mod/crepair to src/Module/Contact/Repair 2020-02-01 00:20:50 +01:00
nupplaPhil
d4e836855b
Remove deprecated code 2020-02-01 00:05:27 +01:00
nupplaPhil
17389de261
Move mod/worker to src\Module\Worker 2020-01-31 22:38:49 +01:00
Philipp
4c07c725b6
Merge pull request #8203 from MrPetovan/task/4599-frio-jot-async
[frio] Add new asynchronous submission of modal form
2020-01-30 06:42:12 +01:00
Hypolite Petovan
ada9e2a0f2 Suppress Countable type warning messages in mod/dfrn_request
- Address https://github.com/friendica/friendica/issues/8192
2020-01-29 23:19:03 -05:00
Hypolite Petovan
b2143cae53 [frio] Add new asynchronous submission of modal form
- Add loading state for jot submit buttons
2020-01-29 22:50:10 -05:00
Hypolite Petovan
3370300376 Add new info messages to mod/item 2020-01-29 22:45:13 -05:00
Hypolite Petovan
b86083de06 Remove superfluous code in mod/item 2020-01-29 22:44:09 -05:00
Hypolite Petovan
4faad5a47c Replace exit calls with exception throwing in mod/item 2020-01-29 22:43:37 -05:00
Hypolite Petovan
b03796957b Improve logging in mod/item
- Set legacy Logger constants as deprecated
2020-01-29 22:42:49 -05:00
Hypolite Petovan
c17b2efb7a Normalize redirect in item_post() 2020-01-29 22:34:32 -05:00
Hypolite Petovan
694d93ded9 Replace json_encode + exit by System::jsonExit in mod/item 2020-01-29 22:31:13 -05:00
nupplaPhil
c2b8c65104
Merge "notification" routes 2020-01-28 23:21:24 +01:00
Hypolite Petovan
a7dd0173a7 Remove obsolete profile_id parameter in Model\Profile::load 2020-01-27 22:01:12 -05:00
Hypolite Petovan
a607656607 Replace profile tab GET parameter by route 2020-01-27 19:21:18 -05:00
Hypolite Petovan
589b7e718d
Merge pull request #8178 from nupplaphil/task/mod_noscrape
Move mod/noscrape to Module\Noscrape
2020-01-26 17:14:26 -05:00
nupplaPhil
4260b94fec
Move mod/noscrape to Module\Noscrape 2020-01-26 23:43:47 +01:00
Philipp
9827e933a2
Merge pull request #8179 from MrPetovan/bug/notices
Various notice fixes
2020-01-26 23:10:56 +01:00
Hypolite Petovan
fb2f8dcb9c
Improve formatting in mod/display
Co-Authored-By: Philipp <admin+Github@philipp.info>
2020-01-26 16:59:02 -05:00
Hypolite Petovan
0736e4e42c Check for $a->user["nickname"] existence before retrieving its value in mod/display
- Addresses part of https://github.com/friendica/friendica/issues/8000#issuecomment-573883153
2020-01-26 16:44:02 -05:00
nupplaPhil
2b8f067715
Introduce interface for emailing and create email classes 2020-01-26 21:35:04 +01:00
nupplaPhil
915abe8a33
Add explicit parameters to Sender::send() method signature 2020-01-26 21:35:03 +01:00
nupplaPhil
ea9d3b7438
Make EMailer util dynamic 2020-01-26 21:35:03 +01:00
Philipp
9269221825
Merge pull request #8175 from MrPetovan/task/revert-profile-default-tab
Revert profile base URL behavior
2020-01-26 20:33:27 +01:00
Hypolite Petovan
f2d917114f Move Model\Profile::getTabs to new Module\BaseProfile class 2020-01-26 14:21:18 -05:00
nupplaPhil
0840938dff
Rename classes
- Repository/Model Notification => Notify
- Factory/Object Notification => Notification
2020-01-26 20:30:24 +01:00
nupplaPhil
0850fb88dd
ReWork Notification Model/Module/Object/Repository/Factory
- Introduce Repository for interaction with "notify" table
- Introduce Factory for read-only notification objects (they're just loosely based on notification the table!)
- Introduce Objects for type-safe usage at the presentation layer
- Reworked Model, which is now fully based on the notify table, including generated fields (cache, ..)
2020-01-25 19:58:22 +01:00
nupplaPhil
5a9ec841af
Make Notification bubble work again 2020-01-25 17:25:11 +01:00
Philipp
09de4a5b47
Merge pull request #8156 from MrPetovan/task/7817-custom-fields-part-2
New custom profile fields feature part 2: Feature switcheroo
2020-01-24 20:17:52 +01:00
nupplaPhil
0f932ae723
Notify => Notification
Notifs => Notifications
2020-01-24 18:32:38 +01:00
Hypolite Petovan
18cfd8dfaa Remove references to deprecated profile.is-default and profile.profile-name fields 2020-01-22 19:42:37 -05:00
Hypolite Petovan
f6f4cbab9d Remove multi profiles feature
- Remove mod/profperm
- Remove additional feature
- Remove profile visibility on contact page
- Remove profile list templates
2020-01-22 19:42:33 -05:00
Hypolite Petovan
d1be68b754 Move Module\Profile to Module\Profile\Index
- Move /profiles to Module\Settings\Profile\Index
2020-01-22 19:42:32 -05:00
nupplaPhil
fa6c33d3ac
Move mod/notifications to Module\Notification 2020-01-22 23:18:14 +01:00
Hypolite Petovan
3c1f174c7f
Merge pull request #8150 from nupplaphil/task/prepare_enotify
Prepare Model\Notify for include/enotify.php (Part 1)
2020-01-22 14:18:59 -05:00
nupplaPhil
011a64cde5
Make non-deterministic redirect in case of unknown visitor for redir.php dynamic 2020-01-22 20:34:07 +01:00
nupplaPhil
7984965183
Add DI:: call 2020-01-22 00:14:14 +01:00
nupplaPhil
26d6afd27f
Move "Notify::getTab()" to notification module since it's presentation layer logic 2020-01-22 00:03:57 +01:00
Philipp
b7527a803a
Merge pull request #8148 from annando/remote-comment
Remotely commenting on Peertube posts now does work
2020-01-21 09:27:21 +01:00
Michael
fbe5de7c55 Remotely commenting on Peertube posts now does work 2020-01-21 06:26:07 +00:00
Hypolite Petovan
db518e7ef2 Fix birthday display and setting
- Add new translation string
2020-01-20 07:47:10 -05:00
Hypolite Petovan
6d7f0a6fd8 Remove duplicate profile_uid key in App->profile array 2020-01-20 07:32:46 -05:00
Hypolite Petovan
0d1befdf2d Move /profile_photo to Module\Settings\Profile\Photo 2020-01-20 07:27:12 -05:00
nupplaPhil
ed9392469e
Remove unneeded Config namespace usages 2020-01-19 22:50:44 +01:00
nupplaPhil
21640ec5d8
Add missing Friendica\DI namespace to files (PHPStorm inspection) 2020-01-19 21:26:42 +01:00
nupplaPhil
3411ced833
Move Config::set() to DI::config()->set() 2020-01-19 21:21:53 +01:00
nupplaPhil
6c36fd9e01
Move Config::get() to DI::config()->get() 2020-01-19 21:21:13 +01:00
nupplaPhil
174129af94
add missing namespaces/fix wrong class-names 2020-01-19 16:31:35 +01:00
nupplaPhil
d6efc90194
cleanup namespace usages for L10n 2020-01-19 16:31:33 +01:00
nupplaPhil
67f2066b8b
Move L10n::getPokeVerbs() calls to DI::l10n()->getPokeVerbs() calls 2020-01-19 16:31:20 +01:00
nupplaPhil
d83f6335eb
Move L10n::getCurrentLang() calls to DI::l10n()->getCurrentLang() calls 2020-01-19 16:31:19 +01:00
nupplaPhil
d3255afa66
Move L10n::withLang() calls to DI::l10n()->withLang() calls 2020-01-19 16:31:18 +01:00
nupplaPhil
a9a36fb302
Move L10n::tt() calls to DI::l10n()->tt() calls 2020-01-19 16:31:17 +01:00
nupplaPhil
5dfee31108
Move L10n::t() calls to DI::l10n()->t() calls 2020-01-19 16:31:16 +01:00
Michael
0a4119adaf @brief is removed completely 2020-01-19 06:05:23 +00:00
Hypolite Petovan
58f69481e6
Merge pull request #8130 from nupplaphil/task/di_pconfig
Move PConfig to DI::pConfig()
2020-01-18 13:57:57 -05:00
nupplaPhil
800694e9b3
Remove unused use statements & remove PConfig class 2020-01-18 17:02:59 +01:00
nupplaPhil
b5c0df439f
Move PConfig::delete() to DI::pConfig()->delete() 2020-01-18 16:56:46 +01:00
nupplaPhil
88bb66371c
Move PConfig::set() to DI::pConfig()->set() 2020-01-18 16:54:50 +01:00
nupplaPhil
9e9429b56d
Move PConfig::get() to DI::pConfig()->get() 2020-01-18 16:50:57 +01:00
nupplaPhil
424c87195b
CleanUp Cache namespace
- Introduce enum "Duration"
- Introduce enum "Type"
- Move "Cache\Cache" to "BaseCache"
2020-01-18 15:41:19 +01:00
Michael
8215c493cf The archive functionality is working again 2020-01-15 04:06:30 +00:00
Michael
b83f328983 Remove "f" parameter / network page parameter cleanup 2020-01-13 20:10:13 +00:00
Michael
ac04ff88b8 Improved code 2020-01-13 17:10:11 +00:00
Michael
1c9fa4451a Improved query 2020-01-13 17:07:05 +00:00
Michael
c65a5cc0d5 Use "http_build_query" to build queries 2020-01-13 17:03:04 +00:00
Hypolite Petovan
b12c646503 Initial event share status doesn't depend on the user's default permissions anymore 2020-01-12 12:16:56 -05:00
Hypolite Petovan
36190d1e79
Merge pull request #8072 from nupplaphil/task/Cache_to_DI
Replace Core\Cache wrapper with DI::cache() method
2020-01-10 08:46:03 -05:00
Hypolite Petovan
6b8db5ad13 Update the Introductions domain to use repository, model and collection 2020-01-06 21:39:05 -05:00
nupplaPhil
a38b0f7eaf
Move remaining namespaces and delete Core\Cache.php 2020-01-07 00:51:02 +01:00
nupplaPhil
fe078410a1
Move Cache::get() to DI::cache()->get() 2020-01-07 00:45:49 +01:00
nupplaPhil
f68929633b
Move Cache::set() to DI::cache()->set() 2020-01-07 00:41:20 +01:00
Hypolite Petovan
465d7e6751 Use default user permissions when creating new event 2020-01-05 17:09:14 -05:00
Hypolite Petovan
393a671501
Merge pull request #8055 from nupplaphil/task/remove_get_server
Remove get_server() in favor of Search::getGlobalDirectory()
2020-01-04 20:10:50 -05:00
nupplaPhil
48baa0be4b
Remove get_server() in favor of Search::getGlobalDirectory() 2020-01-05 00:04:55 +01:00
nupplaPhil
244f440d97
Remove unused killme() 2020-01-04 23:43:13 +01:00
nupplaPhil
f0eea6f875
Remove get_app() in favor of DI::app() 2020-01-04 23:42:01 +01:00
Hypolite Petovan
52c5b0e0f3 Remove unused BBCode::scaleExternalImage parameters
- Remove now obsolete system.no_view_full_size config key
2020-01-02 20:44:15 -05:00
Hypolite Petovan
542e83137b Remove useless HTML encode on item save 2020-01-02 20:38:07 -05:00
Steffen K9
b75707f826
Fix missing use statement for DI (fatal error) 2020-01-01 12:35:44 +01:00
Philipp
b9dba631aa
Merge pull request #8037 from MrPetovan/bug/notices
Replace remaining $a->page by DI::page()
2019-12-30 23:41:23 +01:00
Hypolite Petovan
e84ad15569 Replace remaining $a->page by DI::page() 2019-12-30 17:35:01 -05:00
nupplaPhil
a4a7f19df1
Move redundant System::removedBaseUrl() to DI::baseUrl()->remove() calls 2019-12-30 23:03:56 +01:00
nupplaPhil
3f34229752
Move redundant System::baseUrl() to DI::baseUrl() calls 2019-12-30 23:00:08 +01:00
nupplaPhil
6d7362da41
Replace deprecated $a->page with DI::page() 2019-12-30 20:02:09 +01:00
Hypolite Petovan
efadab66c5 Update wrong/missing references to classes 2019-12-29 21:51:16 -05:00
Hypolite Petovan
3b1f2f4f27 Fix redirect calls using DI::baseUrl() and System::externalRedirect 2019-12-29 21:50:51 -05:00
Hypolite Petovan
015db25d9f Replace obsolete references to App baseURL and getApp by DI 2019-12-29 21:50:15 -05:00
nupplaPhil
df0c05d635
Add Model\Introduction class to DI registry 2019-12-29 20:18:25 +01:00
nupplaPhil
33674808dc
Remove deprecated App::cmd - replace with DI::args()->getCommand() 2019-12-29 20:17:51 +01:00
nupplaPhil
e6f61c2cc7
Remove deprecated App::query_string - replace with DI::args()->getQueryString() 2019-12-29 20:17:50 +01:00
nupplaPhil
26af2feee2
Remove deprecated App::is_mobile/is_tablet - replace with DI::mode()->isMobile()/isTablet() 2019-12-29 20:17:50 +01:00
nupplaPhil
e944d7bed6
Remove deprecated App::getBaseURL() - process methods to DI::baseUrl()->get() 2019-12-29 20:17:48 +01:00
nupplaPhil
50be94aa5e
Remove deprecated App::getHostName() - process methods to DI::baseUrl()->getHostName() 2019-12-29 20:17:47 +01:00
nupplaPhil
2900389696
Remove deprecated App::getUrlPath - process methods to DI::baseUrl()->getUrlPath() 2019-12-29 20:17:46 +01:00
nupplaPhil
e93fba5136
Remove deprecated App::removeBaseURL - process methods to DI::baseUrl()->remove() 2019-12-29 20:17:45 +01:00
nupplaPhil
8b6e123b3f
Refactor deprecated App::isAjax() to DI::mode()->isAjax() 2019-12-29 20:17:44 +01:00
nupplaPhil
8e6973b774
Refactor deprecated App::internalRedirect() to DI::baseUrl()->redirect() 2019-12-29 20:17:43 +01:00
nupplaPhil
2bb9e46be3
Optimize DI class (introduce method-mapping constant) 2019-12-29 20:17:40 +01:00
nupplaPhil
388b963714
Replace BaseObject class with DI::* calls 2019-12-29 20:17:38 +01:00
Hypolite Petovan
a9220aa83b
Merge pull request #8026 from nupplaphil/task/l10n_immutable
Make L10n immutable
2019-12-29 13:54:32 -05:00
Hypolite Petovan
25847c4c71
Merge pull request #8022 from nupplaphil/task/mod_hcard
Move mod/hcard to src\Module\HoverCard
2019-12-28 21:42:01 -05:00
nupplaPhil
7a2f4dc54e
Make L10n immutable
- Remove Push/Pop
- Add "withLang($lang)" method
2019-12-28 23:12:01 +01:00
nupplaPhil
eeb78d2d29
Move mod/hcard to src\Module\HoverCard 2019-12-27 22:53:09 +01:00
nupplaPhil
aa5771cf3e
Move Login/Logout/TwoFactor to bundled submodule "Security" 2019-12-27 22:19:28 +01:00
nupplaPhil
d30e8665e1
Move mod/openid to src\Module\OpenId 2019-12-27 22:16:40 +01:00
Hypolite Petovan
eaeb9438d8 Add missing use statement in mod/community
- Addresses https://github.com/friendica/friendica/issues/7998#issuecomment-569265877
2019-12-27 08:08:47 -05:00
Hypolite Petovan
66e9f0e0da Remove unused albumname input in album drop modal
- Addresses https://github.com/friendica/friendica/issues/8000#issuecomment-568798634
2019-12-24 15:19:08 -05:00
Hypolite Petovan
b4704b7205 Protect potentially missing array keys in mod/profiles
- Addresses https://github.com/friendica/friendica/issues/8000#issuecomment-568784029
- Addresses https://github.com/friendica/friendica/issues/8000#issuecomment-568785161
2019-12-24 12:56:20 -05:00
Hypolite Petovan
3694396758 Rename wrong desc form value name in mod/events
- Addresses https://github.com/friendica/friendica/issues/8000#issuecomment-568783457
2019-12-24 12:44:36 -05:00
Tobias Diekershoff
00756737b5 Merge branch 'master' 2019.12 into develop 2019-12-23 20:03:47 +01:00
Hypolite Petovan
637d526d6a
Ensure $item exists in mod/display
- Addresses https://github.com/friendica/friendica/issues/7677#issuecomment-567575161
2019-12-22 09:00:16 -05:00
Hypolite Petovan
bba8f03296 Check for parent existence in mod/display
- Addresses https://github.com/friendica/friendica/issues/7677#issuecomment-566079001
2019-12-19 07:47:35 -05:00
Philipp
5197833c55
Merge pull request #7930 from MrPetovan/task/7887-api-followers-request
Add POST follow request Mastodon API endpoint
2019-12-18 22:12:52 +01:00
Hypolite Petovan
6e4a428c73
Merge pull request #7907 from nupplaphil/task/reduce_app_deps
Cleanup Session/Authentication
2019-12-14 09:53:40 -05:00
Hypolite Petovan
c23543f463 Restore correct highlighted contact tabs 2019-12-13 15:27:16 -05:00
Hypolite Petovan
0656e9ece4 Update web modules handling introduction to use new model class 2019-12-11 08:24:17 -05:00
nupplaPhil
54392fab81
Move Cookie to own class (with tests)
Move Authentication to App namespace
2019-12-08 22:45:34 +01:00
Michael
23cdc9cec8 Fixes issue 7914: Reshares got crumbled 2019-12-07 21:05:14 +00:00
nupplaPhil
96555a7385
Refactor "Authentication" class with four main methods:
- withSession() - for auto authentication with Session/Cookie variables
- withOpenId() - for authentication with an OpenID account
- withPassword() - for authentication with Password
- setForUser() - for setting the user auth context of the current session

Refactor "Session" class - contains now "native" Session Management methods
2019-12-05 23:02:51 +01:00
nupplaPhil
18a3d18ba6
Move Authentication methods to class "Authentication" 2019-12-05 23:02:50 +01:00
Michael
eeb8bee1b7 Use the new function to fetch shared information 2019-12-05 06:16:27 +00:00
Michael
22c66e1811 Add data for shared posts from the original 2019-12-04 22:57:09 +00:00
Hypolite Petovan
4403aeeda5
Merge pull request #7901 from annando/disable-smart-threading
Changed the option to enable the smart threading with the option to disable this
2019-12-04 15:25:53 -05:00
Michael Vogel
9cf1aea8c9 Changed the option to enable the smart threading with the option to disable this 2019-12-04 21:21:20 +01:00
Hypolite Petovan
f989c331a3 Fix warnings about unexpected parameter array values type in ACL::getFullSelectorHTML
- Addresses https://github.com/friendica/friendica/issues/7676#issuecomment-560503744
2019-12-03 06:59:51 -05:00
Michael Vogel
2f2480d88d
Merge pull request #7876 from MrPetovan/task/7308-backport-compose-acl
Generalize the Compose ACL to the whole site
2019-11-28 21:24:20 +01:00
Hypolite Petovan
ae3d4f63a3 Use visibility tags input for the default ACL selector
- Move friendica-tagsinput to default view folder
- Update all references to ACL::getFullSelectorHTML
- Fix theme-specific issues with the new ACL
2019-11-28 12:54:53 -05:00
Michael Vogel
3ed196fd9c Added option for insecure IMAP 2019-11-26 23:27:20 +01:00
Michael Vogel
16d2f11b40 Don't allow unencrypted IMAP, allow deleting mails 2019-11-26 22:27:25 +01:00
Michael
7c1f8a0597 Renamed config name 2019-11-19 16:31:22 +00:00
Michael
1e9214bfea Use the correct field 2019-11-19 13:10:38 +00:00
Michael
fa876d770e Make the automatic title appending optional 2019-11-19 12:59:21 +00:00
Hypolite Petovan
31f0fe0992 Use correct variable to store user.hidewall in mod/settings 2019-11-09 09:12:20 -05:00
Hypolite Petovan
28537dbf63 Use correct variable to store user.page-flags in mod/settings 2019-11-09 09:12:10 -05:00
Michael
8c03bdada9 parameters now are having a default value and are optional 2019-11-05 21:48:54 +00:00
Tobias Diekershoff
9fad4abcec add missing quotation 2019-11-03 22:47:57 +01:00
Philipp
d0068170db
Merge pull request #7806 from tobiasd/20191102-csvexport
added export and import of followed contacts to and from  CSV files
2019-11-03 20:28:08 +01:00
Tobias Diekershoff
9815d63352 use config var in settings form 2019-11-03 17:31:01 +01:00
Tobias Diekershoff
955a84a266 added export and import of followed contacts to and from CSV files 2019-11-03 00:12:16 +01:00
Michael Vogel
6ba7b5961c
Merge pull request #7798 from MrPetovan/task/rework-photo-functions
Rework photo functions
2019-11-02 21:20:38 +01:00
Philipp
ebef0d5cd4
Merge pull request #7749 from MrPetovan/bug/7740-frio-hovercard-add-unfollow
[frio] Rework hovercard actions
2019-11-02 20:36:39 +01:00
Michael
421db4e454 Changed label for network sorting 2019-11-02 17:03:40 +00:00
Hypolite Petovan
e3e2b0e6d0 Remove mod/hovercard file 2019-11-02 12:48:04 -04:00
Tobias Diekershoff
9f215fc33b
Merge pull request #7797 from annando/arrival-order
Posted order is now arrival order
2019-11-02 16:02:27 +01:00
Michael
682001ab0a And some other renaming 2019-11-02 13:55:55 +00:00
Michael
6e11419e00 Aligned code 2019-11-02 12:59:57 +00:00
Michael
f97de52694 Renamed labels 2019-11-02 12:54:26 +00:00
Hypolite Petovan
26b5de9a76 Rename Photo::newResource() result variable from $hash to $resource_id 2019-11-02 07:48:45 -04:00
Hypolite Petovan
03bf1dcbd3 Move Object\Image static methods to Util\Images
- Optimize imports in modified files
2019-11-02 07:48:45 -04:00
Hypolite Petovan
b543ee8ac7
Merge pull request #7726 from tobiasd/20191010-uexport
move uexport module to src
2019-11-02 07:46:57 -04:00
Tobias Diekershoff
8bea9e7523 mv URL path uexport -> userexport 2019-11-02 12:44:46 +01:00
Michael
01142cb4d0 Remove debug logging 2019-11-02 11:17:47 +00:00
Michael
b81ab4f9a4 Posted order is now arrival order 2019-11-02 10:39:51 +00:00
Philipp Holzer
aa7be41728
Fix ACLFormatterTest
- Add nullable to expand() function again
- Add angle bracket support to toString()
2019-11-01 14:13:29 +01:00
Hypolite Petovan
d6ff89d7b4
Merge pull request #7769 from annando/issue-3229
Changed OpenID registration
2019-10-29 10:32:02 -04:00
Philipp Holzer
3eda62bfa6
Check null for acl-fields 2019-10-28 18:16:10 +01:00
Michael
e1f36bfd7a Standards and unneccessary EOL 2019-10-28 13:51:38 +00:00
Michael
bfbce16d0b Merge remote-tracking branch 'upstream/develop' into issue-3229 2019-10-28 13:50:06 +00:00
Philipp Holzer
5d995b854a
just remove parenthess 2019-10-26 05:24:05 +02:00
Philipp Holzer
28d5f39330
simplify show determination 2019-10-26 05:03:58 +02:00
Philipp Holzer
3465bd9f11
rename methods 2019-10-26 05:02:14 +02:00
Philipp Holzer
fdc0236aa1
Fix arguments 2019-10-26 04:37:31 +02:00
Philipp Holzer
a72e65a760
Adapt class structure
- Introduce constants
- Add constructor parameters
- Add typehints
- Renamed fields more meaningful
- Renamed method names to match identifier
- Adjust PHP doc
- Add GetClass call at used places
2019-10-26 04:03:27 +02:00
Philipp Holzer
1f368d469f
Move Friendica\Core\NotificationsManager to Friendica\Model\Notify 2019-10-26 02:01:46 +02:00
Philipp Holzer
7343ee5108
Move Namespace of ActivityNamespace 2019-10-25 00:41:48 +02:00
Philipp Holzer
dc2858938d
Renamed to ActivityNamespace 2019-10-25 00:32:35 +02:00
Philipp Holzer
3897c74deb
Add docs 2019-10-25 00:10:20 +02:00
Michael
aca701bef8 Changed OpenID registration 2019-10-24 20:23:26 +00:00
Philipp Holzer
2fba7ed477
Rename namespace 2019-10-24 21:40:13 +02:00
Philipp Holzer
07cea24430
Move Activity/Namespaces defines to constants 2019-10-24 21:40:12 +02:00
Hypolite Petovan
ee1954f294
Merge pull request #7762 from nupplaphil/task/mod_ignored
move mod/ignored to src/Module/Item/Ignored
2019-10-24 12:04:50 -04:00
Philipp Holzer
c9e1098dd2
Adapt naming convention 2019-10-23 21:39:00 +02:00
Philipp Holzer
ad67fd3aa8
Move is_a_date_arg to DateTimeFormat::isYearMonth
- Improved functionality
- Added tests
2019-10-23 02:39:28 +02:00
Philipp Holzer
52c42491c4
Move activity_match() to Protocol\Activity::match()
- With tests
2019-10-23 02:05:11 +02:00
Philipp Holzer
5843a80b6c
Move perms2str to ACLFormatter::aclToString()
- including new tests
2019-10-23 00:54:34 +02:00
Philipp Holzer
f65f7f11c3
Move expand_acl to ACLFormatter::expand()
- including tests
2019-10-23 00:40:14 +02:00
Philipp Holzer
2870f42ca2
Move bb_translate_video
- To new Class BBCode\Video
- Adding tests
- Make BaseObject::getClass() public
2019-10-23 00:14:47 +02:00
Philipp Holzer
7f49c73730
Move undo_post_tagging to mod/editpost because of the only occurrence 2019-10-22 23:57:44 +02:00
Philipp Holzer
17aca9bee8
move mod/ignored to src/Module/Item/Ignored 2019-10-21 21:19:28 +02:00
Philipp Holzer
2a41f0b104
wrong field 2019-10-21 11:34:47 +02:00
Philipp Holzer
cbc48a4fd4
Fix parameter 2019-10-20 13:23:13 +02:00
Philipp Holzer
7716374593
Move mod/receive to src/Module/Diaspora/receive
- Added routes
- Make Diaspora::decode(Raw) more explicit
- Add new User::getByGuid() method
2019-10-20 13:07:16 +02:00
Hypolite Petovan
e3915d2f93 Prevent empty [url] label regular expression to break image insertion 2019-10-16 13:53:16 -04:00
Philipp
b0967ffd02
Merge pull request #7742 from MrPetovan/task/7190-remove-defaults-mod
Replace deprecated defaults() calls by a combination of ?? and ?: operators in mod/
2019-10-15 18:07:53 +02:00
Hypolite Petovan
2db6171641 Replace deprecated defaults() calls by a combination of ?? and ?: operators in mod/ 2019-10-15 09:01:17 -04:00
Hypolite Petovan
c07cb2c8f3
Merge pull request #7738 from annando/clean-url
Convert links with empty descriptions
2019-10-13 20:11:28 -04:00
Michael
5875830d1e Convert links with empty descriptions 2019-10-13 15:52:33 +00:00
Hypolite Petovan
02f02d44dc Move mod/manage to src/Module/Delegation
- Move templates/manage to templates/delegation
- Update navigation links
- Update CSS classes
2019-10-11 19:59:06 -04:00
Hypolite Petovan
27eaffd7fb
Merge pull request #7725 from dew-git/develop
Fix security vulnerabilities.
2019-10-11 14:48:07 -04:00
Tobias Diekershoff
46172b641d moved UExport to src/Module/Settings/Uexport 2019-10-11 07:38:42 +02:00
Tobias Diekershoff
fb562fc25b removed mod/uexport file 2019-10-11 07:36:41 +02:00
dew-git
811cdcdfcb Fix security vulnerbilities.
Fix possible length extension attack, predicable generators, timing attacks on hash comparision and improved formatting.
2019-10-10 15:21:41 -08:00
Hypolite Petovan
57a749af38 Add required use statement in mod/subthread 2019-10-10 13:12:27 -04:00
Philipp
cf4bae26c7
Merge pull request #7720 from MrPetovan/task/4090-move-delegate-to-src
Move mod/delegate to src/Module/Settings/Delegation
2019-10-10 10:24:15 +02:00
Hypolite Petovan
616edd0600 Move mod/delegate to src/Module/Settings/Delegation
- Move templates/delegate to templates/settings/delegation
2019-10-09 22:17:09 -04:00
Hypolite Petovan
1e737ae888 Move mod/search to src/Module/Search/Index
- Update BaseSeachModule not to depend on a single query string parameter
2019-10-07 14:27:46 -04:00
Hypolite Petovan
22598fc7e8 Improve search box
- Use new saved search module
- Use dynamic search option loop
- Use "q" instead of "search" for search query string parameter
2019-10-07 14:27:46 -04:00
Hypolite Petovan
cdefa7f32a Add new module and widget for managing saved searches 2019-10-07 14:27:46 -04:00
Hypolite Petovan
f4d06ebd47 Remove useless theme session variable deletions in modules 2019-10-06 12:08:15 -04:00
Hypolite Petovan
e5fbaf6a00 Add Session::clear method
- Replace manual session clear by method in mod/manage
2019-10-06 11:21:54 -04:00
Hypolite Petovan
8f20e2054b Move /acl module to src/
- Move Core\ACL::contactAutocomplete to Module\Search\Acl
- Rename module path to /search/acl
2019-10-03 22:40:42 -04:00
Hypolite Petovan
185f1fc687
Merge pull request #7636 from annando/manage
Restructured "manage" functionality, added count parameters
2019-09-30 11:12:46 -04:00
Hypolite Petovan
2333526b8a
Merge pull request #7678 from annando/remote-rework
Reworked the remote authentication
2019-09-30 09:18:43 -04:00
Philipp Holzer
d5dd12b8f8
Add Drone CI
- Add drone test environment
- Add drone config
- apt phpunit
- Fix api.php
- Fix item.php
- Fix DBStructure
- Check if caching is possible during tests
2019-09-30 14:03:12 +02:00
Michael
d41399496e Merge remote-tracking branch 'upstream/develop' into manage 2019-09-30 06:30:13 +00:00
Michael
0d7c79d051 Using central function to set the "remote" session value 2019-09-30 06:29:00 +00:00
Michael
0185c91246 Merge remote-tracking branch 'upstream/2019.09-rc' into remote-rework 2019-09-29 06:32:35 +00:00
Michael Vogel
4e9a810206 Fix magic auth for redirects with non profile paths 2019-09-29 02:16:09 +02:00
Michael
23bad85847 Ensure to fetch the correct item 2019-09-28 20:43:45 +00:00
Michael
83b00ef308 New function "isAuthenticated" 2019-09-28 18:09:11 +00:00
Michael
89f02a1125 Fix warnings 2019-09-28 15:31:36 +00:00
Michael
1c26baec46 remote_user is replaced 2019-09-28 09:59:08 +00:00
Michael
6e9026e033 Renamed function, beginning to replace the "remote_user" function 2019-09-28 09:36:41 +00:00
Michael
1ddd2df4b8 Removed obsolete code 2019-09-28 05:37:24 +00:00
Michael
3dd94355b7 Fix permissions when viewing photos, applying same fix to items as well 2019-09-27 05:49:23 +00:00
Michael
ec66553032 Reworked "remote" cookie handling 2019-09-25 22:24:17 +00:00
Michael
6a376c29d8 Fix session size problems 2019-09-25 05:57:32 +00:00
Michael
08f30e1769 Fix notice 2019-09-24 21:51:08 +00:00
Michael
5254147ccc Fix "redir" loop 2019-09-23 22:13:20 +00:00
Michael
aba23daeca Get rid of zombie introductions that reappear automatically 2019-09-22 10:51:34 +00:00
Hypolite Petovan
118e737a49 Remove dependency to App object in Temporal::getDateofBirthField 2019-09-21 05:15:52 -04:00
Michael
9e7467f8f9 Added to-do 2019-09-18 05:56:06 +00:00
Michael
1144863090 Changed "hidewall" behaviour 2019-09-18 05:20:33 +00:00
Michael
8237d35a87 Restructured "manage" functionality, added count parameters 2019-09-17 04:05:26 +00:00
Tobias Diekershoff
d2707a0e15 Added some help text about influence on search engines 2019-09-14 19:14:52 +02:00
Hypolite Petovan
32707022bf Remove GET page parameter access from Core\ACL 2019-09-13 20:06:57 -04:00
Michael
f71abb30ca Issue 3229: Switched to other function to receive the identity 2019-09-11 16:46:13 +00:00
Michael
57e4b9f806 Issue 7610: Set the appropriate meta header to not being crawled 2019-09-10 17:15:29 +00:00
Michael
323285216b We have to check for "0" in "rel" as well 2019-09-09 20:39:19 +00:00
Michael
f185f6fd3d Pending contacts part 2: Fix contact deletion / added cron job for repairs 2019-09-09 20:03:11 +00:00
Hypolite Petovan
91b0f0465f
Merge pull request #7604 from annando/pending-contacts
Display pending contacts in the contact list
2019-09-09 13:49:51 -04:00
Michael
2dbd843ed2 Don't display ignored pending contacts, link to contact request page 2019-09-09 05:29:33 +00:00
Hypolite Petovan
c2c3bb2074 Remove deprecated defaults() call in mod/events 2019-09-06 08:33:41 -04:00
Michael
d7a8417941 Fix fatal error for empty parameter for "System::removedBaseUrl" 2019-09-04 21:11:58 +00:00
Michael Vogel
35a487ae30 Don't fork worker on frontend by default 2019-08-08 22:42:12 +02:00
Hypolite Petovan
3e2f0e9ffa Feedback changes
- Import namespaces in mod/community
- Fix alignment in Content\Feature
- Add phpDoc to Widget\TrendingTags
2019-08-06 07:37:48 -04:00
Hypolite Petovan
c399e40618 Add trending_tags additional feature + usage in mod/community 2019-08-06 07:09:04 -04:00
Tobias Diekershoff
3053cde210 Typo in setting description 2019-08-05 18:07:43 +02:00
Michael
1b7f96dac8 Partly reverted, real problem fixed 2019-08-04 04:29:52 +00:00