keith/friendica
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Merge branch 'develop' into task/admin-block-list

Browse source
This commit is contained in:
Hypolite Petovan 2017-12-01 00:48:13 -05:00 committed by GitHub
commit ff459441cf
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
29 changed files with 742 additions and 600 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
include/api.php
View file

@ -5,7 +5,6 @@
* *
* @todo Automatically detect if incoming data is HTML or BBCode * @todo Automatically detect if incoming data is HTML or BBCode
*/ */
use Friendica\App; use Friendica\App;
use Friendica\Core\System; use Friendica\Core\System;
use Friendica\Core\Config; use Friendica\Core\Config;
@ -23,6 +22,7 @@ use Friendica\Network\HTTPException\NotImplementedException;
use Friendica\Network\HTTPException\UnauthorizedException; use Friendica\Network\HTTPException\UnauthorizedException;
use Friendica\Network\HTTPException\TooManyRequestsException; use Friendica\Network\HTTPException\TooManyRequestsException;
use Friendica\Object\Contact; use Friendica\Object\Contact;
use Friendica\Object\Photo;
use Friendica\Protocol\Diaspora; use Friendica\Protocol\Diaspora;
use Friendica\Util\XML; use Friendica\Util\XML;
@ -32,7 +32,6 @@ require_once 'include/conversation.php';
require_once 'include/oauth.php'; require_once 'include/oauth.php';
require_once 'include/html2plain.php'; require_once 'include/html2plain.php';
require_once 'mod/share.php'; require_once 'mod/share.php';
require_once 'include/Photo.php';
require_once 'mod/item.php'; require_once 'mod/item.php';
require_once 'include/security.php'; require_once 'include/security.php';
require_once 'include/contact_selectors.php'; require_once 'include/contact_selectors.php';
@ -2377,7 +2376,7 @@ function api_get_attachments(&$body)
$attachments = array(); $attachments = array();
foreach ($images[1] as $image) { foreach ($images[1] as $image) {
$imagedata = get_photo_info($image); $imagedata = Photo::getInfoFromURL($image);
if ($imagedata) { if ($imagedata) {
$attachments[] = array("url" => $image, "mimetype" => $imagedata["mime"], "size" => $imagedata["size"]); $attachments[] = array("url" => $image, "mimetype" => $imagedata["mime"], "size" => $imagedata["size"]);
@ -2509,7 +2508,7 @@ function api_get_entitities(&$text, $bbcode)
$start = iconv_strpos($text, $url, $offset, "UTF-8"); $start = iconv_strpos($text, $url, $offset, "UTF-8");
if (!($start === false)) { if (!($start === false)) {
$image = get_photo_info($url); $image = Photo::getInfoFromURL($url);
if ($image) { if ($image) {
// If image cache is activated, then use the following sizes: // If image cache is activated, then use the following sizes:
// thumb (150), small (340), medium (600) and large (1024) // thumb (150), small (340), medium (600) and large (1024)
@ -2517,19 +2516,19 @@ function api_get_entitities(&$text, $bbcode)
$media_url = proxy_url($url); $media_url = proxy_url($url);
$sizes = array(); $sizes = array();
$scale = scale_image($image[0], $image[1], 150); $scale = Photo::scaleImageTo($image[0], $image[1], 150);
$sizes["thumb"] = array("w" => $scale["width"], "h" => $scale["height"], "resize" => "fit"); $sizes["thumb"] = array("w" => $scale["width"], "h" => $scale["height"], "resize" => "fit");
if (($image[0] > 150) || ($image[1] > 150)) { if (($image[0] > 150) || ($image[1] > 150)) {
$scale = scale_image($image[0], $image[1], 340); $scale = Photo::scaleImageTo($image[0], $image[1], 340);
$sizes["small"] = array("w" => $scale["width"], "h" => $scale["height"], "resize" => "fit"); $sizes["small"] = array("w" => $scale["width"], "h" => $scale["height"], "resize" => "fit");
} }
$scale = scale_image($image[0], $image[1], 600); $scale = Photo::scaleImageTo($image[0], $image[1], 600);
$sizes["medium"] = array("w" => $scale["width"], "h" => $scale["height"], "resize" => "fit"); $sizes["medium"] = array("w" => $scale["width"], "h" => $scale["height"], "resize" => "fit");
if (($image[0] > 600) || ($image[1] > 600)) { if (($image[0] > 600) || ($image[1] > 600)) {
$scale = scale_image($image[0], $image[1], 1024); $scale = Photo::scaleImageTo($image[0], $image[1], 1024);
$sizes["large"] = array("w" => $scale["width"], "h" => $scale["height"], "resize" => "fit"); $sizes["large"] = array("w" => $scale["width"], "h" => $scale["height"], "resize" => "fit");
} }
} else { } else {
@ -3946,7 +3945,7 @@ function save_media_to_database($mediatype, $media, $type, $album, $allow_cid, $
} }
if ($filetype == "") { if ($filetype == "") {
$filetype=guess_image_type($filename); $filetype=Photo::guessImageType($filename);
} }
$imagedata = getimagesize($src); $imagedata = getimagesize($src);
if ($imagedata) { if ($imagedata) {
@ -3971,7 +3970,7 @@ function save_media_to_database($mediatype, $media, $type, $album, $allow_cid, $
// create Photo instance with the data of the image // create Photo instance with the data of the image
$imagedata = @file_get_contents($src); $imagedata = @file_get_contents($src);
$ph = new Photo($imagedata, $filetype); $ph = new Photo($imagedata, $filetype);
if (! $ph->is_valid()) { if (! $ph->isValid()) {
throw new InternalServerErrorException("unable to process image data"); throw new InternalServerErrorException("unable to process image data");
} }

4
include/follow.php
View file

@ -8,13 +8,13 @@ use Friendica\Core\System;
use Friendica\Core\Worker; use Friendica\Core\Worker;
use Friendica\Database\DBM; use Friendica\Database\DBM;
use Friendica\Network\Probe; use Friendica\Network\Probe;
use Friendica\Object\Contact;
use Friendica\Protocol\Diaspora; use Friendica\Protocol\Diaspora;
use Friendica\Protocol\OStatus; use Friendica\Protocol\OStatus;
use Friendica\Protocol\PortableContact; use Friendica\Protocol\PortableContact;
require_once 'include/group.php'; require_once 'include/group.php';
require_once 'include/salmon.php'; require_once 'include/salmon.php';
require_once 'include/Photo.php';
function update_contact($id) { function update_contact($id) {
/* /*
@ -250,7 +250,7 @@ function new_contact($uid, $url, $interactive = false, $network = '') {
} }
// Update the avatar // Update the avatar
update_contact_avatar($ret['photo'],$uid,$contact_id); Contact::updateAvatar($ret['photo'], $uid, $contact_id);
// pull feed and consume it, which should subscribe to the hub. // pull feed and consume it, which should subscribe to the hub.

7
include/items.php
View file

@ -1,9 +1,7 @@
<?php <?php
/** /**
* @file include/items.php * @file include/items.php
*/ */
use Friendica\App; use Friendica\App;
use Friendica\ParseUrl; use Friendica\ParseUrl;
use Friendica\Core\Config; use Friendica\Core\Config;
@ -21,7 +19,6 @@ require_once 'include/bbcode.php';
require_once 'include/oembed.php'; require_once 'include/oembed.php';
require_once 'include/salmon.php'; require_once 'include/salmon.php';
require_once 'include/crypto.php'; require_once 'include/crypto.php';
require_once 'include/Photo.php';
require_once 'include/tags.php'; require_once 'include/tags.php';
require_once 'include/files.php'; require_once 'include/files.php';
require_once 'include/text.php'; require_once 'include/text.php';
@ -1692,7 +1689,7 @@ function new_follower($importer, $contact, $datarray, $item, $sharing = false) {
); );
if (DBM::is_result($r)) { if (DBM::is_result($r)) {
$contact_record = $r[0]; $contact_record = $r[0];
update_contact_avatar($photo, $importer["uid"], $contact_record["id"], true); Contact::updateAvatar($photo, $importer["uid"], $contact_record["id"], true);
} }
/// @TODO Encapsulate this into a function/method /// @TODO Encapsulate this into a function/method
@ -1879,7 +1876,7 @@ function fix_private_photos($s, $uid, $item = null, $cid = 0) {
$height = intval($match[2]); $height = intval($match[2]);
$ph = new Photo($data, $type); $ph = new Photo($data, $type);
if ($ph->is_valid()) { if ($ph->isValid()) {
$ph->scaleImage(max($width, $height)); $ph->scaleImage(max($width, $height));
$data = $ph->imageString(); $data = $ph->imageString();
$type = $ph->getType(); $type = $ph->getType();

8
include/network.php
View file

@ -1,13 +1,12 @@
<?php <?php
/** /**
* @file include/network.php * @file include/network.php
*/ */
use Friendica\App; use Friendica\App;
use Friendica\Core\System; use Friendica\Core\System;
use Friendica\Core\Config; use Friendica\Core\Config;
use Friendica\Network\Probe; use Friendica\Network\Probe;
use Friendica\Object\Photo;
use Friendica\Util\XML; use Friendica\Util\XML;
/** /**
@ -687,7 +686,6 @@ function scale_external_images($srctext, $include_link = true, $scale_replace =
$matches = null; $matches = null;
$c = preg_match_all('/\[img.*?\](.*?)\[\/img\]/ism', $s, $matches, PREG_SET_ORDER); $c = preg_match_all('/\[img.*?\](.*?)\[\/img\]/ism', $s, $matches, PREG_SET_ORDER);
if ($c) { if ($c) {
require_once 'include/Photo.php';
foreach ($matches as $mtch) { foreach ($matches as $mtch) {
logger('scale_external_image: ' . $mtch[1]); logger('scale_external_image: ' . $mtch[1]);
@ -712,11 +710,11 @@ function scale_external_images($srctext, $include_link = true, $scale_replace =
} }
// guess mimetype from headers or filename // guess mimetype from headers or filename
$type = guess_image_type($mtch[1], true); $type = Photo::guessImageType($mtch[1], true);
if ($i) { if ($i) {
$ph = new Photo($i, $type); $ph = new Photo($i, $type);
if ($ph->is_valid()) { if ($ph->isValid()) {
$orig_width = $ph->getWidth(); $orig_width = $ph->getWidth();
$orig_height = $ph->getHeight(); $orig_height = $ph->getHeight();

14
include/plaintext.php
View file

@ -1,17 +1,15 @@
<?php <?php
/** /**
* @file include/plaintext.php * @file include/plaintext.php
*/ */
use Friendica\App; use Friendica\App;
use Friendica\ParseUrl; use Friendica\ParseUrl;
use Friendica\Core\PConfig; use Friendica\Core\PConfig;
use Friendica\Object\Photo;
require_once("include/Photo.php"); require_once "include/bbcode.php";
require_once("include/bbcode.php"); require_once "include/html2plain.php";
require_once("include/html2plain.php"); require_once "include/network.php";
require_once("include/network.php");
/** /**
* @brief Fetches attachment data that were generated the old way * @brief Fetches attachment data that were generated the old way
@ -53,7 +51,7 @@ function get_old_attachment_data($body) {
if (preg_match("/\[img\]([$URLSearchString]*)\[\/img\]/ism", $attacheddata, $matches)) { if (preg_match("/\[img\]([$URLSearchString]*)\[\/img\]/ism", $attacheddata, $matches)) {
$picturedata = get_photo_info($matches[1]); $picturedata = Photo::getInfoFromURL($matches[1]);
if (($picturedata[0] >= 500) && ($picturedata[0] >= $picturedata[1])) if (($picturedata[0] >= 500) && ($picturedata[0] >= $picturedata[1]))
$post["image"] = $matches[1]; $post["image"] = $matches[1];
@ -223,7 +221,7 @@ function get_attached_data($body, $item = array()) {
$post["preview"] = $pictures[0][2]; $post["preview"] = $pictures[0][2];
$post["text"] = str_replace($pictures[0][0], "", $body); $post["text"] = str_replace($pictures[0][0], "", $body);
} else { } else {
$imgdata = get_photo_info($pictures[0][1]); $imgdata = Photo::getInfoFromURL($pictures[0][1]);
if (substr($imgdata["mime"], 0, 6) == "image/") { if (substr($imgdata["mime"], 0, 6) == "image/") {
$post["type"] = "photo"; $post["type"] = "photo";
$post["image"] = $pictures[0][1]; $post["image"] = $pictures[0][1];

6
include/uimport.php
View file

@ -1,12 +1,14 @@
<?php <?php
/**
* @file include/uimport.php
*/
use Friendica\App; use Friendica\App;
use Friendica\Core\System; use Friendica\Core\System;
use Friendica\Core\PConfig; use Friendica\Core\PConfig;
use Friendica\Core\Worker; use Friendica\Core\Worker;
use Friendica\Database\DBM; use Friendica\Database\DBM;
use Friendica\Object\Photo;
require_once("include/Photo.php");
define("IMPORT_DEBUG", False); define("IMPORT_DEBUG", False);
function last_insert_id() { function last_insert_id() {

11
include/user.php
View file

@ -1,8 +1,11 @@
<?php <?php
/**
* @file include/user.php
*/
use Friendica\Core\Config; use Friendica\Core\Config;
use Friendica\Core\System; use Friendica\Core\System;
use Friendica\Database\DBM; use Friendica\Database\DBM;
use Friendica\Object\Photo;
require_once 'include/network.php'; require_once 'include/network.php';
require_once 'include/plugin.php'; require_once 'include/plugin.php';
@ -283,18 +286,16 @@ function create_user($arr) {
// unless there is no avatar-plugin loaded // unless there is no avatar-plugin loaded
if (strlen($photo)) { if (strlen($photo)) {
require_once('include/Photo.php');
$photo_failure = false; $photo_failure = false;
$filename = basename($photo); $filename = basename($photo);
$img_str = fetch_url($photo, true); $img_str = fetch_url($photo, true);
// guess mimetype from headers or filename // guess mimetype from headers or filename
$type = guess_image_type($photo,true); $type = Photo::guessImageType($photo, true);
$img = new Photo($img_str, $type); $img = new Photo($img_str, $type);
if($img->is_valid()) { if ($img->isValid()) {
$img->scaleImageSquare(175); $img->scaleImageSquare(175);
$hash = photo_new_resource(); $hash = photo_new_resource();

7
mod/contacts.php
View file

@ -1,5 +1,7 @@
<?php <?php
/**
* @file mod/contacts.php
*/
use Friendica\App; use Friendica\App;
use Friendica\Core\System; use Friendica\Core\System;
use Friendica\Core\Worker; use Friendica\Core\Worker;
@ -10,7 +12,6 @@ use Friendica\Object\Contact;
require_once 'include/contact_selectors.php'; require_once 'include/contact_selectors.php';
require_once 'mod/proxy.php'; require_once 'mod/proxy.php';
require_once 'include/Photo.php';
function contacts_init(App $a) { function contacts_init(App $a) {
if (! local_user()) { if (! local_user()) {
@ -309,7 +310,7 @@ function _contact_update_profile($contact_id) {
); );
// Update the entry in the contact table // Update the entry in the contact table
update_contact_avatar($data['photo'], local_user(), $contact_id, true); Contact::updateAvatar($data['photo'], local_user(), $contact_id, true);
// Update the entry in the gcontact table // Update the entry in the gcontact table
GlobalContact::updateFromProbe($data["url"]); GlobalContact::updateFromProbe($data["url"]);

13
mod/crepair.php
View file

@ -1,5 +1,7 @@
<?php <?php
/**
* @file mod/crepair.php
*/
use Friendica\App; use Friendica\App;
use Friendica\Core\Config; use Friendica\Core\Config;
use Friendica\Database\DBM; use Friendica\Database\DBM;
@ -86,16 +88,15 @@ function crepair_post(App $a) {
if ($photo) { if ($photo) {
logger('mod-crepair: updating photo from ' . $photo); logger('mod-crepair: updating photo from ' . $photo);
require_once("include/Photo.php");
update_contact_avatar($photo,local_user(),$contact['id']); Contact::updateAvatar($photo, local_user(), $contact['id']);
} }
if($r) if ($r) {
info(t('Contact settings applied.') . EOL); info(t('Contact settings applied.') . EOL);
else } else {
notice(t('Contact update failed.') . EOL); notice(t('Contact update failed.') . EOL);
}
return; return;
} }

9
mod/dfrn_confirm.php
View file

@ -25,6 +25,7 @@ use Friendica\Core\System;
use Friendica\Core\Worker; use Friendica\Core\Worker;
use Friendica\Database\DBM; use Friendica\Database\DBM;
use Friendica\Network\Probe; use Friendica\Network\Probe;
use Friendica\Object\Contact;
use Friendica\Protocol\Diaspora; use Friendica\Protocol\Diaspora;
require_once 'include/enotify.php'; require_once 'include/enotify.php';
@ -325,9 +326,7 @@ function dfrn_confirm_post(App $a, $handsfree = null) {
* *
*/ */
require_once 'include/Photo.php'; Contact::updateAvatar($contact['photo'], $uid, $contact_id);
update_contact_avatar($contact['photo'],$uid,$contact_id);
logger('dfrn_confirm: confirm - imported photos'); logger('dfrn_confirm: confirm - imported photos');
@ -676,9 +675,7 @@ function dfrn_confirm_post(App $a, $handsfree = null) {
$photo = System::baseUrl() . '/images/person-175.jpg'; $photo = System::baseUrl() . '/images/person-175.jpg';
} }
require_once 'include/Photo.php'; Contact::updateAvatar($photo,$local_uid,$dfrn_record);
update_contact_avatar($photo,$local_uid,$dfrn_record);
logger('dfrn_confirm: request - photos imported'); logger('dfrn_confirm: request - photos imported');

11
mod/dfrn_request.php
View file

@ -1,5 +1,4 @@
<?php <?php
/** /**
* @file mod/dfrn_request.php * @file mod/dfrn_request.php
* @brief Module: dfrn_request * @brief Module: dfrn_request
@ -11,19 +10,19 @@
* You also find a graphic which describes the confirmation process at * You also find a graphic which describes the confirmation process at
* https://github.com/friendica/friendica/blob/master/spec/dfrn2_contact_request.png * https://github.com/friendica/friendica/blob/master/spec/dfrn2_contact_request.png
*/ */
use Friendica\App; use Friendica\App;
use Friendica\Core\Config; use Friendica\Core\Config;
use Friendica\Core\PConfig; use Friendica\Core\PConfig;
use Friendica\Core\System; use Friendica\Core\System;
use Friendica\Database\DBM; use Friendica\Database\DBM;
use Friendica\Network\Probe; use Friendica\Network\Probe;
use Friendica\Object\Contact;
require_once 'include/enotify.php'; require_once 'include/enotify.php';
require_once 'include/group.php'; require_once 'include/group.php';
function dfrn_request_init(App $a) { function dfrn_request_init(App $a)
{
if ($a->argc > 1) if ($a->argc > 1)
$which = $a->argv[1]; $which = $a->argv[1];
@ -196,7 +195,7 @@ function dfrn_request_post(App $a) {
group_add_member(local_user(), '', $r[0]['id'], $def_gid); group_add_member(local_user(), '', $r[0]['id'], $def_gid);
if (isset($photo)) if (isset($photo))
update_contact_avatar($photo, local_user(), $r[0]["id"], true); Contact::updateAvatar($photo, local_user(), $r[0]["id"], true);
$forwardurl = System::baseUrl()."/contacts/".$r[0]['id']; $forwardurl = System::baseUrl()."/contacts/".$r[0]['id'];
} else { } else {
@ -587,7 +586,7 @@ function dfrn_request_post(App $a) {
); );
if (DBM::is_result($r)) { if (DBM::is_result($r)) {
$contact_record = $r[0]; $contact_record = $r[0];
update_contact_avatar($photo, $uid, $contact_record["id"], true); Contact::updateAvatar($photo, $uid, $contact_record["id"], true);
} }
} }

3
mod/fbrowser.php
View file

@ -7,8 +7,7 @@
use Friendica\App; use Friendica\App;
use Friendica\Core\System; use Friendica\Core\System;
use Friendica\Object\Photo;
require_once('include/Photo.php');
/** /**
* @param App $a * @param App $a

7
mod/install.php
View file

@ -1,10 +1,11 @@
<?php <?php
/**
* @file mod/install.php
*/
use Friendica\App; use Friendica\App;
use Friendica\Core\System; use Friendica\Core\System;
use Friendica\Database\DBM; use Friendica\Database\DBM;
use Friendica\Object\Photo;
require_once "include/Photo.php";
$install_wizard_pass = 1; $install_wizard_pass = 1;

10
mod/photo.php
View file

@ -1,10 +1,12 @@
<?php <?php
/**
* @file mod/photo.php
*/
use Friendica\App; use Friendica\App;
use Friendica\Database\DBM; use Friendica\Database\DBM;
use Friendica\Object\Photo;
require_once('include/security.php'); require_once 'include/security.php';
require_once('include/Photo.php');
function photo_init(App $a) { function photo_init(App $a) {
global $_SERVER; global $_SERVER;
@ -167,7 +169,7 @@ function photo_init(App $a) {
// Resize only if its not a GIF and it is supported by the library // Resize only if its not a GIF and it is supported by the library
if (($mimetype != "image/gif") && in_array($mimetype, Photo::supportedTypes())) { if (($mimetype != "image/gif") && in_array($mimetype, Photo::supportedTypes())) {
$ph = new Photo($data, $mimetype); $ph = new Photo($data, $mimetype);
if ($ph->is_valid()) { if ($ph->isValid()) {
if (isset($customres) && $customres > 0 && $customres < 500) { if (isset($customres) && $customres > 0 && $customres < 500) {
$ph->scaleImageSquare($customres); $ph->scaleImageSquare($customres);
} }

12
mod/photos.php
View file

@ -1,5 +1,7 @@
<?php <?php
/**
* @file mod/photos.php
*/
use Friendica\App; use Friendica\App;
use Friendica\Core\System; use Friendica\Core\System;
use Friendica\Core\Config; use Friendica\Core\Config;
@ -7,8 +9,8 @@ use Friendica\Core\Worker;
use Friendica\Database\DBM; use Friendica\Database\DBM;
use Friendica\Network\Probe; use Friendica\Network\Probe;
use Friendica\Object\Contact; use Friendica\Object\Contact;
use Friendica\Object\Photo;
require_once 'include/Photo.php';
require_once 'include/photos.php'; require_once 'include/photos.php';
require_once 'include/items.php'; require_once 'include/items.php';
require_once 'include/acl_selectors.php'; require_once 'include/acl_selectors.php';
@ -422,7 +424,7 @@ function photos_post(App $a) {
); );
if (DBM::is_result($r)) { if (DBM::is_result($r)) {
$ph = new Photo($r[0]['data'], $r[0]['type']); $ph = new Photo($r[0]['data'], $r[0]['type']);
if ($ph->is_valid()) { if ($ph->isValid()) {
$rotate_deg = ( (intval($_POST['rotate']) == 1) ? 270 : 90 ); $rotate_deg = ( (intval($_POST['rotate']) == 1) ? 270 : 90 );
$ph->rotate($rotate_deg); $ph->rotate($rotate_deg);
@ -808,7 +810,7 @@ function photos_post(App $a) {
$type = $_FILES['userfile']['type']; $type = $_FILES['userfile']['type'];
} }
if ($type == "") { if ($type == "") {
$type = guess_image_type($filename); $type = Photo::guessImageType($filename);
} }
logger('photos: upload: received file: ' . $filename . ' as ' . $src . ' ('. $type . ') ' . $filesize . ' bytes', LOGGER_DEBUG); logger('photos: upload: received file: ' . $filename . ' as ' . $src . ' ('. $type . ') ' . $filesize . ' bytes', LOGGER_DEBUG);
@ -837,7 +839,7 @@ function photos_post(App $a) {
$ph = new Photo($imagedata, $type); $ph = new Photo($imagedata, $type);
if (! $ph->is_valid()) { if (! $ph->isValid()) {
logger('mod/photos.php: photos_post(): unable to process image' , LOGGER_DEBUG); logger('mod/photos.php: photos_post(): unable to process image' , LOGGER_DEBUG);
notice( t('Unable to process image.') . EOL ); notice( t('Unable to process image.') . EOL );
@unlink($src); @unlink($src);

13
mod/profile_photo.php
View file

@ -1,12 +1,13 @@
<?php <?php
/**
* @file mod/profile_photo.php
*/
use Friendica\App; use Friendica\App;
use Friendica\Core\Config; use Friendica\Core\Config;
use Friendica\Core\System; use Friendica\Core\System;
use Friendica\Core\Worker; use Friendica\Core\Worker;
use Friendica\Database\DBM; use Friendica\Database\DBM;
use Friendica\Object\Photo;
require_once("include/Photo.php");
function profile_photo_init(App $a) { function profile_photo_init(App $a) {
@ -72,7 +73,7 @@ function profile_photo_post(App $a) {
$base_image = $r[0]; $base_image = $r[0];
$im = new Photo($base_image['data'], $base_image['type']); $im = new Photo($base_image['data'], $base_image['type']);
if($im->is_valid()) { if ($im->isValid()) {
$im->cropImage(175,$srcX,$srcY,$srcW,$srcH); $im->cropImage(175,$srcX,$srcY,$srcW,$srcH);
$r = $im->store(local_user(), 0, $base_image['resource-id'],$base_image['filename'], t('Profile Photos'), 4, $is_default_profile); $r = $im->store(local_user(), 0, $base_image['resource-id'],$base_image['filename'], t('Profile Photos'), 4, $is_default_profile);
@ -150,7 +151,7 @@ function profile_photo_post(App $a) {
$filesize = intval($_FILES['userfile']['size']); $filesize = intval($_FILES['userfile']['size']);
$filetype = $_FILES['userfile']['type']; $filetype = $_FILES['userfile']['type'];
if ($filetype == "") { if ($filetype == "") {
$filetype = guess_image_type($filename); $filetype = Photo::guessImageType($filename);
} }
$maximagesize = Config::get('system', 'maximagesize'); $maximagesize = Config::get('system', 'maximagesize');
@ -164,7 +165,7 @@ function profile_photo_post(App $a) {
$imagedata = @file_get_contents($src); $imagedata = @file_get_contents($src);
$ph = new Photo($imagedata, $filetype); $ph = new Photo($imagedata, $filetype);
if (! $ph->is_valid()) { if (! $ph->isValid()) {
notice(t('Unable to process image.') . EOL); notice(t('Unable to process image.') . EOL);
@unlink($src); @unlink($src);
return; return;

15
mod/proxy.php
View file

@ -1,10 +1,14 @@
<?php <?php
// Based upon "Privacy Image Cache" by Tobias Hößl <https://github.com/CatoTH/> /**
* @file mod/proxy.php
* @brief Based upon "Privacy Image Cache" by Tobias Hößl <https://github.com/CatoTH/>
*/
use Friendica\App; use Friendica\App;
use Friendica\Core\Config; use Friendica\Core\Config;
use Friendica\Core\System; use Friendica\Core\System;
use Friendica\Database\DBM; use Friendica\Database\DBM;
use Friendica\Object\Photo;
define('PROXY_DEFAULT_TIME', 86400); // 1 Day define('PROXY_DEFAULT_TIME', 86400); // 1 Day
@ -15,7 +19,6 @@ define('PROXY_SIZE_MEDIUM', 'medium');
define('PROXY_SIZE_LARGE', 'large'); define('PROXY_SIZE_LARGE', 'large');
require_once 'include/security.php'; require_once 'include/security.php';
require_once 'include/Photo.php';
function proxy_init(App $a) { function proxy_init(App $a) {
// Pictures are stored in one of the following ways: // Pictures are stored in one of the following ways:
@ -128,7 +131,7 @@ function proxy_init(App $a) {
// reduce quality - if it isn't a GIF // reduce quality - if it isn't a GIF
if ($mime != 'image/gif') { if ($mime != 'image/gif') {
$img = new Photo($img_str, $mime); $img = new Photo($img_str, $mime);
if ($img->is_valid()) { if ($img->isValid()) {
$img_str = $img->imageString(); $img_str = $img->imageString();
} }
} }
@ -172,7 +175,7 @@ function proxy_init(App $a) {
$cachefile = ''; // Clear the cachefile so that the dummy isn't stored $cachefile = ''; // Clear the cachefile so that the dummy isn't stored
$valid = false; $valid = false;
$img = new Photo($img_str, 'image/png'); $img = new Photo($img_str, 'image/png');
if ($img->is_valid()) { if ($img->isValid()) {
$img->scaleImage(10); $img->scaleImage(10);
$img_str = $img->imageString(); $img_str = $img->imageString();
} }
@ -190,7 +193,7 @@ function proxy_init(App $a) {
dba::insert('photo', $fields); dba::insert('photo', $fields);
} else { } else {
$img = new Photo($img_str, $mime); $img = new Photo($img_str, $mime);
if ($img->is_valid() && !$direct_cache && ($cachefile == '')) { if ($img->isValid() && !$direct_cache && ($cachefile == '')) {
$img->store(0, 0, $urlhash, $_REQUEST['url'], '', 100); $img->store(0, 0, $urlhash, $_REQUEST['url'], '', 100);
} }
} }
@ -201,7 +204,7 @@ function proxy_init(App $a) {
// reduce quality - if it isn't a GIF // reduce quality - if it isn't a GIF
if ($mime != 'image/gif') { if ($mime != 'image/gif') {
$img = new Photo($img_str, $mime); $img = new Photo($img_str, $mime);
if ($img->is_valid()) { if ($img->isValid()) {
$img->scaleImage($size); $img->scaleImage($size);
$img_str = $img->imageString(); $img_str = $img->imageString();
} }

7
mod/wall_upload.php
View file

@ -13,8 +13,7 @@ use Friendica\App;
use Friendica\Core\System; use Friendica\Core\System;
use Friendica\Core\Config; use Friendica\Core\Config;
use Friendica\Database\DBM; use Friendica\Database\DBM;
use Friendica\Object\Photo;
require_once 'include/Photo.php';
function wall_upload_post(App $a, $desktopmode = true) { function wall_upload_post(App $a, $desktopmode = true) {
@ -163,7 +162,7 @@ function wall_upload_post(App $a, $desktopmode = true) {
} }
if ($filetype=="") { if ($filetype=="") {
$filetype=guess_image_type($filename); $filetype=Photo::guessImageType($filename);
} }
// If there is a temp name, then do a manual check // If there is a temp name, then do a manual check
@ -193,7 +192,7 @@ function wall_upload_post(App $a, $desktopmode = true) {
$imagedata = @file_get_contents($src); $imagedata = @file_get_contents($src);
$ph = new Photo($imagedata, $filetype); $ph = new Photo($imagedata, $filetype);
if (! $ph->is_valid()) { if (! $ph->isValid()) {
$msg = t('Unable to process image.'); $msg = t('Unable to process image.');
if ($r_json) { if ($r_json) {
echo json_encode(array('error'=>$msg)); echo json_encode(array('error'=>$msg));

4
src/Model/GlobalContact.php
View file

@ -10,6 +10,7 @@ use Friendica\Core\System;
use Friendica\Core\Worker; use Friendica\Core\Worker;
use Friendica\Database\DBM; use Friendica\Database\DBM;
use Friendica\Network\Probe; use Friendica\Network\Probe;
use Friendica\Object\Contact;
use Friendica\Object\Profile; use Friendica\Object\Profile;
use Friendica\Protocol\PortableContact; use Friendica\Protocol\PortableContact;
use dba; use dba;
@ -18,7 +19,6 @@ use Exception;
require_once 'include/datetime.php'; require_once 'include/datetime.php';
require_once 'include/network.php'; require_once 'include/network.php';
require_once 'include/html2bbcode.php'; require_once 'include/html2bbcode.php';
require_once 'include/Photo.php';
/** /**
* @brief This class handles GlobalContact related functions * @brief This class handles GlobalContact related functions
@ -881,7 +881,7 @@ class GlobalContact
if (DBM::is_result($r)) { if (DBM::is_result($r)) {
logger("Update public contact ".$r[0]["id"], LOGGER_DEBUG); logger("Update public contact ".$r[0]["id"], LOGGER_DEBUG);
update_contact_avatar($contact["photo"], 0, $r[0]["id"]); Contact::updateAvatar($contact["photo"], 0, $r[0]["id"]);
$fields = array('name', 'nick', 'addr', $fields = array('name', 'nick', 'addr',
'network', 'bd', 'gender', 'network', 'bd', 'gender',

50
src/Object/Contact.php
View file

@ -13,6 +13,7 @@ use Friendica\Core\System;
use Friendica\Core\Worker; use Friendica\Core\Worker;
use Friendica\Database\DBM; use Friendica\Database\DBM;
use Friendica\Network\Probe; use Friendica\Network\Probe;
use Friendica\Object\Photo;
use Friendica\Protocol\Diaspora; use Friendica\Protocol\Diaspora;
use Friendica\Protocol\DFRN; use Friendica\Protocol\DFRN;
use Friendica\Protocol\OStatus; use Friendica\Protocol\OStatus;
@ -645,9 +646,7 @@ class Contact extends BaseObject
} }
} }
require_once 'include/Photo.php'; self::updateAvatar($data["photo"], $uid, $contact_id);
update_contact_avatar($data["photo"], $uid, $contact_id);
$contact = dba::select('contact', array('url', 'nurl', 'addr', 'alias', 'name', 'nick', 'keywords', 'location', 'about', 'avatar-date'), array('id' => $contact_id), array('limit' => 1)); $contact = dba::select('contact', array('url', 'nurl', 'addr', 'alias', 'name', 'nick', 'keywords', 'location', 'about', 'avatar-date'), array('id' => $contact_id), array('limit' => 1));
@ -847,4 +846,49 @@ class Contact extends BaseObject
return $return; return $return;
} }
/**
* @brief Updates the avatar links in a contact only if needed
*
* @param string $avatar Link to avatar picture
* @param int $uid User id of contact owner
* @param int $cid Contact id
* @param bool $force force picture update
*
* @return array Returns array of the different avatar sizes
*/
public static function updateAvatar($avatar, $uid, $cid, $force = false)
{
// Limit = 1 returns the row so no need for dba:inArray()
$r = dba::select('contact', array('avatar', 'photo', 'thumb', 'micro', 'nurl'), array('id' => $cid), array('limit' => 1));
if (!DBM::is_result($r)) {
return false;
} else {
$data = array($r["photo"], $r["thumb"], $r["micro"]);
}
if (($r["avatar"] != $avatar) || $force) {
$photos = Photo::importProfilePhoto($avatar, $uid, $cid, true);
if ($photos) {
dba::update(
'contact',
array('avatar' => $avatar, 'photo' => $photos[0], 'thumb' => $photos[1], 'micro' => $photos[2], 'avatar-date' => datetime_convert()),
array('id' => $cid)
);
// Update the public contact (contact id = 0)
if ($uid != 0) {
$pcontact = dba::select('contact', array('id'), array('nurl' => $r[0]['nurl']), array('limit' => 1));
if (DBM::is_result($pcontact)) {
self::updateAvatar($avatar, 0, $pcontact['id'], $force);
}
}
return $photos;
}
}
return $data;
}
} }

392
include/Photo.php → src/Object/Photo.php
View file

@ -1,19 +1,26 @@
<?php <?php
/** /**
* @file include/Photo.php * @file src/Object/Photo.php
* @brief This file contains the Photo class for image processing * @brief This file contains the Photo class for image processing
*/ */
namespace Friendica\Object;
use Friendica\App; use Friendica\App;
use Friendica\Core\Cache; use Friendica\Core\Cache;
use Friendica\Core\Config; use Friendica\Core\Config;
use Friendica\Core\System; use Friendica\Core\System;
use Friendica\Database\DBM; use Friendica\Database\DBM;
use dba;
use Imagick;
use ImagickPixel;
require_once("include/photos.php"); require_once "include/photos.php";
class Photo {
/**
* Class to handle Photos
*/
class Photo
{
private $image; private $image;
/* /*
@ -28,10 +35,11 @@ class Photo {
/** /**
* @brief supported mimetypes and corresponding file extensions * @brief supported mimetypes and corresponding file extensions
* @return array
*/ */
public static function supportedTypes() { public static function supportedTypes()
{
if (class_exists('Imagick')) { if (class_exists('Imagick')) {
// Imagick::queryFormats won't help us a lot there... // Imagick::queryFormats won't help us a lot there...
// At least, not yet, other parts of friendica uses this array // At least, not yet, other parts of friendica uses this array
$t = array( $t = array(
@ -50,7 +58,14 @@ class Photo {
return $t; return $t;
} }
public function __construct($data, $type=null) { /**
* @brief Constructor
* @param object $data data
* @param boolean $type optional, default null
* @return object
*/
public function __construct($data, $type = null)
{
$this->imagick = class_exists('Imagick'); $this->imagick = class_exists('Imagick');
$this->types = static::supportedTypes(); $this->types = static::supportedTypes();
if (!array_key_exists($type, $this->types)) { if (!array_key_exists($type, $this->types)) {
@ -58,18 +73,23 @@ class Photo {
} }
$this->type = $type; $this->type = $type;
if ($this->is_imagick() && $this->load_data($data)) { if ($this->isImagick() && $this->loadData($data)) {
return true; return true;
} else { } else {
// Failed to load with Imagick, fallback // Failed to load with Imagick, fallback
$this->imagick = false; $this->imagick = false;
} }
return $this->load_data($data); return $this->loadData($data);
} }
public function __destruct() { /**
* @brief Destructor
* @return void
*/
public function __destruct()
{
if ($this->image) { if ($this->image) {
if ($this->is_imagick()) { if ($this->isImagick()) {
$this->image->clear(); $this->image->clear();
$this->image->destroy(); $this->image->destroy();
return; return;
@ -80,7 +100,11 @@ class Photo {
} }
} }
public function is_imagick() { /**
* @return boolean
*/
public function isImagick()
{
return $this->imagick; return $this->imagick;
} }
@ -88,7 +112,8 @@ class Photo {
* @brief Maps Mime types to Imagick formats * @brief Maps Mime types to Imagick formats
* @return arr With with image formats (mime type as key) * @return arr With with image formats (mime type as key)
*/ */
public function get_FormatsMap() { public static function getFormatsMap()
{
$m = array( $m = array(
'image/jpeg' => 'JPG', 'image/jpeg' => 'JPG',
'image/png' => 'PNG', 'image/png' => 'PNG',
@ -97,8 +122,13 @@ class Photo {
return $m; return $m;
} }
private function load_data($data) { /**
if ($this->is_imagick()) { * @param object $data data
* @return boolean
*/
private function loadData($data)
{
if ($this->isImagick()) {
$this->image = new Imagick(); $this->image = new Imagick();
try { try {
$this->image->readImageBlob($data); $this->image->readImageBlob($data);
@ -110,7 +140,7 @@ class Photo {
/* /*
* Setup the image to the format it will be saved to * Setup the image to the format it will be saved to
*/ */
$map = $this->get_FormatsMap(); $map = self::getFormatsMap();
$format = $map[$type]; $format = $map[$type];
$this->image->setFormat($format); $this->image->setFormat($format);
@ -168,41 +198,57 @@ class Photo {
return false; return false;
} }
public function is_valid() { /**
if ($this->is_imagick()) { * @return boolean
*/
public function isValid()
{
if ($this->isImagick()) {
return ($this->image !== false); return ($this->image !== false);
} }
return $this->valid; return $this->valid;
} }
public function getWidth() { /**
if (!$this->is_valid()) { * @return mixed
*/
public function getWidth()
{
if (!$this->isValid()) {
return false; return false;
} }
if ($this->is_imagick()) { if ($this->isImagick()) {
return $this->image->getImageWidth(); return $this->image->getImageWidth();
} }
return $this->width; return $this->width;
} }
public function getHeight() { /**
if (!$this->is_valid()) { * @return mixed
*/
public function getHeight()
{
if (!$this->isValid()) {
return false; return false;
} }
if ($this->is_imagick()) { if ($this->isImagick()) {
return $this->image->getImageHeight(); return $this->image->getImageHeight();
} }
return $this->height; return $this->height;
} }
public function getImage() { /**
if (!$this->is_valid()) { * @return mixed
*/
public function getImage()
{
if (!$this->isValid()) {
return false; return false;
} }
if ($this->is_imagick()) { if ($this->isImagick()) {
/* Clean it */ /* Clean it */
$this->image = $this->image->deconstructImages(); $this->image = $this->image->deconstructImages();
return $this->image; return $this->image;
@ -210,24 +256,37 @@ class Photo {
return $this->image; return $this->image;
} }
public function getType() { /**
if (!$this->is_valid()) { * @return mixed
*/
public function getType()
{
if (!$this->isValid()) {
return false; return false;
} }
return $this->type; return $this->type;
} }
public function getExt() { /**
if (!$this->is_valid()) { * @return mixed
*/
public function getExt()
{
if (!$this->isValid()) {
return false; return false;
} }
return $this->types[$this->getType()]; return $this->types[$this->getType()];
} }
public function scaleImage($max) { /**
if (!$this->is_valid()) { * @param integer $max max dimension
* @return mixed
*/
public function scaleImage($max)
{
if (!$this->isValid()) {
return false; return false;
} }
@ -241,7 +300,6 @@ class Photo {
} }
if ($width > $max && $height > $max) { if ($width > $max && $height > $max) {
// very tall image (greater than 16:9) // very tall image (greater than 16:9)
// constrain the width - let the height float. // constrain the width - let the height float.
@ -262,7 +320,6 @@ class Photo {
$dest_height = intval(($height * $max) / $width); $dest_height = intval(($height * $max) / $width);
} else { } else {
if ($height > $max) { if ($height > $max) {
// very tall image (greater than 16:9) // very tall image (greater than 16:9)
// but width is OK - don't do anything // but width is OK - don't do anything
@ -281,7 +338,7 @@ class Photo {
} }
if ($this->is_imagick()) { if ($this->isImagick()) {
/* /*
* If it is not animated, there will be only one iteration here, * If it is not animated, there will be only one iteration here,
* so don't bother checking * so don't bother checking
@ -289,7 +346,6 @@ class Photo {
// Don't forget to go back to the first frame // Don't forget to go back to the first frame
$this->image->setFirstIterator(); $this->image->setFirstIterator();
do { do {
// FIXME - implement horizantal bias for scaling as in followin GD functions // FIXME - implement horizantal bias for scaling as in followin GD functions
// to allow very tall images to be constrained only horizontally. // to allow very tall images to be constrained only horizontally.
@ -319,12 +375,17 @@ class Photo {
$this->height = imagesy($this->image); $this->height = imagesy($this->image);
} }
public function rotate($degrees) { /**
if (!$this->is_valid()) { * @param integer $degrees degrees to rotate image
* @return mixed
*/
public function rotate($degrees)
{
if (!$this->isValid()) {
return false; return false;
} }
if ($this->is_imagick()) { if ($this->isImagick()) {
$this->image->setFirstIterator(); $this->image->setFirstIterator();
do { do {
$this->image->rotateImage(new ImagickPixel(), -$degrees); // ImageMagick rotates in the opposite direction of imagerotate() $this->image->rotateImage(new ImagickPixel(), -$degrees); // ImageMagick rotates in the opposite direction of imagerotate()
@ -338,12 +399,18 @@ class Photo {
$this->height = imagesy($this->image); $this->height = imagesy($this->image);
} }
public function flip($horiz = true, $vert = false) { /**
if (!$this->is_valid()) { * @param boolean $horiz optional, default true
* @param boolean $vert optional, default false
* @return mixed
*/
public function flip($horiz = true, $vert = false)
{
if (!$this->isValid()) {
return false; return false;
} }
if ($this->is_imagick()) { if ($this->isImagick()) {
$this->image->setFirstIterator(); $this->image->setFirstIterator();
do { do {
if ($horiz) { if ($horiz) {
@ -372,28 +439,33 @@ class Photo {
$this->image = $flipped; $this->image = $flipped;
} }
public function orient($filename) { /**
if ($this->is_imagick()) { * @param string $filename filename
* @return mixed
*/
public function orient($filename)
{
if ($this->isImagick()) {
// based off comment on http://php.net/manual/en/imagick.getimageorientation.php // based off comment on http://php.net/manual/en/imagick.getimageorientation.php
$orientation = $this->image->getImageOrientation(); $orientation = $this->image->getImageOrientation();
switch ($orientation) { switch ($orientation) {
case imagick::ORIENTATION_BOTTOMRIGHT: case Imagick::ORIENTATION_BOTTOMRIGHT:
$this->image->rotateimage("#000", 180); $this->image->rotateimage("#000", 180);
break; break;
case imagick::ORIENTATION_RIGHTTOP: case Imagick::ORIENTATION_RIGHTTOP:
$this->image->rotateimage("#000", 90); $this->image->rotateimage("#000", 90);
break; break;
case imagick::ORIENTATION_LEFTBOTTOM: case Imagick::ORIENTATION_LEFTBOTTOM:
$this->image->rotateimage("#000", -90); $this->image->rotateimage("#000", -90);
break; break;
} }
$this->image->setImageOrientation(imagick::ORIENTATION_TOPLEFT); $this->image->setImageOrientation(Imagick::ORIENTATION_TOPLEFT);
return true; return true;
} }
// based off comment on http://php.net/manual/en/function.imagerotate.php // based off comment on http://php.net/manual/en/function.imagerotate.php
if (!$this->is_valid()) { if (!$this->isValid()) {
return false; return false;
} }
@ -408,8 +480,7 @@ class Photo {
$ort = $exif['IFD0']['Orientation']; $ort = $exif['IFD0']['Orientation'];
switch($ort) switch ($ort) {
{
case 1: // nothing case 1: // nothing
break; break;
@ -446,17 +517,18 @@ class Photo {
// logger('exif: ' . print_r($exif,true)); // logger('exif: ' . print_r($exif,true));
return $exif; return $exif;
} }
/**
* @param integer $min minimum dimension
public function scaleImageUp($min) { * @return mixed
if (!$this->is_valid()) { */
public function scaleImageUp($min)
{
if (!$this->isValid()) {
return false; return false;
} }
$width = $this->getWidth(); $width = $this->getWidth();
$height = $this->getHeight(); $height = $this->getHeight();
@ -489,7 +561,7 @@ class Photo {
} }
} }
if ($this->is_imagick()) { if ($this->isImagick()) {
return $this->scaleImage($dest_width, $dest_height); return $this->scaleImage($dest_width, $dest_height);
} }
@ -508,14 +580,17 @@ class Photo {
$this->height = imagesy($this->image); $this->height = imagesy($this->image);
} }
/**
* @param integer $dim dimension
public function scaleImageSquare($dim) { * @return mixed
if (!$this->is_valid()) { */
public function scaleImageSquare($dim)
{
if (!$this->isValid()) {
return false; return false;
} }
if ($this->is_imagick()) { if ($this->isImagick()) {
$this->image->setFirstIterator(); $this->image->setFirstIterator();
do { do {
$this->image->scaleImage($dim, $dim); $this->image->scaleImage($dim, $dim);
@ -538,13 +613,21 @@ class Photo {
$this->height = imagesy($this->image); $this->height = imagesy($this->image);
} }
/**
public function cropImage($max, $x, $y, $w, $h) { * @param integer $max maximum
if (!$this->is_valid()) { * @param integer $x x coordinate
* @param integer $y y coordinate
* @param integer $w width
* @param integer $h height
* @return mixed
*/
public function cropImage($max, $x, $y, $w, $h)
{
if (!$this->isValid()) {
return false; return false;
} }
if ($this->is_imagick()) { if ($this->isImagick()) {
$this->image->setFirstIterator(); $this->image->setFirstIterator();
do { do {
$this->image->cropImage($w, $h, $x, $y); $this->image->cropImage($w, $h, $x, $y);
@ -573,8 +656,13 @@ class Photo {
$this->height = imagesy($this->image); $this->height = imagesy($this->image);
} }
public function saveImage($path) { /**
if (!$this->is_valid()) { * @param string $path file path
* @return mixed
*/
public function saveImage($path)
{
if (!$this->isValid()) {
return false; return false;
} }
@ -587,12 +675,16 @@ class Photo {
$a->save_timestamp($stamp1, "file"); $a->save_timestamp($stamp1, "file");
} }
public function imageString() { /**
if (!$this->is_valid()) { * @return mixed
*/
public function imageString()
{
if (!$this->isValid()) {
return false; return false;
} }
if ($this->is_imagick()) { if ($this->isImagick()) {
/* Clean it */ /* Clean it */
$this->image = $this->image->deconstructImages(); $this->image = $this->image->deconstructImages();
$string = $this->image->getImagesBlob(); $string = $this->image->getImagesBlob();
@ -627,10 +719,23 @@ class Photo {
return $string; return $string;
} }
/**
* @param integer $uid uid
public function store($uid, $cid, $rid, $filename, $album, $scale, $profile = 0, $allow_cid = '', $allow_gid = '', $deny_cid = '', $deny_gid = '', $desc = '') { * @param integer $cid cid
* @param integer $rid rid
* @param string $filename filename
* @param string $album album name
* @param integer $scale scale
* @param integer $profile optional, default = 0
* @param string $allow_cid optional, default = ''
* @param string $allow_gid optional, default = ''
* @param string $deny_cid optional, default = ''
* @param string $deny_gid optional, default = ''
* @param string $desc optional, default = ''
* @return object
*/
public function store($uid, $cid, $rid, $filename, $album, $scale, $profile = 0, $allow_cid = '', $allow_gid = '', $deny_cid = '', $deny_gid = '', $desc = '')
{
$r = dba::select('photo', array('guid'), array("`resource-id` = ? AND `guid` != ?", $rid, ''), array('limit' => 1)); $r = dba::select('photo', array('guid'), array("`resource-id` = ? AND `guid` != ?", $rid, ''), array('limit' => 1));
if (DBM::is_result($r)) { if (DBM::is_result($r)) {
$guid = $r['guid']; $guid = $r['guid'];
@ -653,17 +758,18 @@ class Photo {
return $r; return $r;
} }
}
/** /**
* Guess image mimetype from filename or from Content-Type header * Guess image mimetype from filename or from Content-Type header
* *
* @arg $filename string Image filename * @param string $filename Image filename
* @arg $fromcurl boolean Check Content-Type header from curl request * @param boolean $fromcurl Check Content-Type header from curl request
*
* @return object
*/ */
function guess_image_type($filename, $fromcurl=false) { public static function guessImageType($filename, $fromcurl = false)
logger('Photo: guess_image_type: '.$filename . ($fromcurl?' from curl headers':''), LOGGER_DEBUG); {
logger('Photo: guessImageType: '.$filename . ($fromcurl?' from curl headers':''), LOGGER_DEBUG);
$type = null; $type = null;
if ($fromcurl) { if ($fromcurl) {
$a = get_app(); $a = get_app();
@ -689,7 +795,7 @@ function guess_image_type($filename, $fromcurl=false) {
$image->setInterlaceScheme(Imagick::INTERLACE_PLANE); $image->setInterlaceScheme(Imagick::INTERLACE_PLANE);
} else { } else {
$ext = pathinfo($filename, PATHINFO_EXTENSION); $ext = pathinfo($filename, PATHINFO_EXTENSION);
$types = Photo::supportedTypes(); $types = self::supportedTypes();
$type = "image/jpeg"; $type = "image/jpeg";
foreach ($types as $m => $e) { foreach ($types as $m => $e) {
if ($ext == $e) { if ($ext == $e) {
@ -698,60 +804,28 @@ function guess_image_type($filename, $fromcurl=false) {
} }
} }
} }
logger('Photo: guess_image_type: type='.$type, LOGGER_DEBUG); logger('Photo: guessImageType: type='.$type, LOGGER_DEBUG);
return $type; return $type;
} }
/** /**
* @brief Updates the avatar links in a contact only if needed * @param string $photo photo
* * @param integer $uid user id
* @param string $avatar Link to avatar picture * @param integer $cid contact id
* @param int $uid User id of contact owner * @param boolean $quit_on_error optional, default false
* @param int $cid Contact id * @return array
* @param bool $force force picture update
*
* @return array Returns array of the different avatar sizes
*/ */
function update_contact_avatar($avatar, $uid, $cid, $force = false) { public static function importProfilePhoto($photo, $uid, $cid, $quit_on_error = false)
$r = q("SELECT `avatar`, `photo`, `thumb`, `micro`, `nurl` FROM `contact` WHERE `id` = %d LIMIT 1", intval($cid)); {
if (!DBM::is_result($r)) { $r = dba::select(
return false; 'photo',
} else { array('resource-id'),
$data = array($r[0]["photo"], $r[0]["thumb"], $r[0]["micro"]); array('uid' => $uid, 'contact-id' => $cid, 'scale' => 4, 'album' => 'Contact Photos'),
} array('limit' => 1)
if (($r[0]["avatar"] != $avatar) || $force) {
$photos = import_profile_photo($avatar, $uid, $cid, true);
if ($photos) {
q("UPDATE `contact` SET `avatar` = '%s', `photo` = '%s', `thumb` = '%s', `micro` = '%s', `avatar-date` = '%s' WHERE `id` = %d",
dbesc($avatar), dbesc($photos[0]), dbesc($photos[1]), dbesc($photos[2]),
dbesc(datetime_convert()), intval($cid));
// Update the public contact (contact id = 0)
if ($uid != 0) {
$pcontact = dba::select('contact', array('id'), array('nurl' => $r[0]['nurl']), array('limit' => 1));
if (DBM::is_result($pcontact)) {
update_contact_avatar($avatar, 0, $pcontact['id'], $force);
}
}
return $photos;
}
}
return $data;
}
function import_profile_photo($photo, $uid, $cid, $quit_on_error = false) {
$r = q("SELECT `resource-id` FROM `photo` WHERE `uid` = %d AND `contact-id` = %d AND `scale` = 4 AND `album` = 'Contact Photos' LIMIT 1",
intval($uid),
intval($cid)
); );
if (DBM::is_result($r) && strlen($r[0]['resource-id'])) {
$hash = $r[0]['resource-id']; if (DBM::is_result($r) && strlen($r['resource-id'])) {
$hash = $r['resource-id'];
} else { } else {
$hash = photo_new_resource(); $hash = photo_new_resource();
} }
@ -765,23 +839,24 @@ function import_profile_photo($photo, $uid, $cid, $quit_on_error = false) {
return false; return false;
} }
$type = guess_image_type($photo, true); $type = self::guessImageType($photo, true);
$img = new Photo($img_str, $type); $img = new Photo($img_str, $type);
if ($img->is_valid()) { if ($img->isValid()) {
$img->scaleImageSquare(175); $img->scaleImageSquare(175);
$r = $img->store($uid, $cid, $hash, $filename, 'Contact Photos', 4); $r = $img->store($uid, $cid, $hash, $filename, 'Contact Photos', 4);
if ($r === false) if ($r === false) {
$photo_failure = true; $photo_failure = true;
}
$img->scaleImage(80); $img->scaleImage(80);
$r = $img->store($uid, $cid, $hash, $filename, 'Contact Photos', 5); $r = $img->store($uid, $cid, $hash, $filename, 'Contact Photos', 5);
if ($r === false) if ($r === false) {
$photo_failure = true; $photo_failure = true;
}
$img->scaleImage(48); $img->scaleImage(48);
@ -829,11 +904,15 @@ function import_profile_photo($photo, $uid, $cid, $quit_on_error = false) {
$micro = System::baseUrl() . '/images/person-48.jpg'; $micro = System::baseUrl() . '/images/person-48.jpg';
} }
return(array($photo,$thumb,$micro)); return array($photo, $thumb, $micro);
} }
function get_photo_info($url) { /**
* @param string $url url
* @return object
*/
public static function getInfoFromURL($url)
{
$data = array(); $data = array();
$data = Cache::get($url); $data = Cache::get($url);
@ -866,8 +945,14 @@ function get_photo_info($url) {
return $data; return $data;
} }
function scale_image($width, $height, $max) { /**
* @param integer $width width
* @param integer $height height
* @param integer $max max
* @return array
*/
public static function scaleImageTo($width, $height, $max)
{
$dest_width = $dest_height = 0; $dest_width = $dest_height = 0;
if ((!$width) || (!$height)) { if ((!$width) || (!$height)) {
@ -875,7 +960,6 @@ function scale_image($width, $height, $max) {
} }
if ($width > $max && $height > $max) { if ($width > $max && $height > $max) {
// very tall image (greater than 16:9) // very tall image (greater than 16:9)
// constrain the width - let the height float. // constrain the width - let the height float.
@ -896,7 +980,6 @@ function scale_image($width, $height, $max) {
$dest_height = intval(($height * $max) / $width); $dest_height = intval(($height * $max) / $width);
} else { } else {
if ($height > $max) { if ($height > $max) {
// very tall image (greater than 16:9) // very tall image (greater than 16:9)
// but width is OK - don't do anything // but width is OK - don't do anything
@ -916,10 +999,21 @@ function scale_image($width, $height, $max) {
return array("width" => $dest_width, "height" => $dest_height); return array("width" => $dest_width, "height" => $dest_height);
} }
function store_photo(App $a, $uid, $imagedata = "", $url = "") { /**
$r = q("SELECT `user`.`nickname`, `user`.`page-flags`, `contact`.`id` FROM `user` INNER JOIN `contact` on `user`.`uid` = `contact`.`uid` * @brief This function is used by the fromgplus addon
* @param object $a App
* @param integer $uid user id
* @param string $imagedata optional, default empty
* @param string $url optional, default empty
* @return array
*/
public static function storePhoto(App $a, $uid, $imagedata = "", $url = "")
{
$r = q(
"SELECT `user`.`nickname`, `user`.`page-flags`, `contact`.`id` FROM `user` INNER JOIN `contact` on `user`.`uid` = `contact`.`uid`
WHERE `user`.`uid` = %d AND `user`.`blocked` = 0 AND `contact`.`self` = 1 LIMIT 1", WHERE `user`.`uid` = %d AND `user`.`blocked` = 0 AND `contact`.`self` = 1 LIMIT 1",
intval($uid)); intval($uid)
);
if (!DBM::is_result($r)) { if (!DBM::is_result($r)) {
logger("Can't detect user data for uid ".$uid, LOGGER_DEBUG); logger("Can't detect user data for uid ".$uid, LOGGER_DEBUG);
@ -966,7 +1060,7 @@ function store_photo(App $a, $uid, $imagedata = "", $url = "") {
$ph = new Photo($imagedata, $data["mime"]); $ph = new Photo($imagedata, $data["mime"]);
if (!$ph->is_valid()) { if (!$ph->isValid()) {
unlink($tempfile); unlink($tempfile);
logger("Picture is no valid picture", LOGGER_DEBUG); logger("Picture is no valid picture", LOGGER_DEBUG);
return(array()); return(array());
@ -979,6 +1073,7 @@ function store_photo(App $a, $uid, $imagedata = "", $url = "") {
if (! $max_length) { if (! $max_length) {
$max_length = MAX_IMAGE_LENGTH; $max_length = MAX_IMAGE_LENGTH;
} }
if ($max_length > 0) { if ($max_length > 0) {
$ph->scaleImage($max_length); $ph->scaleImage($max_length);
} }
@ -1067,3 +1162,4 @@ function store_photo(App $a, $uid, $imagedata = "", $url = "") {
return($image); return($image);
} }
}

6
src/ParseUrl.php
View file

@ -6,6 +6,7 @@
namespace Friendica; namespace Friendica;
use Friendica\Core\Config; use Friendica\Core\Config;
use Friendica\Object\Photo;
use Friendica\Util\XML; use Friendica\Util\XML;
use dba; use dba;
@ -13,7 +14,6 @@ use DomXPath;
use DOMDocument; use DOMDocument;
require_once "include/network.php"; require_once "include/network.php";
require_once "include/Photo.php";
require_once "include/oembed.php"; require_once "include/oembed.php";
/** /**
@ -353,7 +353,7 @@ class ParseUrl
} }
$src = self::completeUrl($attr["src"], $url); $src = self::completeUrl($attr["src"], $url);
$photodata = get_photo_info($src); $photodata = Photo::getInfoFromURL($src);
if (($photodata) && ($photodata[0] > 150) && ($photodata[1] > 150)) { if (($photodata) && ($photodata[0] > 150) && ($photodata[1] > 150)) {
if ($photodata[0] > 300) { if ($photodata[0] > 300) {
@ -374,7 +374,7 @@ class ParseUrl
unset($siteinfo["image"]); unset($siteinfo["image"]);
$photodata = get_photo_info($src); $photodata = Photo::getInfoFromURL($src);
if (($photodata) && ($photodata[0] > 10) && ($photodata[1] > 10)) { if (($photodata) && ($photodata[0] > 10) && ($photodata[1] > 10)) {
$siteinfo["images"][] = array("src" => $src, $siteinfo["images"][] = array("src" => $src,

5
src/Protocol/DFRN.php
View file

@ -15,6 +15,7 @@ use Friendica\Core\Worker;
use Friendica\Database\DBM; use Friendica\Database\DBM;
use Friendica\Model\GlobalContact; use Friendica\Model\GlobalContact;
use Friendica\Object\Contact; use Friendica\Object\Contact;
use Friendica\Object\Photo;
use Friendica\Object\Profile; use Friendica\Object\Profile;
use Friendica\Protocol\OStatus; use Friendica\Protocol\OStatus;
use Friendica\Util\XML; use Friendica\Util\XML;
@ -1659,7 +1660,7 @@ class DFRN
); );
} }
update_contact_avatar( Contact::updateAvatar(
$author["avatar"], $author["avatar"],
$importer["uid"], $importer["uid"],
$contact["id"], $contact["id"],
@ -2034,7 +2035,7 @@ class DFRN
dbesc(normalise_link($old["url"])) dbesc(normalise_link($old["url"]))
); );
update_contact_avatar($relocate["avatar"], $importer["importer_uid"], $importer["id"], true); Contact::updateAvatar($relocate["avatar"], $importer["importer_uid"], $importer["id"], true);
if ($x === false) { if ($x === false) {
return false; return false;

7
src/Protocol/Diaspora.php
View file

@ -27,7 +27,6 @@ use SimpleXMLElement;
require_once 'include/items.php'; require_once 'include/items.php';
require_once 'include/bb2diaspora.php'; require_once 'include/bb2diaspora.php';
require_once 'include/Photo.php';
require_once 'include/group.php'; require_once 'include/group.php';
require_once 'include/datetime.php'; require_once 'include/datetime.php';
require_once 'include/queue_fn.php'; require_once 'include/queue_fn.php';
@ -2211,7 +2210,7 @@ class Diaspora
$image_url = "http://".$handle_parts[1].$image_url; $image_url = "http://".$handle_parts[1].$image_url;
} }
update_contact_avatar($image_url, $importer["uid"], $contact["id"]); Contact::updateAvatar($image_url, $importer["uid"], $contact["id"]);
// Generic birthday. We don't know the timezone. The year is irrelevant. // Generic birthday. We don't know the timezone. The year is irrelevant.
@ -2471,7 +2470,7 @@ class Diaspora
group_add_member($importer["uid"], "", $contact_record["id"], $def_gid); group_add_member($importer["uid"], "", $contact_record["id"], $def_gid);
} }
update_contact_avatar($ret["photo"], $importer['uid'], $contact_record["id"], true); Contact::updateAvatar($ret["photo"], $importer['uid'], $contact_record["id"], true);
if ($importer["page-flags"] == PAGE_NORMAL) { if ($importer["page-flags"] == PAGE_NORMAL) {
logger("Sending intra message for author ".$author.".", LOGGER_DEBUG); logger("Sending intra message for author ".$author.".", LOGGER_DEBUG);
@ -2494,7 +2493,7 @@ class Diaspora
logger("Does an automatic friend approval for author ".$author.".", LOGGER_DEBUG); logger("Does an automatic friend approval for author ".$author.".", LOGGER_DEBUG);
update_contact_avatar($contact_record["photo"], $importer["uid"], $contact_record["id"]); Contact::updateAvatar($contact_record["photo"], $importer["uid"], $contact_record["id"]);
// technically they are sharing with us (CONTACT_IS_SHARING), // technically they are sharing with us (CONTACT_IS_SHARING),
// but if our page-type is PAGE_COMMUNITY or PAGE_SOAPBOX // but if our page-type is PAGE_COMMUNITY or PAGE_SOAPBOX

10
src/Protocol/OStatus.php
View file

@ -12,6 +12,7 @@ use Friendica\Database\DBM;
use Friendica\Model\GlobalContact; use Friendica\Model\GlobalContact;
use Friendica\Network\Probe; use Friendica\Network\Probe;
use Friendica\Object\Contact; use Friendica\Object\Contact;
use Friendica\Object\Photo;
use Friendica\Util\Lock; use Friendica\Util\Lock;
use Friendica\Util\XML; use Friendica\Util\XML;
use dba; use dba;
@ -24,7 +25,6 @@ require_once 'include/bbcode.php';
require_once 'include/items.php'; require_once 'include/items.php';
require_once 'mod/share.php'; require_once 'mod/share.php';
require_once 'include/enotify.php'; require_once 'include/enotify.php';
require_once 'include/Photo.php';
require_once 'include/follow.php'; require_once 'include/follow.php';
require_once 'include/api.php'; require_once 'include/api.php';
require_once 'mod/proxy.php'; require_once 'mod/proxy.php';
@ -203,7 +203,7 @@ class OStatus
if (!empty($author["author-avatar"]) && ($author["author-avatar"] != $current['avatar'])) { if (!empty($author["author-avatar"]) && ($author["author-avatar"] != $current['avatar'])) {
logger("Update profile picture for contact ".$contact["id"], LOGGER_DEBUG); logger("Update profile picture for contact ".$contact["id"], LOGGER_DEBUG);
update_contact_avatar($author["author-avatar"], $importer["uid"], $contact["id"]); Contact::updateAvatar($author["author-avatar"], $importer["uid"], $contact["id"]);
} }
// Ensure that we are having this contact (with uid=0) // Ensure that we are having this contact (with uid=0)
@ -223,7 +223,7 @@ class OStatus
dba::update('contact', $fields, array('id' => $cid), $old_contact); dba::update('contact', $fields, array('id' => $cid), $old_contact);
// Update the avatar // Update the avatar
update_contact_avatar($author["author-avatar"], 0, $cid); Contact::updateAvatar($author["author-avatar"], 0, $cid);
} }
$contact["generation"] = 2; $contact["generation"] = 2;
@ -1326,7 +1326,7 @@ class OStatus
switch ($siteinfo["type"]) { switch ($siteinfo["type"]) {
case 'photo': case 'photo':
$imgdata = get_photo_info($siteinfo["image"]); $imgdata = Photo::getInfoFromURL($siteinfo["image"]);
$attributes = array("rel" => "enclosure", $attributes = array("rel" => "enclosure",
"href" => $siteinfo["image"], "href" => $siteinfo["image"],
"type" => $imgdata["mime"], "type" => $imgdata["mime"],
@ -1346,7 +1346,7 @@ class OStatus
} }
if (!Config::get('system', 'ostatus_not_attach_preview') && ($siteinfo["type"] != "photo") && isset($siteinfo["image"])) { if (!Config::get('system', 'ostatus_not_attach_preview') && ($siteinfo["type"] != "photo") && isset($siteinfo["image"])) {
$imgdata = get_photo_info($siteinfo["image"]); $imgdata = Photo::getInfoFromURL($siteinfo["image"]);
$attributes = array("rel" => "enclosure", $attributes = array("rel" => "enclosure",
"href" => $siteinfo["image"], "href" => $siteinfo["image"],
"type" => $imgdata["mime"], "type" => $imgdata["mime"],

2
src/Protocol/PortableContact.php
View file

@ -14,6 +14,7 @@ use Friendica\Core\Worker;
use Friendica\Database\DBM; use Friendica\Database\DBM;
use Friendica\Model\GlobalContact; use Friendica\Model\GlobalContact;
use Friendica\Network\Probe; use Friendica\Network\Probe;
use Friendica\Object\Photo;
use Friendica\Object\Profile; use Friendica\Object\Profile;
use dba; use dba;
use DOMDocument; use DOMDocument;
@ -23,7 +24,6 @@ use Exception;
require_once 'include/datetime.php'; require_once 'include/datetime.php';
require_once 'include/network.php'; require_once 'include/network.php';
require_once 'include/html2bbcode.php'; require_once 'include/html2bbcode.php';
require_once 'include/Photo.php';
class PortableContact class PortableContact
{ {

7
update.php
View file

@ -6,6 +6,7 @@ use Friendica\Core\Config;
use Friendica\Core\PConfig; use Friendica\Core\PConfig;
use Friendica\Core\Worker; use Friendica\Core\Worker;
use Friendica\Database\DBM; use Friendica\Database\DBM;
use Friendica\Object\Photo;
/** /**
* *
@ -146,14 +147,14 @@ function update_1013() {
AFTER `object` , ADD `target` TEXT NOT NULL AFTER `target-type`"); AFTER `object` , ADD `target` TEXT NOT NULL AFTER `target-type`");
} }
function update_1014() { function update_1014()
require_once('include/Photo.php'); {
q("ALTER TABLE `contact` ADD `micro` TEXT NOT NULL AFTER `thumb` "); q("ALTER TABLE `contact` ADD `micro` TEXT NOT NULL AFTER `thumb` ");
$r = q("SELECT * FROM `photo` WHERE `scale` = 4"); $r = q("SELECT * FROM `photo` WHERE `scale` = 4");
if (DBM::is_result($r)) { if (DBM::is_result($r)) {
foreach ($r as $rr) { foreach ($r as $rr) {
$ph = new Photo($rr['data']); $ph = new Photo($rr['data']);
if ($ph->is_valid()) { if ($ph->isValid()) {
$ph->scaleImage(48); $ph->scaleImage(48);
$ph->store($rr['uid'],$rr['contact-id'],$rr['resource-id'],$rr['filename'],$rr['album'],6,(($rr['profile']) ? 1 : 0)); $ph->store($rr['uid'],$rr['contact-id'],$rr['resource-id'],$rr['filename'],$rr['album'],6,(($rr['profile']) ? 1 : 0));
} }

6
view/theme/frio/theme.php
View file

@ -12,6 +12,7 @@ use Friendica\Core\Config;
use Friendica\Core\PConfig; use Friendica\Core\PConfig;
use Friendica\Core\System; use Friendica\Core\System;
use Friendica\Database\DBM; use Friendica\Database\DBM;
use Friendica\Object\Photo;
$frio = "view/theme/frio"; $frio = "view/theme/frio";
@ -79,9 +80,8 @@ function frio_uninstall() {
* @param App $a Unused but required by hook definition * @param App $a Unused but required by hook definition
* @param array $body_info The item and its html output * @param array $body_info The item and its html output
*/ */
function frio_item_photo_links(App $a, &$body_info) { function frio_item_photo_links(App $a, &$body_info)
require_once('include/Photo.php'); {
$phototypes = Photo::supportedTypes(); $phototypes = Photo::supportedTypes();
$occurence = 1; $occurence = 1;
$p = bb_find_open_close($body_info['html'], "<a", ">"); $p = bb_find_open_close($body_info['html'], "<a", ">");

5
view/theme/frost/theme.php
View file

@ -11,6 +11,7 @@
use Friendica\App; use Friendica\App;
use Friendica\Core\System; use Friendica\Core\System;
use Friendica\Object\Photo;
function frost_init(App $a) { function frost_init(App $a) {
$a->videowidth = 400; $a->videowidth = 400;
@ -45,8 +46,8 @@ function frost_uninstall() {
logger("uninstalled theme frost"); logger("uninstalled theme frost");
} }
function frost_item_photo_links(App $a, &$body_info) { function frost_item_photo_links(App $a, &$body_info)
require_once('include/Photo.php'); {
$phototypes = Photo::supportedTypes(); $phototypes = Photo::supportedTypes();
$occurence = 1; $occurence = 1;