diff --git a/bin/daemon.php b/bin/daemon.php index bf82912ee..159b20e15 100755 --- a/bin/daemon.php +++ b/bin/daemon.php @@ -13,9 +13,8 @@ use Friendica\Core\Worker; use Friendica\Database\DBA; // Get options -$shortopts = ''; -$shortopts .= 'f'; -$longopts = [ 'foreground' ]; +$shortopts = 'f'; +$longopts = ['foreground']; $options = getopt($shortopts, $longopts); // Ensure that daemon.php is executed from the base path of the installation diff --git a/bin/worker.php b/bin/worker.php index 0f8dd98ad..d821fe626 100755 --- a/bin/worker.php +++ b/bin/worker.php @@ -11,9 +11,8 @@ use Friendica\Core\Config; use Friendica\Core\Worker; // Get options -$shortopts = ''; -$shortopts .= 'sc'; -$longopts = [ 'spawn', 'cron' ]; +$shortopts = 'sc'; +$longopts = ['spawn', 'cron']; $options = getopt($shortopts, $longopts); // Ensure that worker.php is executed from the base path of the installation diff --git a/src/App.php b/src/App.php index c56d9c10e..02215d2e6 100644 --- a/src/App.php +++ b/src/App.php @@ -1127,7 +1127,7 @@ class App return; } - $cmdline = $this->getConfigValue('config', 'php_path', 'php') . ' ' . $command; + $cmdline = $this->getConfigValue('config', 'php_path', 'php') . ' ' . escapeshellarg($command); foreach ($args as $key => $value) { if (!is_null($value) && is_bool($value) && !$value) { @@ -1140,8 +1140,6 @@ class App } } - $cmdline = escapeshellarg($cmdline); - if ($this->min_memory_reached()) { return; }