keith/friendica
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Apply suggestions from code review

Browse source 
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
This commit is contained in:
Philipp 2023-01-17 19:12:33 +01:00 committed by GitHub
parent 293c121c48
commit eed6db2465
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
src/Core/Hooks/Capabilities/ICanManageInstances.php
View file

@ -35,8 +35,8 @@ interface ICanManageInstances
* @see https://refactoring.guru/design-patterns/strategy * @see https://refactoring.guru/design-patterns/strategy
* *
* @param string $interface The interface, which the given class implements * @param string $interface The interface, which the given class implements
* @param string $name The name of the given class, which will be used for factories, dependency injections etc. * @param string $name An arbitrary identifier for the given class, which will be used for factories, dependency injections etc.
* @param string $class The class of the given class * @param string $class The fully-qualified given class name
* @param ?array $arguments Additional arguments, which can be passed to the constructor * @param ?array $arguments Additional arguments, which can be passed to the constructor
* *
* @return $this This interface for chain-calls * @return $this This interface for chain-calls
@ -51,8 +51,8 @@ interface ICanManageInstances
* *
* @note Decorator attach new behaviors to classes without changing them or without letting them know about it. * @note Decorator attach new behaviors to classes without changing them or without letting them know about it.
* *
* @param string $class The class or interface, which gets decorated by a class * @param string $class The fully-qualified class or interface name, which gets decorated by a class
* @param string $decoratorClass The class, which mimics the given class or interface and adds new functionality * @param string $decoratorClass The fully-qualified name of the class which mimics the given class or interface and adds new functionality
* @param array $arguments Additional arguments, which can be passed to the constructor of "decoratorClass" * @param array $arguments Additional arguments, which can be passed to the constructor of "decoratorClass"
* *
* @return $this This interface for chain-calls * @return $this This interface for chain-calls
@ -69,7 +69,7 @@ interface ICanManageInstances
* In case, there are registered decorators for this class as well, all decorators of the list will be wrapped * In case, there are registered decorators for this class as well, all decorators of the list will be wrapped
* around the instance before returning it * around the instance before returning it
* *
* @param string $class A given class or interface, which will get returned * @param string $class The fully-qualified name of the given class or interface which will get returned
* @param string $name The name of the concrete class, wich * @param string $name The name of the concrete class, wich
* @param array $arguments Additional arguments, which can be passed to the constructor of "$class" at runtime * @param array $arguments Additional arguments, which can be passed to the constructor of "$class" at runtime
* *

2
src/Core/Hooks/Model/InstanceManager.php
View file

@ -67,7 +67,7 @@ class InstanceManager implements ICanManageInstances
public function registerDecorator(string $class, string $decoratorClass, array $arguments = []): ICanManageInstances public function registerDecorator(string $class, string $decoratorClass, array $arguments = []): ICanManageInstances
{ {
if (!is_a($decoratorClass, $class, true)) { if (!is_a($decoratorClass, $class, true)) {
throw new HookRegisterArgumentException(sprintf('%s is not a valid subsituation for the given class or interface %s', $decoratorClass, $class)); throw new HookRegisterArgumentException(sprintf('%s is not a valid substitution for the given class or interface %s', $decoratorClass, $class));
} }
$this->decorator[$class][] = [ $this->decorator[$class][] = [