keith/friendica
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Apply suggestions from code review

Browse source 
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
This commit is contained in:
Michael Vogel 2023-01-07 19:54:13 +01:00 committed by GitHub
parent f5fd99f7ea
commit d5bc6d0006
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
mod/item.php
View file

@ -156,7 +156,7 @@ function item_insert(int $uid, array $request, bool $preview, string $return_pat
if (!empty($request['parent'])) { if (!empty($request['parent'])) {
$parent_item = Post::selectFirst(Item::ITEM_FIELDLIST, ['id' => $request['parent']]); $parent_item = Post::selectFirst(Item::ITEM_FIELDLIST, ['id' => $request['parent']]);
if (DBA::isResult($parent_item)) { if ($parent_item) {
// if this isn't the top-level parent of the conversation, find it // if this isn't the top-level parent of the conversation, find it
if ($parent_item['gravity'] != Item::GRAVITY_PARENT) { if ($parent_item['gravity'] != Item::GRAVITY_PARENT) {
$toplevel_item = Post::selectFirst(Item::ITEM_FIELDLIST, ['id' => $parent_item['parent']]); $toplevel_item = Post::selectFirst(Item::ITEM_FIELDLIST, ['id' => $parent_item['parent']]);
@ -206,7 +206,7 @@ function item_insert(int $uid, array $request, bool $preview, string $return_pat
} }
$post = Post::selectFirst(Item::ITEM_FIELDLIST, ['id' => $post_id]); $post = Post::selectFirst(Item::ITEM_FIELDLIST, ['id' => $post_id]);
if (!DBA::isResult($post)) { if (!$post) {
Logger::error('Item couldn\'t be fetched.', ['post_id' => $post_id]); Logger::error('Item couldn\'t be fetched.', ['post_id' => $post_id]);
if ($return_path) { if ($return_path) {
DI::baseUrl()->redirect($return_path); DI::baseUrl()->redirect($return_path);

2
src/Content/Item.php
View file

@ -856,7 +856,7 @@ class Item
} }
$user = User::getById($post['uid'], ['allow_cid', 'allow_gid', 'deny_cid', 'deny_gid']); $user = User::getById($post['uid'], ['allow_cid', 'allow_gid', 'deny_cid', 'deny_gid']);
if (!DBA::isResult($user)) { if (!$user) {
throw new HTTPException\NotFoundException($this->l10n->t('Unable to locate original post.')); throw new HTTPException\NotFoundException($this->l10n->t('Unable to locate original post.'));
} }