From c217e9da345d6c6c0d42da3a0de39294a4454f6f Mon Sep 17 00:00:00 2001 From: Friendika Date: Fri, 24 Dec 2010 15:59:12 -0800 Subject: [PATCH 1/7] add authentication plugin hooks --- include/auth.php | 43 +++++++++++++++++++++++++++++++++---------- 1 file changed, 33 insertions(+), 10 deletions(-) diff --git a/include/auth.php b/include/auth.php index fe09ef160..bc77e5dbc 100644 --- a/include/auth.php +++ b/include/auth.php @@ -132,17 +132,38 @@ else { } if((x($_POST,'auth-params')) && $_POST['auth-params'] === 'login') { - // process login request - $r = q("SELECT * FROM `user` - WHERE ( `email` = '%s' OR `nickname` = '%s' ) AND `password` = '%s' AND `blocked` = 0 AND `verified` = 1 LIMIT 1", - dbesc(trim($_POST['openid_url'])), - dbesc(trim($_POST['openid_url'])), - dbesc($encrypted)); - if(($r === false) || (! count($r))) { - notice( t('Login failed.') . EOL ); - goaway($a->get_baseurl()); - } + $addon_auth = array( + 'name' => trim($_POST['openid_url']), + 'password' => trim($_POST['password']), + 'authenticated' => 0 + ); + + /** + * + * A plugin indicates successful login by setting 'authenticated' to non-zero value + * Plugins should never set 'authenticated' except to indicate success - as hooks may be chained + * and later plugins should not interfere with an earlier one that succeeded. + * + */ + + call_hooks('authenticate', $addon_auth); + + if(! $addon_auth['authenticated']) { + // process login request + + $r = q("SELECT * FROM `user` WHERE ( `email` = '%s' OR `nickname` = '%s' ) + AND `password` = '%s' AND `blocked` = 0 AND `verified` = 1 LIMIT 1", + dbesc(trim($_POST['openid_url'])), + dbesc(trim($_POST['openid_url'])), + dbesc($encrypted) + ); + if(($r === false) || (! count($r))) { + notice( t('Login failed.') . EOL ); + goaway($a->get_baseurl()); + } + } + $_SESSION['uid'] = $r[0]['uid']; $_SESSION['theme'] = $r[0]['theme']; $_SESSION['authenticated'] = 1; @@ -167,6 +188,8 @@ else { intval($_SESSION['uid']) ); + call_hooks('logged_in', $a->user); + header('X-Account-Management-Status: active; name="' . $a->user['username'] . '"; id="' . $a->user['nickname'] .'"'); if(($a->module !== 'home') && isset($_SESSION['return_url'])) goaway($a->get_baseurl() . '/' . $_SESSION['return_url']); From 10731ea361005bc6a56516ad03984b6c366b3a27 Mon Sep 17 00:00:00 2001 From: Friendika Date: Fri, 24 Dec 2010 18:32:23 -0800 Subject: [PATCH 2/7] more plugin hooks --- include/items.php | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/include/items.php b/include/items.php index 75445ee49..a606749ce 100644 --- a/include/items.php +++ b/include/items.php @@ -158,7 +158,12 @@ function get_feed_for(&$a, $dfrn_id, $owner_id, $last_update, $direction = 0) { )); + call_hooks('atom_feed', $atom); + if(! count($items)) { + + call_hooks('atom_feed_end', $atom); + $atom .= '' . "\r\n"; return $atom; } @@ -177,6 +182,8 @@ function get_feed_for(&$a, $dfrn_id, $owner_id, $last_update, $direction = 0) { $atom .= atom_entry($item,$type,null,$owner,true); } + call_hooks('atom_feed_end', $atom); + $atom .= '' . "\r\n"; return $atom; } @@ -491,6 +498,8 @@ function get_atom_elements($feed,$item) { $res['target'] .= '' . "\n"; } + call_hooks('parse_atom', array('feed' => $feed, 'item' => $item, 'result' => $res)); + return $res; } @@ -1231,6 +1240,9 @@ function atom_author($tag,$name,$uri,$h,$w,$photo) { $o .= "$uri\r\n"; $o .= '' . "\r\n"; $o .= '' . "\r\n"; + + call_hooks('atom_author', $o); + $o .= "\r\n"; return $o; } @@ -1287,6 +1299,8 @@ function atom_entry($item,$type,$author,$owner,$comment = false) { if($mentioned) $o .= $mentioned; + call_hooks('atom_entry', $o); + $o .= '' . "\r\n"; return $o; From 3ba322889fdfecc07099377cf6e28c4b2fb30e59 Mon Sep 17 00:00:00 2001 From: Friendika Date: Fri, 24 Dec 2010 19:04:40 -0800 Subject: [PATCH 3/7] undo one of the hooks from last checkin - passing objects led to error --- include/items.php | 3 ++- mod/dfrn_poll.php | 3 +++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/include/items.php b/include/items.php index a606749ce..c00ec93ae 100644 --- a/include/items.php +++ b/include/items.php @@ -185,6 +185,7 @@ function get_feed_for(&$a, $dfrn_id, $owner_id, $last_update, $direction = 0) { call_hooks('atom_feed_end', $atom); $atom .= '' . "\r\n"; + return $atom; } @@ -498,7 +499,7 @@ function get_atom_elements($feed,$item) { $res['target'] .= '' . "\n"; } - call_hooks('parse_atom', array('feed' => $feed, 'item' => $item, 'result' => $res)); +// call_hooks('parse_atom', array('feed' => $feed, 'item' => $item, 'result' => $res)); return $res; } diff --git a/mod/dfrn_poll.php b/mod/dfrn_poll.php index a8c27efc1..22d2ee40f 100644 --- a/mod/dfrn_poll.php +++ b/mod/dfrn_poll.php @@ -1,11 +1,14 @@ Date: Fri, 24 Dec 2010 20:23:49 -0800 Subject: [PATCH 4/7] show creative commons coverage on registration page --- mod/register.php | 4 ++++ util/strings.php | 13 +++++++++---- view/it/strings.php | 7 ++++--- view/register.tpl | 3 +++ view/theme/default/style.css | 7 ++++++- 5 files changed, 26 insertions(+), 8 deletions(-) diff --git a/mod/register.php b/mod/register.php index d9dae49a2..bd169fbbb 100644 --- a/mod/register.php +++ b/mod/register.php @@ -357,6 +357,9 @@ function register_content(&$a) { $oidlabel = t("Your OpenID \x28optional\x29: "); } + $license = t('Shared content is covered by the Creative Commons Attribution 3.0 license.'); + + $o = load_view_file("view/register.tpl"); $o = replace_macros($o, array( '$oidhtml' => $oidhtml, @@ -377,6 +380,7 @@ function register_content(&$a) { '$username' => $username, '$email' => $email, '$nickname' => $nickname, + '$license' => $license, '$sitename' => $a->get_hostname() )); return $o; diff --git a/util/strings.php b/util/strings.php index 6e6c4b27c..e776d052f 100644 --- a/util/strings.php +++ b/util/strings.php @@ -4,7 +4,6 @@ $a->strings['Page not found.' ] = 'Page not found.' ; $a->strings['Permission denied'] = 'Permission denied'; $a->strings['Permission denied.'] = 'Permission denied.'; $a->strings['Nickname or Email address: '] = 'Nickname or Email address: '; -$a->strings['Welcome to '] = 'Welcome to '; $a->strings['Password: '] = 'Password: '; $a->strings['Login'] = 'Login'; $a->strings['Nickname/Email/OpenID: '] = 'Nickname/Email/OpenID: '; @@ -84,6 +83,7 @@ $a->strings['Remote site reported: '] = 'Remote site reported: '; $a->strings["Temporary failure. Please wait and try again."] = "Temporary failure. Please wait and try again."; $a->strings["Introduction failed or was revoked."] = "Introduction failed or was revoked."; $a->strings['Unable to set contact photo.'] = 'Unable to set contact photo.'; +$a->strings['is now friends with'] = 'is now friends with'; $a->strings['No user record found for '] = 'No user record found for '; $a->strings['Our site encryption key is apparently messed up.'] = 'Our site encryption key is apparently messed up.'; $a->strings['Empty site URL was provided or URL could not be decrypted by us.'] = 'Empty site URL was provided or URL could not be decrypted by us.'; @@ -108,6 +108,9 @@ $a->strings["not found at the given location."] = "not found at the given locati $a->strings["Introduction complete."] = "Introduction complete."; $a->strings['Unrecoverable protocol error.'] = 'Unrecoverable protocol error.'; $a->strings['Profile unavailable.'] = 'Profile unavailable.'; +$a->strings[' has received too many connection requests today.'] = ' has received too many connection requests today.'; +$a->strings['Spam protection measures have been invoked.'] = 'Spam protection measures have been invoked.'; +$a->strings['Friends are advised to please try again in 24 hours.'] = 'Friends are advised to please try again in 24 hours.'; $a->strings["Invalid locator"] = "Invalid locator"; $a->strings["Unable to resolve your name at the provided location."] = "Unable to resolve your name at the provided location."; $a->strings['You have already introduced yourself here.'] = 'You have already introduced yourself here.'; @@ -149,11 +152,12 @@ $a->strings['Membership list updated.'] = 'Membership list updated.'; $a->strings['Group removed.'] = 'Group removed.'; $a->strings['Unable to remove group.'] = 'Unable to remove group.'; $a->strings['Delete'] = 'Delete'; +$a->strings["Welcome to "] = "Welcome to "; $a->strings['Could not create/connect to database.'] = 'Could not create/connect to database.'; $a->strings['Connected to database.'] = 'Connected to database.'; $a->strings['Database import succeeded.'] = 'Database import succeeded.'; $a->strings['IMPORTANT: You will need to [manually] setup a scheduled task for the poller.'] = 'IMPORTANT: You will need to [manually] setup a scheduled task for the poller.'; -$a->strings['Please see the file INSTALL.'] = 'Please see the file INSTALL.'; +$a->strings['Please see the file "INSTALL.txt".'] = 'Please see the file "INSTALL.txt".'; $a->strings['Database import failed.'] = 'Database import failed.'; $a->strings['You may need to import the file "database.sql" manually using phpmyadmin or mysql.'] = 'You may need to import the file "database.sql" manually using phpmyadmin or mysql.'; $a->strings['Welcome to Friendika.'] = 'Welcome to Friendika.'; @@ -163,16 +167,16 @@ $a->strings['This is required. Please adjust the configuration file .htconfig.ph $a->strings['The command line version of PHP on your system does not have "register_argc_argv" enabled.'] = 'The command line version of PHP on your system does not have "register_argc_argv" enabled.'; $a->strings['This is required for message delivery to work.'] = 'This is required for message delivery to work.'; $a->strings['Error: the "openssl_pkey_new" function on this system is not able to generate encryption keys'] = 'Error: the "openssl_pkey_new" function on this system is not able to generate encryption keys'; +$a->strings['If running under Windows, please see "http://www.php.net/manual/en/openssl.installation.php".'] = 'If running under Windows, please see "http://www.php.net/manual/en/openssl.installation.php".'; $a->strings['Error: Apache webserver mod-rewrite module is required but not installed.'] = 'Error: Apache webserver mod-rewrite module is required but not installed.'; $a->strings['Error: libCURL PHP module required but not installed.'] = 'Error: libCURL PHP module required but not installed.'; $a->strings['Error: GD graphics PHP module with JPEG support required but not installed.'] = 'Error: GD graphics PHP module with JPEG support required but not installed.'; $a->strings['Error: openssl PHP module required but not installed.'] = 'Error: openssl PHP module required but not installed.'; $a->strings['Error: mysqli PHP module required but not installed.'] = 'Error: mysqli PHP module required but not installed.'; -$a->strings['Please see the file "INSTALL".'] = 'Please see the file "INSTALL".'; $a->strings['The web installer needs to be able to create a file called ".htconfig.php" in the top folder of your web server and it is unable to do so.'] = 'The web installer needs to be able to create a file called ".htconfig.php" in the top folder of your web server and it is unable to do so.'; $a->strings['This is most often a permission setting, as the web server may not be able to write files in your folder - even if you can.'] = 'This is most often a permission setting, as the web server may not be able to write files in your folder - even if you can.'; $a->strings['Please check with your site documentation or support people to see if this situation can be corrected.'] = 'Please check with your site documentation or support people to see if this situation can be corrected.'; -$a->strings['If not, you may be required to perform a manual installation. Please see the file "INSTALL" for instructions.'] = 'If not, you may be required to perform a manual installation. Please see the file "INSTALL" for instructions.'; +$a->strings['If not, you may be required to perform a manual installation. Please see the file "INSTALL.txt" for instructions.'] = 'If not, you may be required to perform a manual installation. Please see the file "INSTALL.txt" for instructions.'; $a->strings['The database configuration file ".htconfig.php" could not be written. Please use the enclosed text to create a configuration file in your web server root.'] = 'The database configuration file ".htconfig.php" could not be written. Please use the enclosed text to create a configuration file in your web server root.'; $a->strings['Errors encountered creating database tables.'] = 'Errors encountered creating database tables.'; $a->strings[' : '] = ' : '; @@ -305,6 +309,7 @@ $a->strings['Your registration is pending approval by the site owner.'] = 'Your $a->strings["You may \x28optionally\x29 fill in this form via OpenID by supplying your OpenID and clicking 'Register'."] = "You may \x28optionally\x29 fill in this form via OpenID by supplying your OpenID and clicking 'Register'."; $a->strings['If you are not familiar with OpenID, please leave that field blank and fill in the rest of the items.'] = 'If you are not familiar with OpenID, please leave that field blank and fill in the rest of the items.'; $a->strings["Your OpenID \x28optional\x29: "] = "Your OpenID \x28optional\x29: "; +$a->strings['Shared content is covered by the Creative Commons Attribution 3.0 license.'] = 'Shared content is covered by the Creative Commons Attribution 3.0 license.'; $a->strings['Registration'] = 'Registration'; $a->strings['Your Full Name ' . "\x28" . 'e.g. Joe Smith' . "\x29" . ': '] = 'Your Full Name ' . "\x28" . 'e.g. Joe Smith' . "\x29" . ': '; $a->strings['Your Email Address: '] = 'Your Email Address: '; diff --git a/view/it/strings.php b/view/it/strings.php index 08eb5063c..7cb95cd3d 100644 --- a/view/it/strings.php +++ b/view/it/strings.php @@ -153,7 +153,7 @@ $a->strings['Could not create/connect to database.'] = 'Impossibile creare/colle $a->strings['Connected to database.'] = 'Collegato al database.'; $a->strings['Database import succeeded.'] = 'Importazione database completata.'; $a->strings['IMPORTANT: You will need to [manually] setup a scheduled task for the poller.'] = 'IMPORTANTE: Devi impostare manualmente un operazione pianificata per il poller'; -$a->strings['Please see the file INSTALL.'] = 'Guarda il file INSTALL.'; +$a->strings['Please see the file "INSTALL.txt".'] = 'Guarda il file "INSTALL.txt".'; $a->strings['Database import failed.'] = 'Importazione database fallita.'; $a->strings['You may need to import the file "database.sql" manually using phpmyadmin or mysql.'] = 'Potresti dover importare il file "database.sql" manualmente con phpmyadmin o mysql'; $a->strings['Welcome to Friendika.'] = 'Benvenuto su Friendika.'; @@ -168,11 +168,11 @@ $a->strings['Error: libCURL PHP module required but not installed.'] = 'Errore: $a->strings['Error: GD graphics PHP module with JPEG support required but not installed.'] = 'Errore: Il modulo GD graphics di PHP con supporto a JPEG è richiesto ma non installato.'; $a->strings['Error: openssl PHP module required but not installed.'] = 'Errore: il modulo openssl di PHP è richiesto ma non installato.'; $a->strings['Error: mysqli PHP module required but not installed.'] = 'Errore: il modulo mysqli di PHP è richiesto ma non installato'; -$a->strings['Please see the file "INSTALL".'] = 'Guarda il file "INSTALL".'; +$a->strings['Please see the file "INSTALL.txt".'] = 'Guarda il file "INSTALL.txt".'; $a->strings['The web installer needs to be able to create a file called ".htconfig.php" in the top folder of your web server and it is unable to do so.'] = 'L\'installazione web deve poter creare un file chiamato ".htconfig.php" nella cartella principale del tuo web server ma non è in grado di farlo.'; $a->strings['This is most often a permission setting, as the web server may not be able to write files in your folder - even if you can.'] = 'Ció è dovuto spesso a impostazioni di permessi, dato che il web server puo\' scrivere il file nella tua cartella, anche se tu puoi.'; $a->strings['Please check with your site documentation or support people to see if this situation can be corrected.'] = 'Controlla la documentazione del tuo sito o con il personale di suporto se la situazione puo\' essere corretta.'; -$a->strings['If not, you may be required to perform a manual installation. Please see the file "INSTALL" for instructions.'] = 'Altrimenti dovrai procedere con l\'installazione manuale. Guarda il file "INSTALL" per istuzioni'; +$a->strings['If not, you may be required to perform a manual installation. Please see the file "INSTALL.txt" for instructions.'] = 'Altrimenti dovrai procedere con l\'installazione manuale. Guarda il file "INSTALL.txt" per istuzioni'; $a->strings['The database configuration file ".htconfig.php" could not be written. Please use the enclosed text to create a configuration file in your web server root.'] = 'Il file di configurazione del database ".htconfig.php" non puo\' essere scritto. Usa il testo qui di seguito per creare un file di configurazione nella cartella principale del tuo sito.'; $a->strings['Errors encountered creating database tables.'] = 'Errori creando le tabelle nel database.'; $a->strings[' : '] = ' : '; @@ -305,6 +305,7 @@ $a->strings['Your registration is pending approval by the site owner.'] = 'La tu $a->strings["You may \x28optionally\x29 fill in this form via OpenID by supplying your OpenID and clicking 'Register'."] = "Puoi \x28opzionalmento\x29 riempire questa maschera via OpenID inserendo il tuo OpenID e cliccando 'Registra'."; $a->strings['If you are not familiar with OpenID, please leave that field blank and fill in the rest of the items.'] = 'Se non hai famigliarità con OpenID, lascia quel campo in bianco e riempi il resto della maschera.'; $a->strings["Your OpenID \x28optional\x29: "] = "Il tuo OpenID \x28opzionale\x29: "; +$a->strings['Shared content is covered by the Creative Commons Attribution 3.0 license.'] = 'Contenuto in comune h coperto da licenza Creative Commons Attribution 3.0.'; $a->strings['Registration'] = 'Registrazione'; $a->strings['Your Full Name ' . "\x28" . 'e.g. Joe Smith' . "\x29" . ': '] = 'Il tuo Nome Completo ' . "\x28" . 'p.e. Mario Rossi' . "\x29" . ': '; $a->strings['Your Email Address: '] = 'Il tuo Indirizzo Email: '; diff --git a/view/register.tpl b/view/register.tpl index 08da5112d..ed528bb33 100644 --- a/view/register.tpl +++ b/view/register.tpl @@ -44,3 +44,6 @@
+ +
$license
+ diff --git a/view/theme/default/style.css b/view/theme/default/style.css index e3cddc355..086f59c30 100644 --- a/view/theme/default/style.css +++ b/view/theme/default/style.css @@ -1946,4 +1946,9 @@ a.mail-list-link { .clear { clear: both; -} \ No newline at end of file +} + +.cc-license { + margin-top: 50px; + font-size: 70%; +} From 6891d44e0b765d230bd3b483c5e283647947c4cb Mon Sep 17 00:00:00 2001 From: Friendika Date: Fri, 24 Dec 2010 20:28:34 -0800 Subject: [PATCH 5/7] link italian creative commons license to italian cc page --- view/it/strings.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/view/it/strings.php b/view/it/strings.php index 7cb95cd3d..2b1a3c830 100644 --- a/view/it/strings.php +++ b/view/it/strings.php @@ -305,7 +305,7 @@ $a->strings['Your registration is pending approval by the site owner.'] = 'La tu $a->strings["You may \x28optionally\x29 fill in this form via OpenID by supplying your OpenID and clicking 'Register'."] = "Puoi \x28opzionalmento\x29 riempire questa maschera via OpenID inserendo il tuo OpenID e cliccando 'Registra'."; $a->strings['If you are not familiar with OpenID, please leave that field blank and fill in the rest of the items.'] = 'Se non hai famigliarità con OpenID, lascia quel campo in bianco e riempi il resto della maschera.'; $a->strings["Your OpenID \x28optional\x29: "] = "Il tuo OpenID \x28opzionale\x29: "; -$a->strings['Shared content is covered by the Creative Commons Attribution 3.0 license.'] = 'Contenuto in comune h coperto da licenza Creative Commons Attribution 3.0.'; +$a->strings['Shared content is covered by the Creative Commons Attribution 3.0 license.'] = 'Contenuto in comune h coperto da licenza Creative Commons Attribution 3.0.'; $a->strings['Registration'] = 'Registrazione'; $a->strings['Your Full Name ' . "\x28" . 'e.g. Joe Smith' . "\x29" . ': '] = 'Il tuo Nome Completo ' . "\x28" . 'p.e. Mario Rossi' . "\x29" . ': '; $a->strings['Your Email Address: '] = 'Il tuo Indirizzo Email: '; From d045fd04d4b42a749a113dd27f439f9766800975 Mon Sep 17 00:00:00 2001 From: Friendika Date: Fri, 24 Dec 2010 23:44:17 -0800 Subject: [PATCH 6/7] provide separate plugin settings page, update demo plugin, fix hook_register --- addon/randplace/randplace.php | 14 +++++++------- boot.php | 2 +- mod/settings.php | 18 ++++++++++++++++++ util/strings.php | 2 ++ view/en/settings.tpl | 2 ++ view/it/settings.tpl | 3 +++ view/it/strings.php | 2 ++ view/theme/default/style.css | 5 +++++ 8 files changed, 40 insertions(+), 8 deletions(-) diff --git a/addon/randplace/randplace.php b/addon/randplace/randplace.php index e14ae74c7..6203dab8f 100644 --- a/addon/randplace/randplace.php +++ b/addon/randplace/randplace.php @@ -36,13 +36,13 @@ function randplace_install() { /** * - * Then we'll attach into the settings page, on both the - * form and post hooks so that we can create and update + * Then we'll attach into the plugin settings page, and also the + * settings post hooks so that we can create and update * user preferences. * */ - register_hook('settings_form', 'addon/randplace/randplace.php', 'randplace_settings'); + register_hook('plugin_settings', 'addon/randplace/randplace.php', 'randplace_settings'); register_hook('settings_post', 'addon/randplace/randplace.php', 'randplace_settings_post'); logger("installed randplace"); @@ -60,7 +60,7 @@ function randplace_uninstall() { */ unregister_hook('post_local', 'addon/randplace/randplace.php', 'randplace_post_hook'); - unregister_hook('settings_form', 'addon/randplace/randplace.php', 'randplace_settings'); + unregister_hook('plugin_settings', 'addon/randplace/randplace.php', 'randplace_settings'); unregister_hook('settings_post', 'addon/randplace/randplace.php', 'randplace_settings_post'); @@ -154,7 +154,7 @@ function randplace_settings(&$a,&$s) { if(! local_user()) return; - /* Add our stylesheet so we can match the page layout */ + /* Add our stylesheet so we can make our settings look nice */ $a->page['htmlhead'] .= '' . "\r\n"; @@ -164,7 +164,7 @@ function randplace_settings(&$a,&$s) { $checked = (($enabled) ? ' checked="checked" ' : ''); - /* Add some HTML to the form */ + /* Add some HTML to the existing form */ $s .= '

' . t('Randplace Settings') . '

'; $s .= '
'; @@ -172,7 +172,7 @@ function randplace_settings(&$a,&$s) { $s .= ''; $s .= '
'; - /* provide another submit button */ + /* provide a submit button */ $s .= '
'; diff --git a/boot.php b/boot.php index c34002809..7b7adba82 100644 --- a/boot.php +++ b/boot.php @@ -2047,7 +2047,7 @@ function profile_sidebar($profile) { if(! function_exists('register_hook')) { function register_hook($hook,$file,$function) { - $r = q("SELECT FROM `hook` WHERE `hook` = '%s' AND `file` = '%s' AND `function` = '%s' LIMIT 1", + $r = q("SELECT * FROM `hook` WHERE `hook` = '%s' AND `file` = '%s' AND `function` = '%s' LIMIT 1", dbesc($hook), dbesc($file), dbesc($function) diff --git a/mod/settings.php b/mod/settings.php index b10f9e3fc..000258db9 100644 --- a/mod/settings.php +++ b/mod/settings.php @@ -17,6 +17,9 @@ function settings_post(&$a) { call_hooks('settings_post', $_POST); + if(($a->argc > 1) && ($a->argv[1] == 'addon')) + return; + if(count($a->user) && x($a->user,'uid') && $a->user['uid'] != local_user()) { notice( t('Permission denied.') . EOL); return; @@ -182,6 +185,21 @@ function settings_content(&$a) { return; } + if(($a->argc > 1) && ($a->argv[1] === 'addon')) { + $o .= '

' . t('Plugin Settings') . '

'; + $o .= ''; + + $o .= '
'; + + $r = q("SELECT * FROM `hook` WHERE `hook` = 'plugin_settings' "); + if(! count($r)) + notice('No Plugin settings configured'); + + call_hooks('plugin_settings', $o); + $o .= '
'; + return $o; + } + require_once('include/acl_selectors.php'); $p = q("SELECT * FROM `profile` WHERE `is-default` = 1 AND `uid` = %d LIMIT 1", diff --git a/util/strings.php b/util/strings.php index e776d052f..f42449690 100644 --- a/util/strings.php +++ b/util/strings.php @@ -328,6 +328,8 @@ $a->strings[' Please use a shorter name.'] = ' Please use a shorter name.'; $a->strings[' Name too short.'] = ' Name too short.'; $a->strings[' Not valid email.'] = ' Not valid email.'; $a->strings['Settings updated.'] = 'Settings updated.'; +$a->strings['Plugin Settings'] = 'Plugin Settings'; +$a->strings['Account Settings'] = 'Account Settings'; $a->strings['OpenID: '] = 'OpenID: '; $a->strings[" \x28Optional\x29 Allow this OpenID to login to this account."] = " \x28Optional\x29 Allow this OpenID to login to this account."; $a->strings['Profile is not published.'] = 'Profile is not published.'; diff --git a/view/en/settings.tpl b/view/en/settings.tpl index 594ce73fc..5e1bfabf4 100644 --- a/view/en/settings.tpl +++ b/view/en/settings.tpl @@ -1,5 +1,7 @@

Account Settings

+ + $nickname_block diff --git a/view/it/settings.tpl b/view/it/settings.tpl index 364fd6ba2..365e5cb70 100644 --- a/view/it/settings.tpl +++ b/view/it/settings.tpl @@ -1,5 +1,8 @@

Impostazioni account

+ + + $nickname_block diff --git a/view/it/strings.php b/view/it/strings.php index 2b1a3c830..3640997d9 100644 --- a/view/it/strings.php +++ b/view/it/strings.php @@ -324,6 +324,8 @@ $a->strings[' Please use a shorter name.'] = ' Usa un nome più corto.'; $a->strings[' Name too short.'] = ' Nome troppo corto.'; $a->strings[' Not valid email.'] = ' Email non valida.'; $a->strings['Settings updated.'] = 'Impostazioni aggiornate.'; +$a->strings['Plugin Settings'] = 'Impostazioni Plugin'; +$a->strings['Account Settings'= = 'Impostazioni Account'; $a->strings['OpenID: '] = 'OpenID: '; $a->strings[" \x28Optional\x29 Allow this OpenID to login to this account."] = " \x28Opzionale\x29 Permetti a questo OpenID di accedere a questo account."; $a->strings['Profile is not published.'] = 'Il profilo non è pubblicato.'; diff --git a/view/theme/default/style.css b/view/theme/default/style.css index 086f59c30..240ace896 100644 --- a/view/theme/default/style.css +++ b/view/theme/default/style.css @@ -1952,3 +1952,8 @@ a.mail-list-link { margin-top: 50px; font-size: 70%; } + + +#plugin-settings-link, #account-settings-link { + margin-bottom: 25px; +} From 7382c353e521f36db2d40ac9aa2b3ca14cc64369 Mon Sep 17 00:00:00 2001 From: Friendika Date: Fri, 24 Dec 2010 23:50:06 -0800 Subject: [PATCH 7/7] minor nits after proof-reading --- addon/randplace/randplace.php | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/addon/randplace/randplace.php b/addon/randplace/randplace.php index 6203dab8f..2e1bd33ac 100644 --- a/addon/randplace/randplace.php +++ b/addon/randplace/randplace.php @@ -37,7 +37,7 @@ function randplace_install() { /** * * Then we'll attach into the plugin settings page, and also the - * settings post hooks so that we can create and update + * settings post hook so that we can create and update * user preferences. * */ @@ -142,7 +142,8 @@ function randplace_settings_post($a,$post) { /** - * Called from the end of the settings form. + * + * Called from the Plugin Setting form. * Add our own settings info to the page. * */ @@ -154,7 +155,7 @@ function randplace_settings(&$a,&$s) { if(! local_user()) return; - /* Add our stylesheet so we can make our settings look nice */ + /* Add our stylesheet to the page so we can make our settings look nice */ $a->page['htmlhead'] .= '' . "\r\n";