keith/friendica
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Merge pull request #12177 from MrPetovan/bug/warnings

Browse source 
Ensure Post::toArray returns an array
This commit is contained in:
Philipp 2022-11-14 20:58:42 +01:00 committed by GitHub
commit c3cae0ae96
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
src/Model/Post.php
View file

@ -102,26 +102,25 @@ class Post
} }
/** /**
* Fills an array with data from an post query * Fills an array with data from a post query
* *
* @param object $stmt statement object * @param object|bool $stmt Return value from Database->select
* @param bool $do_close
* @return array Data array * @return array Data array
* @todo Find proper type-hint for $stmt and maybe avoid boolean * @throws \Exception
*/ */
public static function toArray($stmt, bool $do_close = true) public static function toArray($stmt): array
{ {
if (is_bool($stmt)) { if (is_bool($stmt)) {
return $stmt; return [];
} }
$data = []; $data = [];
while ($row = self::fetch($stmt)) { while ($row = self::fetch($stmt)) {
$data[] = $row; $data[] = $row;
} }
if ($do_close) {
DBA::close($stmt); DBA::close($stmt);
}
return $data; return $data;
} }