diff --git a/include/enotify.php b/include/enotify.php index 7567613b4..e21adc91a 100644 --- a/include/enotify.php +++ b/include/enotify.php @@ -500,7 +500,7 @@ function notification($params) DI::notify()->update($notification); - $itemlink = DI::baseUrl() . '/notification/view/' . $notification->id; + $itemlink = DI::baseUrl() . '/notification/' . $notification->id; $notify_id = $notification->id; } diff --git a/mod/ping.php b/mod/ping.php index dd57ba34d..70c580d3d 100644 --- a/mod/ping.php +++ b/mod/ping.php @@ -443,7 +443,7 @@ function ping_get_notifications($uid) ); } - $notification["href"] = DI::baseUrl() . "/notification/view/" . $notification["id"]; + $notification["href"] = DI::baseUrl() . "/notification/" . $notification["id"]; if ($notification["visible"] && !$notification["deleted"] diff --git a/src/Factory/Notification/Notification.php b/src/Factory/Notification/Notification.php index 2b179cca5..399e6b0e7 100644 --- a/src/Factory/Notification/Notification.php +++ b/src/Factory/Notification/Notification.php @@ -219,7 +219,7 @@ class Notification extends BaseFactory foreach ($notifications as $notification) { $formattedNotifications[] = new \Friendica\Object\Notification\Notification([ 'label' => 'notification', - 'link' => $this->baseUrl->get(true) . '/notification/view/' . $notification->id, + 'link' => $this->baseUrl->get(true) . '/notification/' . $notification->id, 'image' => Proxy::proxifyUrl($notification->photo, false, Proxy::SIZE_MICRO), 'url' => $notification->url, 'text' => strip_tags(BBCode::convert($notification->msg)), diff --git a/src/Module/Notifications/Notification.php b/src/Module/Notifications/Notification.php index 20530e81a..b8d0e47f0 100644 --- a/src/Module/Notifications/Notification.php +++ b/src/Module/Notifications/Notification.php @@ -23,7 +23,7 @@ class Notification extends BaseModule { $request_id = $parameters['id'] ?? false; - if (DI::args()->get(1) == 'action' && $request_id) { + if ($request_id) { $intro = DI::intro()->selectFirst(['id' => $request_id, 'uid' => local_user()]); switch ($_POST['submit']) { @@ -65,10 +65,11 @@ class Notification extends BaseModule */ public static function content(array $parameters = []) { - // @TODO: Replace with parameter from router - if (DI::args()->getArgc() > 2 && DI::args()->get(1) === 'view' && intval(DI::args()->get(2))) { + $request_id = $parameters['id'] ?? false; + + if ($request_id) { try { - $notification = DI::notify()->getByID(DI::args()->get(2)); + $notification = DI::notify()->getByID($request_id); $notification->setSeen(); if (!empty($notification->link)) { @@ -86,3 +87,4 @@ class Notification extends BaseModule DI::baseUrl()->redirect('notifications/system'); } } + diff --git a/static/routes.config.php b/static/routes.config.php index 2dd6da1bf..4aad69d8c 100644 --- a/static/routes.config.php +++ b/static/routes.config.php @@ -184,10 +184,9 @@ return [ ], '/notification' => [ - '[/]' => [Module\Notifications\Notification::class, [R::GET]], - '/view/{id:\d+}' => [Module\Notifications\Notification::class, [R::GET]], - '/mark/all' => [Module\Notifications\Notification::class, [R::GET]], - '/action/{id:\d+}' => [Module\Notifications\Notification::class, [ R::POST]], + '[/]' => [Module\Notifications\Notification::class, [R::GET]], + '/mark/all' => [Module\Notifications\Notification::class, [R::GET]], + '/{id:\d+}' => [Module\Notifications\Notification::class, [R::GET, R::POST]], ], '/objects/{guid}' => [Module\Objects::class, [R::GET]], diff --git a/view/templates/notifications/intros.tpl b/view/templates/notifications/intros.tpl index 4ad96c727..b04c19c18 100644 --- a/view/templates/notifications/intros.tpl +++ b/view/templates/notifications/intros.tpl @@ -12,7 +12,7 @@
{{$lbl_knowyou}} {{$knowyou}}
{{$note}}
-
+ {{if $discard}}{{/if}}
diff --git a/view/templates/notifications/suggestions.tpl b/view/templates/notifications/suggestions.tpl index ac5c2e9c2..d0c013ac5 100644 --- a/view/templates/notifications/suggestions.tpl +++ b/view/templates/notifications/suggestions.tpl @@ -8,7 +8,7 @@ {{$fullname}}
{{$note}}
-
+
diff --git a/view/theme/frio/templates/notifications/intros.tpl b/view/theme/frio/templates/notifications/intros.tpl index 879920af3..8f4fa6218 100644 --- a/view/theme/frio/templates/notifications/intros.tpl +++ b/view/theme/frio/templates/notifications/intros.tpl @@ -13,7 +13,7 @@