keith/friendica
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Apply suggestions from code review

Browse source 
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
This commit is contained in:
Michael Vogel 2021-10-25 21:27:21 +02:00 committed by GitHub
parent 87673fd0c5
commit 81c9d8d479
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
6 changed files with 11 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
mod/pubsub.php
View file

@ -107,7 +107,7 @@ function pubsub_post(App $a)
{ {
$xml = Network::postdata(); $xml = Network::postdata();
Logger::notice('Feed arrived from ' . $_SERVER['REMOTE_ADDR'] . ' for ' . DI::args()->getCommand() . ' with user-agent: ' . $_SERVER['HTTP_USER_AGENT']); Logger::info('Feed arrived from ' . $_SERVER['REMOTE_ADDR'] . ' for ' . DI::args()->getCommand() . ' with user-agent: ' . $_SERVER['HTTP_USER_AGENT']);
Logger::debug('Data: ' . $xml); Logger::debug('Data: ' . $xml);
$nick = ((DI::args()->getArgc() > 1) ? Strings::escapeTags(trim(DI::args()->getArgv()[1])) : ''); $nick = ((DI::args()->getArgc() > 1) ? Strings::escapeTags(trim(DI::args()->getArgv()[1])) : '');
@ -149,7 +149,7 @@ function pubsub_post(App $a)
hub_post_return(); hub_post_return();
} }
Logger::notice('Import item for ' . $nick . ' from ' . $contact['nick'] . ' (' . $contact['id'] . ')'); Logger::info('Import item for ' . $nick . ' from ' . $contact['nick'] . ' (' . $contact['id'] . ')');
$feedhub = ''; $feedhub = '';
OStatus::import($xml, $importer, $contact, $feedhub); OStatus::import($xml, $importer, $contact, $feedhub);

2
mod/pubsubhubbub.php
View file

@ -64,7 +64,7 @@ function pubsubhubbub_init(App $a) {
throw new \Friendica\Network\HTTPException\NotFoundException(); throw new \Friendica\Network\HTTPException\NotFoundException();
} }
Logger::notice("$hub_mode request from " . $_SERVER['REMOTE_ADDR']); Logger::info("$hub_mode request from " . $_SERVER['REMOTE_ADDR']);
if (DI::args()->getArgc() > 1) { if (DI::args()->getArgc() > 1) {
// Normally the url should now contain the nick name as last part of the url // Normally the url should now contain the nick name as last part of the url

6
src/Protocol/OStatus.php
View file

@ -535,12 +535,12 @@ class OStatus
foreach (self::$itemlist as $item) { foreach (self::$itemlist as $item) {
$found = Post::exists(['uid' => $importer["uid"], 'uri' => $item["uri"]]); $found = Post::exists(['uid' => $importer["uid"], 'uri' => $item["uri"]]);
if ($found) { if ($found) {
Logger::info("Item with uri ".$item["uri"]." for user ".$importer["uid"]." already exists."); Logger::notice("Item with uri ".$item["uri"]." for user ".$importer["uid"]." already exists.");
} elseif ($item['contact-id'] < 0) { } elseif ($item['contact-id'] < 0) {
Logger::info("Item with uri ".$item["uri"]." is from a blocked contact."); Logger::notice("Item with uri ".$item["uri"]." is from a blocked contact.");
} else { } else {
$ret = Item::insert($item); $ret = Item::insert($item);
Logger::notice("Item with uri ".$item["uri"]." for user ".$importer["uid"].' stored. Return value: '.$ret); Logger::info("Item with uri ".$item["uri"]." for user ".$importer["uid"].' stored. Return value: '.$ret);
} }
} }
} }

6
src/Protocol/Salmon.php
View file

@ -46,7 +46,7 @@ class Salmon
{ {
$ret = []; $ret = [];
Logger::notice('Fetching salmon key for '.$uri); Logger::info('Fetching salmon key for '.$uri);
$arr = Probe::lrdd($uri); $arr = Probe::lrdd($uri);
@ -121,7 +121,7 @@ class Salmon
return; return;
} }
Logger::notice('slapper called for '.$url.'. Data: ' . $slap); Logger::info('slapper called for '.$url.'. Data: ' . $slap);
// create a magic envelope // create a magic envelope
@ -209,7 +209,7 @@ class Salmon
$return_code = $postResult->getReturnCode(); $return_code = $postResult->getReturnCode();
} }
Logger::notice('slapper for '.$url.' returned ' . $return_code); Logger::info('slapper for '.$url.' returned ' . $return_code);
if (! $return_code) { if (! $return_code) {
return -1; return -1;

2
src/Worker/PubSubPublish.php
View file

@ -72,7 +72,7 @@ class PubSubPublish
$ret = $postResult->getReturnCode(); $ret = $postResult->getReturnCode();
if ($ret >= 200 && $ret <= 299) { if ($ret >= 200 && $ret <= 299) {
Logger::notice('Successfully pushed to ' . $subscriber['callback_url']); Logger::info('Successfully pushed to ' . $subscriber['callback_url']);
PushSubscriber::reset($subscriber['id'], $last_update); PushSubscriber::reset($subscriber['id'], $last_update);
} else { } else {

2
view/theme/frio/theme.php
View file

@ -57,7 +57,7 @@ function frio_install()
Hook::register('nav_info', 'view/theme/frio/theme.php', 'frio_remote_nav'); Hook::register('nav_info', 'view/theme/frio/theme.php', 'frio_remote_nav');
Hook::register('display_item', 'view/theme/frio/theme.php', 'frio_display_item'); Hook::register('display_item', 'view/theme/frio/theme.php', 'frio_display_item');
Logger::notice('installed theme frio'); Logger::info('installed theme frio');
} }
/** /**