keith/friendica
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Merge pull request #3030 from Hypolite/bug/proxy_url_extension

Browse source 
proxy_url: Fix extension extraction for URLs containing a . after a ?
This commit is contained in:
Michael Vogel 2016-12-20 17:53:26 +01:00 committed by GitHub
commit 7141ce9163
1 changed files with 8 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
mod/proxy.php
View file

@ -281,14 +281,14 @@ function proxy_url($url, $writemode = false, $size = '') {
$longpath .= '/' . strtr(base64_encode($url), '+/', '-_'); $longpath .= '/' . strtr(base64_encode($url), '+/', '-_');
// Checking for valid extensions. Only add them if they are safe // Extract the URL extension, disregarding GET parameters starting with ?
$pos = strrpos($url, '.'); $question_mark_pos = strpos($url, '?');
if ($pos) { if ($question_mark_pos === false) {
$extension = strtolower(substr($url, $pos + 1)); $question_mark_pos = strlen($url);
$pos = strpos($extension, '?'); }
if ($pos) { $dot_pos = strrpos($url, '.', $question_mark_pos - strlen($url));
$extension = substr($extension, 0, $pos); if ($dot_pos !== false) {
} $extension = strtolower(substr($url, $dot_pos + 1, $question_mark_pos - ($dot_pos + 1)));
} }
$extensions = array('jpg', 'jpeg', 'gif', 'png'); $extensions = array('jpg', 'jpeg', 'gif', 'png');