From 82b423c5ac3269d39e6384fa3c43d1d9e5285ad4 Mon Sep 17 00:00:00 2001 From: Hypolite Petovan Date: Sun, 7 May 2017 14:40:23 -0400 Subject: [PATCH 1/6] Fix require_once format --- include/Contact.php | 14 +++++++------- include/NotificationsManager.php | 6 +++--- include/bb2diaspora.php | 10 +++++----- include/cronjobs.php | 14 +++++++------- include/delivery.php | 20 ++++++++++---------- include/event.php | 2 +- include/follow.php | 12 ++++++------ include/gprobe.php | 4 ++-- include/notifier.php | 22 +++++++++++----------- include/ostatus.php | 28 ++++++++++++++-------------- include/salmon.php | 2 +- include/socgraph.php | 12 ++++++------ mod/contacts.php | 16 ++++++++-------- mod/dfrn_confirm.php | 16 ++++++++-------- mod/dfrn_request.php | 8 +++----- mod/follow.php | 6 +++--- mod/item.php | 2 -- mod/ostatus_subscribe.php | 2 +- mod/photos.php | 6 +++--- mod/profiles.php | 8 ++++---- mod/repair_ostatus.php | 2 +- 21 files changed, 104 insertions(+), 108 deletions(-) diff --git a/include/Contact.php b/include/Contact.php index d8971abc3..5787439c1 100644 --- a/include/Contact.php +++ b/include/Contact.php @@ -91,11 +91,11 @@ function terminate_friendship($user,$self,$contact) { /// @TODO Get rid of this, include/datetime.php should care about it by itself $a = get_app(); - require_once('include/datetime.php'); + require_once 'include/datetime.php'; if ($contact['network'] === NETWORK_OSTATUS) { - require_once('include/ostatus.php'); + require_once 'include/ostatus.php'; // create an unfollow slap $item = array(); @@ -104,14 +104,14 @@ function terminate_friendship($user,$self,$contact) { $slap = ostatus::salmon($item, $user); if ((x($contact,'notify')) && (strlen($contact['notify']))) { - require_once('include/salmon.php'); + require_once 'include/salmon.php'; slapper($user,$contact['notify'],$slap); } } elseif ($contact['network'] === NETWORK_DIASPORA) { - require_once('include/diaspora.php'); + require_once 'include/diaspora.php'; Diaspora::send_unshare($user,$contact); } elseif ($contact['network'] === NETWORK_DFRN) { - require_once('include/dfrn.php'); + require_once 'include/dfrn.php'; dfrn::deliver($user,$contact,'placeholder', 1); } @@ -706,7 +706,7 @@ function get_contact($url, $uid = 0, $no_update = false) { */ function posts_from_gcontact(App $a, $gcontact_id) { - require_once('include/conversation.php'); + require_once 'include/conversation.php'; // There are no posts with "uid = 0" with connector networks // This speeds up the query a lot @@ -745,7 +745,7 @@ function posts_from_gcontact(App $a, $gcontact_id) { */ function posts_from_contact_url(App $a, $contact_url) { - require_once('include/conversation.php'); + require_once 'include/conversation.php'; // There are no posts with "uid = 0" with connector networks // This speeds up the query a lot diff --git a/include/NotificationsManager.php b/include/NotificationsManager.php index bce65a092..add19a177 100644 --- a/include/NotificationsManager.php +++ b/include/NotificationsManager.php @@ -4,9 +4,9 @@ * @brief Methods for read and write notifications from/to database * or for formatting notifications */ -require_once('include/html2plain.php'); -require_once("include/datetime.php"); -require_once("include/bbcode.php"); +require_once 'include/html2plain.php'; +require_once 'include/datetime.php'; +require_once 'include/bbcode.php'; /** * @brief Methods for read and write notifications from/to database diff --git a/include/bb2diaspora.php b/include/bb2diaspora.php index 1dc775887..c1a6d38c0 100644 --- a/include/bb2diaspora.php +++ b/include/bb2diaspora.php @@ -4,11 +4,11 @@ use Friendica\App; use League\HTMLToMarkdown\HtmlConverter; -require_once "include/oembed.php"; -require_once "include/event.php"; -require_once "library/markdown.php"; -require_once "include/html2bbcode.php"; -require_once "include/bbcode.php"; +require_once 'include/oembed.php'; +require_once 'include/event.php'; +require_once 'library/markdown.php'; +require_once 'include/html2bbcode.php'; +require_once 'include/bbcode.php'; /** * @brief Callback function to replace a Diaspora style mention in a mention for Friendica diff --git a/include/cronjobs.php b/include/cronjobs.php index ee1ac517a..a2fc99825 100644 --- a/include/cronjobs.php +++ b/include/cronjobs.php @@ -6,14 +6,14 @@ use Friendica\Core\Config; function cronjobs_run(&$argv, &$argc){ global $a; - require_once('include/datetime.php'); - require_once('include/ostatus.php'); - require_once('include/post_update.php'); - require_once('mod/nodeinfo.php'); - require_once('include/photos.php'); - require_once('include/user.php'); - require_once('include/socgraph.php'); require_once('include/Probe.php'); + require_once 'include/datetime.php'; + require_once 'include/ostatus.php'; + require_once 'include/post_update.php'; + require_once 'mod/nodeinfo.php'; + require_once 'include/photos.php'; + require_once 'include/user.php'; + require_once 'include/socgraph.php'; // No parameter set? So return if ($argc <= 1) { diff --git a/include/delivery.php b/include/delivery.php index 3aecf3b72..7589b556d 100644 --- a/include/delivery.php +++ b/include/delivery.php @@ -3,20 +3,20 @@ use Friendica\App; use Friendica\Core\Config; -require_once('include/queue_fn.php'); -require_once('include/html2plain.php'); require_once('include/Scrape.php'); -require_once('include/diaspora.php'); -require_once('include/ostatus.php'); -require_once('include/dfrn.php'); +require_once 'include/queue_fn.php'; +require_once 'include/html2plain.php'; +require_once 'include/diaspora.php'; +require_once 'include/ostatus.php'; +require_once 'include/dfrn.php'; function delivery_run(&$argv, &$argc){ global $a; - require_once('include/datetime.php'); - require_once('include/items.php'); - require_once('include/bbcode.php'); - require_once('include/email.php'); + require_once 'include/datetime.php'; + require_once 'include/items.php'; + require_once 'include/bbcode.php'; + require_once 'include/email.php'; if ($argc < 3) { return; @@ -166,7 +166,7 @@ function delivery_run(&$argv, &$argc){ $public_message = true; if (!($mail || $fsuggest || $relocate)) { - require_once('include/group.php'); + require_once 'include/group.php'; $parent = $items[0]; diff --git a/include/event.php b/include/event.php index afb8ea755..9b49bdb40 100644 --- a/include/event.php +++ b/include/event.php @@ -88,7 +88,7 @@ function format_event_html($ev, $simple = false) { function parse_event($h) { require_once('include/Scrape.php'); - require_once('include/html2bbcode'); + require_once 'include/html2bbcode'; $h = '' . $h . ''; diff --git a/include/follow.php b/include/follow.php index 161e669e9..f3dc793c2 100644 --- a/include/follow.php +++ b/include/follow.php @@ -3,12 +3,12 @@ use Friendica\App; require_once("include/Scrape.php"); -require_once("include/socgraph.php"); -require_once('include/group.php'); -require_once('include/salmon.php'); -require_once('include/ostatus.php'); -require_once("include/Photo.php"); -require_once('include/diaspora.php'); +require_once 'include/socgraph.php'; +require_once 'include/group.php'; +require_once 'include/salmon.php'; +require_once 'include/ostatus.php'; +require_once 'include/Photo.php'; +require_once 'include/diaspora.php'; function update_contact($id) { /* diff --git a/include/gprobe.php b/include/gprobe.php index 55ce4c706..46aec0d1d 100644 --- a/include/gprobe.php +++ b/include/gprobe.php @@ -3,8 +3,8 @@ use Friendica\Core\Config; require_once('include/Scrape.php'); -require_once('include/socgraph.php'); -require_once('include/datetime.php'); +require_once 'include/socgraph.php'; +require_once 'include/datetime.php'; function gprobe_run(&$argv, &$argc){ if ($argc != 2) { diff --git a/include/notifier.php b/include/notifier.php index ad89eacb6..1ae56bd05 100644 --- a/include/notifier.php +++ b/include/notifier.php @@ -3,12 +3,12 @@ use Friendica\App; use Friendica\Core\Config; -require_once('include/queue_fn.php'); -require_once('include/html2plain.php'); require_once('include/Scrape.php'); -require_once('include/diaspora.php'); -require_once('include/ostatus.php'); -require_once('include/salmon.php'); +require_once 'include/queue_fn.php'; +require_once 'include/html2plain.php'; +require_once 'include/diaspora.php'; +require_once 'include/ostatus.php'; +require_once 'include/salmon.php'; /* * This file was at one time responsible for doing all deliveries, but this caused @@ -46,10 +46,10 @@ require_once('include/salmon.php'); function notifier_run(&$argv, &$argc){ global $a; - require_once('include/datetime.php'); - require_once('include/items.php'); - require_once('include/bbcode.php'); - require_once('include/email.php'); + require_once 'include/datetime.php'; + require_once 'include/items.php'; + require_once 'include/bbcode.php'; + require_once 'include/email.php'; if ($argc < 3) { return; @@ -139,7 +139,7 @@ function notifier_run(&$argv, &$argc){ if (!$r) { return; } - require_once('include/Contact.php'); + require_once 'include/Contact.php'; foreach ($r as $contact) { terminate_friendship($user, $self, $contact); } @@ -223,7 +223,7 @@ function notifier_run(&$argv, &$argc){ $slap = ostatus::salmon($target_item,$owner); - require_once('include/group.php'); + require_once 'include/group.php'; $parent = $items[0]; diff --git a/include/ostatus.php b/include/ostatus.php index c3bdadf55..1138906ca 100644 --- a/include/ostatus.php +++ b/include/ostatus.php @@ -5,21 +5,21 @@ use Friendica\App; use Friendica\Core\Config; - -require_once("include/Contact.php"); -require_once("include/threads.php"); -require_once("include/html2bbcode.php"); -require_once("include/bbcode.php"); -require_once("include/items.php"); -require_once("mod/share.php"); -require_once("include/enotify.php"); -require_once("include/socgraph.php"); -require_once("include/Photo.php"); require_once("include/Scrape.php"); -require_once("include/follow.php"); -require_once("include/api.php"); -require_once("mod/proxy.php"); -require_once("include/xml.php"); + +require_once 'include/Contact.php'; +require_once 'include/threads.php'; +require_once 'include/html2bbcode.php'; +require_once 'include/bbcode.php'; +require_once 'include/items.php'; +require_once 'mod/share.php'; +require_once 'include/enotify.php'; +require_once 'include/socgraph.php'; +require_once 'include/Photo.php'; +require_once 'include/follow.php'; +require_once 'include/api.php'; +require_once 'mod/proxy.php'; +require_once 'include/xml.php'; /** * @brief This class contain functions for the OStatus protocol diff --git a/include/salmon.php b/include/salmon.php index 79fd4c10d..8ebd9016f 100644 --- a/include/salmon.php +++ b/include/salmon.php @@ -1,6 +1,6 @@ App::get_baseurl(true), )); - require_once('include/contact_selectors.php'); + require_once 'include/contact_selectors.php'; $tpl = get_markup_template("contact_edit.tpl"); diff --git a/mod/dfrn_confirm.php b/mod/dfrn_confirm.php index 6ebde734e..10ea8937e 100644 --- a/mod/dfrn_confirm.php +++ b/mod/dfrn_confirm.php @@ -20,9 +20,9 @@ use Friendica\App; -require_once('include/enotify.php'); -require_once('include/group.php'); require_once('include/Probe.php'); +require_once 'include/enotify.php'; +require_once 'include/group.php'; function dfrn_confirm_post(App $a, $handsfree = null) { @@ -154,7 +154,7 @@ function dfrn_confirm_post(App $a, $handsfree = null) { * worried about key leakage than anybody cracking it. * */ - require_once('include/crypto.php'); + require_once 'include/crypto.php'; $res = new_keypair(4096); @@ -319,7 +319,7 @@ function dfrn_confirm_post(App $a, $handsfree = null) { * */ - require_once('include/Photo.php'); + require_once 'include/Photo.php'; update_contact_avatar($contact['photo'],$uid,$contact_id); @@ -435,7 +435,7 @@ function dfrn_confirm_post(App $a, $handsfree = null) { if ((isset($new_relation) && $new_relation == CONTACT_IS_FRIEND)) { if (($contact) && ($contact['network'] === NETWORK_DIASPORA)) { - require_once('include/diaspora.php'); + require_once 'include/diaspora.php'; $ret = Diaspora::send_share($user[0],$r[0]); logger('share returns: ' . $ret); } @@ -448,7 +448,7 @@ function dfrn_confirm_post(App $a, $handsfree = null) { if((dbm::is_result($r)) && ($r[0]['hide-friends'] == 0) && ($activity) && (! $hidden)) { - require_once('include/items.php'); + require_once 'include/items.php'; $self = q("SELECT * FROM `contact` WHERE `self` = 1 AND `uid` = %d LIMIT 1", intval($uid) @@ -672,7 +672,7 @@ function dfrn_confirm_post(App $a, $handsfree = null) { $photo = App::get_baseurl() . '/images/person-175.jpg'; } - require_once("include/Photo.php"); + require_once 'include/Photo.php'; update_contact_avatar($photo,$local_uid,$dfrn_record); @@ -752,7 +752,7 @@ function dfrn_confirm_post(App $a, $handsfree = null) { if((dbm::is_result($r)) && ($r[0]['hide-friends'] == 0)) { - require_once('include/items.php'); + require_once 'include/items.php'; $self = q("SELECT * FROM `contact` WHERE `self` = 1 AND `uid` = %d LIMIT 1", intval($local_uid) diff --git a/mod/dfrn_request.php b/mod/dfrn_request.php index 18a6b7ebd..8e461cbb3 100644 --- a/mod/dfrn_request.php +++ b/mod/dfrn_request.php @@ -14,10 +14,10 @@ use Friendica\App; -require_once('include/enotify.php'); require_once('include/Scrape.php'); require_once('include/Probe.php'); -require_once('include/group.php'); +require_once 'include/enotify.php'; +require_once 'include/group.php'; function dfrn_request_init(App $a) { @@ -522,8 +522,6 @@ function dfrn_request_post(App $a) { return; // NOTREACHED } - require_once('include/Scrape.php'); - $parms = Probe::profile(($hcard) ? $hcard : $url); if (! count($parms)) { @@ -767,7 +765,7 @@ function dfrn_request_content(App $a) { } if($auto_confirm) { - require_once('mod/dfrn_confirm.php'); + require_once 'mod/dfrn_confirm.php'; $handsfree = array( 'uid' => $r[0]['uid'], 'node' => $r[0]['nickname'], diff --git a/mod/follow.php b/mod/follow.php index c59af73ee..fbe4602f5 100644 --- a/mod/follow.php +++ b/mod/follow.php @@ -3,9 +3,9 @@ use Friendica\App; require_once('include/Scrape.php'); -require_once('include/follow.php'); -require_once('include/Contact.php'); -require_once('include/contact_selectors.php'); +require_once 'include/follow.php'; +require_once 'include/Contact.php'; +require_once 'include/contact_selectors.php'; function follow_content(App $a) { diff --git a/mod/item.php b/mod/item.php index 4744ec4ad..151575e6b 100644 --- a/mod/item.php +++ b/mod/item.php @@ -144,7 +144,6 @@ function item_post(App $a) { $parent_contact = get_contact_details_by_url($thrparent[0]["author-link"]); if (!isset($parent_contact["nick"])) { - require_once 'include/Scrape.php'; $probed_contact = probe_url($thrparent[0]["author-link"]); if ($probed_contact["network"] != NETWORK_FEED) { $parent_contact = $probed_contact; @@ -1106,7 +1105,6 @@ function item_content(App $a) { * @return boolean true if replaced, false if not replaced */ function handle_tag(App $a, &$body, &$inform, &$str_tags, $profile_uid, $tag, $network = "") { - require_once 'include/Scrape.php'; require_once 'include/socgraph.php'; $replaced = false; diff --git a/mod/ostatus_subscribe.php b/mod/ostatus_subscribe.php index a36821aa2..28dc5f866 100644 --- a/mod/ostatus_subscribe.php +++ b/mod/ostatus_subscribe.php @@ -3,7 +3,7 @@ use Friendica\App; require_once('include/Scrape.php'); -require_once('include/follow.php'); +require_once 'include/follow.php'; function ostatus_subscribe_content(App $a) { diff --git a/mod/photos.php b/mod/photos.php index 8d6d54ac8..1d20120a8 100644 --- a/mod/photos.php +++ b/mod/photos.php @@ -982,9 +982,9 @@ function photos_content(App $a) { return; } - require_once('include/bbcode.php'); - require_once('include/security.php'); - require_once('include/conversation.php'); + require_once 'include/bbcode.php'; + require_once 'include/security.php'; + require_once 'include/conversation.php'; if (! x($a->data,'user')) { notice( t('No photos selected') . EOL ); diff --git a/mod/profiles.php b/mod/profiles.php index 42699e5e0..0d3e1afba 100644 --- a/mod/profiles.php +++ b/mod/profiles.php @@ -2,7 +2,7 @@ use Friendica\App; -require_once("include/Contact.php"); +require_once 'include/Contact.php'; require_once('include/Probe.php'); function profiles_init(App $a) { @@ -504,7 +504,7 @@ function profiles_post(App $a) { proc_run(PRIORITY_LOW, "include/directory.php", $url); } - require_once('include/profile_update.php'); + require_once 'include/profile_update.php'; profile_change(); // Update the global contact for the user @@ -529,7 +529,7 @@ function profile_activity($changed, $value) { return; } - require_once('include/items.php'); + require_once 'include/items.php'; $self = q("SELECT * FROM `contact` WHERE `self` = 1 AND `uid` = %d LIMIT 1", intval(local_user()) @@ -623,7 +623,7 @@ function profiles_content(App $a) { return; } - require_once('include/profile_selectors.php'); + require_once 'include/profile_selectors.php'; $a->page['htmlhead'] .= replace_macros(get_markup_template('profed_head.tpl'), array( diff --git a/mod/repair_ostatus.php b/mod/repair_ostatus.php index a690680d1..b9b94e551 100755 --- a/mod/repair_ostatus.php +++ b/mod/repair_ostatus.php @@ -3,7 +3,7 @@ use Friendica\App; require_once('include/Scrape.php'); -require_once('include/follow.php'); +require_once 'include/follow.php'; function repair_ostatus_content(App $a) { From 36e515ee6d00139a2aefed265ef38171c7c8e4fa Mon Sep 17 00:00:00 2001 From: Hypolite Petovan Date: Sun, 7 May 2017 14:44:30 -0400 Subject: [PATCH 2/6] Move Probe to src --- include/Contact.php | 3 +-- include/Scrape.php | 3 ++- include/bb2diaspora.php | 1 + include/cronjobs.php | 2 +- include/network.php | 2 +- include/ostatus.php | 1 + include/salmon.php | 3 ++- include/socgraph.php | 1 + mod/contacts.php | 1 + mod/dfrn_confirm.php | 2 +- mod/dfrn_request.php | 2 +- mod/photos.php | 2 +- mod/profiles.php | 2 +- mod/webfinger.php | 3 +-- {include => src/Network}/Probe.php | 5 ++++- 15 files changed, 20 insertions(+), 13 deletions(-) rename {include => src/Network}/Probe.php (99%) diff --git a/include/Contact.php b/include/Contact.php index 5787439c1..20ae524cb 100644 --- a/include/Contact.php +++ b/include/Contact.php @@ -1,6 +1,7 @@ Date: Sun, 7 May 2017 14:45:19 -0400 Subject: [PATCH 3/6] Rename include/Scrape to include/probe --- include/delivery.php | 2 +- include/diaspora.php | 2 +- include/event.php | 2 +- include/follow.php | 2 +- include/gprobe.php | 2 +- include/message.php | 2 +- include/notifier.php | 2 +- include/ostatus.php | 2 +- include/{Scrape.php => probe.php} | 0 include/socgraph.php | 2 +- include/update_gcontact.php | 2 +- mod/acctlink.php | 2 +- mod/contacts.php | 2 +- mod/dfrn_request.php | 4 ++-- mod/follow.php | 2 +- mod/item.php | 2 +- mod/ostatus_subscribe.php | 2 +- mod/probe.php | 2 +- mod/repair_ostatus.php | 2 +- 19 files changed, 19 insertions(+), 19 deletions(-) rename include/{Scrape.php => probe.php} (100%) diff --git a/include/delivery.php b/include/delivery.php index 7589b556d..098e423d1 100644 --- a/include/delivery.php +++ b/include/delivery.php @@ -3,9 +3,9 @@ use Friendica\App; use Friendica\Core\Config; -require_once('include/Scrape.php'); require_once 'include/queue_fn.php'; require_once 'include/html2plain.php'; +require_once 'include/probe.php'; require_once 'include/diaspora.php'; require_once 'include/ostatus.php'; require_once 'include/dfrn.php'; diff --git a/include/diaspora.php b/include/diaspora.php index 51b496f86..cc3f32e4a 100644 --- a/include/diaspora.php +++ b/include/diaspora.php @@ -13,7 +13,7 @@ use Friendica\Core\Config; require_once 'include/items.php'; require_once 'include/bb2diaspora.php'; -require_once 'include/Scrape.php'; +require_once 'include/probe.php'; require_once 'include/Contact.php'; require_once 'include/Photo.php'; require_once 'include/socgraph.php'; diff --git a/include/event.php b/include/event.php index 9b49bdb40..5ef8b010f 100644 --- a/include/event.php +++ b/include/event.php @@ -87,7 +87,7 @@ function format_event_html($ev, $simple = false) { @TODO old-lost code found? function parse_event($h) { - require_once('include/Scrape.php'); + require_once 'include/probe.php'; require_once 'include/html2bbcode'; $h = '' . $h . ''; diff --git a/include/follow.php b/include/follow.php index f3dc793c2..cdeac6db2 100644 --- a/include/follow.php +++ b/include/follow.php @@ -2,7 +2,7 @@ use Friendica\App; -require_once("include/Scrape.php"); +require_once 'include/probe.php'; require_once 'include/socgraph.php'; require_once 'include/group.php'; require_once 'include/salmon.php'; diff --git a/include/gprobe.php b/include/gprobe.php index 46aec0d1d..8e9ebd122 100644 --- a/include/gprobe.php +++ b/include/gprobe.php @@ -2,7 +2,7 @@ use Friendica\Core\Config; -require_once('include/Scrape.php'); +require_once 'include/probe.php'; require_once 'include/socgraph.php'; require_once 'include/datetime.php'; diff --git a/include/message.php b/include/message.php index b857bd604..66e173d35 100644 --- a/include/message.php +++ b/include/message.php @@ -174,7 +174,7 @@ function send_wallmessage($recipient='', $body='', $subject='', $replyto=''){ $convid = 0; $reply = false; - require_once('include/Scrape.php'); + require_once 'include/probe.php'; $me = probe_url($replyto); diff --git a/include/notifier.php b/include/notifier.php index 1ae56bd05..4f9b34d01 100644 --- a/include/notifier.php +++ b/include/notifier.php @@ -3,9 +3,9 @@ use Friendica\App; use Friendica\Core\Config; -require_once('include/Scrape.php'); require_once 'include/queue_fn.php'; require_once 'include/html2plain.php'; +require_once 'include/probe.php'; require_once 'include/diaspora.php'; require_once 'include/ostatus.php'; require_once 'include/salmon.php'; diff --git a/include/ostatus.php b/include/ostatus.php index cc9ee4c70..d41974709 100644 --- a/include/ostatus.php +++ b/include/ostatus.php @@ -5,7 +5,6 @@ use Friendica\App; use Friendica\Core\Config; -require_once("include/Scrape.php"); use Friendica\Network\Probe; require_once 'include/Contact.php'; @@ -17,6 +16,7 @@ require_once 'mod/share.php'; require_once 'include/enotify.php'; require_once 'include/socgraph.php'; require_once 'include/Photo.php'; +require_once 'include/probe.php'; require_once 'include/follow.php'; require_once 'include/api.php'; require_once 'mod/proxy.php'; diff --git a/include/Scrape.php b/include/probe.php similarity index 100% rename from include/Scrape.php rename to include/probe.php diff --git a/include/socgraph.php b/include/socgraph.php index 94924873d..3de114fca 100644 --- a/include/socgraph.php +++ b/include/socgraph.php @@ -9,10 +9,10 @@ use Friendica\App; use Friendica\Core\Config; -require_once("include/Scrape.php"); use Friendica\Network\Probe; require_once 'include/datetime.php'; +require_once 'include/probe.php'; require_once 'include/network.php'; require_once 'include/html2bbcode.php'; require_once 'include/Contact.php'; diff --git a/include/update_gcontact.php b/include/update_gcontact.php index 7a3e48937..d283bd268 100644 --- a/include/update_gcontact.php +++ b/include/update_gcontact.php @@ -5,7 +5,7 @@ use Friendica\Core\Config; function update_gcontact_run(&$argv, &$argc) { global $a; - require_once 'include/Scrape.php'; + require_once 'include/probe.php'; require_once 'include/socgraph.php'; logger('update_gcontact: start'); diff --git a/mod/acctlink.php b/mod/acctlink.php index bb59d7b94..5e98ed32b 100644 --- a/mod/acctlink.php +++ b/mod/acctlink.php @@ -2,7 +2,7 @@ use Friendica\App; -require_once('include/Scrape.php'); +require_once 'include/probe.php'; function acctlink_init(App $a) { diff --git a/mod/contacts.php b/mod/contacts.php index 57c96a1e3..21a4f7446 100644 --- a/mod/contacts.php +++ b/mod/contacts.php @@ -3,10 +3,10 @@ use Friendica\App; use Friendica\Network\Probe; -require_once('include/Scrape.php'); require_once 'include/Contact.php'; require_once 'include/socgraph.php'; require_once 'include/contact_selectors.php'; +require_once 'include/probe.php'; require_once 'mod/proxy.php'; require_once 'include/Photo.php'; diff --git a/mod/dfrn_request.php b/mod/dfrn_request.php index eadbb920d..c3b7a523d 100644 --- a/mod/dfrn_request.php +++ b/mod/dfrn_request.php @@ -13,10 +13,10 @@ */ use Friendica\App; - -require_once('include/Scrape.php'); use Friendica\Network\Probe; + require_once 'include/enotify.php'; +require_once 'include/probe.php'; require_once 'include/group.php'; function dfrn_request_init(App $a) { diff --git a/mod/follow.php b/mod/follow.php index fbe4602f5..45e017f08 100644 --- a/mod/follow.php +++ b/mod/follow.php @@ -2,7 +2,7 @@ use Friendica\App; -require_once('include/Scrape.php'); +require_once 'include/probe.php'; require_once 'include/follow.php'; require_once 'include/Contact.php'; require_once 'include/contact_selectors.php'; diff --git a/mod/item.php b/mod/item.php index 151575e6b..f2d7babcd 100644 --- a/mod/item.php +++ b/mod/item.php @@ -25,7 +25,7 @@ require_once 'include/files.php'; require_once 'include/threads.php'; require_once 'include/text.php'; require_once 'include/items.php'; -require_once 'include/Scrape.php'; +require_once 'include/probe.php'; require_once 'include/diaspora.php'; require_once 'include/Contact.php'; diff --git a/mod/ostatus_subscribe.php b/mod/ostatus_subscribe.php index 28dc5f866..0b399acf2 100644 --- a/mod/ostatus_subscribe.php +++ b/mod/ostatus_subscribe.php @@ -2,7 +2,7 @@ use Friendica\App; -require_once('include/Scrape.php'); +require_once 'include/probe.php'; require_once 'include/follow.php'; function ostatus_subscribe_content(App $a) { diff --git a/mod/probe.php b/mod/probe.php index 2911bc05c..abeccef44 100644 --- a/mod/probe.php +++ b/mod/probe.php @@ -2,7 +2,7 @@ use Friendica\App; -require_once('include/Scrape.php'); +require_once 'include/probe.php'; function probe_content(App $a) { diff --git a/mod/repair_ostatus.php b/mod/repair_ostatus.php index b9b94e551..ff4c11a7a 100755 --- a/mod/repair_ostatus.php +++ b/mod/repair_ostatus.php @@ -2,7 +2,7 @@ use Friendica\App; -require_once('include/Scrape.php'); +require_once 'include/probe.php'; require_once 'include/follow.php'; function repair_ostatus_content(App $a) { From ee7650795d3a6a5fd207b28f41defeaa0eb944c3 Mon Sep 17 00:00:00 2001 From: Hypolite Petovan Date: Sun, 7 May 2017 14:50:47 -0400 Subject: [PATCH 4/6] Updated composer static autoloader --- vendor/composer/autoload_classmap.php | 1 + vendor/composer/autoload_static.php | 1 + 2 files changed, 2 insertions(+) diff --git a/vendor/composer/autoload_classmap.php b/vendor/composer/autoload_classmap.php index 58744c098..a3f90a0f7 100644 --- a/vendor/composer/autoload_classmap.php +++ b/vendor/composer/autoload_classmap.php @@ -12,6 +12,7 @@ return array( 'Friendica\\App' => $baseDir . '/src/App.php', 'Friendica\\Core\\Config' => $baseDir . '/src/Core/Config.php', 'Friendica\\Core\\PConfig' => $baseDir . '/src/Core/PConfig.php', + 'Friendica\\Network\\Probe' => $baseDir . '/src/Network/Probe.php', 'Friendica\\ParseUrl' => $baseDir . '/src/ParseUrl.php', 'HTMLPurifier' => $vendorDir . '/ezyang/htmlpurifier/library/HTMLPurifier.php', 'HTMLPurifier_Arborize' => $vendorDir . '/ezyang/htmlpurifier/library/HTMLPurifier/Arborize.php', diff --git a/vendor/composer/autoload_static.php b/vendor/composer/autoload_static.php index 0ea04c537..2b6416c2e 100644 --- a/vendor/composer/autoload_static.php +++ b/vendor/composer/autoload_static.php @@ -56,6 +56,7 @@ class ComposerStaticInitFriendica 'Friendica\\App' => __DIR__ . '/../..' . '/src/App.php', 'Friendica\\Core\\Config' => __DIR__ . '/../..' . '/src/Core/Config.php', 'Friendica\\Core\\PConfig' => __DIR__ . '/../..' . '/src/Core/PConfig.php', + 'Friendica\\Network\\Probe' => __DIR__ . '/../..' . '/src/Network/Probe.php', 'Friendica\\ParseUrl' => __DIR__ . '/../..' . '/src/ParseUrl.php', 'HTMLPurifier' => __DIR__ . '/..' . '/ezyang/htmlpurifier/library/HTMLPurifier.php', 'HTMLPurifier_Arborize' => __DIR__ . '/..' . '/ezyang/htmlpurifier/library/HTMLPurifier/Arborize.php', From 92550861e9dc1294fd1a1822c575e3c905a783c2 Mon Sep 17 00:00:00 2001 From: Hypolite Petovan Date: Sun, 7 May 2017 15:00:38 -0400 Subject: [PATCH 5/6] Updated doc in include/probe.php - Fix standards --- include/probe.php | 33 +++++++++++++++++++-------------- 1 file changed, 19 insertions(+), 14 deletions(-) diff --git a/include/probe.php b/include/probe.php index 2d5205984..8cf703be8 100644 --- a/include/probe.php +++ b/include/probe.php @@ -2,15 +2,6 @@ use Friendica\Network\Probe; -/** - * - * Probe a network address to discover what kind of protocols we need to communicate with it. - * - * Warning: this function is a bit touchy and there are some subtle dependencies within the logic flow. - * Edit with care. - * - */ - /** * * PROBE_DIASPORA has a bias towards returning Diaspora information @@ -19,16 +10,30 @@ use Friendica\Network\Probe; * of network. * */ - define('PROBE_NORMAL', 0); define('PROBE_DIASPORA', 1); -function probe_url($url, $mode = PROBE_NORMAL, $level = 1) { +/** + * @brief Probes a network address to discover what kind of protocols we need to communicate with it. + * + * Warning: this function is a bit touchy and there are some subtle dependencies within the logic flow. + * Edit with care. + * + * @deprecated Use Friendica\Network\Probe instead + * + * @see Friendica\Network\Probe::uri() + * + * @param string $url Any URI + * @param int $mode One of the PROBE_* constants + * @return array Same data array returned by Friendica\Network\Probe::uri() + */ +function probe_url($url, $mode = PROBE_NORMAL) { - if ($mode == PROBE_DIASPORA) + if ($mode == PROBE_DIASPORA) { $network = NETWORK_DIASPORA; - else - $network = ""; + } else { + $network = ''; + } $data = Probe::uri($url, $network); From 45ec3fb5d8d26c69733491394a298b37b3e93260 Mon Sep 17 00:00:00 2001 From: Hypolite Petovan Date: Sun, 7 May 2017 17:08:32 -0400 Subject: [PATCH 6/6] Add missing include/probe require for probe_url support --- include/NotificationsManager.php | 1 + include/discover_poco.php | 5 ++- include/event.php | 68 -------------------------------- mod/dirfind.php | 11 +++--- 4 files changed, 10 insertions(+), 75 deletions(-) diff --git a/include/NotificationsManager.php b/include/NotificationsManager.php index add19a177..718339380 100644 --- a/include/NotificationsManager.php +++ b/include/NotificationsManager.php @@ -5,6 +5,7 @@ * or for formatting notifications */ require_once 'include/html2plain.php'; +require_once 'include/probe.php'; require_once 'include/datetime.php'; require_once 'include/bbcode.php'; diff --git a/include/discover_poco.php b/include/discover_poco.php index e371080d1..e71c26fc1 100644 --- a/include/discover_poco.php +++ b/include/discover_poco.php @@ -2,8 +2,9 @@ use Friendica\Core\Config; -require_once('include/socgraph.php'); -require_once('include/datetime.php'); +require_once 'include/probe.php'; +require_once 'include/socgraph.php'; +require_once 'include/datetime.php'; function discover_poco_run(&$argv, &$argc) { diff --git a/include/event.php b/include/event.php index 5ef8b010f..089fe705d 100644 --- a/include/event.php +++ b/include/event.php @@ -83,74 +83,6 @@ function format_event_html($ev, $simple = false) { return $o; } -/* -@TODO old-lost code found? -function parse_event($h) { - - require_once 'include/probe.php'; - require_once 'include/html2bbcode'; - - $h = '' . $h . ''; - - $ret = array(); - - - try { - $dom = HTML5_Parser::parse($h); - } catch (DOMException $e) { - logger('parse_event: parse error: ' . $e); - } - - if (! $dom) - return $ret; - - $items = $dom->getElementsByTagName('*'); - - foreach ($items as $item) { - if (attribute_contains($item->getAttribute('class'), 'vevent')) { - $level2 = $item->getElementsByTagName('*'); - foreach ($level2 as $x) { - if (attribute_contains($x->getAttribute('class'),'dtstart') && $x->getAttribute('title')) { - $ret['start'] = $x->getAttribute('title'); - if (! strpos($ret['start'],'Z')) - $ret['adjust'] = true; - } - if (attribute_contains($x->getAttribute('class'),'dtend') && $x->getAttribute('title')) - $ret['finish'] = $x->getAttribute('title'); - - if (attribute_contains($x->getAttribute('class'),'description')) - $ret['desc'] = $x->textContent; - if (attribute_contains($x->getAttribute('class'),'location')) - $ret['location'] = $x->textContent; - } - } - } - - // sanitise - - if ((x($ret,'desc')) && ((strpos($ret['desc'],'<') !== false) || (strpos($ret['desc'],'>') !== false))) { - $config = HTMLPurifier_Config::createDefault(); - $config->set('Cache.DefinitionImpl', null); - $purifier = new HTMLPurifier($config); - $ret['desc'] = html2bbcode($purifier->purify($ret['desc'])); - } - - if ((x($ret,'location')) && ((strpos($ret['location'],'<') !== false) || (strpos($ret['location'],'>') !== false))) { - $config = HTMLPurifier_Config::createDefault(); - $config->set('Cache.DefinitionImpl', null); - $purifier = new HTMLPurifier($config); - $ret['location'] = html2bbcode($purifier->purify($ret['location'])); - } - - if (x($ret,'start')) - $ret['start'] = datetime_convert('UTC','UTC',$ret['start']); - if (x($ret,'finish')) - $ret['finish'] = datetime_convert('UTC','UTC',$ret['finish']); - - return $ret; -} -*/ - function format_event_bbcode($ev) { $o = ''; diff --git a/mod/dirfind.php b/mod/dirfind.php index c24ab9dbd..a64a804ba 100644 --- a/mod/dirfind.php +++ b/mod/dirfind.php @@ -2,11 +2,12 @@ use Friendica\App; -require_once('include/contact_widgets.php'); -require_once('include/socgraph.php'); -require_once('include/Contact.php'); -require_once('include/contact_selectors.php'); -require_once('mod/contacts.php'); +require_once 'include/contact_widgets.php'; +require_once 'include/probe.php'; +require_once 'include/socgraph.php'; +require_once 'include/Contact.php'; +require_once 'include/contact_selectors.php'; +require_once 'mod/contacts.php'; function dirfind_init(App $a) {