keith/friendica
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Fix various Notices

Browse source
This commit is contained in:
Philipp 2021-09-13 20:22:55 +02:00
parent 9b19fb9b4d
commit 644f312896
No known key found for this signature in database
GPG key ID: 24A7501396EB5432
7 changed files with 12 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/Model/Contact.php
View file

@ -2757,12 +2757,14 @@ class Contact
return null;
}
public static function removeFollower($importer, $contact)
public static function removeFollower(array $contact)
{
if (($contact['rel'] == self::FRIEND) || ($contact['rel'] == self::SHARING)) {
if (!empty($contact['rel']) && (($contact['rel'] == self::FRIEND) || ($contact['rel'] == self::SHARING))) {
DBA::update('contact', ['rel' => self::SHARING], ['id' => $contact['id']]);
} else {
} elseif (!empty($contact['id'])) {
self::remove($contact['id']);
} else {
DI::logger()->info('Couldn\'t remove follower because of invalid contact array', ['contact' => $contact]);
}
}

4
src/Model/Item.php
View file

@ -2292,9 +2292,9 @@ class Item
continue;
} elseif (!$expire_starred && intval($item['starred'])) {
continue;
} elseif (!$expire_notes && ($item['post-type'] == self::PT_PERSONAL_NOTE)) {
} elseif (!$expire_notes && (($item['post-type'] ?? null) == self::PT_PERSONAL_NOTE)) {
continue;
} elseif (!$expire_items && ($item['post-type'] != self::PT_PERSONAL_NOTE)) {
} elseif (!$expire_items && (($item['post-type'] ?? null) != self::PT_PERSONAL_NOTE)) {
continue;
}

2
src/Module/Contact.php
View file

@ -293,7 +293,7 @@ class Contact extends BaseModule
$contact = DBA::selectFirst('contact', [], ['id' => $contact_id, 'uid' => [0, local_user()], 'deleted' => false]);
// Don't display contacts that are about to be deleted
if ($contact['network'] == Protocol::PHANTOM) {
if (DBA::isResult($contact) && !empty($contact['network']) && $contact['network'] == Protocol::PHANTOM) {
$contact = false;
}
}

2
src/Protocol/ActivityPub/Processor.php
View file

@ -1102,7 +1102,7 @@ class Processor
return;
}
Contact::removeFollower($owner, $contact);
Contact::removeFollower($contact);
Logger::info('Undo following request', ['contact' => $cid, 'user' => $uid]);
}

2
src/Protocol/DFRN.php
View file

@ -1584,7 +1584,7 @@ class DFRN
}
if ($activity->match($item["verb"], Activity::UNFOLLOW)) {
Logger::log("Lost follower");
Contact::removeFollower($importer, $contact, $item);
Contact::removeFollower($contact);
return false;
}
if ($activity->match($item["verb"], Activity::REQ_FRIEND)) {

2
src/Protocol/Diaspora.php
View file

@ -2211,7 +2211,7 @@ class Diaspora
return true;
} else {
Logger::log("Author ".$author." doesn't want to follow us anymore.", Logger::DEBUG);
Contact::removeFollower($importer, $contact);
Contact::removeFollower($contact);
return true;
}
}

2
src/Protocol/OStatus.php
View file

@ -471,7 +471,7 @@ class OStatus
if ($item["verb"] == Activity::O_UNFOLLOW) {
$dummy = null;
Contact::removeFollower($importer, $contact, $item, $dummy);
Contact::removeFollower($contact);
continue;
}