keith/friendica
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

mail() requires additional headers to be separated by CRLF

Browse source 
- Rewrite Email->getAdditionalMailHeaderString to have only one string concatenation statement
This commit is contained in:
Hypolite Petovan 2022-11-13 02:28:06 -05:00
parent b1eba05e93
commit 4dc96daeb3
2 changed files with 10 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
src/Object/Email.php
View file

@ -135,14 +135,15 @@ class Email implements IEmail
$headerString = ''; $headerString = '';
foreach ($this->additionalMailHeader as $name => $values) { foreach ($this->additionalMailHeader as $name => $values) {
if (is_array($values)) { if (!is_array($values)) {
foreach ($values as $value) { $values = [$values];
$headerString .= "$name: $value\n"; }
}
} else { foreach ($values as $value) {
$headerString .= "$name: $values\n"; $headerString .= "$name: $value\r\n";
} }
} }
return $headerString; return $headerString;
} }

6
src/Util/Emailer.php
View file

@ -163,9 +163,9 @@ class Emailer
// generate a multipart/alternative message header // generate a multipart/alternative message header
$messageHeader = $email->getAdditionalMailHeaderString() . $messageHeader = $email->getAdditionalMailHeaderString() .
"From: $fromName <{$fromAddress}>\n" . "From: $fromName <{$fromAddress}>\r\n" .
"Reply-To: $fromName <{$replyTo}>\n" . "Reply-To: $fromName <{$replyTo}>\r\n" .
"MIME-Version: 1.0\n" . "MIME-Version: 1.0\r\n" .
"Content-Type: multipart/alternative; boundary=\"{$mimeBoundary}\""; "Content-Type: multipart/alternative; boundary=\"{$mimeBoundary}\"";
// assemble the final multipart message body with the text and html types included // assemble the final multipart message body with the text and html types included