keith/friendica
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Merge pull request #12541 from MrPetovan/task/10974-screen-reader-part-3

Browse source 
Remove counter-productive role="heading" and aria-level attributes
This commit is contained in:
Michael Vogel 2022-12-27 19:35:39 +01:00 committed by GitHub
commit 4bb0fdc9a9
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
view/theme/frio/css/style.css
View file

@ -1717,13 +1717,13 @@ aside .panel-body {
}
/* wall items action dropdown menu */
.media [role="heading"] {
.media .contact-info {
position: relative;
}
/* Workaround for Firefox where the post heading covers the avatar, preventing hovercard interaction,
48px is the width of the avatar image and should be adjusted accordingly if it ever changes. */
.media .dropdown.pull-left + [role="heading"] {
.media .dropdown.pull-left + .contact-info {
margin-left: 48px;
}

4
view/theme/frio/templates/search_item.tpl
View file

@ -23,7 +23,7 @@
{{* contact info header*}}
<div role="heading" class="contact-info hidden-sm hidden-xs media-body"><!-- <= For computer -->
<div class="contact-info hidden-sm hidden-xs media-body"><!-- Desktop -->
<div class="preferences">
{{if $item.network_icon != ""}}
<span class="wall-item-network"><i class="fa fa-{{$item.network_icon}}" title="{{$item.network_name}}" aria-hidden="true"></i></span>
@ -77,7 +77,7 @@
</div>
{{* contact info header for smartphones *}}
<div role="heading" class="contact-info-xs hidden-lg hidden-md">
<div class="contact-info contact-info-xs hidden-lg hidden-md">
<div class="preferences">
{{if $item.network_icon != ""}}
<span class="wall-item-network"><i class="fa fa-{{$item.network_icon}}" title="{{$item.network_name}}" aria-hidden="true"></i></span>

2
view/theme/frio/templates/wall_thread.tpl
View file

@ -132,7 +132,7 @@ as the value of $top_child_total (this is done at the end of this file)
{{/if}}
{{* contact info header*}}
<div role="heading" aria-level="{{$item.thread_level}}">
<div class="contact-info">
<div class="preferences">
{{if $item.network_icon != ""}}
<span class="wall-item-network"><i class="fa fa-{{$item.network_icon}}" title="{{$item.network_name}}" aria-hidden="true"></i></span>

2
view/theme/vier/templates/wall_thread.tpl
View file

@ -52,7 +52,7 @@
</div>
{{/if}}
</div>
<div role="heading" aria-level="{{$item.thread_level}}" class="wall-item-actions-author">
<div class="wall-item-actions-author">
<a href="{{$item.profile_url}}" target="redir" title="{{$item.linktitle}}" class="wall-item-name-link"><span class="wall-item-name{{$item.sparkle}}">{{$item.name}}</span></a>
{{if $item.owner_url}}{{$item.via}} <a href="{{$item.owner_url}}" target="redir" title="{{$item.olinktitle}}" class="wall-item-name-link"><span class="wall-item-name{{$item.osparkle}}" id="wall-item-ownername-{{$item.id}}">{{$item.owner_name}}</span></a>{{/if}}
<span class="wall-item-ago">