keith/friendica
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

api_friendships_destroy idents, DBA::selectFirst, Excepions and LogMessages

Browse source
This commit is contained in:
Jonny Tischbein 2018-09-14 09:28:14 +02:00
parent a89f9cf7d5
commit 3eb539aefd
1 changed files with 29 additions and 29 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

32
include/api.php
View file

@ -3631,29 +3631,30 @@ api_register_func('api/direct_messages/destroy', 'api_direct_messages_destroy',
function api_friendships_destroy($type) function api_friendships_destroy($type)
{ {
$a = get_app(); $a = api_user();
if (api_user() === false) { if ($a === false) {
throw new ForbiddenException(); throw new ForbiddenException();
} }
$uid = local_user(); $uid = local_user();
$contact_id = (x($_REQUEST, 'user_id') ? $_REQUEST['user_id'] : null); $contact_id = defaults($_REQUEST, 'user_id');
if ($contact_id == null) { if ($contact_id == null) {
logger("No given user_id", LOGGER_DEBUG); logger("No user_id specified", LOGGER_DEBUG);
throw new BadRequestException("no user_id specified"); throw new BadRequestException("no user_id specified");
} }
// Get Contact by given id // Get Contact by given id
$contact = q("SELECT * FROM `contact` WHERE `id` = %d AND `uid` = %d AND `self` = 0", intval($contact_id), 0); $contact = DBA::selectFirst('contact', ['url'], ['id' => $contact_id, 'uid' => 0, 'self' => false]);
if(!DBA::isResult($contact)) { if(!DBA::isResult($contact)) {
logger("No contact by id founded", LOGGER_DEBUG); logger("No contact found for ID" . $contact_id, LOGGER_DEBUG);
throw new BadRequestException("no contact found to given ID"); throw new NoFoundException("no contact found to given ID");
} }
$url = $contact[0]["url"]; $url = $contact["url"];
$condition = ["`uid` = ? AND (`rel` = ? OR `rel` = ?) AND (`nurl` = ? OR `alias` = ? OR `alias` = ?)", $condition = ["`uid` = ? AND (`rel` = ? OR `rel` = ?) AND (`nurl` = ? OR `alias` = ? OR `alias` = ?)",
$uid, Contact::SHARING, Contact::FRIEND, normalise_link($url), $uid, Contact::SHARING, Contact::FRIEND, normalise_link($url),
@ -3662,12 +3663,12 @@ function api_friendships_destroy($type)
if (!DBA::isResult($contact)) { if (!DBA::isResult($contact)) {
logger("Not following Contact", LOGGER_DEBUG); logger("Not following Contact", LOGGER_DEBUG);
throw new BadRequestException("Not following Contact"); throw new NoFoundException("Not following Contact");
} }
if (!in_array($contact['network'], Protocol::NATIVE_SUPPORT)) { if (!in_array($contact['network'], Protocol::NATIVE_SUPPORT)) {
logger("Not supported", LOGGER_DEBUG); logger("Not supported", LOGGER_DEBUG);
throw new BadRequestException("Not supported"); throw new ExpectationFailedException("Not supported");
} }
$dissolve = ($contact['rel'] == Contact::SHARING); $dissolve = ($contact['rel'] == Contact::SHARING);
@ -3676,24 +3677,23 @@ function api_friendships_destroy($type)
if ($owner) { if ($owner) {
Contact::terminateFriendship($owner, $contact, $dissolve); Contact::terminateFriendship($owner, $contact, $dissolve);
} }
else {
logger("No owner found", LOGGER_DEBUG);
throw new Exception("Error Processing Request");
}
// Sharing-only contacts get deleted as there no relationship any more // Sharing-only contacts get deleted as there no relationship any more
if ($dissolve) { if ($dissolve) {
Contact::remove($contact['id']); Contact::remove($contact['id']);
$return_path = 'contacts';
} else { } else {
DBA::update('contact', ['rel' => Contact::FOLLOWER], ['id' => $contact['id']]); DBA::update('contact', ['rel' => Contact::FOLLOWER], ['id' => $contact['id']]);
} }
$answer = ['result' => 'ok', 'user_id' => $contact_id, 'contact' => 'contact deleted'];
$answer = ['result' => 'ok', 'contact' => 'contact deleted'];
return api_format_data("friendships-destroy", $type, ['result' => $answer]); return api_format_data("friendships-destroy", $type, ['result' => $answer]);
} }
api_register_func('api/friendships/destroy', 'api_friendships_destroy', true, API_METHOD_POST); api_register_func('api/friendships/destroy', 'api_friendships_destroy', true, API_METHOD_POST);
/** /**
* *
* @param string $type Return type (atom, rss, xml, json) * @param string $type Return type (atom, rss, xml, json)