diff --git a/include/acl_selectors.php b/include/acl_selectors.php index b4eed7dd4..b965c2ca6 100644 --- a/include/acl_selectors.php +++ b/include/acl_selectors.php @@ -9,10 +9,6 @@ use Friendica\Model\Contact; require_once "mod/proxy.php"; -function contact_select($selname, $selclass, $preselected = false, $size = 4, $privmail = false, $celeb = false, $privatenet = false, $tabindex = null) { - return Acl::getMessageContactSelectHTML($selname, $selclass, defaults($preselected, []), $size, $privmail, $celeb, $privatenet, $tabindex); -} - function prune_deadguys($arr) { Contact::pruneUnavailable($arr); return $arr; diff --git a/mod/message.php b/mod/message.php index 40f1dd08c..d2980aaea 100644 --- a/mod/message.php +++ b/mod/message.php @@ -7,6 +7,7 @@ use Friendica\App; use Friendica\Content\Nav; use Friendica\Content\Smilies; use Friendica\Content\Text\BBCode; +use Friendica\Core\Acl; use Friendica\Core\L10n; use Friendica\Core\System; use Friendica\Database\DBM; @@ -236,14 +237,14 @@ function message_content(App $a) $preid = $r[0]['id']; $preselect = [$preid]; } else { - $preselect = false; + $preselect = []; } } $prefill = $preselect ? $prename : ''; // the ugly select box - $select = contact_select('messageto', 'message-to-select', $preselect, 4, true, false, false, 10); + $select = Acl::getMessageContactSelectHTML('messageto', 'message-to-select', $preselect, 4, 10); $tpl = get_markup_template('prv_message.tpl'); $o .= replace_macros($tpl, [ diff --git a/src/Core/Acl.php b/src/Core/Acl.php index 67e2633a2..1c72d23cb 100644 --- a/src/Core/Acl.php +++ b/src/Core/Acl.php @@ -153,17 +153,12 @@ class Acl extends BaseObject * * @param string $selname Name attribute of the select input tag * @param string $selclass Class attribute of the select input tag - * @param array $preselected Contact ID that should be already selected + * @param array $preselected Contact IDs that should be already selected * @param int $size Length of the select box - * @param bool $privmail - * @param bool $celeb - * @param bool $privatenet * @param int $tabindex Select input tag tabindex attribute * @return string */ - public static function getMessageContactSelectHTML( - $selname, $selclass, array $preselected = [], $size = 4, $privmail = false, $celeb = false, $privatenet = false, - $tabindex = null) + public static function getMessageContactSelectHTML($selname, $selclass, array $preselected = [], $size = 4, $tabindex = null) { $a = self::getApp(); @@ -171,34 +166,18 @@ class Acl extends BaseObject // When used for private messages, we limit correspondence to mutual DFRN/Friendica friends and the selector // to one recipient. By default our selector allows multiple selects amongst all contacts. - - $sql_extra = ''; - - if ($privmail || $celeb) { - $sql_extra .= sprintf(" AND `rel` = %d ", intval(CONTACT_IS_FRIEND)); - } - - if ($privmail) { - $sql_extra .= sprintf(" AND `network` IN ('%s' , '%s') ", NETWORK_DFRN, NETWORK_DIASPORA); - } elseif ($privatenet) { - $sql_extra .= sprintf(" AND `network` IN ('%s' , '%s', '%s', '%s') ", NETWORK_DFRN, NETWORK_MAIL, NETWORK_FACEBOOK, - NETWORK_DIASPORA); - } + $sql_extra = sprintf(" AND `rel` = %d ", intval(CONTACT_IS_FRIEND)); + $sql_extra .= sprintf(" AND `network` IN ('%s' , '%s') ", NETWORK_DFRN, NETWORK_DIASPORA); $tabindex_attr = !empty($tabindex) ? ' tabindex="' . intval($tabindex) . '"' : ''; - if ($privmail && $preselected) { + $hidepreselected = ''; + if ($preselected) { $sql_extra .= " AND `id` IN (" . implode(",", $preselected) . ")"; $hidepreselected = ' style="display: none;"'; - } else { - $hidepreselected = ''; } - if ($privmail) { - $o .= "\r\n"; - } + $o .= "' . PHP_EOL; - if ($privmail && $preselected) { + if ($preselected) { $o .= implode(', ', $receiverlist); }