keith/barkey
1
0
Fork 0
mirror of https://codeberg.org/yeentown/barkey synced 2024-11-24 22:55:12 +00:00
Code Issues Projects Releases Packages Wiki Activity

update icon-related instructions

Browse source
This commit is contained in:
dakkar 2024-08-02 13:25:27 +01:00
parent 6b55713097
commit fb082222c1
1 changed files with 10 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
CONTRIBUTING.md
View file

@ -580,7 +580,7 @@ seems to do a decent job)
*after that commit*, do all the extra work, on the same branch: *after that commit*, do all the extra work, on the same branch:
* copy all changes: * copy all changes (commit after each step):
* in `packages/backend/src/core/NoteCreateService.ts`, from `create` to * in `packages/backend/src/core/NoteCreateService.ts`, from `create` to
`import` (and vice versa if `git` got confused!) `import` (and vice versa if `git` got confused!)
* from `packages/backend/src/core/NoteCreateService.ts` to * from `packages/backend/src/core/NoteCreateService.ts` to
@ -599,12 +599,18 @@ seems to do a decent job)
`packages/frontend/src/pages/timeline.vue`, `packages/frontend/src/pages/timeline.vue`,
`packages/frontend/src/ui/deck/tl-column.vue`, `packages/frontend/src/ui/deck/tl-column.vue`,
`packages/frontend/src/widgets/WidgetTimeline.vue`) `packages/frontend/src/widgets/WidgetTimeline.vue`)
* re-generate `misskey-js` (`pnpm build-misskey-js-with-types`) and commit
* build the frontend: `rm -rf built/; NODE_ENV=development pnpm --filter=frontend
build` (the `development` tells it to keep some of the original
filenames in the built files)
* make sure there aren't any new `ti-*` classes (Tabler Icons), and * make sure there aren't any new `ti-*` classes (Tabler Icons), and
replace them with appropriate `ph-*` ones (Phosphor Icons). replace them with appropriate `ph-*` ones (Phosphor Icons):
`git grep '["'\'']ti[ -](?!fw)'` should show you what to change. `grep -rP '["'\'']ti[ -](?!fw)' -- built/` should show you what to change.
NOTE: `ti-fw` is a special class that's defined by Misskey, leave it NOTE: `ti-fw` is a special class that's defined by Misskey, leave it
alone alone
* re-generate `misskey-js`: `pnpm build-misskey-js-with-types`
after every change, re-build the frontend and check again, until
there are no more `ti-*` classes in the built files
* run tests `pnpm test` and fix as much as you can * run tests `pnpm test` and fix as much as you can
* right now `megalodon` doesn't pass its tests, you probably need to * right now `megalodon` doesn't pass its tests, you probably need to
run `pnpm --filter=backend test` (requires a test database, [see run `pnpm --filter=backend test` (requires a test database, [see