From d77033b0d0fb3d450276b2b95ec967d1450a9227 Mon Sep 17 00:00:00 2001 From: tterrag Date: Mon, 15 May 2017 04:39:54 -0400 Subject: [PATCH] Fix normals not being generated for formats without normals (#3896) Fix normals not being generated for formats without normals --- .../client/model/pipeline/VertexLighterFlat.java | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/main/java/net/minecraftforge/client/model/pipeline/VertexLighterFlat.java b/src/main/java/net/minecraftforge/client/model/pipeline/VertexLighterFlat.java index e18999a82..7be971e91 100644 --- a/src/main/java/net/minecraftforge/client/model/pipeline/VertexLighterFlat.java +++ b/src/main/java/net/minecraftforge/client/model/pipeline/VertexLighterFlat.java @@ -108,10 +108,10 @@ public class VertexLighterFlat extends QuadGatheringTransformer float[][] lightmap = quadData[lightmapIndex]; float[][] color = quadData[colorIndex]; - if(normalIndex != -1 && ( - quadData[normalIndex][0][0] != -1 || - quadData[normalIndex][0][1] != -1 || - quadData[normalIndex][0][2] != -1)) + // If all three normal values are either -1 or 0, normals must be generated + if(quadData[normalIndex][0][0] != quadData[normalIndex][0][1] || + quadData[normalIndex][0][1] != quadData[normalIndex][0][2] || + (quadData[normalIndex][0][0] != -1 && quadData[normalIndex][0][0] != 0)) { normal = quadData[normalIndex]; }