keith
/
ForgePatch
1
0
Fork 0
Code Issues Pull Requests Projects Releases 2 Wiki Activity

Fix a couple more ItemStack null checks (#3586)

This commit is contained in:
Ben Staddon 2017-01-11 23:15:47 +00:00 committed by LexManos
parent 43f3b3ec65
commit c4dea9fc66
2 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/main/java/net/minecraftforge/client/GuiIngameForge.java
View File

@ -253,15 +253,16 @@ public class GuiIngameForge extends GuiIngame
ItemStack itemstack = this.mc.player.inventory.armorItemInSlot(3);
if (this.mc.gameSettings.thirdPersonView == 0 && itemstack != null && itemstack.getItem() != null)
if (this.mc.gameSettings.thirdPersonView == 0 && !itemstack.isEmpty())
{
if (itemstack.getItem() == Item.getItemFromBlock(Blocks.PUMPKIN))
Item item = itemstack.getItem();
if (item == Item.getItemFromBlock(Blocks.PUMPKIN))
{
renderPumpkinOverlay(res);
}
else
{
itemstack.getItem().renderHelmetOverlay(itemstack, mc.player, res, partialTicks);
item.renderHelmetOverlay(itemstack, mc.player, res, partialTicks);
}
}

2
src/main/java/net/minecraftforge/fluids/UniversalBucket.java
View File

@ -217,7 +217,7 @@ public class UniversalBucket extends Item
// not for us to handle
ItemStack emptyBucket = event.getEmptyBucket();
if (emptyBucket == null ||
if (emptyBucket.isEmpty() ||
!emptyBucket.isItemEqual(getEmpty()) ||
(isNbtSensitive() && ItemStack.areItemStackTagsEqual(emptyBucket, getEmpty())))
{