From a42cf1ae37cc61f2f97feb800cc1f3aaa323a5ec Mon Sep 17 00:00:00 2001 From: Sergey Shatunov Date: Wed, 8 Apr 2015 17:26:40 +0600 Subject: [PATCH] Fix FluidRegsitry.registerFluid FluidRegistry: ```java static BiMap fluids = HashBiMap.create(); static BiMap fluidIDs = HashBiMap.create(); ... public static boolean registerFluid(Fluid fluid) { if (fluidIDs.containsKey(fluid.getName())) ^^^^^^^ ``` There is definitely should be fluids instead fluidIDs. This mistake broke many mods. --- src/main/java/net/minecraftforge/fluids/FluidRegistry.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/java/net/minecraftforge/fluids/FluidRegistry.java b/src/main/java/net/minecraftforge/fluids/FluidRegistry.java index 30d777494..cd9ef9292 100644 --- a/src/main/java/net/minecraftforge/fluids/FluidRegistry.java +++ b/src/main/java/net/minecraftforge/fluids/FluidRegistry.java @@ -79,7 +79,7 @@ public abstract class FluidRegistry */ public static boolean registerFluid(Fluid fluid) { - if (fluidIDs.containsKey(fluid.getName())) + if (fluids.containsKey(fluid.getName())) { FMLLog.bigWarning("Duplicate registration attempt for fluid %s (type %s) has occurred. This is not a problem itself, but subsequent failed FluidStacks might be a result if not handled properly", fluid.getName(), fluid.getClass().getName()); return false;