From 37e5dc1e6635784fd4325cf05986329f38024504 Mon Sep 17 00:00:00 2001 From: Ben Staddon Date: Sun, 17 Dec 2017 02:30:18 +0000 Subject: [PATCH] Adjust light matrix calculations to use per-face logic (#4339) --- .../minecraftforge/client/model/pipeline/BlockInfo.java | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/src/main/java/net/minecraftforge/client/model/pipeline/BlockInfo.java b/src/main/java/net/minecraftforge/client/model/pipeline/BlockInfo.java index 1ed42f50c..44bf2e903 100644 --- a/src/main/java/net/minecraftforge/client/model/pipeline/BlockInfo.java +++ b/src/main/java/net/minecraftforge/client/model/pipeline/BlockInfo.java @@ -105,7 +105,6 @@ public class BlockInfo public void updateLightMatrix() { - boolean full = false; for(int x = 0; x <= 2; x++) { for(int y = 0; y <= 2; y++) @@ -120,16 +119,12 @@ public class BlockInfo s[x][y][z] = (brightness >> 0x14) & 0xF; b[x][y][z] = (brightness >> 0x04) & 0xF; ao[x][y][z] = state.getAmbientOcclusionLightValue(); - if(x == 1 && y == 1 && z == 1) - { - full = state.isFullCube(); - } } } } - if(!full) + for(EnumFacing side : SIDES) { - for(EnumFacing side : SIDES) + if(!state.getBlock().doesSideBlockRendering(state, world, blockPos, side)) { int x = side.getFrontOffsetX() + 1; int y = side.getFrontOffsetY() + 1;