Merge pull request #12325 from GPUCode/better-nce-message

settings: Clearer NCE error messages
This commit is contained in:
liamwhite 2023-12-09 19:00:44 -05:00 committed by GitHub
commit 8f9d5c3143
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23

View file

@ -160,12 +160,16 @@ static bool is_nce_enabled = false;
void SetNceEnabled(bool is_39bit) { void SetNceEnabled(bool is_39bit) {
const bool is_nce_selected = values.cpu_backend.GetValue() == CpuBackend::Nce; const bool is_nce_selected = values.cpu_backend.GetValue() == CpuBackend::Nce;
is_nce_enabled = IsFastmemEnabled() && is_nce_selected && is_39bit; if (is_nce_selected && !IsFastmemEnabled()) {
if (is_nce_selected && !is_nce_enabled) { LOG_WARNING(Common, "Fastmem is required to natively execute code in a performant manner, "
"falling back to Dynarmic");
}
if (is_nce_selected && !is_39bit) {
LOG_WARNING( LOG_WARNING(
Common, Common,
"Program does not utilize 39-bit address space, unable to natively execute code"); "Program does not utilize 39-bit address space, unable to natively execute code");
} }
is_nce_enabled = IsFastmemEnabled() && is_nce_selected && is_39bit;
} }
bool IsNceEnabled() { bool IsNceEnabled() {