etc/yuzu
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

service: Halt on ReportUnimplementedFunction and improve output log.

Browse source
This commit is contained in:
bunnei 2017-12-28 15:24:59 -05:00
parent d5995fd30f
commit 16fb1c8fe7
1 changed files with 2 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/core/hle/service/service.cpp
View file

@ -96,7 +96,7 @@ void ServiceFrameworkBase::RegisterHandlersBase(const FunctionInfoBase* function
void ServiceFrameworkBase::ReportUnimplementedFunction(Kernel::HLERequestContext& ctx,
const FunctionInfoBase* info) {
auto cmd_buf = ctx.CommandBuffer();
std::string function_name = info == nullptr ? fmt::format("{:#08x}", ctx.GetCommand()) : info->name;
std::string function_name = info == nullptr ? fmt::format("{}", ctx.GetCommand()) : info->name;
fmt::MemoryWriter w;
w.write("function '{}': port='{}' cmd_buf={{[0]={:#x}", function_name, service_name,
@ -107,9 +107,7 @@ void ServiceFrameworkBase::ReportUnimplementedFunction(Kernel::HLERequestContext
w << '}';
LOG_ERROR(Service, "unknown / unimplemented %s", w.c_str());
// TODO(bunnei): Hack - ignore error
IPC::RequestBuilder rb{ctx, 1};
rb.Push(RESULT_SUCCESS);
UNIMPLEMENTED();
}
void ServiceFrameworkBase::InvokeRequest(Kernel::HLERequestContext& ctx) {