0
0
Fork 0
mirror of https://github.com/yt-dlp/yt-dlp.git synced 2024-11-22 02:15:12 +00:00
yt-dlp/youtube_dl/postprocessor
Yen Chi Hsuan 23495d6a39
Revert "[ffmpeg] Fix embedding subtitles (#9063)"
This reverts commit ccff2c404d.

Fixes #10081.

The new approach breaks embedding subtitles into video-only or
audio-only files. FFMpeg provides a trick: add '?' after the argument of
'-map' so that a missing stream is ignored. For example:

opts = [
    '-map', '0:v?',
    '-c:v', 'copy',
    '-map', '0:a?',
    '-c:a', 'copy',
    # other options...
]

Unfortunately, such a format is not implemented in avconv, either.
I guess adding '-ignore_unknown' if self.basename == 'ffmpeg' is the
best solution. However, the example mentioned in #9063 no longer serves
problematic files, so I can't test it. I'll reopen #9063 and wait for
another example so that I can test '-ignore_unknown'.
2016-07-15 20:02:36 +08:00
..
__init__.py Add fixup for media files produced by HlsNative downloader(fixes #4776) 2016-03-01 21:10:41 +01:00
common.py [postprocessor/common] Use 'self._downloader.params' instead of 'self.params' 2015-09-05 12:11:36 +02:00
embedthumbnail.py [postprocessor/embedthumbnail] Allow mkv to embed thumbnails 2016-02-21 03:32:03 +08:00
execafterdownload.py [compat] Rename shlex_quote and remove unused subprocess_check_output 2016-05-10 16:00:21 +08:00
ffmpeg.py Revert "[ffmpeg] Fix embedding subtitles (#9063)" 2016-07-15 20:02:36 +08:00
metadatafromtitle.py [refactor] Single quotes consistency 2016-02-14 15:37:17 +06:00
xattrpp.py [jython] Introduce compat_os_name 2016-03-03 19:24:24 +08:00