From 14ba6ba5cebaf32749ef9c8ea7c7cc4d9d9a9dfb Mon Sep 17 00:00:00 2001
From: MysterD <myster@d>
Date: Sat, 12 Mar 2022 20:41:02 -0800
Subject: [PATCH] Fix Discord error when using a lot of mods

---
 src/pc/network/discord/activity.c | 18 +++++++++++-------
 1 file changed, 11 insertions(+), 7 deletions(-)

diff --git a/src/pc/network/discord/activity.c b/src/pc/network/discord/activity.c
index bdb95582..d700e94f 100644
--- a/src/pc/network/discord/activity.c
+++ b/src/pc/network/discord/activity.c
@@ -78,20 +78,22 @@ void discord_activity_update(bool hosting) {
         gCurActivity.party.size.max_size = 1;
     }
 
-    snprintf(gCurActivity.details, 128, "%s", get_version());
+    char details[256] = { 0 };
+
+    snprintf(details, 127, "%s", get_version());
 
     bool displayDash = true;
     bool displayComma = false;
 
     if (gRegisteredMods.string != NULL) {
-        strncat(gCurActivity.details, " - ", 127);
+        strncat(details, " - ", 127);
         displayDash = false;
 
         // add patches to activity
         struct StringLinkedList* node = &gRegisteredMods;
         while (node != NULL && node->string != NULL) {
-            if (displayComma) { strncat(gCurActivity.details, ", ", 127); }
-            strncat(gCurActivity.details, node->string, 127);
+            if (displayComma) { strncat(details, ", ", 127); }
+            strncat(details, node->string, 127);
             displayComma = true;
             node = node->next;
         }
@@ -103,16 +105,18 @@ void discord_activity_update(bool hosting) {
         for (int i = 0; i < table->entryCount; i++) {
             struct ModListEntry* entry = &table->entries[i];
             if (!entry->enabled) { continue; }
-            if (displayDash) { strncat(gCurActivity.details, " - ", 127); }
-            if (displayComma) { strncat(gCurActivity.details, ", ", 127); }
+            if (displayDash) { strncat(details, " - ", 127); }
+            if (displayComma) { strncat(details, ", ", 127); }
 
-            strncat(gCurActivity.details, entry->displayName ? entry->displayName : entry->name, 127);
+            strncat(details, entry->displayName ? entry->displayName : entry->name, 127);
 
             displayDash = false;
             displayComma = true;
         }
     }
 
+    snprintf(gCurActivity.details, 125, "%s", details);
+
     app.activities->update_activity(app.activities, &gCurActivity, NULL, on_activity_update_callback);
     LOGFILE_INFO(LFT_DISCORD, "set activity");
 }