From e3ddbe43361dfb31d08992aab140b630cdb83d0e Mon Sep 17 00:00:00 2001
From: Michael Fabian 'Xaymar' Dirks <info@xaymar.com>
Date: Sat, 30 Sep 2023 01:22:06 +0200
Subject: [PATCH] denoising: Move into its own component

---
 CMakeLists.txt                                | 42 -------------------
 components/denoising/CMakeLists.txt           |  8 ++++
 .../source}/filters/filter-denoising.cpp      |  0
 .../source}/filters/filter-denoising.hpp      |  0
 4 files changed, 8 insertions(+), 42 deletions(-)
 create mode 100644 components/denoising/CMakeLists.txt
 rename {source => components/denoising/source}/filters/filter-denoising.cpp (100%)
 rename {source => components/denoising/source}/filters/filter-denoising.hpp (100%)

diff --git a/CMakeLists.txt b/CMakeLists.txt
index f3aeda9e..d08c0827 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -288,8 +288,6 @@ set(${PREFIX}VERSION "" CACHE STRING "Specify an override for the automatically
 
 # Features
 ## Filters
-set(${PREFIX}ENABLE_FILTER_DENOISING ${FEATURE_EXPERIMENTAL} CACHE BOOL "Enable Denoising filter")
-set(${PREFIX}ENABLE_FILTER_DENOISING_NVIDIA ${FEATURE_EXPERIMENTAL} CACHE BOOL "Enable NVIDIA provider(s) for Denoising Filter")
 set(${PREFIX}ENABLE_FILTER_UPSCALING ${FEATURE_EXPERIMENTAL} CACHE BOOL "Enable Upscaling Filter")
 set(${PREFIX}ENABLE_FILTER_UPSCALING_NVIDIA ${FEATURE_EXPERIMENTAL} CACHE BOOL "Enable NVIDIA provider(s) for Upscaling Filter")
 set(${PREFIX}ENABLE_FILTER_VIRTUAL_GREENSCREEN ${FEATURE_EXPERIMENTAL} CACHE BOOL "Enable Virtual Greenscreen Filter")
@@ -426,26 +424,6 @@ macro(set_feature_disabled FEATURE DISABLED)
 	set(${PREFIX}DISABLE_${FEATURE} ${DISABLED} CACHE INTERNAL "" FORCE)
 endmacro()
 
-function(feature_filter_denoising RESOLVE)
-	is_feature_enabled(FILTER_DENOISING T_CHECK)
-	if(RESOLVE AND T_CHECK)
-		# Verify that the requirements for the providers are available
-		if(NOT HAVE_NVIDIA_VFX_SDK)
-			message(WARNING "'NVIDIA Video Effects SDK' is missing. Disabling NVIDIA provider...")
-			set_feature_disabled(FILTER_DENOISING_NVIDIA ON)
-		endif()
-
-		# Verify that we have at least one provider for Video Denoising.
-		is_feature_enabled(FILTER_DENOISING_NVIDIA T_CHECK_NVIDIA)
-		if(NOT T_CHECK_NVIDIA)
-			message(WARNING "Denoising has no available providers. Disabling...")
-			set_feature_disabled(FILTER_DENOISING ON)
-		endif()
-	elseif(T_CHECK)
-		set(REQUIRE_NVIDIA_VFX_SDK ON PARENT_SCOPE)
-	endif()
-endfunction()
-
 function(feature_filter_upscaling RESOLVE)
 	is_feature_enabled(FILTER_UPSCALING T_CHECK)
 	if(RESOLVE AND T_CHECK)
@@ -523,7 +501,6 @@ function(feature_updater RESOLVE)
 endfunction()
 
 # Set Requirements
-feature_filter_denoising(OFF)
 feature_filter_upscaling(OFF)
 feature_filter_virtual_greenscreen(OFF)
 feature_frontend(OFF)
@@ -650,7 +627,6 @@ if(REQUIRE_QT)
 endif()
 
 # Verify Requirements
-feature_filter_denoising(ON)
 feature_filter_upscaling(ON)
 feature_filter_virtual_greenscreen(ON)
 feature_frontend(ON)
@@ -923,24 +899,6 @@ list(APPEND PROJECT_INCLUDE_DIRS
 	"${PROJECT_SOURCE_DIR}/source"
 )
 
-# Filter/Denoising
-is_feature_enabled(FILTER_DENOISING T_CHECK)
-if(T_CHECK)
-	list(APPEND PROJECT_PRIVATE_SOURCE
-		"source/filters/filter-denoising.hpp"
-		"source/filters/filter-denoising.cpp"
-	)
-	list(APPEND PROJECT_DEFINITIONS
-		ENABLE_FILTER_DENOISING
-	)
-	is_feature_enabled(FILTER_DENOISING_NVIDIA T_CHECK)
-	if(T_CHECK)
-		list(APPEND PROJECT_DEFINITIONS
-			ENABLE_FILTER_DENOISING_NVIDIA
-		)
-	endif()
-endif()
-
 # Filter/Upscaling
 is_feature_enabled(FILTER_UPSCALING T_CHECK)
 if(T_CHECK)
diff --git a/components/denoising/CMakeLists.txt b/components/denoising/CMakeLists.txt
new file mode 100644
index 00000000..8311476b
--- /dev/null
+++ b/components/denoising/CMakeLists.txt
@@ -0,0 +1,8 @@
+## AUTOGENERATED COPYRIGHT HEADER START
+# Copyright (C) NaN-NaN undefined
+# AUTOGENERATED COPYRIGHT HEADER END
+cmake_minimum_required(VERSION 3.26)
+project("Denoising")
+list(APPEND CMAKE_MESSAGE_INDENT "[${PROJECT_NAME}] ")
+
+streamfx_add_component("Denoising")
diff --git a/source/filters/filter-denoising.cpp b/components/denoising/source/filters/filter-denoising.cpp
similarity index 100%
rename from source/filters/filter-denoising.cpp
rename to components/denoising/source/filters/filter-denoising.cpp
diff --git a/source/filters/filter-denoising.hpp b/components/denoising/source/filters/filter-denoising.hpp
similarity index 100%
rename from source/filters/filter-denoising.hpp
rename to components/denoising/source/filters/filter-denoising.hpp