From a51840b801707ebae3fb38a85f81c1dee2e24a62 Mon Sep 17 00:00:00 2001
From: System64 <42580501+system64MC@users.noreply.github.com>
Date: Wed, 12 Oct 2022 11:59:04 +0200
Subject: [PATCH] Fixed assertion crash and fixed a bug with the cubic
 interpolation. The interpolated waveform will now stay in phase.

---
 src/gui/waveEdit.cpp | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/src/gui/waveEdit.cpp b/src/gui/waveEdit.cpp
index d3e5327c..6913ae37 100644
--- a/src/gui/waveEdit.cpp
+++ b/src/gui/waveEdit.cpp
@@ -537,7 +537,12 @@ void FurnaceGUI::drawWaveEdit() {
                     if (waveGenScaleX > 0 && wave->len != waveGenScaleX) e->lockEngine([this, wave]() {
                         int origData[256];
                         // Copy original wave to temp buffer
-                        assert(wave->len <= 256);
+                        // If longer than 256 samples, return
+                        if (wave->len >= 256)
+                        {
+                            showError("ERROR : Wavetable longer than 256 samples!");
+                            return;
+                        }
                         memcpy(origData, wave->data, wave->len * sizeof(int));
 
                         float t = 0; // Index used into `origData`
@@ -576,7 +581,7 @@ void FurnaceGUI::drawWaveEdit() {
                             case 3: // Cubic Spline
                             {
                                 int idx = t; // Implicitly floors `t`
-                                int s0 = origData[(idx) % wave->len], s1 = origData[(idx + 1) % wave->len], s2 = origData[(idx + 2) % wave->len], s3 = origData[(idx + 3) % wave->len];
+                                int s0 = origData[((idx - 1 % wave->len + wave->len) % wave->len)], s1 = origData[(idx) % wave->len], s2 = origData[(idx + 1) % wave->len], s3 = origData[(idx + 2) % wave->len];
                                 double a0, a1, a2, a3;
                                 double mu = (t - idx);
                                 double mu2 = mu * mu;