From db92f4d59557f6d0ff12fa6c144df49b5720b785 Mon Sep 17 00:00:00 2001
From: Kenny <27463495+Frontesque@users.noreply.github.com>
Date: Wed, 22 Jun 2022 16:46:52 -0400
Subject: [PATCH] refactor: :heavy_minus_sign: Remove useless dependancy

Remove @capacitor/browser dependancy from the app, extra space that can be accomplished now with `this.$vuetube.openexternal(url)`
---
 NUXT/components/UtilRenderers/YtTextFormatter.vue  |  5 ++---
 NUXT/pages/activities/packageInstaller.vue         |  4 ++--
 NUXT/pages/mods/about.vue                          |  5 ++---
 NUXT/pages/mods/updates.vue                        | 10 +++-------
 NUXT/plugins/vuetube.js                            |  6 ++++++
 android/app/capacitor.build.gradle                 |  1 -
 android/app/src/main/assets/capacitor.plugins.json |  4 ----
 android/capacitor.settings.gradle                  |  3 ---
 ios/App/Podfile                                    |  1 -
 package.json                                       |  1 -
 10 files changed, 15 insertions(+), 25 deletions(-)

diff --git a/NUXT/components/UtilRenderers/YtTextFormatter.vue b/NUXT/components/UtilRenderers/YtTextFormatter.vue
index a508dab..34d6c57 100644
--- a/NUXT/components/UtilRenderers/YtTextFormatter.vue
+++ b/NUXT/components/UtilRenderers/YtTextFormatter.vue
@@ -43,7 +43,6 @@
 </template>
 
 <script>
-import { Browser } from "@capacitor/browser";
 export default {
   props: {
     textRuns: {
@@ -52,8 +51,8 @@ export default {
     },
   },
   methods: {
-    async openExternal(url) {
-      await Browser.open({ url: url });
+    openExternal(url) {
+      this.$vuetube.openExternal(url);
     },
     async openInternal(url) {
       await this.$router.push(url);
diff --git a/NUXT/pages/activities/packageInstaller.vue b/NUXT/pages/activities/packageInstaller.vue
index a86bc6f..57a87f5 100644
--- a/NUXT/pages/activities/packageInstaller.vue
+++ b/NUXT/pages/activities/packageInstaller.vue
@@ -67,8 +67,8 @@
 
     methods: {
         dl(item) {
-            console.log(item.download_url)
-            window.open(item.download_url, '_blank');
+          window.open(item.download_url, '_blank');
+          this.$router.push(`/mods/updates`);
         }
     }
 
diff --git a/NUXT/pages/mods/about.vue b/NUXT/pages/mods/about.vue
index 03fa234..2f4bc26 100644
--- a/NUXT/pages/mods/about.vue
+++ b/NUXT/pages/mods/about.vue
@@ -88,7 +88,6 @@
 </template>
 
 <script>
-import { Browser } from "@capacitor/browser";
 import { Device } from "@capacitor/device";
 
 export default {
@@ -113,8 +112,8 @@ export default {
     this.lang = this.$lang().mods.about;
   },
   methods: {
-    async openExternal(url) {
-      await Browser.open({ url: url });
+    openExternal(url) {
+      this.$vuetube.openExternal(url);
     },
   },
 };
diff --git a/NUXT/pages/mods/updates.vue b/NUXT/pages/mods/updates.vue
index 1fdb32c..5b5ce0a 100644
--- a/NUXT/pages/mods/updates.vue
+++ b/NUXT/pages/mods/updates.vue
@@ -73,8 +73,6 @@
 </style>
 
 <script>
-import { Browser } from "@capacitor/browser";
-
 export default {
   computed: {
     roundTweak() {
@@ -95,14 +93,12 @@ export default {
     this.lang = this.$lang("mods").updates;
   },
   methods: {
-    async openExternal(item) {
-      await Browser.open({
-        url: item.html_url,
-      });
+    openExternal(item) {
+      this.$vuetube.openExternal(item.html_url,);
     },
 
     install(item, index) {
-      this.$router.push(`/activities/packageInstaller?v=${index}`)
+      this.$router.push(`/activities/packageInstaller?v=${index}`);
     },
   },
 };
diff --git a/NUXT/plugins/vuetube.js b/NUXT/plugins/vuetube.js
index f7ef765..ee94111 100644
--- a/NUXT/plugins/vuetube.js
+++ b/NUXT/plugins/vuetube.js
@@ -18,6 +18,12 @@ Vue.directive("emoji", {
 let backActions;
 
 const module = {
+
+  //---   Open External / Open In Browser   ---//
+  openExternal(url) {
+    window.open(url, '_blank');
+  },
+
   //---   Get GitHub Commits   ---//
   releases: new Promise((resolve, reject) => {
     Http.request({
diff --git a/android/app/capacitor.build.gradle b/android/app/capacitor.build.gradle
index 7d5d749..a93f8a0 100644
--- a/android/app/capacitor.build.gradle
+++ b/android/app/capacitor.build.gradle
@@ -11,7 +11,6 @@ apply from: "../capacitor-cordova-android-plugins/cordova.variables.gradle"
 dependencies {
     implementation project(':capacitor-community-http')
     implementation project(':capacitor-app')
-    implementation project(':capacitor-browser')
     implementation project(':capacitor-device')
     implementation project(':capacitor-filesystem')
     implementation project(':capacitor-haptics')
diff --git a/android/app/src/main/assets/capacitor.plugins.json b/android/app/src/main/assets/capacitor.plugins.json
index b9031b2..183e229 100644
--- a/android/app/src/main/assets/capacitor.plugins.json
+++ b/android/app/src/main/assets/capacitor.plugins.json
@@ -7,10 +7,6 @@
 		"pkg": "@capacitor/app",
 		"classpath": "com.capacitorjs.plugins.app.AppPlugin"
 	},
-	{
-		"pkg": "@capacitor/browser",
-		"classpath": "com.capacitorjs.plugins.browser.BrowserPlugin"
-	},
 	{
 		"pkg": "@capacitor/device",
 		"classpath": "com.capacitorjs.plugins.device.DevicePlugin"
diff --git a/android/capacitor.settings.gradle b/android/capacitor.settings.gradle
index ef61b14..10ef8c6 100644
--- a/android/capacitor.settings.gradle
+++ b/android/capacitor.settings.gradle
@@ -8,9 +8,6 @@ project(':capacitor-community-http').projectDir = new File('../node_modules/@cap
 include ':capacitor-app'
 project(':capacitor-app').projectDir = new File('../node_modules/@capacitor/app/android')
 
-include ':capacitor-browser'
-project(':capacitor-browser').projectDir = new File('../node_modules/@capacitor/browser/android')
-
 include ':capacitor-device'
 project(':capacitor-device').projectDir = new File('../node_modules/@capacitor/device/android')
 
diff --git a/ios/App/Podfile b/ios/App/Podfile
index d3fc14a..04080d7 100644
--- a/ios/App/Podfile
+++ b/ios/App/Podfile
@@ -11,7 +11,6 @@ def capacitor_pods
   pod 'CapacitorCordova', :path => '../../node_modules/@capacitor/ios'
   pod 'CapacitorCommunityHttp', :path => '..\..\node_modules\@capacitor-community\http'
   pod 'CapacitorApp', :path => '..\..\node_modules\@capacitor\app'
-  pod 'CapacitorBrowser', :path => '..\..\node_modules\@capacitor\browser'
   pod 'CapacitorDevice', :path => '..\..\node_modules\@capacitor\device'
   pod 'CapacitorFilesystem', :path => '..\..\node_modules\@capacitor\filesystem'
   pod 'CapacitorHaptics', :path => '..\..\node_modules\@capacitor\haptics'
diff --git a/package.json b/package.json
index a6d5143..2ca60ca 100644
--- a/package.json
+++ b/package.json
@@ -3,7 +3,6 @@
     "@capacitor-community/http": "^1.4.1",
     "@capacitor/android": "^3.4.0",
     "@capacitor/app": "^1.1.1",
-    "@capacitor/browser": "^1.0.7",
     "@capacitor/cli": "^3.4.0",
     "@capacitor/core": "^3.4.0",
     "@capacitor/device": "^1.1.2",