From 933910f7443b4d0b99c934695d60142f9daaa7fb Mon Sep 17 00:00:00 2001 From: Kenny <27463495+Frontesque@users.noreply.github.com> Date: Tue, 14 Jun 2022 21:13:23 -0400 Subject: [PATCH 1/4] fix: :bug: Fix elements displaying over the bottom nav bar fix #288 --- NUXT/components/bottomNavigation.vue | 1 + 1 file changed, 1 insertion(+) diff --git a/NUXT/components/bottomNavigation.vue b/NUXT/components/bottomNavigation.vue index d95172c..3852b6a 100644 --- a/NUXT/components/bottomNavigation.vue +++ b/NUXT/components/bottomNavigation.vue @@ -105,6 +105,7 @@ export default { position: fixed; width: 100%; bottom: 0; + z-index: 100; } .navButton { width: 25vw !important; From 21e905beb04447eb600b630224d732c167bc171d Mon Sep 17 00:00:00 2001 From: Kenny <27463495+Frontesque@users.noreply.github.com> Date: Tue, 14 Jun 2022 21:37:40 -0400 Subject: [PATCH 2/4] fix: :bug: Change position of update cards Move "installed" and "latest" cards on the updates page to prevent clipping fix #273 --- NUXT/pages/mods/updates.vue | 19 ++----------------- 1 file changed, 2 insertions(+), 17 deletions(-) diff --git a/NUXT/pages/mods/updates.vue b/NUXT/pages/mods/updates.vue index d3ff188..a479375 100644 --- a/NUXT/pages/mods/updates.vue +++ b/NUXT/pages/mods/updates.vue @@ -14,23 +14,6 @@ :class="$vuetify.theme.dark ? 'text--lighten-4' : 'text--darken-4'" v-text="`• ${item.sha.substring(0, 7)}`" /> - - - Latest - - - Installed -
@@ -43,6 +26,8 @@
+ Latest + Installed mdi-githubView From 187616a01ee6cc0e17e9f06eb79d65539859a297 Mon Sep 17 00:00:00 2001 From: Kenny <27463495+Frontesque@users.noreply.github.com> Date: Tue, 14 Jun 2022 21:41:08 -0400 Subject: [PATCH 3/4] refactor: :fire: Remove "Open In VLC" --- NUXT/pages/watch.vue | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/NUXT/pages/watch.vue b/NUXT/pages/watch.vue index 33bc4d8..5c0d8f1 100644 --- a/NUXT/pages/watch.vue +++ b/NUXT/pages/watch.vue @@ -367,12 +367,6 @@ export default { dialogTitle: "Share video", }); }, - vlc() { - this.$youtube.showToast("Opening in VLC"); - - // redirect to vlc://url - window.location.href = "vlc://" + this.video.availableResolutions[this.video.availableResolutions.length-1].url; - }, sendWatchTime() { const player = this.$refs.player.getPlayer(); const rt = Math.floor(Date.now() / 1000) - this.startTime; @@ -441,12 +435,6 @@ export default { actionName: "enqueue", disabled: true, }, - { - name: "Open in VLC", - icon: "mdi-traffic-cone", - actionName: "vlc", - disabled: false, - }, // { // name: "Quality", // icon: "mdi-high-definition", From c66e2d0b4eb41fee3a238865468100fc6a54a1fa Mon Sep 17 00:00:00 2001 From: Kenny <27463495+Frontesque@users.noreply.github.com> Date: Tue, 14 Jun 2022 21:45:42 -0400 Subject: [PATCH 4/4] perf: :zap: store lang pack as variable instead of 3 seperate calls --- NUXT/components/bottomNavigation.vue | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/NUXT/components/bottomNavigation.vue b/NUXT/components/bottomNavigation.vue index 3852b6a..ab0d93a 100644 --- a/NUXT/components/bottomNavigation.vue +++ b/NUXT/components/bottomNavigation.vue @@ -74,24 +74,25 @@ export default { tabSelection: 0, tabs: [ // TODO: pull from Vuex & localStorage for customizations - { name: "...", icon: "mdi-home", link: "/home" }, + { name: "", icon: "mdi-home", link: "/home" }, //{ name: "Shorts", icon: "mdi-lightning-bolt", link: "/shorts" }, //{ name: "Upload", icon: "mdi-plus", link: "/upload" }, { - name: "...", + name: "", icon: "mdi-youtube-subscription", link: "/subscriptions", }, - { name: "...", icon: "mdi-view-list", link: "/library" }, + { name: "", icon: "mdi-view-list", link: "/library" }, // { name: "Settings", icon: "mdi-menu", link: "/settings" }, ], }; }, mounted() { - this.tabs[0].name = this.$lang("global").home; - this.tabs[1].name = this.$lang("global").subscriptions; - this.tabs[2].name = this.$lang("global").library; + const lang = this.$lang("global"); + this.tabs[0].name = lang.home; + this.tabs[1].name = lang.subscriptions; + this.tabs[2].name = lang.library; }, };