etc/VancedMicroG
0
0
Fork 0
mirror of https://github.com/YTVanced/VancedMicroG synced 2024-12-05 01:07:27 +00:00
Code Issues Projects Releases Wiki Activity

Don't log callbacks of Google Sign-In page to logcat

Browse source 
Google seems to include sensitive account details in some of these fields.
Fixes #1567
This commit is contained in:
Marvin W 2021-10-06 10:22:29 +02:00
parent 96cfe2bd9b
commit e90ce370d4
No known key found for this signature in database
GPG key ID: 072E9235DB996F2A
1 changed files with 5 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
play-services-core/src/main/java/org/microg/gms/auth/login/LoginActivity.java
View file

@ -389,7 +389,7 @@ public class LoginActivity extends AssistantActivity {
@JavascriptInterface @JavascriptInterface
public final void addAccount(String json) { public final void addAccount(String json) {
Log.d(TAG, "JSBridge: addAccount " + json); Log.d(TAG, "JSBridge: addAccount");
} }
@JavascriptInterface @JavascriptInterface
@ -425,7 +425,7 @@ public class LoginActivity extends AssistantActivity {
@JavascriptInterface @JavascriptInterface
public final String getAndroidId() { public final String getAndroidId() {
long androidId = LastCheckinInfo.read(LoginActivity.this).getAndroidId(); long androidId = LastCheckinInfo.read(LoginActivity.this).getAndroidId();
Log.d(TAG, "JSBridge: getAndroidId " + androidId); Log.d(TAG, "JSBridge: getAndroidId");
if (androidId == 0 || androidId == -1) return null; if (androidId == 0 || androidId == -1) return null;
return Long.toHexString(androidId); return Long.toHexString(androidId);
} }
@ -442,7 +442,7 @@ public class LoginActivity extends AssistantActivity {
@JavascriptInterface @JavascriptInterface
public final void getDroidGuardResult(String s) { public final void getDroidGuardResult(String s) {
Log.d(TAG, "JSBridge: getDroidGuardResult: " + s); Log.d(TAG, "JSBridge: getDroidGuardResult");
} }
@JavascriptInterface @JavascriptInterface
@ -492,7 +492,6 @@ public class LoginActivity extends AssistantActivity {
@JavascriptInterface @JavascriptInterface
public final void hideKeyboard() { public final void hideKeyboard() {
Log.d(TAG, "JSBridge: hideKeyboard");
inputMethodManager.hideSoftInputFromWindow(webView.getWindowToken(), 0); inputMethodManager.hideSoftInputFromWindow(webView.getWindowToken(), 0);
} }
@ -508,7 +507,7 @@ public class LoginActivity extends AssistantActivity {
@JavascriptInterface @JavascriptInterface
public final void log(String s) { public final void log(String s) {
Log.d(TAG, "JSBridge: log " + s); Log.d(TAG, "JSBridge: log");
} }
@JavascriptInterface @JavascriptInterface
@ -518,13 +517,12 @@ public class LoginActivity extends AssistantActivity {
@JavascriptInterface @JavascriptInterface
public final void setAccountIdentifier(String accountIdentifier) { public final void setAccountIdentifier(String accountIdentifier) {
Log.d(TAG, "JSBridge: setAccountIdentifier " + accountIdentifier); Log.d(TAG, "JSBridge: setAccountIdentifier");
} }
@TargetApi(HONEYCOMB) @TargetApi(HONEYCOMB)
@JavascriptInterface @JavascriptInterface
public final void setBackButtonEnabled(boolean backButtonEnabled) { public final void setBackButtonEnabled(boolean backButtonEnabled) {
Log.d(TAG, "JSBridge: setBackButtonEnabled: " + backButtonEnabled);
if (SDK_INT <= GINGERBREAD_MR1) return; if (SDK_INT <= GINGERBREAD_MR1) return;
int visibility = getWindow().getDecorView().getSystemUiVisibility(); int visibility = getWindow().getDecorView().getSystemUiVisibility();
if (backButtonEnabled) if (backButtonEnabled)
@ -542,13 +540,11 @@ public class LoginActivity extends AssistantActivity {
@JavascriptInterface @JavascriptInterface
public final void showKeyboard() { public final void showKeyboard() {
Log.d(TAG, "JSBridge: showKeyboard");
inputMethodManager.showSoftInput(webView, SHOW_IMPLICIT); inputMethodManager.showSoftInput(webView, SHOW_IMPLICIT);
} }
@JavascriptInterface @JavascriptInterface
public final void showView() { public final void showView() {
Log.d(TAG, "JSBridge: showView");
runOnUiThread(() -> webView.setVisibility(VISIBLE)); runOnUiThread(() -> webView.setVisibility(VISIBLE));
} }